)]}'
{"glanceclient/openstack/common/apiclient/base.py":[{"author":{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},"change_message_id":"69824467c0dbbe888d223f72701160f7f149c551","unresolved":false,"context_lines":[{"line_number":561,"context_line":"        \"\"\"Find all items with attributes matching ``**kwargs``."},{"line_number":562,"context_line":""},{"line_number":563,"context_line":"        This isn\u0027t very efficient: it loads the entire list then filters on"},{"line_number":564,"context_line":"        the Python side."},{"line_number":565,"context_line":"        \"\"\""},{"line_number":566,"context_line":"        found \u003d []"},{"line_number":567,"context_line":"        searches \u003d kwargs.items()"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba63e191_5840c956","line":564,"range":{"start_line":564,"start_character":19,"end_line":564,"end_character":23},"updated":"2016-01-19 09:08:47.000000000","message":"I am wondering why you can\u0027t use filters in the request?\nDo you have some issues with that? AFAIK, filters on server side are working with models(even metadata should be included in filter conditions). Could you please clarify your case?","commit_id":"704ed2e5f52bea65792bc4817738a18aa4a27616"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"c5ab67d4024079eddefa57e053d610c3b07baf69","unresolved":false,"context_lines":[{"line_number":561,"context_line":"        \"\"\"Find all items with attributes matching ``**kwargs``."},{"line_number":562,"context_line":""},{"line_number":563,"context_line":"        This isn\u0027t very efficient: it loads the entire list then filters on"},{"line_number":564,"context_line":"        the Python side."},{"line_number":565,"context_line":"        \"\"\""},{"line_number":566,"context_line":"        found \u003d []"},{"line_number":567,"context_line":"        searches \u003d kwargs.items()"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba63e191_9f0380b8","line":564,"range":{"start_line":564,"start_character":19,"end_line":564,"end_character":23},"in_reply_to":"ba63e191_5840c956","updated":"2016-01-19 11:06:49.000000000","message":"Are you suggesting to use filters with \u0027get\u0027 request in the consuming application ex. heat? Possibly we can. \n\nHowever, by not supporting the find interfaces available in v1 would not v2  be backward incompatible?","commit_id":"704ed2e5f52bea65792bc4817738a18aa4a27616"},{"author":{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},"change_message_id":"a7eca9b82f8e5634d8e1e9d62fda38bb4361d180","unresolved":false,"context_lines":[{"line_number":561,"context_line":"        \"\"\"Find all items with attributes matching ``**kwargs``."},{"line_number":562,"context_line":""},{"line_number":563,"context_line":"        This isn\u0027t very efficient: it loads the entire list then filters on"},{"line_number":564,"context_line":"        the Python side."},{"line_number":565,"context_line":"        \"\"\""},{"line_number":566,"context_line":"        found \u003d []"},{"line_number":567,"context_line":"        searches \u003d kwargs.items()"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba63e191_fa1dea0f","line":564,"range":{"start_line":564,"start_character":19,"end_line":564,"end_character":23},"in_reply_to":"ba63e191_9f0380b8","updated":"2016-01-19 11:27:18.000000000","message":"Is it possible to re-define findall method in v2.images.Controller? I think that the we won\u0027t backward incompatible in this case because client just passes set of filters and receives list of images. WDYT?","commit_id":"704ed2e5f52bea65792bc4817738a18aa4a27616"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"dec587a2ec2c319647ee5807bc280a728a246f94","unresolved":false,"context_lines":[{"line_number":561,"context_line":"        \"\"\"Find all items with attributes matching ``**kwargs``."},{"line_number":562,"context_line":""},{"line_number":563,"context_line":"        This isn\u0027t very efficient: it loads the entire list then filters on"},{"line_number":564,"context_line":"        the Python side."},{"line_number":565,"context_line":"        \"\"\""},{"line_number":566,"context_line":"        found \u003d []"},{"line_number":567,"context_line":"        searches \u003d kwargs.items()"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba63e191_b0ba2ae0","line":564,"range":{"start_line":564,"start_character":19,"end_line":564,"end_character":23},"in_reply_to":"ba63e191_f9aad518","updated":"2016-01-19 13:54:01.000000000","message":"it seems we can\u0027t do an attribute matching with id, as filters based on request query strings don\u0027t allow it.\n\nSomething like this \u0027/v2/images?id\u003d3a4560a1-e585-443e-9b39-553b46ec92d1\u0026limit\u003d20\u0027","commit_id":"704ed2e5f52bea65792bc4817738a18aa4a27616"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"a8e44034818b9d41fa219effc7b5e719ba50cd98","unresolved":false,"context_lines":[{"line_number":561,"context_line":"        \"\"\"Find all items with attributes matching ``**kwargs``."},{"line_number":562,"context_line":""},{"line_number":563,"context_line":"        This isn\u0027t very efficient: it loads the entire list then filters on"},{"line_number":564,"context_line":"        the Python side."},{"line_number":565,"context_line":"        \"\"\""},{"line_number":566,"context_line":"        found \u003d []"},{"line_number":567,"context_line":"        searches \u003d kwargs.items()"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba63e191_f9aad518","line":564,"range":{"start_line":564,"start_character":19,"end_line":564,"end_character":23},"in_reply_to":"ba63e191_fa1dea0f","updated":"2016-01-19 12:49:20.000000000","message":"If I understand correctly, you\u0027re suggesting  to rewrite the findall function using filters. I think we can do that.\n\nIMO, it would be good to define it in a base class, as it can be used for entities other than image.","commit_id":"704ed2e5f52bea65792bc4817738a18aa4a27616"}],"glanceclient/v2/images.py":[{"author":{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},"change_message_id":"a7eca9b82f8e5634d8e1e9d62fda38bb4361d180","unresolved":false,"context_lines":[{"line_number":32,"context_line":"                   \u0027size\u0027, \u0027id\u0027, \u0027created_at\u0027, \u0027updated_at\u0027)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"class Controller(base.BaseController):"},{"line_number":36,"context_line":"    entity \u003d \u0027image\u0027"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def __init__(self, http_client, schema_client):"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba63e191_3a5dc2e9","line":35,"updated":"2016-01-19 11:27:18.000000000","message":"Why can\u0027t we inherit from ManagerWithFind:\nhttps://github.com/openstack/python-glanceclient/blob/master/glanceclient/openstack/common/apiclient/base.py#L228","commit_id":"704ed2e5f52bea65792bc4817738a18aa4a27616"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"a8e44034818b9d41fa219effc7b5e719ba50cd98","unresolved":false,"context_lines":[{"line_number":32,"context_line":"                   \u0027size\u0027, \u0027id\u0027, \u0027created_at\u0027, \u0027updated_at\u0027)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"class Controller(base.BaseController):"},{"line_number":36,"context_line":"    entity \u003d \u0027image\u0027"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def __init__(self, http_client, schema_client):"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba63e191_dc2b3f81","line":35,"in_reply_to":"ba63e191_3a5dc2e9","updated":"2016-01-19 12:49:20.000000000","message":"I thought the object model of BaseManager/ManagerWithFind/CrudManager is very specific to v1. \n\nIf it\u0027s ok for you guys to have Controller inherit from ManagerWithFind, I would have no issues to reuse it.","commit_id":"704ed2e5f52bea65792bc4817738a18aa4a27616"}]}