)]}'
{"id":"openstack%2Fpython-glanceclient~27536","triplet_id":"openstack%2Fpython-glanceclient~master~I6ff65b0e226be509de9cd3f021560081529283b0","project":"openstack/python-glanceclient","branch":"master","topic":"bug/1173044","hashtags":[],"change_id":"I6ff65b0e226be509de9cd3f021560081529283b0","subject":"Don\u0027t attempt to read stdin if it is empty.","status":"MERGED","created":"2013-04-26 08:01:51.000000000","updated":"2013-05-24 16:45:05.000000000","submitted":"2013-05-24 16:45:05.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":8,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"d56a3a204186db8d12a96150c4b60c89538d4d6c","_number":27536,"virtual_id_number":27536,"owner":{"_account_id":7217,"name":"Hugh Saunders","email":"hugh@wherenow.org","username":"hughsaunders"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":7217,"name":"Hugh Saunders","email":"hugh@wherenow.org","username":"hughsaunders"},{"value":0,"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},{"value":2,"date":"2013-05-24 16:45:05.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"all":[{"value":0,"date":"2013-05-23 13:25:50.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":7217,"name":"Hugh Saunders","email":"hugh@wherenow.org","username":"hughsaunders"},{"value":2,"date":"2013-05-24 15:55:03.000000000","_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2013-05-23 13:30:32.000000000","_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"all":[{"value":0,"_account_id":7217,"name":"Hugh Saunders","email":"hugh@wherenow.org","username":"hughsaunders"},{"value":1,"date":"2013-05-24 15:55:03.000000000","_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"date":"2013-05-23 12:55:13.000000000","_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":7217,"name":"Hugh Saunders","email":"hugh@wherenow.org","username":"hughsaunders"},{"value":0,"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Top Priority / Holds Gate"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},{"_account_id":7217,"name":"Hugh Saunders","email":"hugh@wherenow.org","username":"hughsaunders"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-05-23 12:55:13.000000000","updated_by":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"reviewer":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"state":"REVIEWER"},{"updated":"2013-05-24 15:55:03.000000000","updated_by":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"reviewer":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"state":"REVIEWER"},{"updated":"2013-05-24 16:45:05.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"0f1da3382eb7607059d52cc52b171c6dcb9a509e","author":{"_account_id":7217,"name":"Hugh Saunders","email":"hugh@wherenow.org","username":"hughsaunders"},"date":"2013-04-26 08:35:58.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"5744354d1db37de296bc7c961b81ee24097b2f47","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-04-26 09:20:49.000000000","message":"Patch Set 2: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/27536/2/check/gate-python-glanceclient-pep8/709 : SUCCESS\n- http://docs-draft.openstack.org/27536/2/check/gate-python-glanceclient-docs/641/doc/build/html/ : SUCCESS\n- http://logs.openstack.org/27536/2/check/gate-python-glanceclient-python26/704 : SUCCESS\n- http://logs.openstack.org/27536/2/check/gate-python-glanceclient-python26-rhel6/51 : SUCCESS (non-voting)\n- http://logs.openstack.org/27536/2/check/gate-python-glanceclient-python27/702 : SUCCESS\n- http://logs.openstack.org/27536/2/check/gate-tempest-devstack-vm-full/13673 : SUCCESS\n- http://logs.openstack.org/27536/2/check/gate-tempest-devstack-vm-postgres-full/13388 : FAILURE (non-voting)\n- http://logs.openstack.org/27536/2/check/gate-tempest-devstack-vm-quantum/19641 : SUCCESS\n- http://logs.openstack.org/27536/2/check/gate-grenade-devstack-vm/1526 : FAILURE (non-voting)\n","accounts_in_message":[],"_revision_number":2},{"id":"f6bcf9bc5bdf3fa60f79528d68f4ca0e1f55af69","author":{"_account_id":7217,"name":"Hugh Saunders","email":"hugh@wherenow.org","username":"hughsaunders"},"date":"2013-04-29 17:06:09.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"fd81772576987b39ad1e0b1a531b9761e276ebfc","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-04-29 17:49:21.000000000","message":"Patch Set 3: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/27536/3/check/gate-python-glanceclient-pep8/715 : SUCCESS\n- http://docs-draft.openstack.org/27536/3/check/gate-python-glanceclient-docs/647/doc/build/html/ : SUCCESS\n- http://logs.openstack.org/27536/3/check/gate-python-glanceclient-python26/710 : SUCCESS\n- http://logs.openstack.org/27536/3/check/gate-python-glanceclient-python26-rhel6/57 : SUCCESS (non-voting)\n- http://logs.openstack.org/27536/3/check/gate-python-glanceclient-python27/708 : SUCCESS\n- http://logs.openstack.org/27536/3/check/gate-tempest-devstack-vm-full/13910 : SUCCESS\n- http://logs.openstack.org/27536/3/check/gate-tempest-devstack-vm-postgres-full/13625 : FAILURE (non-voting)\n- http://logs.openstack.org/27536/3/check/gate-tempest-devstack-vm-quantum/19933 : SUCCESS\n- http://logs.openstack.org/27536/3/check/gate-grenade-devstack-vm/1748 : FAILURE (non-voting)\n","accounts_in_message":[],"_revision_number":3},{"id":"0396e2736d90350c551d3ecc3d4ca2a8cbf13622","author":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"date":"2013-04-30 20:08:17.000000000","message":"Patch Set 3: I would prefer that you didn\u0027t merge this\n\nThanks for this and adding good test coverage. Just one concern below.\n\nI think this patch needs to be split into two. It\u0027s doing two things: 1) only uploading data if the image is in queued status 2) only setting data if stdin is specified and data is actually being provided","accounts_in_message":[],"_revision_number":3},{"id":"5ef1e38a8b8f2729a03f40e2de9d7e080ee5378c","author":{"_account_id":7217,"name":"Hugh Saunders","email":"hugh@wherenow.org","username":"hughsaunders"},"date":"2013-04-30 22:19:38.000000000","message":"Patch Set 3:\n\nHi Alex,\nThanks for having a look at my patch. I will split it into two and resubmit as requested.\n\nHugh Saunders","accounts_in_message":[],"_revision_number":3},{"id":"de63d4aa8239ceb5d75c5b5236dddd212e829e65","author":{"_account_id":7217,"name":"Hugh Saunders","email":"hugh@wherenow.org","username":"hughsaunders"},"date":"2013-04-30 22:21:54.000000000","message":"Patch Set 3: Work In Progress","accounts_in_message":[],"_revision_number":3},{"id":"9c4bc4c0ec95e495b69c01ebe16e0ac4d849a027","author":{"_account_id":7217,"name":"Hugh Saunders","email":"hugh@wherenow.org","username":"hughsaunders"},"date":"2013-05-01 10:27:41.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"3e2501c8ea20f5ad49b3fab6875a29bdb71c5521","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-05-01 11:14:14.000000000","message":"Patch Set 4: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/27536/4/check/gate-python-glanceclient-pep8/716 : SUCCESS\n- http://docs-draft.openstack.org/27536/4/check/gate-python-glanceclient-docs/648/doc/build/html/ : SUCCESS\n- http://logs.openstack.org/27536/4/check/gate-python-glanceclient-python26/711 : SUCCESS\n- http://logs.openstack.org/27536/4/check/gate-python-glanceclient-python26-centos6/1 : SUCCESS (non-voting)\n- http://logs.openstack.org/27536/4/check/gate-python-glanceclient-python27/709 : SUCCESS\n- http://logs.openstack.org/27536/4/check/gate-tempest-devstack-vm-full/14127 : SUCCESS\n- http://logs.openstack.org/27536/4/check/gate-tempest-devstack-vm-postgres-full/13842 : FAILURE (non-voting)\n- http://logs.openstack.org/27536/4/check/gate-tempest-devstack-vm-quantum/20194 : SUCCESS\n- http://logs.openstack.org/27536/4/check/gate-grenade-devstack-vm/1957 : FAILURE (non-voting)\n","accounts_in_message":[],"_revision_number":4},{"id":"8f4d39b97318d5872681fdf7a8e7e875d72d6432","author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"date":"2013-05-06 08:17:19.000000000","message":"Patch Set 4: I would prefer that you didn\u0027t merge this\n\n(1 inline comment)\n\nThanks a lot for the patch. The code looks good!","accounts_in_message":[],"_revision_number":4},{"id":"c4a121a2de6ec444da282f08d7d247094e0e8685","author":{"_account_id":7217,"name":"Hugh Saunders","email":"hugh@wherenow.org","username":"hughsaunders"},"date":"2013-05-06 08:23:49.000000000","message":"Patch Set 4: Work In Progress\n\nHi Flavio, \nThanks for reviewing, I will move the tests to a new module and resubmit. \n\n--\nHugh Saunders","accounts_in_message":[],"_revision_number":4},{"id":"7695b172ad1df4b2fac04c43a987cd227c397b72","author":{"_account_id":7217,"name":"Hugh Saunders","email":"hugh@wherenow.org","username":"hughsaunders"},"date":"2013-05-06 09:47:14.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"ac4c4b49b589866865c8484a1d4751589a21a080","author":{"_account_id":7217,"name":"Hugh Saunders","email":"hugh@wherenow.org","username":"hughsaunders"},"date":"2013-05-06 09:49:00.000000000","message":"Uploaded patch set 6.","accounts_in_message":[],"_revision_number":6},{"id":"4fd7c66ef16353b7d42f38c0204766db98993c14","author":{"_account_id":7217,"name":"Hugh Saunders","email":"hugh@wherenow.org","username":"hughsaunders"},"date":"2013-05-06 09:52:29.000000000","message":"Patch Set 4: (1 inline comment)\n\nI have moved the shell tests to a separate module as requested - see patch set 6.","accounts_in_message":[],"_revision_number":4},{"id":"16026fc2835a3e44e2e8f8b9ce8b1409f5afc22b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-05-06 10:40:32.000000000","message":"Patch Set 6: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/27536/6/check/gate-python-glanceclient-pep8/725 : SUCCESS in 00:00:33\n- http://docs-draft.openstack.org/27536/6/check/gate-python-glanceclient-docs/657/doc/build/html/ : SUCCESS in 00:00:56\n- http://logs.openstack.org/27536/6/check/gate-python-glanceclient-python26/720 : SUCCESS in 00:00:55\n- http://logs.openstack.org/27536/6/check/gate-python-glanceclient-python26-centos6/9 : SUCCESS in 00:00:48 (non-voting)\n- http://logs.openstack.org/27536/6/check/gate-python-glanceclient-python27/718 : SUCCESS in 00:00:35\n- http://logs.openstack.org/27536/6/check/gate-tempest-devstack-vm-full/14665 : SUCCESS in 00:44:35\n- http://logs.openstack.org/27536/6/check/gate-tempest-devstack-vm-postgres-full/14380 : FAILURE in 00:51:21 (non-voting)\n- http://logs.openstack.org/27536/6/check/gate-tempest-devstack-vm-quantum/20827 : SUCCESS in 00:20:49\n- http://logs.openstack.org/27536/6/check/gate-grenade-devstack-vm/2464 : SUCCESS in 00:14:38 (non-voting)\n","accounts_in_message":[],"_revision_number":6},{"id":"1529a1f2c677e01f4070e9bd78acc776ea57ee1e","author":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"date":"2013-05-07 02:29:46.000000000","message":"Patch Set 6: Looks good to me (core reviewer)\n\nTested it and it works and looks good.","accounts_in_message":[],"_revision_number":6},{"id":"3da11abea404c29a294ea8e681b3fcab47c8480d","author":{"_account_id":9,"name":"LaunchpadSync","username":"launchpadsync"},"date":"2013-05-21 06:03:02.000000000","message":"Patch Set 6:\n\ncode review expired after 2 weeks of no activity, it can be restored using the `Restore Change` button  under the Patch Set on the web interface","accounts_in_message":[],"_revision_number":6},{"id":"a4aea81149455994bcd954f5712dc7ad8dd2c0aa","author":{"_account_id":9,"name":"LaunchpadSync","username":"launchpadsync"},"date":"2013-05-21 06:03:02.000000000","message":"Patch Set 6: Abandoned\n\ncode review expired after 2 weeks of no activity, it can be restored using the `Restore Change` button  under the Patch Set on the web interface","accounts_in_message":[],"_revision_number":6},{"id":"86496b364f5712febf4c95e4d918aa8035ef135e","author":{"_account_id":7217,"name":"Hugh Saunders","email":"hugh@wherenow.org","username":"hughsaunders"},"date":"2013-05-21 07:18:34.000000000","message":"Patch Set 6: Restored\n\nHi, please could someone +2 this patch? It already has one approval from a core reviewer.\n\nThanks","accounts_in_message":[],"_revision_number":6},{"id":"0f6368b76145b1089b093111299e194b8d187091","author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"date":"2013-05-21 08:21:30.000000000","message":"Patch Set 6: Looks good to me (core reviewer); Approved\n\nthanks","accounts_in_message":[],"_revision_number":6},{"id":"1c63580cdc916565d7164f94996ecd453e23aff2","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-05-21 08:22:24.000000000","message":"Patch Set 6: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":6},{"id":"f193a73078f94f5e77adc500aa98af4544f802d6","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-05-21 08:22:26.000000000","message":"Patch Set 6: Fails\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGithub#Test_Failures\n\nThis change was unable to be automatically merged with the current state of the repository. Please rebase your change and upload a new patchset.","accounts_in_message":[],"_revision_number":6},{"id":"dda69e95cdb537df16a1abf74d9dd8454d438f34","author":{"_account_id":7217,"name":"Hugh Saunders","email":"hugh@wherenow.org","username":"hughsaunders"},"date":"2013-05-21 08:37:41.000000000","message":"Patch Set 6:\n\nThis review has been open for a while, so there has probably been an incompatible change in the interim.\n\nI\u0027ll have a look at the commits and see what\u0027s changed.","accounts_in_message":[],"_revision_number":6},{"id":"2d173fd44d6e47ae75f8939ce1a84c9b35ab085d","author":{"_account_id":7217,"name":"Hugh Saunders","email":"hugh@wherenow.org","username":"hughsaunders"},"date":"2013-05-23 08:34:58.000000000","message":"Patch Set 6: Work In Progress","accounts_in_message":[],"_revision_number":6},{"id":"98064483fa20bdc25f0819eaf638118e7f1fa8c3","author":{"_account_id":7217,"name":"Hugh Saunders","email":"hugh@wherenow.org","username":"hughsaunders"},"date":"2013-05-23 08:45:09.000000000","message":"Uploaded patch set 7.","accounts_in_message":[],"_revision_number":7},{"id":"7228c8de7250945b20c9c2d62064b37b57616039","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-05-23 09:36:10.000000000","message":"Patch Set 7: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/27536/7/check/gate-python-glanceclient-pep8/762 : SUCCESS in 43s\n- http://docs-draft.openstack.org/27536/7/check/gate-python-glanceclient-docs/694/doc/build/html/ : SUCCESS in 49s\n- http://logs.openstack.org/27536/7/check/gate-python-glanceclient-python26/757 : SUCCESS in 1m 13s\n- http://logs.openstack.org/27536/7/check/gate-python-glanceclient-python27/755 : SUCCESS in 51s\n- http://logs.openstack.org/27536/7/check/gate-tempest-devstack-vm-full/17960 : SUCCESS in 43m 46s\n- http://logs.openstack.org/27536/7/check/gate-tempest-devstack-vm-postgres-full/17670 : FAILURE in 50m 49s (non-voting)\n- http://logs.openstack.org/27536/7/check/gate-tempest-devstack-vm-quantum/24686 : SUCCESS in 22m 03s\n- http://logs.openstack.org/27536/7/check/gate-grenade-devstack-vm/5456 : FAILURE in 9m 59s (non-voting)\n","accounts_in_message":[],"_revision_number":7},{"id":"015e5e6ad8e1d5927d9807a6a3b0890d67e044f0","author":{"_account_id":7217,"name":"Hugh Saunders","email":"hugh@wherenow.org","username":"hughsaunders"},"date":"2013-05-23 09:41:25.000000000","message":"Patch Set 7:\n\nPatch set 7 is just a rebase of patch set 6. However it required a manual merge as a/tests/v1/test_shell.py was created with conflicting content while this patch was being reviewed.","accounts_in_message":[],"_revision_number":7},{"id":"a834ae20d5c46b3d3c75e960061bb4424650404d","author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"date":"2013-05-23 11:18:13.000000000","message":"Patch Set 7: I would prefer that you didn\u0027t merge this\n\n(3 inline comments)\n\nHey,\n\nthanks for restoring this and your patience. Sorry about the delay.\n\nI added some notes, minor nitpicks. I was also wondering whether the user should be notified when stdin is closed / open and empty. (A warning would be enough).","accounts_in_message":[],"_revision_number":7},{"id":"730d640add70549910d555fae61d3597d0d10e85","author":{"_account_id":7217,"name":"Hugh Saunders","email":"hugh@wherenow.org","username":"hughsaunders"},"date":"2013-05-23 11:22:47.000000000","message":"Patch Set 7: Work In Progress\n\nHi Flavio, \nThanks for your comments, will implement the suggestions shortly.","accounts_in_message":[],"_revision_number":7},{"id":"8a6ca071e728450a740eb6cf59506910f0a99192","author":{"_account_id":7217,"name":"Hugh Saunders","email":"hugh@wherenow.org","username":"hughsaunders"},"date":"2013-05-23 12:37:40.000000000","message":"Uploaded patch set 8.","accounts_in_message":[],"_revision_number":8},{"id":"3466767f1391b1ab66ab1b3dc8f19ac22007f486","author":{"_account_id":7217,"name":"Hugh Saunders","email":"hugh@wherenow.org","username":"hughsaunders"},"date":"2013-05-23 12:48:31.000000000","message":"Patch Set 7: (3 inline comments)\n\nImplemented suggestions from inline comments. \n\nFrom Flavio\u0027s previous comment: \"I was also wondering whether the user should be notified when stdin is closed / open and empty. (A warning would be enough).\"\n\nIn order to do this, it is necessary to know whether input via stdin is required. In order to know that, we need to know the current status of the image. However Alex asked me to take an image status check out in a comment on patch set 3. \n\nI could re-add a test for image state, and warn the user if data is required but not provided, but should that be done in this change, a new change or a dependant change?","accounts_in_message":[],"_revision_number":7},{"id":"e8a85182bc1a6c81d9587f08a5ad1150639f4628","author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"date":"2013-05-23 12:55:13.000000000","message":"Patch Set 8:\n\nHey, thanks for taking care of this so quickly.\n\nI was thinking something like:\n\n  if not sys.stdin.isatty() and stat_result.st_size \u003d\u003d 0:\n     LOG.warn(\"You\u0027re doing it wrong :D\")\n\nSo that the user know that nothing is actually being sent because nothing can be read.\n\nDoes that make sense?\n\nThanks","accounts_in_message":[],"_revision_number":8},{"id":"c8dc1b4ad4bedf15aa876f922a7077ea8be93fd3","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-05-23 13:23:00.000000000","message":"Patch Set 8: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/27536/8/check/gate-python-glanceclient-pep8/765 : SUCCESS in 39s\n- http://docs-draft.openstack.org/27536/8/check/gate-python-glanceclient-docs/697/doc/build/html/ : SUCCESS in 43s\n- http://logs.openstack.org/27536/8/check/gate-python-glanceclient-python26/760 : SUCCESS in 1m 04s\n- http://logs.openstack.org/27536/8/check/gate-python-glanceclient-python27/758 : SUCCESS in 45s\n- http://logs.openstack.org/27536/8/check/gate-tempest-devstack-vm-full/17991 : SUCCESS in 44m 32s\n- http://logs.openstack.org/27536/8/check/gate-tempest-devstack-vm-postgres-full/17701 : FAILURE in 45m 10s (non-voting)\n- http://logs.openstack.org/27536/8/check/gate-tempest-devstack-vm-quantum/24726 : SUCCESS in 19m 07s\n- http://logs.openstack.org/27536/8/check/gate-grenade-devstack-vm/5485 : FAILURE in 11m 28s (non-voting)\n","accounts_in_message":[],"_revision_number":8},{"id":"40e466c507238d0a1868e65a84f4995b8f0c9618","author":{"_account_id":7217,"name":"Hugh Saunders","email":"hugh@wherenow.org","username":"hughsaunders"},"date":"2013-05-23 13:25:50.000000000","message":"Patch Set 8:\n\nThe user may not be doing anything wrong though. If the operation doesn\u0027t require data (metadata change for example), then it shouldn\u0027t matter whether stdin is a tty or not and whether it is open/closed/empty. This bug came up because our internal tests presented an empty stdin to glanceclient for an operation that doesn\u0027t require data, would be a shame to have an unnecessary warning each time. \n\nWe could minimise this by only giving a warning if the image is in queued state, as that is when it is most likely that the user intends to upload data, however that is still a guess as metadata operations are still valid on queued images. \n\nThe cleanest way I can think of is to have a parameter  (eg --data) that specifies a path/url/whatever to an to be uploaded and allow the user to specify \u0027-\u0027 for read stdin. If --data isn\u0027t specified then the client doesn\u0027t attempt to read data from anywhere. I realise thats quite a large change to how the client works though :-/","accounts_in_message":[],"_revision_number":8},{"id":"7d3b4f13768f6e93fb39c11913d6b32cb66a14e6","author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"date":"2013-05-23 13:30:32.000000000","message":"Patch Set 8: Looks good to me (core reviewer)\n\nmmh, Fair enough. I guess the case we should care about is the one you mentioned, that is, image-related operations. We can discuss this on IRC and see what\u0027s more convenient.","accounts_in_message":[],"_revision_number":8},{"id":"f686e60df4dd9b13c765c9ebdcd021c862b4d8dc","author":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"date":"2013-05-24 15:55:03.000000000","message":"Patch Set 8: Looks good to me (core reviewer); Approved\n\n","accounts_in_message":[],"_revision_number":8},{"id":"d5a3fbb05f348b45f76689745b4c5e3356160ab6","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-05-24 15:55:04.000000000","message":"Patch Set 8: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":8},{"id":"80f5e3721786a011fba03ac9adf67c2dab36aa0a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-05-24 16:45:05.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":8},{"id":"a99293dd52c59dd1f471411dbf200d90f934d970","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-05-24 16:45:05.000000000","message":"Patch Set 8: Verified\n\nBuild succeeded.\n\n- http://docs-draft.openstack.org/27536/8/gate/gate-python-glanceclient-docs/698/doc/build/html/ : SUCCESS in 51s\n- http://logs.openstack.org/27536/8/gate/gate-python-glanceclient-pep8/766 : SUCCESS in 46s\n- http://logs.openstack.org/27536/8/gate/gate-python-glanceclient-python26/761 : SUCCESS in 1m 27s\n- http://logs.openstack.org/27536/8/gate/gate-python-glanceclient-python27/759 : SUCCESS in 54s\n- http://logs.openstack.org/27536/8/gate/gate-tempest-devstack-vm-full/18360 : SUCCESS in 49m 52s\n- http://logs.openstack.org/27536/8/gate/gate-tempest-devstack-vm-postgres-full/18070 : FAILURE in 45m 08s (non-voting)\n- http://logs.openstack.org/27536/8/gate/gate-tempest-devstack-vm-quantum/25129 : SUCCESS in 20m 50s\n- http://logs.openstack.org/27536/8/gate/gate-grenade-devstack-vm/5815 : SUCCESS in 14m 27s (non-voting)\n","accounts_in_message":[],"_revision_number":8}],"current_revision_number":8,"current_revision":"a3585ef62dbaa2c67f5b400f41e02cc686be5e7c","revisions":{"8571dc23382df86df58515098698b83f25271852":{"kind":"REWORK","_number":1,"created":"2013-04-26 08:01:51.000000000","uploader":{"_account_id":7217,"name":"Hugh Saunders","email":"hugh@wherenow.org","username":"hughsaunders"},"ref":"refs/changes/36/27536/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/36/27536/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/36/27536/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/36/27536/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/36/27536/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/36/27536/1"}}},"commit":{"parents":[{"commit":"addd3c3be383d9db363415096d5dcc4fe384af97","subject":"Merge \"Prevent WantReadError when using https\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/addd3c3be383d9db363415096d5dcc4fe384af97"}]}],"author":{"name":"Hugh Saunders","email":"hugh@wherenow.org","date":"2013-04-26 07:26:11.000000000","tz":60},"committer":{"name":"Hugh Saunders","email":"hugh@wherenow.org","date":"2013-04-26 08:01:47.000000000","tz":60},"subject":"Only upload data to queued images.","message":"Only upload data to queued images.\n\n * Check the image status in v1/shell.py/do_image_update. Only attempt\n   to read data is status is queued.\n * Check for available data size in v1/shell.py/_set_data_field, dont\n   read if 0.\n\nChange-Id: I6ff65b0e226be509de9cd3f021560081529283b0\nFixes: bug #1173044\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/8571dc23382df86df58515098698b83f25271852"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/8571dc23382df86df58515098698b83f25271852"}]},"branch":"refs/heads/master"},"0a4724bcf69fd0b0943f45335d587a8b513d4154":{"kind":"REWORK","_number":2,"created":"2013-04-26 08:35:58.000000000","uploader":{"_account_id":7217,"name":"Hugh Saunders","email":"hugh@wherenow.org","username":"hughsaunders"},"ref":"refs/changes/36/27536/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/36/27536/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/36/27536/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/36/27536/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/36/27536/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/36/27536/2"}}},"commit":{"parents":[{"commit":"addd3c3be383d9db363415096d5dcc4fe384af97","subject":"Merge \"Prevent WantReadError when using https\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/addd3c3be383d9db363415096d5dcc4fe384af97"}]}],"author":{"name":"Hugh Saunders","email":"hugh@wherenow.org","date":"2013-04-26 07:26:11.000000000","tz":60},"committer":{"name":"Hugh Saunders","email":"hugh@wherenow.org","date":"2013-04-26 08:35:19.000000000","tz":60},"subject":"Only upload data to queued images.","message":"Only upload data to queued images.\n\n * Check the image status in v1/shell.py/do_image_update. Only attempt\n   to read data is status is queued.\n * Check for available data size in v1/shell.py/_set_data_field, dont\n   read if 0.\n\nChange-Id: I6ff65b0e226be509de9cd3f021560081529283b0\nFixes: bug #1173044\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/0a4724bcf69fd0b0943f45335d587a8b513d4154"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/0a4724bcf69fd0b0943f45335d587a8b513d4154"}]},"branch":"refs/heads/master"},"4f1ba1b2302222b7cb6b8331cba31a8085282c2b":{"kind":"REWORK","_number":3,"created":"2013-04-29 17:06:09.000000000","uploader":{"_account_id":7217,"name":"Hugh Saunders","email":"hugh@wherenow.org","username":"hughsaunders"},"ref":"refs/changes/36/27536/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/36/27536/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/36/27536/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/36/27536/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/36/27536/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/36/27536/3"}}},"commit":{"parents":[{"commit":"addd3c3be383d9db363415096d5dcc4fe384af97","subject":"Merge \"Prevent WantReadError when using https\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/addd3c3be383d9db363415096d5dcc4fe384af97"}]}],"author":{"name":"Hugh Saunders","email":"hugh@wherenow.org","date":"2013-04-26 07:26:11.000000000","tz":60},"committer":{"name":"Hugh Saunders","email":"hugh@wherenow.org","date":"2013-04-29 16:58:37.000000000","tz":60},"subject":"Only upload data to queued images.","message":"Only upload data to queued images.\n\n * Check the image status in v1/shell.py/do_image_update. Only attempt\n   to read data is status is queued.\n * Check for available data size in v1/shell.py/_set_data_field, dont\n   read if 0.\n * Add tests for 3x stdin scenarios: closed, open and empty, open with data.\n\nChange-Id: I6ff65b0e226be509de9cd3f021560081529283b0\nFixes: bug #1173044\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/4f1ba1b2302222b7cb6b8331cba31a8085282c2b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/4f1ba1b2302222b7cb6b8331cba31a8085282c2b"}]},"branch":"refs/heads/master"},"3eec8dee35e6a37bc5538f04b65ca956a6d9e1af":{"kind":"REWORK","_number":4,"created":"2013-05-01 10:27:41.000000000","uploader":{"_account_id":7217,"name":"Hugh Saunders","email":"hugh@wherenow.org","username":"hughsaunders"},"ref":"refs/changes/36/27536/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/36/27536/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/36/27536/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/36/27536/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/36/27536/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/36/27536/4"}}},"commit":{"parents":[{"commit":"addd3c3be383d9db363415096d5dcc4fe384af97","subject":"Merge \"Prevent WantReadError when using https\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/addd3c3be383d9db363415096d5dcc4fe384af97"}]}],"author":{"name":"Hugh Saunders","email":"hugh@wherenow.org","date":"2013-04-26 07:26:11.000000000","tz":60},"committer":{"name":"Hugh Saunders","email":"hugh@wherenow.org","date":"2013-05-01 10:23:51.000000000","tz":60},"subject":"Don\u0027t attempt to read stdin if it is empty.","message":"Don\u0027t attempt to read stdin if it is empty.\n\n * Check for available data size in v1/shell.py/_set_data_field, dont\n   read if 0.\n * Add tests for 3x stdin scenarios: closed, open and empty, open with data.\n\nChange-Id: I6ff65b0e226be509de9cd3f021560081529283b0\nFixes: bug #1173044\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/3eec8dee35e6a37bc5538f04b65ca956a6d9e1af"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/3eec8dee35e6a37bc5538f04b65ca956a6d9e1af"}]},"branch":"refs/heads/master"},"26be4f66a3d9486fcab906ac1c0a6c756c6a5ed5":{"kind":"REWORK","_number":5,"created":"2013-05-06 09:47:14.000000000","uploader":{"_account_id":7217,"name":"Hugh Saunders","email":"hugh@wherenow.org","username":"hughsaunders"},"ref":"refs/changes/36/27536/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/36/27536/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/36/27536/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/36/27536/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/36/27536/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/36/27536/5"}}},"commit":{"parents":[{"commit":"addd3c3be383d9db363415096d5dcc4fe384af97","subject":"Merge \"Prevent WantReadError when using https\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/addd3c3be383d9db363415096d5dcc4fe384af97"}]}],"author":{"name":"Hugh Saunders","email":"hugh@wherenow.org","date":"2013-04-26 07:26:11.000000000","tz":60},"committer":{"name":"Hugh Saunders","email":"hugh@wherenow.org","date":"2013-05-06 09:45:53.000000000","tz":60},"subject":"Don\u0027t attempt to read stdin if it is empty.","message":"Don\u0027t attempt to read stdin if it is empty.\n\n * Check for available data size in v1/shell.py/_set_data_field, don\u0027t\n   read if 0.\n * Add test_shell.py including tests for 3x stdin scenarios:\n\t* closed\n \t* open and empty\n\t* open with data\n\nChange-Id: I6ff65b0e226be509de9cd3f021560081529283b0\nFixes: bug #1173044\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/26be4f66a3d9486fcab906ac1c0a6c756c6a5ed5"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/26be4f66a3d9486fcab906ac1c0a6c756c6a5ed5"}]},"branch":"refs/heads/master"},"df25dca4792cad3b2875181404342a805afeb7d9":{"kind":"REWORK","_number":6,"created":"2013-05-06 09:49:00.000000000","uploader":{"_account_id":7217,"name":"Hugh Saunders","email":"hugh@wherenow.org","username":"hughsaunders"},"ref":"refs/changes/36/27536/6","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/36/27536/6","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/36/27536/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/36/27536/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/36/27536/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/36/27536/6"}}},"commit":{"parents":[{"commit":"addd3c3be383d9db363415096d5dcc4fe384af97","subject":"Merge \"Prevent WantReadError when using https\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/addd3c3be383d9db363415096d5dcc4fe384af97"}]}],"author":{"name":"Hugh Saunders","email":"hugh@wherenow.org","date":"2013-04-26 07:26:11.000000000","tz":60},"committer":{"name":"Hugh Saunders","email":"hugh@wherenow.org","date":"2013-05-06 09:48:46.000000000","tz":60},"subject":"Don\u0027t attempt to read stdin if it is empty.","message":"Don\u0027t attempt to read stdin if it is empty.\n\n * Check for available data size in v1/shell.py/_set_data_field, don\u0027t\n   read if 0.\n * Add test_shell.py including tests for 3x stdin scenarios:\n\t* closed\n \t* open and empty\n\t* open with data\n\nChange-Id: I6ff65b0e226be509de9cd3f021560081529283b0\nFixes: bug #1173044\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/df25dca4792cad3b2875181404342a805afeb7d9"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/df25dca4792cad3b2875181404342a805afeb7d9"}]},"branch":"refs/heads/master"},"581fb843b882b5657fc6ab232e11f7e4186135f2":{"kind":"REWORK","_number":7,"created":"2013-05-23 08:45:09.000000000","uploader":{"_account_id":7217,"name":"Hugh Saunders","email":"hugh@wherenow.org","username":"hughsaunders"},"ref":"refs/changes/36/27536/7","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/36/27536/7","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/36/27536/7 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/36/27536/7 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/36/27536/7 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/36/27536/7"}}},"commit":{"parents":[{"commit":"2a56a32edb9ce2ee8df8e467e3c938224accaf6d","subject":"Merge \"Migrate to pbr.\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/2a56a32edb9ce2ee8df8e467e3c938224accaf6d"}]}],"author":{"name":"Hugh Saunders","email":"hugh@wherenow.org","date":"2013-04-26 07:26:11.000000000","tz":60},"committer":{"name":"Hugh Saunders","email":"hugh@wherenow.org","date":"2013-05-23 08:43:34.000000000","tz":60},"subject":"Don\u0027t attempt to read stdin if it is empty.","message":"Don\u0027t attempt to read stdin if it is empty.\n\n * Check for available data size in v1/shell.py/_set_data_field, don\u0027t\n   read if 0.\n * Add test_shell.py including tests for 3x stdin scenarios:\n\t* closed\n \t* open and empty\n\t* open with data\n\nChange-Id: I6ff65b0e226be509de9cd3f021560081529283b0\nFixes: bug #1173044\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/581fb843b882b5657fc6ab232e11f7e4186135f2"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/581fb843b882b5657fc6ab232e11f7e4186135f2"}]},"branch":"refs/heads/master"},"a3585ef62dbaa2c67f5b400f41e02cc686be5e7c":{"kind":"REWORK","_number":8,"created":"2013-05-23 12:37:40.000000000","uploader":{"_account_id":7217,"name":"Hugh Saunders","email":"hugh@wherenow.org","username":"hughsaunders"},"ref":"refs/changes/36/27536/8","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/36/27536/8","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/36/27536/8 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/36/27536/8 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/36/27536/8 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/36/27536/8"}}},"commit":{"parents":[{"commit":"2a56a32edb9ce2ee8df8e467e3c938224accaf6d","subject":"Merge \"Migrate to pbr.\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/2a56a32edb9ce2ee8df8e467e3c938224accaf6d"}]}],"author":{"name":"Hugh Saunders","email":"hugh@wherenow.org","date":"2013-04-26 07:26:11.000000000","tz":60},"committer":{"name":"Hugh Saunders","email":"hugh@wherenow.org","date":"2013-05-23 12:37:09.000000000","tz":60},"subject":"Don\u0027t attempt to read stdin if it is empty.","message":"Don\u0027t attempt to read stdin if it is empty.\n\n * Check for available data size in v1/shell.py/_set_data_field, don\u0027t\n   read if 0.\n * Add test_shell.py including tests for 3x stdin scenarios:\n\t* closed\n \t* open and empty\n\t* open with data\n\nChange-Id: I6ff65b0e226be509de9cd3f021560081529283b0\nFixes: bug #1173044\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/a3585ef62dbaa2c67f5b400f41e02cc686be5e7c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/a3585ef62dbaa2c67f5b400f41e02cc686be5e7c"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}