)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},"change_message_id":"603e90d8bf90b1392f094cda3649782fb0ae4fd0","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Test: use assert_has_calls() instead"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Some of the assertions in cinder test are sequential, we should better"},{"line_number":10,"context_line":"use assert_has_calls() instead of assert_any_call()."},{"line_number":11,"context_line":"And assert_has_calls() provides more clear messages in case of failure."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"bae84128_a11f75b5","line":9,"updated":"2016-02-24 12:59:31.000000000","message":"cinder?","commit_id":"744b88b8f993b53095bcbe1765a354d7eed51f16"}],"glanceclient/tests/unit/test_shell.py":[{"author":{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},"change_message_id":"603e90d8bf90b1392f094cda3649782fb0ae4fd0","unresolved":false,"context_lines":[{"line_number":686,"context_line":"        self.shell._cache_schemas(self._make_args(options),"},{"line_number":687,"context_line":"                                  client, home_dir\u003dself.cache_dir)"},{"line_number":688,"context_line":""},{"line_number":689,"context_line":"        os.path.exists.assert_has_calls(["},{"line_number":690,"context_line":"            mock.call(self.prefix_path),"},{"line_number":691,"context_line":"            mock.call(self.cache_files[0]),"},{"line_number":692,"context_line":"            mock.call(self.cache_files[1])"}],"source_content_type":"text/x-python","patch_set":2,"id":"bae84128_2456d305","line":689,"updated":"2016-02-24 12:59:31.000000000","message":"Not reason for -1 but can we exists_mock instead of os.path.exists here?\nAnother option would be use os.path.exists.call_count in l 694","commit_id":"744b88b8f993b53095bcbe1765a354d7eed51f16"},{"author":{"_account_id":17081,"name":"Chaozhe Chen(ccz)","email":"chaozhe.chen@easystack.cn","username":"Chaozhe.Chen"},"change_message_id":"81e7c29ba7429c0fb4f90b1459cc3ef282cf92ae","unresolved":false,"context_lines":[{"line_number":686,"context_line":"        self.shell._cache_schemas(self._make_args(options),"},{"line_number":687,"context_line":"                                  client, home_dir\u003dself.cache_dir)"},{"line_number":688,"context_line":""},{"line_number":689,"context_line":"        os.path.exists.assert_has_calls(["},{"line_number":690,"context_line":"            mock.call(self.prefix_path),"},{"line_number":691,"context_line":"            mock.call(self.cache_files[0]),"},{"line_number":692,"context_line":"            mock.call(self.cache_files[1])"}],"source_content_type":"text/x-python","patch_set":2,"id":"bae84128_f945ad6e","line":689,"in_reply_to":"bae84128_2456d305","updated":"2016-02-24 14:50:41.000000000","message":"Yes, better use exists_mock here. Will update","commit_id":"744b88b8f993b53095bcbe1765a354d7eed51f16"},{"author":{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},"change_message_id":"603e90d8bf90b1392f094cda3649782fb0ae4fd0","unresolved":false,"context_lines":[{"line_number":689,"context_line":"        os.path.exists.assert_has_calls(["},{"line_number":690,"context_line":"            mock.call(self.prefix_path),"},{"line_number":691,"context_line":"            mock.call(self.cache_files[0]),"},{"line_number":692,"context_line":"            mock.call(self.cache_files[1])"},{"line_number":693,"context_line":"        ])"},{"line_number":694,"context_line":"        self.assertEqual(4, exists_mock.call_count)"},{"line_number":695,"context_line":"        self.assertEqual(0, open.mock_calls.__len__())"}],"source_content_type":"text/x-python","patch_set":2,"id":"bae84128_c4044716","line":692,"updated":"2016-02-24 12:59:31.000000000","message":"Looks like we need to check mock.call(self.cache_files[4])\nDon\u0027t we?","commit_id":"744b88b8f993b53095bcbe1765a354d7eed51f16"},{"author":{"_account_id":17081,"name":"Chaozhe Chen(ccz)","email":"chaozhe.chen@easystack.cn","username":"Chaozhe.Chen"},"change_message_id":"81e7c29ba7429c0fb4f90b1459cc3ef282cf92ae","unresolved":false,"context_lines":[{"line_number":689,"context_line":"        os.path.exists.assert_has_calls(["},{"line_number":690,"context_line":"            mock.call(self.prefix_path),"},{"line_number":691,"context_line":"            mock.call(self.cache_files[0]),"},{"line_number":692,"context_line":"            mock.call(self.cache_files[1])"},{"line_number":693,"context_line":"        ])"},{"line_number":694,"context_line":"        self.assertEqual(4, exists_mock.call_count)"},{"line_number":695,"context_line":"        self.assertEqual(0, open.mock_calls.__len__())"}],"source_content_type":"text/x-python","patch_set":2,"id":"bae84128_dc9d37bd","line":692,"in_reply_to":"bae84128_c4044716","updated":"2016-02-24 14:50:41.000000000","message":"Should be self.cache_files[2]. Will update.","commit_id":"744b88b8f993b53095bcbe1765a354d7eed51f16"}]}