)]}'
{"id":"openstack%2Fpython-glanceclient~281676","triplet_id":"openstack%2Fpython-glanceclient~master~Ie45e7c56b1c859916a1f31636c639422f1ffef28","project":"openstack/python-glanceclient","branch":"master","topic":"assert_call","hashtags":[],"change_id":"Ie45e7c56b1c859916a1f31636c639422f1ffef28","subject":"Test: use assert_has_calls() instead","status":"MERGED","created":"2016-02-18 07:37:13.000000000","updated":"2016-02-29 19:21:41.000000000","submitted":"2016-02-29 19:21:41.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":5,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"7c87aa2afdb018c369d56e881e1d9e0c6d2910d9","_number":281676,"virtual_id_number":281676,"owner":{"_account_id":17081,"name":"Chaozhe Chen(ccz)","email":"chaozhe.chen@easystack.cn","username":"Chaozhe.Chen"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2016-02-29 19:21:40.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},{"value":0,"_account_id":17081,"name":"Chaozhe Chen(ccz)","email":"chaozhe.chen@easystack.cn","username":"Chaozhe.Chen"},{"value":0,"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2016-02-29 10:02:36.000000000","_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},{"value":0,"_account_id":17081,"name":"Chaozhe Chen(ccz)","email":"chaozhe.chen@easystack.cn","username":"Chaozhe.Chen"},{"value":2,"date":"2016-02-29 18:18:13.000000000","_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},{"value":0,"_account_id":17081,"name":"Chaozhe Chen(ccz)","email":"chaozhe.chen@easystack.cn","username":"Chaozhe.Chen"},{"value":1,"date":"2016-02-29 18:18:13.000000000","_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},{"value":0,"_account_id":17081,"name":"Chaozhe Chen(ccz)","email":"chaozhe.chen@easystack.cn","username":"Chaozhe.Chen"},{"value":0,"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Top Priority / Holds Gate"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},{"_account_id":17081,"name":"Chaozhe Chen(ccz)","email":"chaozhe.chen@easystack.cn","username":"Chaozhe.Chen"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-02-29 10:02:36.000000000","updated_by":{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},"reviewer":{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},"state":"REVIEWER"},{"updated":"2016-02-29 18:18:13.000000000","updated_by":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"reviewer":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"state":"REVIEWER"},{"updated":"2016-02-29 19:21:40.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"1cf453b8ea28c5bdab9bb63dc53c32993ae1c31e","author":{"_account_id":17081,"name":"Chaozhe Chen(ccz)","email":"chaozhe.chen@easystack.cn","username":"Chaozhe.Chen"},"date":"2016-02-18 07:37:13.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"3de8910057543d92a1d1a49c8216547581b2edf4","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-02-18 08:19:46.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-glanceclient-pep8 http://logs.openstack.org/76/281676/1/check/gate-python-glanceclient-pep8/39e4164/ : SUCCESS in 1m 43s\n- gate-python-glanceclient-docs http://docs-draft.openstack.org/76/281676/1/check/gate-python-glanceclient-docs/85d9308//doc/build/html/ : SUCCESS in 52s\n- gate-python-glanceclient-python27 http://logs.openstack.org/76/281676/1/check/gate-python-glanceclient-python27/18f4c1f/ : SUCCESS in 2m 18s\n- gate-python-glanceclient-python34 http://logs.openstack.org/76/281676/1/check/gate-python-glanceclient-python34/6c49f22/ : SUCCESS in 1m 43s\n- gate-tempest-dsvm-neutron-src-python-glanceclient http://logs.openstack.org/76/281676/1/check/gate-tempest-dsvm-neutron-src-python-glanceclient/f4e9d4d/ : SUCCESS in 42m 25s\n- gate-glanceclient-dsvm-functional http://logs.openstack.org/76/281676/1/check/gate-glanceclient-dsvm-functional/cac4628/ : SUCCESS in 20m 25s","accounts_in_message":[],"_revision_number":1},{"id":"be6cbab6d7bebedeb3b5d51a78a20456ca4743f5","author":{"_account_id":17081,"name":"Chaozhe Chen(ccz)","email":"chaozhe.chen@easystack.cn","username":"Chaozhe.Chen"},"date":"2016-02-22 04:18:00.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"480047808fcd6bf52ca90b7a48209b66b82a7692","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-02-22 05:24:15.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-glanceclient-pep8 http://logs.openstack.org/76/281676/2/check/gate-python-glanceclient-pep8/d8f5116/ : SUCCESS in 40s\n- gate-python-glanceclient-docs http://docs-draft.openstack.org/76/281676/2/check/gate-python-glanceclient-docs/b8ce8d1//doc/build/html/ : SUCCESS in 2m 45s\n- gate-python-glanceclient-python27 http://logs.openstack.org/76/281676/2/check/gate-python-glanceclient-python27/dc9c9f2/ : SUCCESS in 54s\n- gate-python-glanceclient-python34 http://logs.openstack.org/76/281676/2/check/gate-python-glanceclient-python34/f1d480a/ : SUCCESS in 1m 45s\n- gate-tempest-dsvm-neutron-src-python-glanceclient http://logs.openstack.org/76/281676/2/check/gate-tempest-dsvm-neutron-src-python-glanceclient/2e2d754/ : SUCCESS in 1h 06m 07s\n- gate-glanceclient-dsvm-functional http://logs.openstack.org/76/281676/2/check/gate-glanceclient-dsvm-functional/2ee49a1/ : SUCCESS in 15m 06s","accounts_in_message":[],"_revision_number":2},{"id":"603e90d8bf90b1392f094cda3649782fb0ae4fd0","author":{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},"date":"2016-02-24 12:59:31.000000000","message":"Patch Set 2: Code-Review-1\n\n(3 comments)","accounts_in_message":[],"_revision_number":2},{"id":"81e7c29ba7429c0fb4f90b1459cc3ef282cf92ae","author":{"_account_id":17081,"name":"Chaozhe Chen(ccz)","email":"chaozhe.chen@easystack.cn","username":"Chaozhe.Chen"},"date":"2016-02-24 14:50:41.000000000","message":"Patch Set 2:\n\n(2 comments)\n\n@Kairat, Thanks for your review - latest patchset will reflect your suggestion.","accounts_in_message":[],"_revision_number":2},{"id":"fa686d55dd13e6d48eafc0c6d9ad37ec13320193","author":{"_account_id":17081,"name":"Chaozhe Chen(ccz)","email":"chaozhe.chen@easystack.cn","username":"Chaozhe.Chen"},"date":"2016-02-24 14:54:20.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"02f5a1ce0569c19fe8a1bfd3970c0585c0f5f8f7","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-02-24 15:53:00.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-glanceclient-pep8 http://logs.openstack.org/76/281676/3/check/gate-python-glanceclient-pep8/6da20f8/ : SUCCESS in 49s\n- gate-python-glanceclient-docs http://docs-draft.openstack.org/76/281676/3/check/gate-python-glanceclient-docs/6606836//doc/build/html/ : SUCCESS in 1m 01s\n- gate-python-glanceclient-python27 http://logs.openstack.org/76/281676/3/check/gate-python-glanceclient-python27/0de85d7/ : SUCCESS in 1m 31s\n- gate-python-glanceclient-python34 http://logs.openstack.org/76/281676/3/check/gate-python-glanceclient-python34/2662ba1/ : SUCCESS in 2m 04s\n- gate-tempest-dsvm-neutron-src-python-glanceclient http://logs.openstack.org/76/281676/3/check/gate-tempest-dsvm-neutron-src-python-glanceclient/f9a9cee/ : SUCCESS in 50m 20s\n- gate-glanceclient-dsvm-functional http://logs.openstack.org/76/281676/3/check/gate-glanceclient-dsvm-functional/4e593c4/ : SUCCESS in 19m 56s","accounts_in_message":[],"_revision_number":3},{"id":"08ae742ad3fff7b5d7bc094c6b745accc770386a","author":{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},"date":"2016-02-29 10:02:36.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"130a0c7b3d56bc6053eb188e5f4245061e3ecea4","author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"date":"2016-02-29 18:18:13.000000000","message":"Patch Set 3: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":3},{"id":"c5edf623d15f3089ff24f17110a6d09038f26474","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-02-29 18:18:20.000000000","message":"Patch Set 3: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":3},{"id":"524abab2fe67e1e31166a6fbd1429f3e5d463552","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-02-29 19:21:40.000000000","message":"Patch Set 3: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-glanceclient-docs http://docs-draft.openstack.org/76/281676/3/gate/gate-python-glanceclient-docs/bcffd5b//doc/build/html/ : SUCCESS in 59s\n- gate-python-glanceclient-pep8 http://logs.openstack.org/76/281676/3/gate/gate-python-glanceclient-pep8/4610a68/ : SUCCESS in 58s\n- gate-python-glanceclient-python27 http://logs.openstack.org/76/281676/3/gate/gate-python-glanceclient-python27/4645d73/ : SUCCESS in 57s\n- gate-python-glanceclient-python34 http://logs.openstack.org/76/281676/3/gate/gate-python-glanceclient-python34/0e6d794/ : SUCCESS in 2m 15s\n- gate-tempest-dsvm-neutron-src-python-glanceclient http://logs.openstack.org/76/281676/3/gate/gate-tempest-dsvm-neutron-src-python-glanceclient/d42c10c/ : SUCCESS in 1h 02m 37s\n- gate-glanceclient-dsvm-functional http://logs.openstack.org/76/281676/3/gate/gate-glanceclient-dsvm-functional/0cba883/ : SUCCESS in 41m 11s","accounts_in_message":[],"_revision_number":3},{"id":"079769ef1440132d5ec85c8744695b092aa6b02c","date":"2016-02-29 19:21:41.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"d28ccb37ff5d9e310c4e6d4409f9d642423dd260","revisions":{"233a62dfd1d064f1a6db0ca8a9319837fa2c5f8e":{"kind":"REWORK","_number":1,"created":"2016-02-18 07:37:13.000000000","uploader":{"_account_id":17081,"name":"Chaozhe Chen(ccz)","email":"chaozhe.chen@easystack.cn","username":"Chaozhe.Chen"},"ref":"refs/changes/76/281676/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/76/281676/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/76/281676/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/76/281676/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/76/281676/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/76/281676/1"}}},"commit":{"parents":[{"commit":"c58b4cc984908d154fd6c7294adac2b5586da874","subject":"Merge \"Auto-generated squash commit\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/c58b4cc984908d154fd6c7294adac2b5586da874"}]}],"author":{"name":"Chaozhe.Chen","email":"chaozhe.chen@easystack.cn","date":"2016-02-18 07:26:16.000000000","tz":480},"committer":{"name":"Chaozhe.Chen","email":"chaozhe.chen@easystack.cn","date":"2016-02-18 07:35:24.000000000","tz":480},"subject":"Test: use assert_has_calls() instead","message":"Test: use assert_has_calls() instead\n\nWhen set any_order false, assert_has_calls() will assert the mock\nhas been called in order.\nSome of the assertions in glanceclient test are sequential, should\nbetter use assert_has_calls() instead of assert_any_call(). What\u0027s\nmore, assert_has_calls() will throw more clear messages in case of\nfailure.\n\nChange-Id: Ie45e7c56b1c859916a1f31636c639422f1ffef28\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/233a62dfd1d064f1a6db0ca8a9319837fa2c5f8e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/233a62dfd1d064f1a6db0ca8a9319837fa2c5f8e"}]},"branch":"refs/heads/master"},"744b88b8f993b53095bcbe1765a354d7eed51f16":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2016-02-22 04:18:00.000000000","uploader":{"_account_id":17081,"name":"Chaozhe Chen(ccz)","email":"chaozhe.chen@easystack.cn","username":"Chaozhe.Chen"},"ref":"refs/changes/76/281676/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/76/281676/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/76/281676/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/76/281676/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/76/281676/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/76/281676/2"}}},"commit":{"parents":[{"commit":"c58b4cc984908d154fd6c7294adac2b5586da874","subject":"Merge \"Auto-generated squash commit\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/c58b4cc984908d154fd6c7294adac2b5586da874"}]}],"author":{"name":"Chaozhe.Chen","email":"chaozhe.chen@easystack.cn","date":"2016-02-18 07:26:16.000000000","tz":480},"committer":{"name":"Chaozhe.Chen","email":"chaozhe.chen@easystack.cn","date":"2016-02-22 04:16:20.000000000","tz":480},"subject":"Test: use assert_has_calls() instead","message":"Test: use assert_has_calls() instead\n\nSome of the assertions in cinder test are sequential, we should better\nuse assert_has_calls() instead of assert_any_call().\nAnd assert_has_calls() provides more clear messages in case of failure.\n\nChange-Id: Ie45e7c56b1c859916a1f31636c639422f1ffef28\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/744b88b8f993b53095bcbe1765a354d7eed51f16"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/744b88b8f993b53095bcbe1765a354d7eed51f16"}]},"branch":"refs/heads/master"},"d28ccb37ff5d9e310c4e6d4409f9d642423dd260":{"kind":"REWORK","_number":3,"created":"2016-02-24 14:54:20.000000000","uploader":{"_account_id":17081,"name":"Chaozhe Chen(ccz)","email":"chaozhe.chen@easystack.cn","username":"Chaozhe.Chen"},"ref":"refs/changes/76/281676/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/76/281676/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/76/281676/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/76/281676/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/76/281676/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/76/281676/3"}}},"commit":{"parents":[{"commit":"c58b4cc984908d154fd6c7294adac2b5586da874","subject":"Merge \"Auto-generated squash commit\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/c58b4cc984908d154fd6c7294adac2b5586da874"}]}],"author":{"name":"Chaozhe.Chen","email":"chaozhe.chen@easystack.cn","date":"2016-02-18 07:26:16.000000000","tz":480},"committer":{"name":"Chaozhe.Chen","email":"chaozhe.chen@easystack.cn","date":"2016-02-24 14:54:00.000000000","tz":480},"subject":"Test: use assert_has_calls() instead","message":"Test: use assert_has_calls() instead\n\nSome of the assertions in glanceclient test are sequential, we should\nbetter use assert_has_calls() instead of assert_any_call().\nAnd assert_has_calls() provides more clear messages in case of failure.\n\nChange-Id: Ie45e7c56b1c859916a1f31636c639422f1ffef28\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/d28ccb37ff5d9e310c4e6d4409f9d642423dd260"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/d28ccb37ff5d9e310c4e6d4409f9d642423dd260"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}