)]}'
{"glanceclient/v2/images.py":[{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"4fad8ce2160e5742902ac452b827e84980dbd28c","unresolved":false,"context_lines":[{"line_number":72,"context_line":"                       \u0027 It must be one of the following: %(available)s.\u0027"},{"line_number":73,"context_line":"                       ) % {\u0027sort_dir\u0027: dir,"},{"line_number":74,"context_line":"                            \u0027available\u0027: \u0027, \u0027.join(SORT_DIR_VALUES)}"},{"line_number":75,"context_line":"                raise exc.ClientException(msg)"},{"line_number":76,"context_line":"            if key not in SORT_KEY_VALUES:"},{"line_number":77,"context_line":"                msg \u003d (\u0027Invalid sort key: %(sort_key)s.\u0027"},{"line_number":78,"context_line":"                       \u0027 It must be one of the following: %(available)s.\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"9aed3d3a_a491b554","line":75,"updated":"2016-02-28 14:49:37.000000000","message":"Changing this would break the API. We should catch the `HTTPBadRequest` in the `shell.py` call and raise the right exception from there.\n\nAlso, TBH, I don\u0027t really mind the `400` error to be there. This code, as much as I hate it, is short-circuiting a check that should happen server side to begin with.","commit_id":"a242b81decb3c7d503a76a1c0c97f9c02c34780e"},{"author":{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},"change_message_id":"9a9296c7ca36d5cc462a7dcdaaaaf57c2491ffc7","unresolved":false,"context_lines":[{"line_number":72,"context_line":"                       \u0027 It must be one of the following: %(available)s.\u0027"},{"line_number":73,"context_line":"                       ) % {\u0027sort_dir\u0027: dir,"},{"line_number":74,"context_line":"                            \u0027available\u0027: \u0027, \u0027.join(SORT_DIR_VALUES)}"},{"line_number":75,"context_line":"                raise exc.ClientException(msg)"},{"line_number":76,"context_line":"            if key not in SORT_KEY_VALUES:"},{"line_number":77,"context_line":"                msg \u003d (\u0027Invalid sort key: %(sort_key)s.\u0027"},{"line_number":78,"context_line":"                       \u0027 It must be one of the following: %(available)s.\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"9aed3d3a_a7db654e","line":75,"in_reply_to":"9aed3d3a_a491b554","updated":"2016-02-29 09:40:19.000000000","message":"I believe we just need to delete this code from client.\nI noticed server behaves the same way: it raises 400 error to client. Such kind of checks makes some assumption about server logic which is not good IMO. So we don\u0027t need to double that check on client side.","commit_id":"a242b81decb3c7d503a76a1c0c97f9c02c34780e"}]}