)]}'
{"id":"openstack%2Fpython-glanceclient~285771","triplet_id":"openstack%2Fpython-glanceclient~master~I81dfe91f18b0d3444d9652036f6ce042117e6077","project":"openstack/python-glanceclient","branch":"master","topic":"bug/1550890","hashtags":[],"change_id":"I81dfe91f18b0d3444d9652036f6ce042117e6077","subject":"Don\u0027t print HTTP code for non-HTTP error.","status":"ABANDONED","created":"2016-02-28 09:33:10.000000000","updated":"2016-06-13 14:36:25.000000000","total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"76272cff28c8b12e15fd984fc923c4caba3c86ed","_number":285771,"virtual_id_number":285771,"owner":{"_account_id":20105,"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","username":"caosf.fnst"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":1,"date":"2016-03-01 10:46:10.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},{"date":"2016-03-01 09:34:06.000000000","_account_id":20105,"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","username":"caosf.fnst"},{"date":"2016-03-01 12:34:57.000000000","_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":20105,"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","username":"caosf.fnst"},{"value":-1,"date":"2016-03-11 20:27:43.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":20105,"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","username":"caosf.fnst"},{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},{"_account_id":20105,"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","username":"caosf.fnst"},{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Top Priority / Holds Gate"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},{"_account_id":20105,"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","username":"caosf.fnst"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-02-29 09:40:19.000000000","updated_by":{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},"reviewer":{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},"state":"REVIEWER"},{"updated":"2016-03-01 10:46:10.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2016-03-01 12:34:57.000000000","updated_by":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"reviewer":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"state":"REVIEWER"}],"messages":[{"id":"aeaf7d9d255a353699de78b0e9ba845c05c74d08","author":{"_account_id":20105,"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","username":"caosf.fnst"},"date":"2016-02-28 09:33:10.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"2c8e2e7c3b1b2c973830dfd56d39133d4d3ac27a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-02-28 10:35:06.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-glanceclient-pep8 http://logs.openstack.org/71/285771/1/check/gate-python-glanceclient-pep8/1018d63/ : SUCCESS in 42s\n- gate-python-glanceclient-docs http://docs-draft.openstack.org/71/285771/1/check/gate-python-glanceclient-docs/cc7b299//doc/build/html/ : SUCCESS in 1m 16s\n- gate-python-glanceclient-python27 http://logs.openstack.org/71/285771/1/check/gate-python-glanceclient-python27/152eb33/ : SUCCESS in 1m 01s\n- gate-python-glanceclient-python34 http://logs.openstack.org/71/285771/1/check/gate-python-glanceclient-python34/4f8bec1/ : SUCCESS in 1m 36s\n- gate-tempest-dsvm-neutron-src-python-glanceclient http://logs.openstack.org/71/285771/1/check/gate-tempest-dsvm-neutron-src-python-glanceclient/6d1afd4/ : SUCCESS in 1h 00m 16s\n- gate-glanceclient-dsvm-functional http://logs.openstack.org/71/285771/1/check/gate-glanceclient-dsvm-functional/acbc2a2/ : SUCCESS in 18m 00s","accounts_in_message":[],"_revision_number":1},{"id":"4fad8ce2160e5742902ac452b827e84980dbd28c","author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"date":"2016-02-28 14:49:37.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"9a9296c7ca36d5cc462a7dcdaaaaf57c2491ffc7","author":{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},"date":"2016-02-29 09:40:19.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"837edf484ad3024c8e0a6f93892b513f786b63d3","author":{"_account_id":20105,"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","username":"caosf.fnst"},"date":"2016-03-01 09:23:12.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"27a816514274786983ea0082b6c54b073a78863d","author":{"_account_id":20105,"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","username":"caosf.fnst"},"date":"2016-03-01 09:34:06.000000000","message":"Patch Set 2:\n\n\u003e (1 comment)\n\nHi, Flavio Percoco:\nThank you for you suggestion, it\u0027s not a good idea to break backward compatibility.\nI hope patch set 2 will work.\nThanks.","accounts_in_message":[],"_revision_number":2},{"id":"371d5724899f327629bfbacd5280392ed76de055","author":{"_account_id":20105,"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","username":"caosf.fnst"},"date":"2016-03-01 09:34:39.000000000","message":"Patch Set 2:\n\n\u003e (1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"3d0bbcb9b533a886f4bb9e983a6653523d277b03","author":{"_account_id":20105,"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","username":"caosf.fnst"},"date":"2016-03-01 09:39:59.000000000","message":"Patch Set 2:\n\n\u003e (1 comment)\n\nHi, Kairat Kushaev:\nThanks for your suggestion.\nI get no plan to delete the client-side check.At least the check can help reduce the server load and save bandwidth.\nI hope patch set 2 will work.\nThanks","accounts_in_message":[],"_revision_number":2},{"id":"71ba18272a38910301dfbb64653c5dc7175e9492","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-03-01 10:46:10.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-glanceclient-pep8 http://logs.openstack.org/71/285771/2/check/gate-python-glanceclient-pep8/9b25d9f/ : SUCCESS in 38s\n- gate-python-glanceclient-docs http://docs-draft.openstack.org/71/285771/2/check/gate-python-glanceclient-docs/4b94116//doc/build/html/ : SUCCESS in 51s\n- gate-python-glanceclient-python27 http://logs.openstack.org/71/285771/2/check/gate-python-glanceclient-python27/50257f3/ : SUCCESS in 1m 01s\n- gate-python-glanceclient-python34 http://logs.openstack.org/71/285771/2/check/gate-python-glanceclient-python34/b53243d/ : SUCCESS in 1m 45s\n- gate-tempest-dsvm-neutron-src-python-glanceclient http://logs.openstack.org/71/285771/2/check/gate-tempest-dsvm-neutron-src-python-glanceclient/d4ec0bd/ : SUCCESS in 53m 19s\n- gate-glanceclient-dsvm-functional http://logs.openstack.org/71/285771/2/check/gate-glanceclient-dsvm-functional/37f529c/ : SUCCESS in 18m 09s","accounts_in_message":[],"_revision_number":2},{"id":"222c56511b1b1fcd20d87fb210636d21aec8ee1d","author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"date":"2016-03-01 12:34:57.000000000","message":"Patch Set 2:\n\nI wonder if there are folks parsing this codes from the CLI output. :/\n\nTBH, I\u0027m not really worried about the HTTP code being there. I don\u0027t think it causes any harm.","accounts_in_message":[],"_revision_number":2},{"id":"927072c81d7f6f415951decc12467e79cf875d26","author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"date":"2016-03-11 20:27:43.000000000","message":"Patch Set 2: Code-Review-1\n\n-1 to raise some awareness","accounts_in_message":[],"_revision_number":2},{"id":"58fea677c791e142eae2b127d69b79ca01344f74","author":{"_account_id":20105,"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","username":"caosf.fnst"},"date":"2016-06-13 14:36:25.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"6bc8b393fbaaa7c6f3c27d08dc48b13adbd1a8ec","revisions":{"a242b81decb3c7d503a76a1c0c97f9c02c34780e":{"kind":"REWORK","_number":1,"created":"2016-02-28 09:33:10.000000000","uploader":{"_account_id":20105,"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","username":"caosf.fnst"},"ref":"refs/changes/71/285771/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/71/285771/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/71/285771/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/71/285771/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/71/285771/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/71/285771/1"}}},"commit":{"parents":[{"commit":"6146e03e5cc5ec574b49ac1ff7d169b559f48320","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/6146e03e5cc5ec574b49ac1ff7d169b559f48320"}]}],"author":{"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","date":"2016-02-28 09:15:47.000000000","tz":480},"committer":{"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","date":"2016-02-28 09:15:47.000000000","tz":480},"subject":"Don\u0027t print HTTP code for non-HTTP error.","message":"Don\u0027t print HTTP code for non-HTTP error.\n\nWhen checking sort params for \"glance image-list\" subcommd fails,\na \"(HTTP 400)\" is returned to cli users. This will make users thought\nthat the status_code is returned from the server-side.\n\nThis changes:\n$ glance image-list  --sort-key name --sort name:asc\nThe \u0027sort\u0027 argument is not supported with \u0027sort_key\u0027 or \u0027sort_dir\u0027. (HTTP 400)\n\nTo:\n$ glance image-list  --sort-key name --sort name:asc\nThe \u0027sort\u0027 argument is not supported with \u0027sort_key\u0027 or \u0027sort_dir\u0027.\n\nChange-Id: I81dfe91f18b0d3444d9652036f6ce042117e6077\nCloses-Bug: 1550890\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/a242b81decb3c7d503a76a1c0c97f9c02c34780e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/a242b81decb3c7d503a76a1c0c97f9c02c34780e"}]},"branch":"refs/heads/master"},"6bc8b393fbaaa7c6f3c27d08dc48b13adbd1a8ec":{"kind":"REWORK","_number":2,"created":"2016-03-01 09:23:12.000000000","uploader":{"_account_id":20105,"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","username":"caosf.fnst"},"ref":"refs/changes/71/285771/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/71/285771/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/71/285771/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/71/285771/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/71/285771/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/71/285771/2"}}},"commit":{"parents":[{"commit":"6146e03e5cc5ec574b49ac1ff7d169b559f48320","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/6146e03e5cc5ec574b49ac1ff7d169b559f48320"}]}],"author":{"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","date":"2016-03-01 07:45:46.000000000","tz":480},"committer":{"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","date":"2016-03-01 09:19:29.000000000","tz":480},"subject":"Don\u0027t print HTTP code for non-HTTP error.","message":"Don\u0027t print HTTP code for non-HTTP error.\n\nGlanceclient will do some client-side check for some behaviors. When\nthe check fails, it will guess a HTTP status_code which the server-side\nwould response if we pass the error params to server-side.\n\nHowever, such status_code will make users thought that it is returned\nfrom server-side.\n\nIt will be quite confusing to anyone debugging things looking for a\nHTTP call resulting in error HTTP status_code.\n\nChange-Id: I81dfe91f18b0d3444d9652036f6ce042117e6077\nCloses-Bug: 1550890\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/6bc8b393fbaaa7c6f3c27d08dc48b13adbd1a8ec"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/6bc8b393fbaaa7c6f3c27d08dc48b13adbd1a8ec"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}