)]}'
{"glanceclient/shell.py":[{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"ad6f18c14e4601251d25f5c3d847573e56803116","unresolved":false,"context_lines":[{"line_number":584,"context_line":"        # Set up the root logger to debug so that the submodules can"},{"line_number":585,"context_line":"        # print debug messages"},{"line_number":586,"context_line":"        logging.basicConfig(level\u003dlogging.DEBUG if args.debug else"},{"line_number":587,"context_line":"                            logging.WARNING)"},{"line_number":588,"context_line":"        LOG \u003d logging.getLogger(\u0027glanceclient\u0027)"},{"line_number":589,"context_line":"        LOG.addHandler(logging.StreamHandler())"},{"line_number":590,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9aed3d3a_a4952888","line":587,"range":{"start_line":587,"start_character":28,"end_line":587,"end_character":43},"updated":"2016-02-29 06:23:53.000000000","message":"So you change the default level from INFO to WARNING. any reason?","commit_id":"d77ded35d9946863bea88635e7fe20ad4fd35624"},{"author":{"_account_id":20105,"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","username":"caosf.fnst"},"change_message_id":"4e684dc5cf57df7d38dadf01d004eee042a1d448","unresolved":false,"context_lines":[{"line_number":584,"context_line":"        # Set up the root logger to debug so that the submodules can"},{"line_number":585,"context_line":"        # print debug messages"},{"line_number":586,"context_line":"        logging.basicConfig(level\u003dlogging.DEBUG if args.debug else"},{"line_number":587,"context_line":"                            logging.WARNING)"},{"line_number":588,"context_line":"        LOG \u003d logging.getLogger(\u0027glanceclient\u0027)"},{"line_number":589,"context_line":"        LOG.addHandler(logging.StreamHandler())"},{"line_number":590,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9aed3d3a_044854cb","line":587,"range":{"start_line":587,"start_character":28,"end_line":587,"end_character":43},"in_reply_to":"9aed3d3a_a4952888","updated":"2016-02-29 06:48:27.000000000","message":"Hi Wang:\nYour concern makes sense.\nI don\u0027t want to change this also, but if we use the INFO level, we get this:\nhttp://paste.openstack.org/show/488500/\n\nFurther more, I searched the source code of glanceclient, and I think that we have never used the INFO level in glanceclient. So I believe this will not break backward compatibility.\n\nThanks","commit_id":"d77ded35d9946863bea88635e7fe20ad4fd35624"},{"author":{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},"change_message_id":"5aa63e4e199dbe2b9f8e5e6ab176e39bb17c9a34","unresolved":false,"context_lines":[{"line_number":49,"context_line":"SUPPORTED_VERSIONS \u003d [1, 2]"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"# set up default stream handler for root logger"},{"line_number":52,"context_line":"logging.basicConfig()"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"class OpenStackImagesShell(object):"}],"source_content_type":"text/x-python","patch_set":8,"id":"1af94dfe_58c89322","line":52,"updated":"2016-03-17 07:40:26.000000000","message":"Don\u0027t we need to setup log level here when debug is chosen. So submodules should use that level also?\nAlso I have a question:\ncan it be local, not global?","commit_id":"b4e079b7cf28910317a5dd896688e2e9c46d8759"},{"author":{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},"change_message_id":"83904ce7d92d88c5c561368826322adde7f718be","unresolved":false,"context_lines":[{"line_number":583,"context_line":""},{"line_number":584,"context_line":"        # Set up the root logger to debug so that the submodules can"},{"line_number":585,"context_line":"        # print debug messages"},{"line_number":586,"context_line":"        logging.basicConfig(level\u003dlogging.DEBUG if args.debug else"},{"line_number":587,"context_line":"                            logging.WARNING)"},{"line_number":588,"context_line":"        LOG \u003d logging.getLogger(\u0027glanceclient\u0027)"},{"line_number":589,"context_line":"        LOG.addHandler(logging.StreamHandler())"}],"source_content_type":"text/x-python","patch_set":9,"id":"1af94dfe_fdadd684","line":586,"updated":"2016-03-18 04:48:36.000000000","message":"nit:\nif args.debug:\n   logging.basicConfig(level\u003dlogging.DEBUG)\nwould be more clear IMO","commit_id":"61c820f23d7ae8c996b48bd9138031b720632762"},{"author":{"_account_id":20105,"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","username":"caosf.fnst"},"change_message_id":"5629e9fa33a1a181cbcf1e923534cc484edda165","unresolved":false,"context_lines":[{"line_number":583,"context_line":""},{"line_number":584,"context_line":"        # Set up the root logger to debug so that the submodules can"},{"line_number":585,"context_line":"        # print debug messages"},{"line_number":586,"context_line":"        logging.basicConfig(level\u003dlogging.DEBUG if args.debug else"},{"line_number":587,"context_line":"                            logging.WARNING)"},{"line_number":588,"context_line":"        LOG \u003d logging.getLogger(\u0027glanceclient\u0027)"},{"line_number":589,"context_line":"        LOG.addHandler(logging.StreamHandler())"}],"source_content_type":"text/x-python","patch_set":9,"id":"1af94dfe_e1c6d466","line":586,"in_reply_to":"1af94dfe_fdadd684","updated":"2016-03-18 05:25:39.000000000","message":"Done","commit_id":"61c820f23d7ae8c996b48bd9138031b720632762"},{"author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"change_message_id":"b58b65d9d04a821150b2273eeb10727a72f21a17","unresolved":false,"context_lines":[{"line_number":587,"context_line":"            logging.basicConfig(level\u003dlogging.DEBUG)"},{"line_number":588,"context_line":"            # for iso8601 \u003c 0.1.11"},{"line_number":589,"context_line":"            logging.getLogger(\u0027iso8601\u0027).setLevel(logging.WARNING)"},{"line_number":590,"context_line":"        LOG \u003d logging.getLogger(\u0027glanceclient\u0027)"},{"line_number":591,"context_line":"        LOG.addHandler(logging.StreamHandler())"},{"line_number":592,"context_line":"        LOG.setLevel(logging.DEBUG if args.debug else logging.INFO)"},{"line_number":593,"context_line":""},{"line_number":594,"context_line":"        profile \u003d osprofiler_profiler and options.profile"},{"line_number":595,"context_line":"        if profile:"}],"source_content_type":"text/x-python","patch_set":12,"id":"ba0121b8_4e2c3e02","line":592,"range":{"start_line":590,"start_character":0,"end_line":592,"end_character":67},"updated":"2016-03-30 14:19:12.000000000","message":"Do we still need the three LOG lines above? If so, why? Thanks.","commit_id":"87c8c933bd9b79a2cf06f9f0bc02160b21e8920d"},{"author":{"_account_id":20105,"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","username":"caosf.fnst"},"change_message_id":"95ce33d5a1f876870b1efa14a90ad61a010c892e","unresolved":false,"context_lines":[{"line_number":587,"context_line":"            logging.basicConfig(level\u003dlogging.DEBUG)"},{"line_number":588,"context_line":"            # for iso8601 \u003c 0.1.11"},{"line_number":589,"context_line":"            logging.getLogger(\u0027iso8601\u0027).setLevel(logging.WARNING)"},{"line_number":590,"context_line":"        LOG \u003d logging.getLogger(\u0027glanceclient\u0027)"},{"line_number":591,"context_line":"        LOG.addHandler(logging.StreamHandler())"},{"line_number":592,"context_line":"        LOG.setLevel(logging.DEBUG if args.debug else logging.INFO)"},{"line_number":593,"context_line":""},{"line_number":594,"context_line":"        profile \u003d osprofiler_profiler and options.profile"},{"line_number":595,"context_line":"        if profile:"}],"source_content_type":"text/x-python","patch_set":12,"id":"ba0121b8_a43b7937","line":592,"range":{"start_line":590,"start_character":0,"end_line":592,"end_character":67},"in_reply_to":"ba0121b8_4e2c3e02","updated":"2016-03-30 14:30:56.000000000","message":"Yes, we need it.\nWithout it, the default logging level of \"glanceclient\" will become logging.WARN and previously it it is logging.INFO.\nWe don\u0027t need to change the original logic.\nThanks.","commit_id":"87c8c933bd9b79a2cf06f9f0bc02160b21e8920d"},{"author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"change_message_id":"c7045ef8b441d76364993b7bd754b589d1e0192a","unresolved":false,"context_lines":[{"line_number":587,"context_line":"            logging.basicConfig(level\u003dlogging.DEBUG)"},{"line_number":588,"context_line":"            # for iso8601 \u003c 0.1.11"},{"line_number":589,"context_line":"            logging.getLogger(\u0027iso8601\u0027).setLevel(logging.WARNING)"},{"line_number":590,"context_line":"        LOG \u003d logging.getLogger(\u0027glanceclient\u0027)"},{"line_number":591,"context_line":"        LOG.addHandler(logging.StreamHandler())"},{"line_number":592,"context_line":"        LOG.setLevel(logging.DEBUG if args.debug else logging.INFO)"},{"line_number":593,"context_line":""},{"line_number":594,"context_line":"        profile \u003d osprofiler_profiler and options.profile"},{"line_number":595,"context_line":"        if profile:"}],"source_content_type":"text/x-python","patch_set":12,"id":"ba0121b8_fce50138","line":592,"range":{"start_line":590,"start_character":0,"end_line":592,"end_character":67},"in_reply_to":"ba0121b8_a43b7937","updated":"2016-03-30 16:48:29.000000000","message":"Ok, we don\u0027t seem to have any glanceclient INFO level messages as far as I can tell. I\u0027d be ok with switching this to be WARN to be consistent with Nova, but that\u0027s probably out of scope for this patch.","commit_id":"87c8c933bd9b79a2cf06f9f0bc02160b21e8920d"}]}