)]}'
{"glanceclient/v1/images.py":[{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"959fd13d0867be6dcc363cd502fabf034818a3c3","unresolved":false,"context_lines":[{"line_number":63,"context_line":"            if key.startswith(\u0027x-image-meta-property-\u0027):"},{"line_number":64,"context_line":"                _key \u003d key[22:]"},{"line_number":65,"context_line":"                meta[\u0027properties\u0027]["},{"line_number":66,"context_line":"                    ensure_unicode(_key, incoming\u003d\u0027utf-8\u0027)] \u003d ("},{"line_number":67,"context_line":"                        ensure_unicode(value, incoming\u003d\u0027utf-8\u0027))"},{"line_number":68,"context_line":"            elif key.startswith(\u0027x-image-meta-\u0027):"},{"line_number":69,"context_line":"                _key \u003d key[13:]"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAPH%2F%2F6s0%3D","line":66,"updated":"2013-05-20 11:45:19.000000000","message":"Should this try to get the charset from headers (Content-Type) and then fallback to \u0027utf-8\u0027?","commit_id":"9d5bc553271f2633beb0536d7104f02ae26689c5"},{"author":{"_account_id":6549,"name":"Zhi Yan Liu","email":"lzy.dev@gmail.com","username":"lzy-dev"},"change_message_id":"51af6a587a19b1c1ed7bb8ef32fa4114ec7fba90","unresolved":false,"context_lines":[{"line_number":63,"context_line":"            if key.startswith(\u0027x-image-meta-property-\u0027):"},{"line_number":64,"context_line":"                _key \u003d key[22:]"},{"line_number":65,"context_line":"                meta[\u0027properties\u0027]["},{"line_number":66,"context_line":"                    ensure_unicode(_key, incoming\u003d\u0027utf-8\u0027)] \u003d ("},{"line_number":67,"context_line":"                        ensure_unicode(value, incoming\u003d\u0027utf-8\u0027))"},{"line_number":68,"context_line":"            elif key.startswith(\u0027x-image-meta-\u0027):"},{"line_number":69,"context_line":"                _key \u003d key[13:]"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAPH%2F%2F6EU%3D","line":66,"in_reply_to":"AAAAPH%2F%2F6JU%3D","updated":"2013-05-20 16:07:22.000000000","message":"Glance API v1 have some wrong design, like this one.","commit_id":"9d5bc553271f2633beb0536d7104f02ae26689c5"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"9c296c5e8defeb97be0ffdc6ef9a899548b3c2f6","unresolved":false,"context_lines":[{"line_number":63,"context_line":"            if key.startswith(\u0027x-image-meta-property-\u0027):"},{"line_number":64,"context_line":"                _key \u003d key[22:]"},{"line_number":65,"context_line":"                meta[\u0027properties\u0027]["},{"line_number":66,"context_line":"                    ensure_unicode(_key, incoming\u003d\u0027utf-8\u0027)] \u003d ("},{"line_number":67,"context_line":"                        ensure_unicode(value, incoming\u003d\u0027utf-8\u0027))"},{"line_number":68,"context_line":"            elif key.startswith(\u0027x-image-meta-\u0027):"},{"line_number":69,"context_line":"                _key \u003d key[13:]"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAPH%2F%2F6JU%3D","line":66,"in_reply_to":"AAAAPH%2F%2F6oA%3D","updated":"2013-05-20 15:47:02.000000000","message":"Oh right! T_T\n\nNevermind about using the header, that was silly.","commit_id":"9d5bc553271f2633beb0536d7104f02ae26689c5"},{"author":{"_account_id":6549,"name":"Zhi Yan Liu","email":"lzy.dev@gmail.com","username":"lzy-dev"},"change_message_id":"0a960648bb1d631139da22688a59287d21f924d5","unresolved":false,"context_lines":[{"line_number":63,"context_line":"            if key.startswith(\u0027x-image-meta-property-\u0027):"},{"line_number":64,"context_line":"                _key \u003d key[22:]"},{"line_number":65,"context_line":"                meta[\u0027properties\u0027]["},{"line_number":66,"context_line":"                    ensure_unicode(_key, incoming\u003d\u0027utf-8\u0027)] \u003d ("},{"line_number":67,"context_line":"                        ensure_unicode(value, incoming\u003d\u0027utf-8\u0027))"},{"line_number":68,"context_line":"            elif key.startswith(\u0027x-image-meta-\u0027):"},{"line_number":69,"context_line":"                _key \u003d key[13:]"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAPH%2F%2F6oA%3D","line":66,"in_reply_to":"AAAAPH%2F%2F6s0%3D","updated":"2013-05-20 12:48:49.000000000","message":"I don\u0027t think so, since: a) Content-Type is for http body as it named, but those key/value pairs in http header. b) utf-8 coding is well-known, glance-api code it explicitly.","commit_id":"9d5bc553271f2633beb0536d7104f02ae26689c5"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"d81de7a81ece1b3c6b4c8196294efd7507aec7f9","unresolved":false,"context_lines":[{"line_number":63,"context_line":"            if key.startswith(\u0027x-image-meta-property-\u0027):"},{"line_number":64,"context_line":"                _key \u003d key[22:]"},{"line_number":65,"context_line":"                meta[\u0027properties\u0027]["},{"line_number":66,"context_line":"                    ensure_unicode(_key, incoming\u003d\u0027utf-8\u0027)] \u003d ("},{"line_number":67,"context_line":"                        ensure_unicode(value, incoming\u003d\u0027utf-8\u0027))"},{"line_number":68,"context_line":"            elif key.startswith(\u0027x-image-meta-\u0027):"},{"line_number":69,"context_line":"                _key \u003d key[13:]"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAPH%2F%2F6Is%3D","line":66,"updated":"2013-05-20 15:49:58.000000000","message":"could you please assign this in a var (say, key) above this line? same for the value","commit_id":"5391a643058f4c7249f3d42c59ce21f23b4f9f00"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"d81de7a81ece1b3c6b4c8196294efd7507aec7f9","unresolved":false,"context_lines":[{"line_number":67,"context_line":"                        ensure_unicode(value, incoming\u003d\u0027utf-8\u0027))"},{"line_number":68,"context_line":"            elif key.startswith(\u0027x-image-meta-\u0027):"},{"line_number":69,"context_line":"                _key \u003d key[13:]"},{"line_number":70,"context_line":"                meta[ensure_unicode(_key, incoming\u003d\u0027utf-8\u0027)] \u003d ("},{"line_number":71,"context_line":"                    ensure_unicode(value, incoming\u003d\u0027utf-8\u0027))"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"        for key in [\u0027is_public\u0027, \u0027protected\u0027, \u0027deleted\u0027]:"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAPH%2F%2F6Ik%3D","line":70,"updated":"2013-05-20 15:49:58.000000000","message":"ditto","commit_id":"5391a643058f4c7249f3d42c59ce21f23b4f9f00"}],"tests/v1/test_images.py":[{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"959fd13d0867be6dcc363cd502fabf034818a3c3","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# coding\u003dutf-8"},{"line_number":2,"context_line":"# Copyright 2012 OpenStack LLC."},{"line_number":3,"context_line":"# All Rights Reserved."},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAPH%2F%2F6tQ%3D","line":1,"updated":"2013-05-20 11:45:19.000000000","message":"Hey,\n\nPlease, use the ascii representation of those characters instead of adding this. Something similar was done here:\n\nhttps://github.com/openstack/python-glanceclient/blob/55cb4f4473a6fc429524e7c4848379013a4d2d1d/tests/test_utils.py#L69","commit_id":"9d5bc553271f2633beb0536d7104f02ae26689c5"},{"author":{"_account_id":6549,"name":"Zhi Yan Liu","email":"lzy.dev@gmail.com","username":"lzy-dev"},"change_message_id":"0a960648bb1d631139da22688a59287d21f924d5","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# coding\u003dutf-8"},{"line_number":2,"context_line":"# Copyright 2012 OpenStack LLC."},{"line_number":3,"context_line":"# All Rights Reserved."},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAPH%2F%2F6mU%3D","line":1,"in_reply_to":"AAAAPH%2F%2F6tQ%3D","updated":"2013-05-20 12:48:49.000000000","message":"Done","commit_id":"9d5bc553271f2633beb0536d7104f02ae26689c5"}]}