)]}'
{"id":"openstack%2Fpython-glanceclient~30070","triplet_id":"openstack%2Fpython-glanceclient~master~I9a0dca31140bae28d8ec6aede515c5bb852b701b","project":"openstack/python-glanceclient","branch":"master","topic":"strutils","hashtags":[],"change_id":"I9a0dca31140bae28d8ec6aede515c5bb852b701b","subject":"Replace utils.ensure_(str|unicode) with strutils.safe(decode|encode)","status":"MERGED","created":"2013-05-22 09:32:12.000000000","updated":"2013-06-06 07:28:08.000000000","submitted":"2013-06-06 07:28:08.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"00e6693817a37eabab5ddbf0df22ceb7333cb039","_number":30070,"virtual_id_number":30070,"owner":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},{"value":2,"date":"2013-06-06 07:28:08.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":616,"name":"Mark Washenberger","email":"mark.washenberger@markwash.net","username":"markwash"},{"value":0,"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},{"value":0,"_account_id":4463,"name":"iccha-sethi","email":"iccha.sethi@rackspace.com","username":"iccha-sethi"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"all":[{"value":2,"date":"2013-06-04 22:01:55.000000000","_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2013-06-05 22:17:04.000000000","_account_id":616,"name":"Mark Washenberger","email":"mark.washenberger@markwash.net","username":"markwash"},{"value":0,"date":"2013-06-06 06:28:25.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},{"value":0,"_account_id":4463,"name":"iccha-sethi","email":"iccha.sethi@rackspace.com","username":"iccha-sethi"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":616,"name":"Mark Washenberger","email":"mark.washenberger@markwash.net","username":"markwash"},"all":[{"value":0,"date":"2013-06-04 22:01:55.000000000","_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2013-06-05 22:17:04.000000000","_account_id":616,"name":"Mark Washenberger","email":"mark.washenberger@markwash.net","username":"markwash"},{"value":0,"date":"2013-06-06 06:28:25.000000000","_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},{"value":0,"_account_id":4463,"name":"iccha-sethi","email":"iccha.sethi@rackspace.com","username":"iccha-sethi"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":616,"name":"Mark Washenberger","email":"mark.washenberger@markwash.net","username":"markwash"},{"value":0,"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},{"value":0,"_account_id":4463,"name":"iccha-sethi","email":"iccha.sethi@rackspace.com","username":"iccha-sethi"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Top Priority / Holds Gate"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},{"_account_id":616,"name":"Mark Washenberger","email":"mark.washenberger@markwash.net","username":"markwash"},{"_account_id":4463,"name":"iccha-sethi","email":"iccha.sethi@rackspace.com","username":"iccha-sethi"},{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-05-30 16:20:11.000000000","updated_by":{"_account_id":4463,"name":"iccha-sethi","email":"iccha.sethi@rackspace.com","username":"iccha-sethi"},"reviewer":{"_account_id":4463,"name":"iccha-sethi","email":"iccha.sethi@rackspace.com","username":"iccha-sethi"},"state":"REVIEWER"},{"updated":"2013-06-04 22:01:55.000000000","updated_by":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"reviewer":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"state":"REVIEWER"},{"updated":"2013-06-05 22:17:04.000000000","updated_by":{"_account_id":616,"name":"Mark Washenberger","email":"mark.washenberger@markwash.net","username":"markwash"},"reviewer":{"_account_id":616,"name":"Mark Washenberger","email":"mark.washenberger@markwash.net","username":"markwash"},"state":"REVIEWER"},{"updated":"2013-06-06 07:28:08.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"8cfe90bfca14042cbfff879ca2fd457d4397d545","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-05-22 10:21:17.000000000","message":"Patch Set 1: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/30070/1/check/gate-python-glanceclient-pep8/750 : SUCCESS in 47s\n- http://docs-draft.openstack.org/30070/1/check/gate-python-glanceclient-docs/682/doc/build/html/ : SUCCESS in 59s\n- http://logs.openstack.org/30070/1/check/gate-python-glanceclient-python26/745 : SUCCESS in 1m 09s\n- http://logs.openstack.org/30070/1/check/gate-python-glanceclient-python27/743 : SUCCESS in 55s\n- http://logs.openstack.org/30070/1/check/gate-tempest-devstack-vm-full/17669 : SUCCESS in 48m 53s\n- http://logs.openstack.org/30070/1/check/gate-tempest-devstack-vm-postgres-full/17379 : FAILURE in 44m 45s (non-voting)\n- http://logs.openstack.org/30070/1/check/gate-tempest-devstack-vm-quantum/24368 : SUCCESS in 19m 46s\n- http://logs.openstack.org/30070/1/check/gate-grenade-devstack-vm/5176 : FAILURE in 11m 27s (non-voting)\n","accounts_in_message":[],"_revision_number":1},{"id":"7580b53d7653b517f6adf5c91428dfef0e4c4457","author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"date":"2013-05-23 09:12:33.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"d35c3a46da8ccb61d725743e9c8079ad753abe26","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-05-23 09:57:14.000000000","message":"Patch Set 2: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/30070/2/check/gate-python-glanceclient-pep8/763 : SUCCESS in 40s\n- http://docs-draft.openstack.org/30070/2/check/gate-python-glanceclient-docs/695/doc/build/html/ : SUCCESS in 43s\n- http://logs.openstack.org/30070/2/check/gate-python-glanceclient-python26/758 : SUCCESS in 1m 13s\n- http://logs.openstack.org/30070/2/check/gate-python-glanceclient-python27/756 : SUCCESS in 46s\n- http://logs.openstack.org/30070/2/check/gate-tempest-devstack-vm-full/17964 : SUCCESS in 44m 22s\n- http://logs.openstack.org/30070/2/check/gate-tempest-devstack-vm-postgres-full/17674 : FAILURE in 44m 29s (non-voting)\n- http://logs.openstack.org/30070/2/check/gate-tempest-devstack-vm-quantum/24696 : SUCCESS in 22m 26s\n- http://logs.openstack.org/30070/2/check/gate-grenade-devstack-vm/5460 : FAILURE in 11m 27s (non-voting)\n","accounts_in_message":[],"_revision_number":2},{"id":"13d37c193a53e30297f4975eb55ef938c43ea98e","author":{"_account_id":616,"name":"Mark Washenberger","email":"mark.washenberger@markwash.net","username":"markwash"},"date":"2013-05-28 17:16:52.000000000","message":"Patch Set 2: I would prefer that you didn\u0027t merge this\n\nHi Flavio,\n\nLooks good! However, I can\u0027t figure out why the gettextutils.py module is being included in this patch. If it was included on purpose, do we need to add it to the openstack-common.conf as a module?\n\nThanks","accounts_in_message":[],"_revision_number":2},{"id":"aaaa9503d5f91537dff21926bcbc829cc80a486f","author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"date":"2013-05-29 08:33:44.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"c554ee0b6bf1f55dd0b20da6bc3574be9f830dae","author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"date":"2013-05-29 08:34:24.000000000","message":"Patch Set 3:\n\nHey Mark,\n\nstrutils depends on gettextutils. I added it to openstack-common.conf :)\n\nThanks for the review.","accounts_in_message":[],"_revision_number":3},{"id":"21502ecff7dac3e2d87506e3d222ab26fbc6ebe8","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-05-29 09:20:20.000000000","message":"Patch Set 3: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/30070/3/check/gate-python-glanceclient-pep8/767 : SUCCESS in 47s\n- http://docs-draft.openstack.org/30070/3/check/gate-python-glanceclient-docs/699/doc/build/html/ : SUCCESS in 46s\n- http://logs.openstack.org/30070/3/check/gate-python-glanceclient-python26/762 : SUCCESS in 1m 04s\n- http://logs.openstack.org/30070/3/check/gate-python-glanceclient-python27/760 : SUCCESS in 50s\n- http://logs.openstack.org/30070/3/check/gate-tempest-devstack-vm-full/19042 : SUCCESS in 43m 50s\n- http://logs.openstack.org/30070/3/check/gate-tempest-devstack-vm-postgres-full/18750 : FAILURE in 46m 23s (non-voting)\n- http://logs.openstack.org/30070/3/check/gate-tempest-devstack-vm-quantum/25902 : SUCCESS in 18m 07s\n- http://logs.openstack.org/30070/3/check/gate-grenade-devstack-vm/6467 : SUCCESS in 16m 01s (non-voting)\n","accounts_in_message":[],"_revision_number":3},{"id":"91a4bd05a5f88cf199891c93ec3bbfdb5813d900","author":{"_account_id":4463,"name":"iccha-sethi","email":"iccha.sethi@rackspace.com","username":"iccha-sethi"},"date":"2013-05-30 16:20:11.000000000","message":"Patch Set 3: Looks good to me (core reviewer)\n\nmakes sense, lgtm","accounts_in_message":[],"_revision_number":3},{"id":"c1c357829342eb9e170cdf418a44af7dd0cc0807","author":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"date":"2013-05-30 17:55:06.000000000","message":"Patch Set 3: I would prefer that you didn\u0027t merge this\n\n(1 inline comment)\n\nOn tiny thing inline.\n\nAlso, there aren\u0027t any tests anywhere ensuring that  \u0027safe_decode\u0027 or \u0027ensure_str\u0027 is being called where it should be. Ideally we would have tests ensuring this change didn\u0027t change any behavior.","accounts_in_message":[],"_revision_number":3},{"id":"c325b734927b97ae863c18449e8924429b674749","author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"date":"2013-05-30 18:14:03.000000000","message":"Patch Set 3: (1 inline comment)\n\n","accounts_in_message":[],"_revision_number":3},{"id":"ab5b0cf01f7594e347ca7043d1b723bbc91209de","author":{"_account_id":4463,"name":"iccha-sethi","email":"iccha.sethi@rackspace.com","username":"iccha-sethi"},"date":"2013-05-30 19:07:30.000000000","message":"Patch Set 3: I would prefer that you didn\u0027t merge this\n\nThis requires a prequel patch with tests, to ensure these changes dont break anything.","accounts_in_message":[],"_revision_number":3},{"id":"febc67b9ac507b08bff2aefec697c24e1ff3f09b","author":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"date":"2013-05-31 15:20:03.000000000","message":"Patch Set 3: No score\n\nHey Flavio, that test that you sent me that was added in one commit: https://github.com/openstack/python-glanceclient/blob/8c70c5b08d6ecae90c2df1ee5c7ba995e3329926/tests/v1/test_images.py#L314\n\nThat doesn\u0027t even test what was added in that commit. if you undo everything but the test changes it still passes.\n\nI\u0027m not sure how much of a stickler we should be about code changes that don\u0027t have test coverage. One the one hand, it\u0027s a lot more work to have to do just because past developers didn\u0027t add tests when they wrote the code. On the other, if we are always strict then the tests will always be there.\n\nI am just going to say that I don\u0027t know if I care enough to hold up this patch. Glance-core needs to establish a philosophy about this that is different from what I\u0027ve seen done in the past (making a bug for missing tests for code that isn\u0027t even merged yet).\n\nSorry for taking up so much time on a simple refactor patch. I\u0027ll defer to other core members.\n\n/rant","accounts_in_message":[],"_revision_number":3},{"id":"4740d09213fdeb9ace929bbb1dc54b0e4e4d8e53","author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"date":"2013-05-31 16:11:02.000000000","message":"Patch Set 3:\n\nThat test was about verifying headers were unicode, I wouldn\u0027t be surprised it passes depending on the environment.\n\nI think we should *always* require tests for patches that actually need one, which means all of them. My point about this one is that it pulls in strutils and doesn\u0027t add any new functionality. While strutils is already tested in oslo, I\u0027d agree that other methods might need further testing here but, is it the right patch to do it?\n\nThinking about this a bit more, I\u0027d say no and this is why:\n\nSomething that every reviewer should keep in mind is that patches might need to be reverted for unexpected reasons and so need to be the patches related to the patch being reverted. If we add tests for this patch in a separate patch then, in an eventual revert, we\u0027d revert this one and still keep the tests which would / should work anyway since the encoding support was already there.\n\nWhat Iccha suggested makes sense, create a patch that this patch will depend on and which will contain tests for the methods requiring them. \n\nThe client needs some care and that\u0027s something we, glance people, should always keep in mind and enforce contributors to keep consistency, coverage not just in the server side but in the client as well.\n\nConclusion: I\u0027ll create a new patch with some tests :)","accounts_in_message":[],"_revision_number":3},{"id":"d21a717b3061206b94181d269668bf5736a83852","author":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"date":"2013-05-31 17:55:08.000000000","message":"Patch Set 3:\n\nSweet sounds good. Exactly what I want...how would we have tests before this patch if they were in it ;)","accounts_in_message":[],"_revision_number":3},{"id":"f075bc5837f8d1ae900cd9c59f2fd3025888f465","author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"date":"2013-06-03 14:52:09.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"4c812deb180c42f96ddb6b0d49d3d6eb1b54ed7a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-06-03 15:43:45.000000000","message":"Patch Set 4: Doesn\u0027t seem to work\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGithub#Test_Failures\n\n- http://logs.openstack.org/30070/4/check/gate-python-glanceclient-pep8/784 : FAILURE in 39s\n- http://docs-draft.openstack.org/30070/4/check/gate-python-glanceclient-docs/716/doc/build/html/ : SUCCESS in 46s\n- http://logs.openstack.org/30070/4/check/gate-python-glanceclient-python26/779 : SUCCESS in 1m 12s\n- http://logs.openstack.org/30070/4/check/gate-python-glanceclient-python27/777 : SUCCESS in 1m 28s\n- http://logs.openstack.org/30070/4/check/gate-tempest-devstack-vm-full/20076 : SUCCESS in 51m 24s\n- http://logs.openstack.org/30070/4/check/gate-tempest-devstack-vm-postgres-full/19783 : FAILURE in 47m 31s (non-voting)\n- http://logs.openstack.org/30070/4/check/gate-tempest-devstack-vm-quantum/27076 : SUCCESS in 19m 48s\n- http://logs.openstack.org/30070/4/check/gate-grenade-devstack-vm/7456 : SUCCESS in 16m 16s (non-voting)\n","accounts_in_message":[],"_revision_number":4},{"id":"84beb4f70bbf6c365f961f2968a7f568ef1e2bf8","author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"date":"2013-06-03 15:44:09.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"0983dc6e38c9b3b3ea5b30b93ca6cae3a4038a27","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-06-03 16:31:43.000000000","message":"Patch Set 5: Doesn\u0027t seem to work\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGithub#Test_Failures\n\n- http://logs.openstack.org/30070/5/check/gate-python-glanceclient-pep8/788 : SUCCESS in 45s\n- http://docs-draft.openstack.org/30070/5/check/gate-python-glanceclient-docs/720/doc/build/html/ : SUCCESS in 50s\n- http://logs.openstack.org/30070/5/check/gate-python-glanceclient-python26/783 : SUCCESS in 1m 08s\n- http://logs.openstack.org/30070/5/check/gate-python-glanceclient-python27/781 : SUCCESS in 1m 34s\n- http://logs.openstack.org/30070/5/check/gate-tempest-devstack-vm-full/20098 : SUCCESS in 47m 10s\n- http://logs.openstack.org/30070/5/check/gate-tempest-devstack-vm-postgres-full/19805 : FAILURE in 46m 43s (non-voting)\n- http://logs.openstack.org/30070/5/check/gate-tempest-devstack-vm-quantum/27099 : FAILURE in 45m 02s\n- http://logs.openstack.org/30070/5/check/gate-grenade-devstack-vm/7475 : SUCCESS in 16m 10s (non-voting)\n","accounts_in_message":[],"_revision_number":5},{"id":"b6b183bf0bf4a5ef3f7e73a8e9ca8557cd940a8f","author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"date":"2013-06-03 17:13:33.000000000","message":"Patch Set 5:\n\nrecheck no bug","accounts_in_message":[],"_revision_number":5},{"id":"df97b0a555539a51a63bd0fe64f99a1cdd96ee48","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-06-03 18:06:02.000000000","message":"Patch Set 5: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/30070/5/check/gate-python-glanceclient-pep8/791 : SUCCESS in 41s\n- http://docs-draft.openstack.org/30070/5/check/gate-python-glanceclient-docs/723/doc/build/html/ : SUCCESS in 45s\n- http://logs.openstack.org/30070/5/check/gate-python-glanceclient-python26/786 : SUCCESS in 1m 26s\n- http://logs.openstack.org/30070/5/check/gate-python-glanceclient-python27/784 : SUCCESS in 48s\n- http://logs.openstack.org/30070/5/check/gate-tempest-devstack-vm-full/20130 : SUCCESS in 51m 18s\n- http://logs.openstack.org/30070/5/check/gate-tempest-devstack-vm-postgres-full/19837 : FAILURE in 52m 17s (non-voting)\n- http://logs.openstack.org/30070/5/check/gate-tempest-devstack-vm-quantum/27136 : SUCCESS in 19m 32s\n- http://logs.openstack.org/30070/5/check/gate-grenade-devstack-vm/7506 : SUCCESS in 13m 16s (non-voting)\n","accounts_in_message":[],"_revision_number":5},{"id":"d63dfa380ba7724cace04c844711ea8a43ecd627","author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"date":"2013-06-03 22:42:46.000000000","message":"Uploaded patch set 6.","accounts_in_message":[],"_revision_number":6},{"id":"d6cd3f47e408d5f2018f05b3a5622cafbef216c3","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-06-03 23:35:00.000000000","message":"Patch Set 6: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/30070/6/check/gate-python-glanceclient-pep8/794 : SUCCESS in 43s\n- http://docs-draft.openstack.org/30070/6/check/gate-python-glanceclient-docs/726/doc/build/html/ : SUCCESS in 48s\n- http://logs.openstack.org/30070/6/check/gate-python-glanceclient-python26/789 : SUCCESS in 1m 08s\n- http://logs.openstack.org/30070/6/check/gate-python-glanceclient-python27/787 : SUCCESS in 50s\n- http://logs.openstack.org/30070/6/check/gate-tempest-devstack-vm-full/20214 : SUCCESS in 51m 20s\n- http://logs.openstack.org/30070/6/check/gate-tempest-devstack-vm-postgres-full/19921 : FAILURE in 51m 58s (non-voting)\n- http://logs.openstack.org/30070/6/check/gate-tempest-devstack-vm-quantum/27231 : SUCCESS in 21m 00s\n- http://logs.openstack.org/30070/6/check/gate-grenade-devstack-vm/7584 : SUCCESS in 14m 23s (non-voting)\n","accounts_in_message":[],"_revision_number":6},{"id":"ff684d82ba5f8fc4566e00b2f079d1c7e8de8828","author":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"date":"2013-06-04 22:01:55.000000000","message":"Patch Set 6: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":6},{"id":"46f47bf0bdf772b3aca9bc98c10dc7de528cc9a7","author":{"_account_id":616,"name":"Mark Washenberger","email":"mark.washenberger@markwash.net","username":"markwash"},"date":"2013-06-05 22:17:04.000000000","message":"Patch Set 6: Looks good to me (core reviewer); Approved\n\n","accounts_in_message":[],"_revision_number":6},{"id":"e33616d271e2ddbc351cb06c03c51d7f2ecf6f04","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-06-05 22:17:15.000000000","message":"Patch Set 6: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":6},{"id":"8bd25222f3d8a1e76f62a9696566f49c2cb06c0c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-06-05 23:09:09.000000000","message":"Patch Set 6: Fails\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGithub#Test_Failures\n\n- http://docs-draft.openstack.org/30070/6/gate/gate-python-glanceclient-docs/731/doc/build/html/ : SUCCESS in 55s\n- http://logs.openstack.org/30070/6/gate/gate-python-glanceclient-pep8/799 : SUCCESS in 1m 25s\n- http://logs.openstack.org/30070/6/gate/gate-python-glanceclient-python26/794 : SUCCESS in 1m 19s\n- http://logs.openstack.org/30070/6/gate/gate-python-glanceclient-python27/792 : SUCCESS in 52s\n- http://logs.openstack.org/30070/6/gate/gate-tempest-devstack-vm-full/20897 : SUCCESS in 43m 37s\n- http://logs.openstack.org/30070/6/gate/gate-tempest-devstack-vm-postgres-full/20604 : SUCCESS in 44m 56s (non-voting)\n- http://logs.openstack.org/30070/6/gate/gate-tempest-devstack-vm-quantum/27973 : FAILURE in 44m 46s\n- http://logs.openstack.org/30070/6/gate/gate-grenade-devstack-vm/8242 : FAILURE in 17m 33s (non-voting)\n","accounts_in_message":[],"_revision_number":6},{"id":"260674407c9f574bf42b2d73dcd5d9c840f34cd5","author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"date":"2013-06-06 06:28:25.000000000","message":"Patch Set 6:\n\nreverify no bug","accounts_in_message":[],"_revision_number":6},{"id":"86749bac17df9b89cd709f03799836f8e6fa0ffa","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-06-06 06:28:27.000000000","message":"Patch Set 6: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":6},{"id":"a2e724cb132e2222039c39384aa177d7415e757f","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-06-06 07:28:08.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":6},{"id":"a512e30015de862de28a59a2a12d26b7909e79ec","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-06-06 07:28:08.000000000","message":"Patch Set 6: Verified\n\nBuild succeeded.\n\n- http://docs-draft.openstack.org/30070/6/gate/gate-python-glanceclient-docs/734/doc/build/html/ : SUCCESS in 52s\n- http://logs.openstack.org/30070/6/gate/gate-python-glanceclient-pep8/802 : SUCCESS in 1m 23s\n- http://logs.openstack.org/30070/6/gate/gate-python-glanceclient-python26/797 : SUCCESS in 1m 22s\n- http://logs.openstack.org/30070/6/gate/gate-python-glanceclient-python27/795 : SUCCESS in 55s\n- http://logs.openstack.org/30070/6/gate/gate-tempest-devstack-vm-full/20975 : SUCCESS in 44m 21s\n- http://logs.openstack.org/30070/6/gate/gate-tempest-devstack-vm-postgres-full/20682 : SUCCESS in 45m 40s (non-voting)\n- http://logs.openstack.org/30070/6/gate/gate-tempest-devstack-vm-quantum/28054 : SUCCESS in 18m 34s\n- http://logs.openstack.org/30070/6/gate/gate-grenade-devstack-vm/8317 : SUCCESS in 15m 49s (non-voting)\n","accounts_in_message":[],"_revision_number":6}],"current_revision_number":6,"current_revision":"7818387d4ac4c4a20899fc4470da86c5bcabf183","revisions":{"de6319d99afa781da2a054380478fba4de281d77":{"kind":"REWORK","_number":1,"created":"2013-05-22 09:32:12.000000000","uploader":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"ref":"refs/changes/70/30070/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/70/30070/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/70/30070/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/70/30070/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/70/30070/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/70/30070/1"}}},"commit":{"parents":[{"commit":"31243741d89027730230853521f14fdb60318074","subject":"Update importutils and openstack-common.conf format","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/31243741d89027730230853521f14fdb60318074"}]}],"author":{"name":"Flaper Fesp","email":"flaper87@gmail.com","date":"2013-05-22 09:31:25.000000000","tz":120},"committer":{"name":"Flaper Fesp","email":"flaper87@gmail.com","date":"2013-05-22 09:31:25.000000000","tz":120},"subject":"Replace utils.ensure_(str|unicode) with strutils.safe(decode|encode)","message":"Replace utils.ensure_(str|unicode) with strutils.safe(decode|encode)\n\nGlanceclient implemented both functions before they landed into oslo.\nSince both functions are already in oslo, it is now possible to pull\nthem in.\n\nThere\u0027s a small difference between glance\u0027s implementation and oslo\u0027s,\nthat is the later does not convert non-str objects - int, bool - to str\nbefore trying to decode / encode them. This patch takes care of that\nwhere necessary, more precisely, while encoding headers before doing a\nnew request.\n\nFixes bug: #1172253\n\nChange-Id: I9a0dca31140bae28d8ec6aede515c5bb852b701b\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/de6319d99afa781da2a054380478fba4de281d77"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/de6319d99afa781da2a054380478fba4de281d77"}]},"branch":"refs/heads/master"},"dc600b4c3270b2387d568447ad370d477c97a600":{"kind":"REWORK","_number":2,"created":"2013-05-23 09:12:33.000000000","uploader":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"ref":"refs/changes/70/30070/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/70/30070/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/70/30070/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/70/30070/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/70/30070/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/70/30070/2"}}},"commit":{"parents":[{"commit":"9e515245a30ea14f343ab54444f51dbf2d75d8a2","subject":"Update importutils and openstack-common.conf format","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/9e515245a30ea14f343ab54444f51dbf2d75d8a2"}]}],"author":{"name":"Flaper Fesp","email":"flaper87@gmail.com","date":"2013-05-22 09:31:25.000000000","tz":120},"committer":{"name":"Flaper Fesp","email":"flaper87@gmail.com","date":"2013-05-23 09:12:16.000000000","tz":120},"subject":"Replace utils.ensure_(str|unicode) with strutils.safe(decode|encode)","message":"Replace utils.ensure_(str|unicode) with strutils.safe(decode|encode)\n\nGlanceclient implemented both functions before they landed into oslo.\nSince both functions are already in oslo, it is now possible to pull\nthem in.\n\nThere\u0027s a small difference between glance\u0027s implementation and oslo\u0027s,\nthat is the later does not convert non-str objects - int, bool - to str\nbefore trying to decode / encode them. This patch takes care of that\nwhere necessary, more precisely, while encoding headers before doing a\nnew request.\n\nFixes bug: #1172253\n\nChange-Id: I9a0dca31140bae28d8ec6aede515c5bb852b701b\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/dc600b4c3270b2387d568447ad370d477c97a600"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/dc600b4c3270b2387d568447ad370d477c97a600"}]},"branch":"refs/heads/master"},"3ab23cd4dca1a2f4c832af27de2c3b72cf84666b":{"kind":"REWORK","_number":3,"created":"2013-05-29 08:33:44.000000000","uploader":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"ref":"refs/changes/70/30070/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/70/30070/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/70/30070/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/70/30070/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/70/30070/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/70/30070/3"}}},"commit":{"parents":[{"commit":"9e515245a30ea14f343ab54444f51dbf2d75d8a2","subject":"Update importutils and openstack-common.conf format","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/9e515245a30ea14f343ab54444f51dbf2d75d8a2"}]}],"author":{"name":"Flaper Fesp","email":"flaper87@gmail.com","date":"2013-05-22 09:31:25.000000000","tz":120},"committer":{"name":"Flaper Fesp","email":"flaper87@gmail.com","date":"2013-05-29 08:33:26.000000000","tz":120},"subject":"Replace utils.ensure_(str|unicode) with strutils.safe(decode|encode)","message":"Replace utils.ensure_(str|unicode) with strutils.safe(decode|encode)\n\nGlanceclient implemented both functions before they landed into oslo.\nSince both functions are already in oslo, it is now possible to pull\nthem in.\n\nThere\u0027s a small difference between glance\u0027s implementation and oslo\u0027s,\nthat is the later does not convert non-str objects - int, bool - to str\nbefore trying to decode / encode them. This patch takes care of that\nwhere necessary, more precisely, while encoding headers before doing a\nnew request.\n\nFixes bug: #1172253\n\nChange-Id: I9a0dca31140bae28d8ec6aede515c5bb852b701b\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/3ab23cd4dca1a2f4c832af27de2c3b72cf84666b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/3ab23cd4dca1a2f4c832af27de2c3b72cf84666b"}]},"branch":"refs/heads/master"},"1c9f933d316fa1b7fc155ddab8253c47e1459b80":{"kind":"REWORK","_number":4,"created":"2013-06-03 14:52:09.000000000","uploader":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"ref":"refs/changes/70/30070/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/70/30070/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/70/30070/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/70/30070/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/70/30070/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/70/30070/4"}}},"commit":{"parents":[{"commit":"3a50a40be2c8c140b0d014008127bc6ac4fd9d7f","subject":"Do not decode headers in v1/images.py","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/3a50a40be2c8c140b0d014008127bc6ac4fd9d7f"}]}],"author":{"name":"Flaper Fesp","email":"flaper87@gmail.com","date":"2013-05-22 09:31:25.000000000","tz":120},"committer":{"name":"Flaper Fesp","email":"flaper87@gmail.com","date":"2013-06-03 14:51:43.000000000","tz":120},"subject":"Replace utils.ensure_(str|unicode) with strutils.safe(decode|encode)","message":"Replace utils.ensure_(str|unicode) with strutils.safe(decode|encode)\n\nGlanceclient implemented both functions before they landed into oslo.\nSince both functions are already in oslo, it is now possible to pull\nthem in.\n\nThere\u0027s a small difference between glance\u0027s implementation and oslo\u0027s,\nthat is the later does not convert non-str objects - int, bool - to str\nbefore trying to decode / encode them. This patch takes care of that\nwhere necessary, more precisely, while encoding headers before doing a\nnew request.\n\nFixes bug: #1172253\n\nChange-Id: I9a0dca31140bae28d8ec6aede515c5bb852b701b\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/1c9f933d316fa1b7fc155ddab8253c47e1459b80"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/1c9f933d316fa1b7fc155ddab8253c47e1459b80"}]},"branch":"refs/heads/master"},"ea6ab3c558df9ac58f58e0dbd90dce9bb3243192":{"kind":"TRIVIAL_REBASE","_number":5,"created":"2013-06-03 15:44:09.000000000","uploader":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"ref":"refs/changes/70/30070/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/70/30070/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/70/30070/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/70/30070/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/70/30070/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/70/30070/5"}}},"commit":{"parents":[{"commit":"e5a5610ff04f29fb8d597fb3ae6bbe906adae4e6","subject":"Do not decode headers in v1/images.py","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/e5a5610ff04f29fb8d597fb3ae6bbe906adae4e6"}]}],"author":{"name":"Flaper Fesp","email":"flaper87@gmail.com","date":"2013-05-22 09:31:25.000000000","tz":120},"committer":{"name":"Flaper Fesp","email":"flaper87@gmail.com","date":"2013-06-03 15:43:54.000000000","tz":120},"subject":"Replace utils.ensure_(str|unicode) with strutils.safe(decode|encode)","message":"Replace utils.ensure_(str|unicode) with strutils.safe(decode|encode)\n\nGlanceclient implemented both functions before they landed into oslo.\nSince both functions are already in oslo, it is now possible to pull\nthem in.\n\nThere\u0027s a small difference between glance\u0027s implementation and oslo\u0027s,\nthat is the later does not convert non-str objects - int, bool - to str\nbefore trying to decode / encode them. This patch takes care of that\nwhere necessary, more precisely, while encoding headers before doing a\nnew request.\n\nFixes bug: #1172253\n\nChange-Id: I9a0dca31140bae28d8ec6aede515c5bb852b701b\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/ea6ab3c558df9ac58f58e0dbd90dce9bb3243192"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/ea6ab3c558df9ac58f58e0dbd90dce9bb3243192"}]},"branch":"refs/heads/master"},"7818387d4ac4c4a20899fc4470da86c5bcabf183":{"kind":"TRIVIAL_REBASE","_number":6,"created":"2013-06-03 22:42:46.000000000","uploader":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"ref":"refs/changes/70/30070/6","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/70/30070/6","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/70/30070/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/70/30070/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/70/30070/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/70/30070/6"}}},"commit":{"parents":[{"commit":"7daa976d14102d3e2aca06d57d82f6aa92c84da2","subject":"Do not decode headers in v1/images.py","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/7daa976d14102d3e2aca06d57d82f6aa92c84da2"}]}],"author":{"name":"Flaper Fesp","email":"flaper87@gmail.com","date":"2013-05-22 09:31:25.000000000","tz":120},"committer":{"name":"Flaper Fesp","email":"flaper87@gmail.com","date":"2013-06-03 22:42:32.000000000","tz":120},"subject":"Replace utils.ensure_(str|unicode) with strutils.safe(decode|encode)","message":"Replace utils.ensure_(str|unicode) with strutils.safe(decode|encode)\n\nGlanceclient implemented both functions before they landed into oslo.\nSince both functions are already in oslo, it is now possible to pull\nthem in.\n\nThere\u0027s a small difference between glance\u0027s implementation and oslo\u0027s,\nthat is the later does not convert non-str objects - int, bool - to str\nbefore trying to decode / encode them. This patch takes care of that\nwhere necessary, more precisely, while encoding headers before doing a\nnew request.\n\nFixes bug: #1172253\n\nChange-Id: I9a0dca31140bae28d8ec6aede515c5bb852b701b\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/7818387d4ac4c4a20899fc4470da86c5bcabf183"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/7818387d4ac4c4a20899fc4470da86c5bcabf183"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}