)]}'
{"id":"openstack%2Fpython-glanceclient~304566","triplet_id":"openstack%2Fpython-glanceclient~master~I993b780f58f7d0aee33095554e85f7371701abd4","project":"openstack/python-glanceclient","branch":"master","topic":"bug_1184965","hashtags":[],"change_id":"I993b780f58f7d0aee33095554e85f7371701abd4","subject":"Glance image-create should have atleast one argument","status":"ABANDONED","created":"2016-04-12 12:27:28.000000000","updated":"2017-12-02 19:07:02.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"97e91adf76b813f5a1e6bdee909292bd3671f8df","_number":304566,"virtual_id_number":304566,"owner":{"_account_id":14780,"name":"Shashwat Srivastava","email":"shashwat.srivastava@tcs.com","username":"Shashwat"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},{"value":-1,"date":"2016-04-12 13:36:47.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},{"date":"2016-04-13 06:41:05.000000000","_account_id":14780,"name":"Shashwat Srivastava","email":"shashwat.srivastava@tcs.com","username":"Shashwat"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"rejected":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"all":[{"value":-2,"date":"2016-04-12 15:52:38.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":-1,"date":"2016-04-13 11:20:20.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":14780,"name":"Shashwat Srivastava","email":"shashwat.srivastava@tcs.com","username":"Shashwat"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":14780,"name":"Shashwat Srivastava","email":"shashwat.srivastava@tcs.com","username":"Shashwat"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":2},"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},{"_account_id":14780,"name":"Shashwat Srivastava","email":"shashwat.srivastava@tcs.com","username":"Shashwat"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Top Priority / Holds Gate"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},{"_account_id":14780,"name":"Shashwat Srivastava","email":"shashwat.srivastava@tcs.com","username":"Shashwat"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-04-12 13:36:47.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2016-04-12 15:52:38.000000000","updated_by":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"reviewer":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"state":"REVIEWER"},{"updated":"2016-04-13 11:20:20.000000000","updated_by":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"reviewer":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"state":"REVIEWER"}],"messages":[{"id":"66cfc040fc1e82714da6c445f155e3d9fd4ab2a8","author":{"_account_id":14780,"name":"Shashwat Srivastava","email":"shashwat.srivastava@tcs.com","username":"Shashwat"},"date":"2016-04-12 12:27:28.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"fdf026dbb43fcdcd8f88cc4e082283be1cb07ea9","author":{"_account_id":14780,"name":"Shashwat Srivastava","email":"shashwat.srivastava@tcs.com","username":"Shashwat"},"date":"2016-04-12 12:33:28.000000000","message":"Patch Set 2: Published edit on patch set 1","accounts_in_message":[],"_revision_number":2},{"id":"d1a8c23945dcd20bd39b6842fb2bba40cae46f66","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-04-12 13:36:47.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-glanceclient-docs http://docs-draft.openstack.org/66/304566/2/check/gate-python-glanceclient-docs/3b9ac9e//doc/build/html/ : SUCCESS in 1m 44s\n- gate-python-glanceclient-pep8 http://logs.openstack.org/66/304566/2/check/gate-python-glanceclient-pep8/1e9d812/ : FAILURE in 1m 17s\n- gate-python-glanceclient-python27 http://logs.openstack.org/66/304566/2/check/gate-python-glanceclient-python27/9b9a56f/ : SUCCESS in 1m 20s\n- gate-python-glanceclient-python34 http://logs.openstack.org/66/304566/2/check/gate-python-glanceclient-python34/c68f919/ : SUCCESS in 2m 23s\n- gate-tempest-dsvm-neutron-src-python-glanceclient http://logs.openstack.org/66/304566/2/check/gate-tempest-dsvm-neutron-src-python-glanceclient/6073460/ : SUCCESS in 1h 00m 19s\n- gate-glanceclient-dsvm-functional http://logs.openstack.org/66/304566/2/check/gate-glanceclient-dsvm-functional/a897ffd/ : SUCCESS in 11m 32s","accounts_in_message":[],"_revision_number":2},{"id":"8cf87c49db83c561295ed9976f281a6dc8289c3d","author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"date":"2016-04-12 15:52:38.000000000","message":"Patch Set 2: Code-Review-2\n\nAbsolutely not. We are not going to break the user land for such artificial requirement.","accounts_in_message":[],"_revision_number":2},{"id":"fdcd5491165d40264e8c4dd9bb42d5e58abb8b5e","author":{"_account_id":14780,"name":"Shashwat Srivastava","email":"shashwat.srivastava@tcs.com","username":"Shashwat"},"date":"2016-04-13 06:41:05.000000000","message":"Patch Set 2:\n\n\u003e Absolutely not. We are not going to break the user land for such\n \u003e artificial requirement.\n\n \u003e Absolutely not. We are not going to break the user land for such\n \u003e artificial requirement.\n\n@\n\n \u003e Absolutely not. We are not going to break the user land for such\n \u003e artificial requirement.\n\n@erno kuvaja This bug is for addition of the argument in the glance image-create command, which as per the discussion on the bug page seems to be logical to implement. I dont know why you dont want this.","accounts_in_message":[],"_revision_number":2},{"id":"26723fa40a370c348afabc2d901e23245fcc570c","author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"date":"2016-04-13 11:20:20.000000000","message":"Patch Set 2: Code-Review-1\n\nI\u0027m a big fan of preserving backwards compatibility. IMHO we should try to avoid changes which could break users\u0027 stuff wherever possible.\n\nAn aside: surprisingly, the client behaves differently when data is supplied on stdin:\n\n $ echo data | glance image-create \n error: Must provide --container-format, --disk-format when using stdin.\n\n(I\u0027m guessing that\u0027s more by accident than design.)","accounts_in_message":[],"_revision_number":2},{"id":"1cb7dc120b871791728fdbfb42c6847169629bb8","author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"date":"2016-04-20 15:20:47.000000000","message":"Patch Set 2:\n\nStuart,\n\nThat\u0027s actually not accidental. This is the fail early check we made for it as those two are needed parameters for the image to transition to active (which happens when the upload completes).\n\nThe image-upload will (or should at least) give you the same error as you see there if you try to upload the image data before setting those properties.\n\nWhat Shashwat is proposing is introducing artificial blocker to create empty image placeholder. And backwards incompatible as mentioned.","accounts_in_message":[],"_revision_number":2},{"id":"a668eeec4fc22c0b018687d0727c05a4596113ed","author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"date":"2017-12-02 19:07:02.000000000","message":"Abandoned\n\nNo activity for \u003e1 year, plus the bug this fixes is classified as a \"Won\u0027t Fix\".  Reading through that discussion, it sounds like something like this change could be proposed as a spec-lite to the python glanceclient if it\u0027s proposed in such a way to get around the backward-incompatibility issues Stuart and Erno point out.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"c52e62dde714b681672de05d0c128738d2e50871","revisions":{"cd8c0bfdecf184439a8601bc7fa0d638af0b1872":{"kind":"REWORK","_number":1,"created":"2016-04-12 12:27:28.000000000","uploader":{"_account_id":14780,"name":"Shashwat Srivastava","email":"shashwat.srivastava@tcs.com","username":"Shashwat"},"ref":"refs/changes/66/304566/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/66/304566/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/66/304566/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/66/304566/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/66/304566/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/66/304566/1"}}},"commit":{"parents":[{"commit":"09e9272c5916733712bfaaf10fc9b61976306bb0","subject":"Merge \"Update auth_token before sending request\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/09e9272c5916733712bfaaf10fc9b61976306bb0"}]}],"author":{"name":"Shashwat","email":"shashwat.srivastava@tcs.com","date":"2016-04-12 12:25:41.000000000","tz":330},"committer":{"name":"Shashwat","email":"shashwat.srivastava@tcs.com","date":"2016-04-12 12:27:20.000000000","tz":330},"subject":"Make image-create require data or at least one argument","message":"Make image-create require data or at least one argument\n\nChange-Id: I993b780f58f7d0aee33095554e85f7371701abd4\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/cd8c0bfdecf184439a8601bc7fa0d638af0b1872"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/cd8c0bfdecf184439a8601bc7fa0d638af0b1872"}]},"branch":"refs/heads/master"},"c52e62dde714b681672de05d0c128738d2e50871":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2016-04-12 12:33:28.000000000","uploader":{"_account_id":14780,"name":"Shashwat Srivastava","email":"shashwat.srivastava@tcs.com","username":"Shashwat"},"ref":"refs/changes/66/304566/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/66/304566/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/66/304566/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/66/304566/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/66/304566/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/66/304566/2"}}},"commit":{"parents":[{"commit":"09e9272c5916733712bfaaf10fc9b61976306bb0","subject":"Merge \"Update auth_token before sending request\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/09e9272c5916733712bfaaf10fc9b61976306bb0"}]}],"author":{"name":"Shashwat","email":"shashwat.srivastava@tcs.com","date":"2016-04-12 12:25:41.000000000","tz":330},"committer":{"name":"Shashwat Srivastava","email":"shashwat.srivastava@tcs.com","date":"2016-04-12 12:33:10.000000000","tz":0},"subject":"Glance image-create should have atleast one argument","message":"Glance image-create should have atleast one argument\n\nCreating a glance image without any argument should not be done.\nSo adding at least one parameter to be given while creating a image.\n\nCloses-Bug: #1184965\n\nChange-Id: I993b780f58f7d0aee33095554e85f7371701abd4\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/c52e62dde714b681672de05d0c128738d2e50871"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/c52e62dde714b681672de05d0c128738d2e50871"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}