)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"change_message_id":"e7cc7fc238be1828dd2e4f53add6d1acb13fb075","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If env[\u0027OS_IMAGE_URL\u0027] is not set then None is returned. This is then"},{"line_number":10,"context_line":"used ignoring the endpoint_type, service_type and region_name. This"},{"line_number":11,"context_line":"patch will use them values if the endpoint is None."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I76cc527b05d2be75d3dbc33123a0d71be97fe25c"},{"line_number":14,"context_line":"Closes-bug: #1579768"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"dab17558_0cb07489","line":11,"range":{"start_line":11,"start_character":15,"end_line":11,"end_character":19},"updated":"2016-05-10 13:49:46.000000000","message":"those?","commit_id":"735244d16bfdd530cec9b3a09a8643fcdf1dc778"}],"glanceclient/shell.py":[{"author":{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},"change_message_id":"46a7e476b146f3a139ed72554194f235b781a322","unresolved":false,"context_lines":[{"line_number":448,"context_line":"        if endpoint is None:"},{"line_number":449,"context_line":"            endpoint_type \u003d args.os_endpoint_type or \u0027public\u0027"},{"line_number":450,"context_line":"            service_type \u003d args.os_service_type or \u0027image\u0027"},{"line_number":451,"context_line":"            endpoint \u003d ks_session.get_endpoint("},{"line_number":452,"context_line":"                service_type\u003dservice_type,"},{"line_number":453,"context_line":"                interface\u003dendpoint_type,"},{"line_number":454,"context_line":"                region_name\u003dargs.os_region_name)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9abb7d3a_027245ad","line":451,"updated":"2016-05-30 12:27:43.000000000","message":"Does that work without keystone sessions? Can we call method from uninitialized variable here?","commit_id":"a862196cfb7f7323b1864b4c1660c39850487a64"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"6af07623c9a822d8582ee810d738972ce058e091","unresolved":false,"context_lines":[{"line_number":448,"context_line":"        if endpoint is None:"},{"line_number":449,"context_line":"            endpoint_type \u003d args.os_endpoint_type or \u0027public\u0027"},{"line_number":450,"context_line":"            service_type \u003d args.os_service_type or \u0027image\u0027"},{"line_number":451,"context_line":"            endpoint \u003d ks_session.get_endpoint("},{"line_number":452,"context_line":"                service_type\u003dservice_type,"},{"line_number":453,"context_line":"                interface\u003dendpoint_type,"},{"line_number":454,"context_line":"                region_name\u003dargs.os_region_name)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9abb7d3a_652d0946","line":451,"in_reply_to":"9abb7d3a_027245ad","updated":"2016-05-30 20:33:17.000000000","message":"can you elaborate please?\n\nand where exactly would be the case of uninitialized var?","commit_id":"a862196cfb7f7323b1864b4c1660c39850487a64"}],"glanceclient/tests/unit/test_shell.py":[{"author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"change_message_id":"e7cc7fc238be1828dd2e4f53add6d1acb13fb075","unresolved":false,"context_lines":[{"line_number":383,"context_line":"        self.assertEqual(1, mock_client.call_count)"},{"line_number":384,"context_line":""},{"line_number":385,"context_line":"    @mock.patch(\u0027glanceclient.v2.client.Client\u0027)"},{"line_number":386,"context_line":"    def test_password_prompted_with_v2(self, v2_client):"},{"line_number":387,"context_line":"        self.requests.post(self.token_url, exc\u003drequests.ConnectionError)"},{"line_number":388,"context_line":""},{"line_number":389,"context_line":"        cli2 \u003d mock.MagicMock()"}],"source_content_type":"text/x-python","patch_set":2,"id":"dab17558_ec39b0f3","side":"PARENT","line":386,"range":{"start_line":386,"start_character":8,"end_line":386,"end_character":38},"updated":"2016-05-10 13:49:46.000000000","message":"Commit c11c8c432bde60e6ef652119186aa205c3bf3076 seems to have rendered this test completely useless. It\u0027s called test_password_prompted_with_v2 but now, because it has added OS_PASSWORD, you are not prompted for a password.\n\nI\u0027d be tempted to remove this and add a bug.","commit_id":"f39647ab47cb10af83a6861149f5897ed570f4a0"},{"author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"change_message_id":"e7cc7fc238be1828dd2e4f53add6d1acb13fb075","unresolved":false,"context_lines":[{"line_number":90,"context_line":"V3_TOKEN \u003d ks_fixture.V3Token()"},{"line_number":91,"context_line":"V3_TOKEN.set_project_scope()"},{"line_number":92,"context_line":"_s \u003d V3_TOKEN.add_service(\u0027image\u0027, name\u003d\u0027glance\u0027)"},{"line_number":93,"context_line":"_s.add_standard_endpoints(public\u003dDEFAULT_IMAGE_URL)"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"class ShellTest(testutils.TestCase):"}],"source_content_type":"text/x-python","patch_set":2,"id":"dab17558_c70f6786","line":93,"range":{"start_line":93,"start_character":3,"end_line":93,"end_character":25},"updated":"2016-05-10 13:49:46.000000000","message":"We can possibly add an \u0027internal\u0027 endpoint type here and add a unit test which can reproduce the issue more faithfully.","commit_id":"735244d16bfdd530cec9b3a09a8643fcdf1dc778"},{"author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"change_message_id":"e7cc7fc238be1828dd2e4f53add6d1acb13fb075","unresolved":false,"context_lines":[{"line_number":635,"context_line":""},{"line_number":636,"context_line":"    @mock.patch(\u0027keystoneclient.discover.Discover\u0027,"},{"line_number":637,"context_line":"                side_effect\u003dks_exc.ClientException())"},{"line_number":638,"context_line":"    def test_api_discovery_failed_with_unversioned_auth_url(self,"},{"line_number":639,"context_line":"                                                            discover):"},{"line_number":640,"context_line":"        args \u003d (\u0027--os-image-api-version 2 --os-auth-url %s image-list\u0027"},{"line_number":641,"context_line":"                % DEFAULT_UNVERSIONED_AUTH_URL)"}],"source_content_type":"text/x-python","patch_set":2,"id":"dab17558_a7c98328","line":638,"range":{"start_line":638,"start_character":8,"end_line":638,"end_character":59},"updated":"2016-05-10 13:49:46.000000000","message":"Is this doing the same thing as the test with the same name below?","commit_id":"735244d16bfdd530cec9b3a09a8643fcdf1dc778"},{"author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"change_message_id":"e7cc7fc238be1828dd2e4f53add6d1acb13fb075","unresolved":false,"context_lines":[{"line_number":681,"context_line":"    auth_env \u003d FAKE_V3_ENV.copy()"},{"line_number":682,"context_line":"    token_url \u003d DEFAULT_V3_AUTH_URL + \u0027/auth/tokens\u0027"},{"line_number":683,"context_line":""},{"line_number":684,"context_line":"    def _assert_auth_plugin_args(self):"},{"line_number":685,"context_line":"        self.assertFalse(self.v2_auth.called)"},{"line_number":686,"context_line":""},{"line_number":687,"context_line":"        body \u003d json.loads(self.v3_auth.last_request.body)"}],"source_content_type":"text/x-python","patch_set":2,"id":"dab17558_e76c2bd2","line":684,"range":{"start_line":684,"start_character":8,"end_line":684,"end_character":32},"updated":"2016-05-10 13:49:46.000000000","message":"As far as I can tell, since commit c11c8c432bde60e6ef652119186aa205c3bf3076 this function, and FAKE_V3_ENV aren\u0027t actually used any more?","commit_id":"735244d16bfdd530cec9b3a09a8643fcdf1dc778"},{"author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"change_message_id":"e7cc7fc238be1828dd2e4f53add6d1acb13fb075","unresolved":false,"context_lines":[{"line_number":706,"context_line":"        args \u003d \u0027--os-image-api-version 2 image-list\u0027"},{"line_number":707,"context_line":"        glance_shell \u003d openstack_shell.OpenStackImagesShell()"},{"line_number":708,"context_line":"        glance_shell.main(args.split())"},{"line_number":709,"context_line":"        self.assertEqual(0, self.v3_auth.call_count)"},{"line_number":710,"context_line":""},{"line_number":711,"context_line":"    @mock.patch(\u0027keystoneclient.discover.Discover\u0027,"},{"line_number":712,"context_line":"                side_effect\u003dks_exc.ClientException())"}],"source_content_type":"text/x-python","patch_set":2,"id":"dab17558_c77f6764","line":709,"range":{"start_line":709,"start_character":33,"end_line":709,"end_character":40},"updated":"2016-05-10 13:49:46.000000000","message":"Again, this test seems to have been made useless by commit c11c8c432bde60e6ef652119186aa205c3bf3076.\n\nIt\u0027s called \"test_auth_plugin_invocation_with_v2\" ... but actually asserts that the v3_auth.call_count is zero.","commit_id":"735244d16bfdd530cec9b3a09a8643fcdf1dc778"},{"author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"change_message_id":"9fe44f3cb5afcbcddae0f13bec2be57560d18cec","unresolved":false,"context_lines":[{"line_number":697,"context_line":"    FAKE_V5_ENV[\u0027OS_ENDPOINT_TYPE\u0027] \u003d \u0027internal\u0027"},{"line_number":698,"context_line":"    auth_env \u003d FAKE_V5_ENV.copy()"},{"line_number":699,"context_line":""},{"line_number":700,"context_line":"    @mock.patch(\u0027glanceclient.v2.client.Client\u0027)"},{"line_number":701,"context_line":"    def test_no_auth_with_1123123(self, v2_client):"},{"line_number":702,"context_line":"        args \u003d (\u0027--os-image-api-version 2 image-list\u0027)"},{"line_number":703,"context_line":"        glance_shell \u003d openstack_shell.OpenStackImagesShell()"}],"source_content_type":"text/x-python","patch_set":3,"id":"dab17558_50cadc1b","line":700,"range":{"start_line":700,"start_character":4,"end_line":700,"end_character":48},"updated":"2016-05-11 12:17:54.000000000","message":"Not sure if it\u0027s overly ambitious, but I\u0027m wondering if it would be possible to not mock this out, but instead rely on requests_mock? ie mock the GET to the internal glance url. If possible that would be a really good test.","commit_id":"683445118e5af96dde8bd1ff1e72ee88232f6cad"},{"author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"change_message_id":"9fe44f3cb5afcbcddae0f13bec2be57560d18cec","unresolved":false,"context_lines":[{"line_number":698,"context_line":"    auth_env \u003d FAKE_V5_ENV.copy()"},{"line_number":699,"context_line":""},{"line_number":700,"context_line":"    @mock.patch(\u0027glanceclient.v2.client.Client\u0027)"},{"line_number":701,"context_line":"    def test_no_auth_with_1123123(self, v2_client):"},{"line_number":702,"context_line":"        args \u003d (\u0027--os-image-api-version 2 image-list\u0027)"},{"line_number":703,"context_line":"        glance_shell \u003d openstack_shell.OpenStackImagesShell()"},{"line_number":704,"context_line":"        glance_shell.main(args.split())"}],"source_content_type":"text/x-python","patch_set":3,"id":"dab17558_3018f8d2","line":701,"range":{"start_line":701,"start_character":8,"end_line":701,"end_character":33},"updated":"2016-05-11 12:17:54.000000000","message":"1123123?","commit_id":"683445118e5af96dde8bd1ff1e72ee88232f6cad"},{"author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"change_message_id":"df72e9131fff8771bb8f36ec91fabcb9e63042b4","unresolved":false,"context_lines":[{"line_number":669,"context_line":"    def setUp(self):"},{"line_number":670,"context_line":"        super(ShellTestWithNoOSImageURLPublic, self).setUp()"},{"line_number":671,"context_line":"        self.image_url \u003d DEFAULT_IMAGE_URL"},{"line_number":672,"context_line":"        self.requests.get(DEFAULT_IMAGE_URL + \u0027v2/images\u0027,"},{"line_number":673,"context_line":"                          text\u003d\u0027{\"images\": []}\u0027)"},{"line_number":674,"context_line":""},{"line_number":675,"context_line":"    @mock.patch(\u0027glanceclient.v1.client.Client\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"dab17558_eedbed1f","line":672,"range":{"start_line":672,"start_character":8,"end_line":672,"end_character":25},"updated":"2016-05-12 12:56:27.000000000","message":"Because this is in setUp it will get called for both ShellTestWithNoOSImageURLPublic and ShellTestWithNoOSImageURLInternal.\n\nYou could have created a function \"register_mock_calls\" and have it be different in the two classes. Calling that from setUp would have called the different one for each class so only one requests.get would have been registered. Not a big deal.","commit_id":"a862196cfb7f7323b1864b4c1660c39850487a64"},{"author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"change_message_id":"df72e9131fff8771bb8f36ec91fabcb9e63042b4","unresolved":false,"context_lines":[{"line_number":706,"context_line":"                         \"sort_key\u003dname\u0026sort_dir\u003dasc\")"},{"line_number":707,"context_line":""},{"line_number":708,"context_line":""},{"line_number":709,"context_line":"class ShellTestWithNoOSImageURLInternal(ShellTestWithNoOSImageURLPublic):"},{"line_number":710,"context_line":"    # auth environment to use"},{"line_number":711,"context_line":"    # this uses internal"},{"line_number":712,"context_line":"    FAKE_V5_ENV \u003d FAKE_V4_ENV.copy()"}],"source_content_type":"text/x-python","patch_set":5,"id":"dab17558_ae1f25b6","line":709,"range":{"start_line":709,"start_character":40,"end_line":709,"end_character":71},"updated":"2016-05-12 12:56:27.000000000","message":"minor nit: Inheriting from a class called \"ShellTestWithNoOSImageURLPublic\" and using it to run non-Public tests is a tiny bit misleading.","commit_id":"a862196cfb7f7323b1864b4c1660c39850487a64"}]}