)]}'
{"id":"openstack%2Fpython-glanceclient~31508","triplet_id":"openstack%2Fpython-glanceclient~master~I80525adbc6e9e576cfad5b576090ef9ee574c1cf","project":"openstack/python-glanceclient","branch":"master","topic":"bug/1172253","hashtags":[],"change_id":"I80525adbc6e9e576cfad5b576090ef9ee574c1cf","subject":"Do not decode headers in v1/images.py","status":"MERGED","created":"2013-06-03 14:49:26.000000000","updated":"2013-06-05 23:09:07.000000000","submitted":"2013-06-05 23:09:07.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"cf3beea5ca66300bcaccda88af188830e3c6382c","_number":31508,"virtual_id_number":31508,"owner":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},{"value":2,"date":"2013-06-05 23:09:07.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":616,"name":"Mark Washenberger","email":"mark.washenberger@markwash.net","username":"markwash"},{"value":0,"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"all":[{"value":2,"date":"2013-06-04 14:58:46.000000000","_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2013-06-05 22:15:30.000000000","_account_id":616,"name":"Mark Washenberger","email":"mark.washenberger@markwash.net","username":"markwash"},{"value":0,"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":616,"name":"Mark Washenberger","email":"mark.washenberger@markwash.net","username":"markwash"},"all":[{"value":0,"date":"2013-06-04 14:58:46.000000000","_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2013-06-05 22:15:30.000000000","_account_id":616,"name":"Mark Washenberger","email":"mark.washenberger@markwash.net","username":"markwash"},{"value":0,"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":616,"name":"Mark Washenberger","email":"mark.washenberger@markwash.net","username":"markwash"},{"value":0,"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Top Priority / Holds Gate"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},{"_account_id":616,"name":"Mark Washenberger","email":"mark.washenberger@markwash.net","username":"markwash"},{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-06-04 14:58:46.000000000","updated_by":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"reviewer":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"state":"REVIEWER"},{"updated":"2013-06-05 22:15:30.000000000","updated_by":{"_account_id":616,"name":"Mark Washenberger","email":"mark.washenberger@markwash.net","username":"markwash"},"reviewer":{"_account_id":616,"name":"Mark Washenberger","email":"mark.washenberger@markwash.net","username":"markwash"},"state":"REVIEWER"},{"updated":"2013-06-05 23:09:07.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"e2cd7b52acded9e2f4dfcaadcdc86b100c257d8b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-06-03 15:42:19.000000000","message":"Patch Set 1: Doesn\u0027t seem to work\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGithub#Test_Failures\n\n- http://logs.openstack.org/31508/1/check/gate-python-glanceclient-pep8/783 : FAILURE in 41s\n- http://docs-draft.openstack.org/31508/1/check/gate-python-glanceclient-docs/715/doc/build/html/ : SUCCESS in 47s\n- http://logs.openstack.org/31508/1/check/gate-python-glanceclient-python26/778 : SUCCESS in 1m 03s\n- http://logs.openstack.org/31508/1/check/gate-python-glanceclient-python27/776 : SUCCESS in 1m 28s\n- http://logs.openstack.org/31508/1/check/gate-tempest-devstack-vm-full/20075 : SUCCESS in 52m 41s\n- http://logs.openstack.org/31508/1/check/gate-tempest-devstack-vm-postgres-full/19782 : FAILURE in 46m 24s (non-voting)\n- http://logs.openstack.org/31508/1/check/gate-tempest-devstack-vm-quantum/27075 : SUCCESS in 20m 59s\n- http://logs.openstack.org/31508/1/check/gate-grenade-devstack-vm/7455 : SUCCESS in 17m 45s (non-voting)\n","accounts_in_message":[],"_revision_number":1},{"id":"91a9f90f9ec21de158685ea64a98b0e52aaab89f","author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"date":"2013-06-03 15:42:56.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"1c3a54beec89db2b6d7c2352f8e5923f09625fe0","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-06-03 16:31:22.000000000","message":"Patch Set 2: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/31508/2/check/gate-python-glanceclient-pep8/787 : SUCCESS in 47s\n- http://docs-draft.openstack.org/31508/2/check/gate-python-glanceclient-docs/719/doc/build/html/ : SUCCESS in 53s\n- http://logs.openstack.org/31508/2/check/gate-python-glanceclient-python26/782 : SUCCESS in 1m 19s\n- http://logs.openstack.org/31508/2/check/gate-python-glanceclient-python27/780 : SUCCESS in 53s\n- http://logs.openstack.org/31508/2/check/gate-tempest-devstack-vm-full/20097 : SUCCESS in 48m 06s\n- http://logs.openstack.org/31508/2/check/gate-tempest-devstack-vm-postgres-full/19804 : FAILURE in 45m 04s (non-voting)\n- http://logs.openstack.org/31508/2/check/gate-tempest-devstack-vm-quantum/27098 : SUCCESS in 19m 27s\n- http://logs.openstack.org/31508/2/check/gate-grenade-devstack-vm/7474 : SUCCESS in 16m 21s (non-voting)\n","accounts_in_message":[],"_revision_number":2},{"id":"3faa8a70f11db2393fccb6a45367008c38723bb8","author":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"date":"2013-06-03 21:58:27.000000000","message":"Patch Set 2: I would prefer that you didn\u0027t merge this\n\n(1 inline comment)\n\nOne thing inline. Also, did you mean to link the same bug as the patch that this depends on?","accounts_in_message":[],"_revision_number":2},{"id":"a7ecf9c8443d465cd92a4c47d54909988e03b086","author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"date":"2013-06-03 22:07:14.000000000","message":"Patch Set 2: (1 inline comment)\n\nHey,\n\nThanks for the review. I meant to use the same bug, it isn\u0027t worth it to create a spearate bug for this change, is it?","accounts_in_message":[],"_revision_number":2},{"id":"9b90da8ad80f93911b5df55b43e3611af75b5623","author":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"date":"2013-06-03 22:11:08.000000000","message":"Patch Set 2:\n\nI don\u0027t think it would be a big deal to use the same bug, just making sure that is your intention. :)","accounts_in_message":[],"_revision_number":2},{"id":"34bfb9ce951bc3d14c4c10f864597c94d6ab0201","author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"date":"2013-06-03 22:41:44.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"f74ae9f2ecf7dad58f684474dbe1a8b1d6f0cb01","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-06-03 23:33:05.000000000","message":"Patch Set 3: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/31508/3/check/gate-python-glanceclient-pep8/793 : SUCCESS in 1m 03s\n- http://docs-draft.openstack.org/31508/3/check/gate-python-glanceclient-docs/725/doc/build/html/ : SUCCESS in 1m 11s\n- http://logs.openstack.org/31508/3/check/gate-python-glanceclient-python26/788 : SUCCESS in 1m 39s\n- http://logs.openstack.org/31508/3/check/gate-python-glanceclient-python27/786 : SUCCESS in 1m 12s\n- http://logs.openstack.org/31508/3/check/gate-tempest-devstack-vm-full/20213 : SUCCESS in 51m 10s\n- http://logs.openstack.org/31508/3/check/gate-tempest-devstack-vm-postgres-full/19920 : FAILURE in 51m 00s (non-voting)\n- http://logs.openstack.org/31508/3/check/gate-tempest-devstack-vm-quantum/27230 : SUCCESS in 18m 56s\n- http://logs.openstack.org/31508/3/check/gate-grenade-devstack-vm/7583 : SUCCESS in 15m 47s (non-voting)\n","accounts_in_message":[],"_revision_number":3},{"id":"bc93ad2c7041ce3c022569ff7e7f44359e5713dc","author":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"date":"2013-06-04 14:58:46.000000000","message":"Patch Set 3: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":3},{"id":"ca10f68847f1c958536e3d508fa70be23e54d937","author":{"_account_id":616,"name":"Mark Washenberger","email":"mark.washenberger@markwash.net","username":"markwash"},"date":"2013-06-05 22:15:30.000000000","message":"Patch Set 3: Looks good to me (core reviewer); Approved\n\n","accounts_in_message":[],"_revision_number":3},{"id":"f5090522f695a952e87926c58f6b62a574fbb2c8","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-06-05 22:17:15.000000000","message":"Patch Set 3: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":3},{"id":"e76374eaaa1e8457281d350a504d233a58340e40","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-06-05 23:09:07.000000000","message":"Patch Set 3: Verified\n\nBuild succeeded.\n\n- http://docs-draft.openstack.org/31508/3/gate/gate-python-glanceclient-docs/730/doc/build/html/ : SUCCESS in 1m 37s\n- http://logs.openstack.org/31508/3/gate/gate-python-glanceclient-pep8/798 : SUCCESS in 45s\n- http://logs.openstack.org/31508/3/gate/gate-python-glanceclient-python26/793 : SUCCESS in 1m 39s\n- http://logs.openstack.org/31508/3/gate/gate-python-glanceclient-python27/791 : SUCCESS in 57s\n- http://logs.openstack.org/31508/3/gate/gate-tempest-devstack-vm-full/20896 : SUCCESS in 44m 16s\n- http://logs.openstack.org/31508/3/gate/gate-tempest-devstack-vm-postgres-full/20603 : SUCCESS in 51m 39s (non-voting)\n- http://logs.openstack.org/31508/3/gate/gate-tempest-devstack-vm-quantum/27972 : SUCCESS in 20m 38s\n- http://logs.openstack.org/31508/3/gate/gate-grenade-devstack-vm/8241 : SUCCESS in 15m 19s (non-voting)\n","accounts_in_message":[],"_revision_number":3},{"id":"5a44bb41c1893e2a31cb8b4c2a5d6b8706eafb7e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-06-05 23:09:07.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"7daa976d14102d3e2aca06d57d82f6aa92c84da2","revisions":{"3a50a40be2c8c140b0d014008127bc6ac4fd9d7f":{"kind":"REWORK","_number":1,"created":"2013-06-03 14:49:26.000000000","uploader":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"ref":"refs/changes/08/31508/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/08/31508/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/08/31508/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/08/31508/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/08/31508/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/08/31508/1"}}},"commit":{"parents":[{"commit":"072729ddd5f5aa74915d9b5caabf5d0d152df1cd","subject":"Add tests for encodings","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/072729ddd5f5aa74915d9b5caabf5d0d152df1cd"}]}],"author":{"name":"Flaper Fesp","email":"flaper87@gmail.com","date":"2013-06-03 14:46:49.000000000","tz":120},"committer":{"name":"Flaper Fesp","email":"flaper87@gmail.com","date":"2013-06-03 14:46:49.000000000","tz":120},"subject":"Do not decode headers in v1/images.py","message":"Do not decode headers in v1/images.py\n\nv1.images._image_meta_to_headers currently encodes headers as a way to\nensure they\u0027re an instance of basestring. This is not necessary since\nheaders will be encoded later during the request. Also, all data within\nthe client should be already decoded.\n\nFixes bug: #1187013\n\nChange-Id: I80525adbc6e9e576cfad5b576090ef9ee574c1cf\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/3a50a40be2c8c140b0d014008127bc6ac4fd9d7f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/3a50a40be2c8c140b0d014008127bc6ac4fd9d7f"}]},"branch":"refs/heads/master"},"e5a5610ff04f29fb8d597fb3ae6bbe906adae4e6":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2013-06-03 15:42:56.000000000","uploader":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"ref":"refs/changes/08/31508/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/08/31508/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/08/31508/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/08/31508/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/08/31508/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/08/31508/2"}}},"commit":{"parents":[{"commit":"81e88344fbd20b792e03eb1002fa5d68e5af212b","subject":"Add tests for encodings","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/81e88344fbd20b792e03eb1002fa5d68e5af212b"}]}],"author":{"name":"Flaper Fesp","email":"flaper87@gmail.com","date":"2013-06-03 14:46:49.000000000","tz":120},"committer":{"name":"Flaper Fesp","email":"flaper87@gmail.com","date":"2013-06-03 15:40:56.000000000","tz":120},"subject":"Do not decode headers in v1/images.py","message":"Do not decode headers in v1/images.py\n\nv1.images._image_meta_to_headers currently encodes headers as a way to\nensure they\u0027re an instance of basestring. This is not necessary since\nheaders will be encoded later during the request. Also, all data within\nthe client should be already decoded.\n\nFixes bug: #1187013\n\nChange-Id: I80525adbc6e9e576cfad5b576090ef9ee574c1cf\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/e5a5610ff04f29fb8d597fb3ae6bbe906adae4e6"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/e5a5610ff04f29fb8d597fb3ae6bbe906adae4e6"}]},"branch":"refs/heads/master"},"7daa976d14102d3e2aca06d57d82f6aa92c84da2":{"kind":"REWORK","_number":3,"created":"2013-06-03 22:41:44.000000000","uploader":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"ref":"refs/changes/08/31508/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/08/31508/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/08/31508/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/08/31508/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/08/31508/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/08/31508/3"}}},"commit":{"parents":[{"commit":"81e88344fbd20b792e03eb1002fa5d68e5af212b","subject":"Add tests for encodings","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/81e88344fbd20b792e03eb1002fa5d68e5af212b"}]}],"author":{"name":"Flaper Fesp","email":"flaper87@gmail.com","date":"2013-06-03 14:46:49.000000000","tz":120},"committer":{"name":"Flaper Fesp","email":"flaper87@gmail.com","date":"2013-06-03 22:41:24.000000000","tz":120},"subject":"Do not decode headers in v1/images.py","message":"Do not decode headers in v1/images.py\n\nv1.images._image_meta_to_headers currently encodes headers as a way to\nensure they\u0027re an instance of basestring. This is not necessary since\nheaders will be encoded later during the request. Also, all data within\nthe client should be already decoded.\n\nFixes bug: #1187013\n\nChange-Id: I80525adbc6e9e576cfad5b576090ef9ee574c1cf\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/7daa976d14102d3e2aca06d57d82f6aa92c84da2"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/7daa976d14102d3e2aca06d57d82f6aa92c84da2"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}