)]}'
{"id":"openstack%2Fpython-glanceclient~31529","triplet_id":"openstack%2Fpython-glanceclient~master~I8d37f6412a0bf9ca21cbd75cde6a4d5a174e5545","project":"openstack/python-glanceclient","branch":"master","topic":"bug/1184566","hashtags":[],"change_id":"I8d37f6412a0bf9ca21cbd75cde6a4d5a174e5545","subject":"Fix problem where image data is not read from a pipe.","status":"MERGED","created":"2013-06-03 17:04:42.000000000","updated":"2013-06-18 12:47:31.000000000","submitted":"2013-06-18 12:47:31.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"dfe985308e4ca015d5127dfe896e5e026581e696","_number":31529,"virtual_id_number":31529,"owner":{"_account_id":7217,"name":"Hugh Saunders","email":"hugh@wherenow.org","username":"hughsaunders"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":7217,"name":"Hugh Saunders","email":"hugh@wherenow.org","username":"hughsaunders"},{"value":0,"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},{"value":2,"date":"2013-06-18 12:47:31.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"all":[{"value":0,"date":"2013-06-03 17:08:31.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":7217,"name":"Hugh Saunders","email":"hugh@wherenow.org","username":"hughsaunders"},{"value":2,"date":"2013-06-13 20:53:24.000000000","_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2013-06-18 11:40:10.000000000","_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"all":[{"value":0,"_account_id":7217,"name":"Hugh Saunders","email":"hugh@wherenow.org","username":"hughsaunders"},{"value":0,"date":"2013-06-13 18:31:30.000000000","_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2013-06-18 11:40:10.000000000","_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":7217,"name":"Hugh Saunders","email":"hugh@wherenow.org","username":"hughsaunders"},{"value":0,"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Top Priority / Holds Gate"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},{"_account_id":7217,"name":"Hugh Saunders","email":"hugh@wherenow.org","username":"hughsaunders"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-06-13 18:31:30.000000000","updated_by":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"reviewer":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"state":"REVIEWER"},{"updated":"2013-06-18 11:40:10.000000000","updated_by":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"reviewer":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"state":"REVIEWER"},{"updated":"2013-06-18 12:47:31.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"f6f4f13ec46b3571c638ce373f52b0076d37d3ad","author":{"_account_id":7217,"name":"Hugh Saunders","email":"hugh@wherenow.org","username":"hughsaunders"},"date":"2013-06-03 17:08:31.000000000","message":"Patch Set 1:\n\nHi, I will be AFK for ~1 week, so won\u0027t be able to make changes to this patch set, feel free to make them for me so that the bug(s) can get fixed.","accounts_in_message":[],"_revision_number":1},{"id":"3b34af092a3367fcae14245873dbca0324f18434","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-06-03 17:58:50.000000000","message":"Patch Set 1: Doesn\u0027t seem to work\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGithub#Test_Failures\n\n- http://logs.openstack.org/31529/1/check/gate-python-glanceclient-pep8/789 : SUCCESS in 44s\n- http://docs-draft.openstack.org/31529/1/check/gate-python-glanceclient-docs/721/doc/build/html/ : SUCCESS in 47s\n- http://logs.openstack.org/31529/1/check/gate-python-glanceclient-python26/784 : SUCCESS in 1m 10s\n- http://logs.openstack.org/31529/1/check/gate-python-glanceclient-python27/782 : SUCCESS in 51s\n- http://logs.openstack.org/31529/1/check/gate-tempest-devstack-vm-full/20126 : SUCCESS in 44m 55s\n- http://logs.openstack.org/31529/1/check/gate-tempest-devstack-vm-postgres-full/19833 : FAILURE in 53m 17s (non-voting)\n- http://logs.openstack.org/31529/1/check/gate-tempest-devstack-vm-quantum/27131 : FAILURE in 47m 32s\n- http://logs.openstack.org/31529/1/check/gate-grenade-devstack-vm/7502 : SUCCESS in 17m 17s (non-voting)\n","accounts_in_message":[],"_revision_number":1},{"id":"5fcbebccebaccbb7b2fdd2f1ad9b55c29089919b","author":{"_account_id":7217,"name":"Hugh Saunders","email":"hugh@wherenow.org","username":"hughsaunders"},"date":"2013-06-05 22:30:24.000000000","message":"Patch Set 1:\n\nrecheck bug 1182164","accounts_in_message":[],"_revision_number":1},{"id":"96df05741adf82731daa6fb9ff2536e50ff2170e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-06-05 23:24:07.000000000","message":"Patch Set 1: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/31529/1/check/gate-python-glanceclient-pep8/800 : SUCCESS in 45s\n- http://docs-draft.openstack.org/31529/1/check/gate-python-glanceclient-docs/732/doc/build/html/ : SUCCESS in 50s\n- http://logs.openstack.org/31529/1/check/gate-python-glanceclient-python26/795 : SUCCESS in 1m 35s\n- http://logs.openstack.org/31529/1/check/gate-python-glanceclient-python27/793 : SUCCESS in 1m 39s\n- http://logs.openstack.org/31529/1/check/gate-tempest-devstack-vm-full/20902 : SUCCESS in 52m 40s\n- http://logs.openstack.org/31529/1/check/gate-tempest-devstack-vm-postgres-full/20609 : SUCCESS in 53m 24s (non-voting)\n- http://logs.openstack.org/31529/1/check/gate-tempest-devstack-vm-quantum/27979 : SUCCESS in 20m 18s\n- http://logs.openstack.org/31529/1/check/gate-grenade-devstack-vm/8247 : SUCCESS in 15m 03s (non-voting)\n","accounts_in_message":[],"_revision_number":1},{"id":"a6e230c951e90c4f6e4366993116f5ba85fb2b03","author":{"_account_id":7217,"name":"Hugh Saunders","email":"hugh@wherenow.org","username":"hughsaunders"},"date":"2013-06-12 09:18:43.000000000","message":"Patch Set 1:\n\nHi all, any comments on this would be appreciated, I am keen to get this bug fixed..","accounts_in_message":[],"_revision_number":1},{"id":"c73c02092853ff24d0b19db915b19e98392a67d2","author":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"date":"2013-06-13 20:53:24.000000000","message":"Patch Set 1: Looks good to me (core reviewer)\n\nI\u0027m good with this even though it will reopen bug 1173044. (That bug will be true for trying to do things like change name of an image in queued state, it will instead change the name and upload empty data)\n\nWe just need to update that bug after this goes in.","accounts_in_message":[],"_revision_number":1},{"id":"f91682ff9dd3a398a72cbd56506afd4e2e25ea7d","author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"date":"2013-06-18 11:40:10.000000000","message":"Patch Set 1: Looks good to me (core reviewer); Approved\n\nHey,\n\nThanks for taking care of this. Are we sure this re-opens bug #1173044 ?","accounts_in_message":[],"_revision_number":1},{"id":"2d28220d61b01dbaf592e89b9ed89c110fc19edc","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-06-18 11:40:12.000000000","message":"Patch Set 1: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"e16d0ff261eec11379d34633e784a5b4829ec2a6","author":{"_account_id":7217,"name":"Hugh Saunders","email":"hugh@wherenow.org","username":"hughsaunders"},"date":"2013-06-18 11:46:02.000000000","message":"Patch Set 1:\n\nHi Flavio\nThis change will reopen bug 1173044, but only for images in queued state. So the problem will exist but for a narrower set of circumstances. \n\nA real fix would involve a restructuring of the create/update shell commands. That is probably too large a change though. Maybe a blueprint for python-openstackclient?","accounts_in_message":[],"_revision_number":1},{"id":"adb63acff24d9067b6cef765fe616211de3b81e8","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-06-18 12:47:31.000000000","message":"Patch Set 1: Verified\n\nBuild succeeded.\n\n- http://docs-draft.openstack.org/31529/1/gate/gate-python-glanceclient-docs/751/doc/build/html/ : SUCCESS in 1m 10s\n- http://logs.openstack.org/31529/1/gate/gate-python-glanceclient-pep8/819 : SUCCESS in 53s\n- http://logs.openstack.org/31529/1/gate/gate-python-glanceclient-python26/814 : SUCCESS in 1m 30s\n- http://logs.openstack.org/31529/1/gate/gate-python-glanceclient-python27/812 : SUCCESS in 1m 00s\n- http://logs.openstack.org/31529/1/gate/gate-tempest-devstack-vm-full/24164 : SUCCESS in 41m 33s\n- http://logs.openstack.org/31529/1/gate/gate-tempest-devstack-vm-postgres-full/23870 : SUCCESS in 42m 01s\n- http://logs.openstack.org/31529/1/gate/gate-tempest-devstack-vm-quantum/31605 : SUCCESS in 16m 27s\n- http://logs.openstack.org/31529/1/gate/gate-grenade-devstack-vm/11069 : FAILURE in 41m 32s (non-voting)\n","accounts_in_message":[],"_revision_number":1},{"id":"85a3a833157fdf3cd4803f6d2b9420ff26d2ab1b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-06-18 12:47:31.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"9fda0dc815f042272c7c2b8ae18424cf1b6505e8","revisions":{"9fda0dc815f042272c7c2b8ae18424cf1b6505e8":{"kind":"REWORK","_number":1,"created":"2013-06-03 17:04:42.000000000","uploader":{"_account_id":7217,"name":"Hugh Saunders","email":"hugh@wherenow.org","username":"hughsaunders"},"ref":"refs/changes/29/31529/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/29/31529/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/29/31529/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/29/31529/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/29/31529/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/29/31529/1"}}},"commit":{"parents":[{"commit":"7d487834344e812c812dab0b14b9a51b5816554b","subject":"Merge \"Update importutils and openstack-common.conf format\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/7d487834344e812c812dab0b14b9a51b5816554b"}]}],"author":{"name":"Hugh Saunders","email":"hugh@wherenow.org","date":"2013-06-03 14:24:51.000000000","tz":60},"committer":{"name":"Hugh Saunders","email":"hugh@wherenow.org","date":"2013-06-03 17:01:58.000000000","tz":60},"subject":"Fix problem where image data is not read from a pipe.","message":"Fix problem where image data is not read from a pipe.\n\nFor image-updae and image-create commands, glanceclient attempts to\ndetermine whether image data should be uploaded based on the presence\nof data on stdin. Unforunately it is difficult to determine if data is\navailable, especially when standard in is from a pipe.\n\nThis is especially problematic for update operations, where data must\nonly be uploaded if the image is in queued state. For example data may\nbe uploaded when the user only wants to rename an image, but the rename\nwill be rejected because data cannot be uploaded to an unqueued image.\n\nThis patch removes the check that attempts to determine if data is\navailable to read as it didn\u0027t work for pipes. It also re-introduces a\ncheck for image state in the update operation, so that glanceclient only\nattempts to read data if the image being updated is in queued state.\n\nThe image state check is part of the original patchset that was removed\nso the patchset could have a single focus [1]\n\nThis patch also removes a test for handling empty stdin, and adds a test\nfor reading stdin from a pipe.\n\n[1] https://review.openstack.org/#/c/27536/3/glanceclient/v1/shell.py\n\nFixes: bug 1184566\nRelated to: bug 1173044\n\nChange-Id: I8d37f6412a0bf9ca21cbd75cde6a4d5a174e5545\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/9fda0dc815f042272c7c2b8ae18424cf1b6505e8"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/9fda0dc815f042272c7c2b8ae18424cf1b6505e8"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}