)]}'
{"glanceclient/tests/unit/test_utils.py":[{"author":{"_account_id":20105,"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","username":"caosf.fnst"},"change_message_id":"9907a3ec871c7fd34d5e54673dd0b8fe681238e1","unresolved":false,"context_lines":[{"line_number":192,"context_line":"    def test_add_request_id(self):"},{"line_number":193,"context_line":"        obj \u003d mock.Mock()"},{"line_number":194,"context_line":"        resp \u003d create_response_obj_with_header()"},{"line_number":195,"context_line":"        ret_resp \u003d utils.add_request_ids(obj, resp)"},{"line_number":196,"context_line":"        self.assertIsInstance(ret_resp, utils.RequestIdProxy)"},{"line_number":197,"context_line":"        # Check request_ids attribute is added to obj"},{"line_number":198,"context_line":"        self.assertTrue(hasattr(ret_resp, \u0027request_ids\u0027))"}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_3f04a07c","line":195,"range":{"start_line":195,"start_character":8,"end_line":195,"end_character":51},"updated":"2016-05-15 05:51:17.000000000","message":"Can we add an assertEqual(ret_resp, obj)?","commit_id":"298adf04631dbada24415e08101bc0d52bbdee92"}],"glanceclient/v2/images.py":[{"author":{"_account_id":20105,"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","username":"caosf.fnst"},"change_message_id":"9907a3ec871c7fd34d5e54673dd0b8fe681238e1","unresolved":false,"context_lines":[{"line_number":286,"context_line":"        # NOTE(bcwaldon): calling image.patch doesn\u0027t clear the changes, so"},{"line_number":287,"context_line":"        # we need to fetch the image again to get a clean history. This is"},{"line_number":288,"context_line":"        # an obvious optimization for warlock"},{"line_number":289,"context_line":"        return self.get(image_id)"},{"line_number":290,"context_line":""},{"line_number":291,"context_line":"    def _get_image_with_locations_or_fail(self, image_id):"},{"line_number":292,"context_line":"        image \u003d self.get(image_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_5fb364e9","line":289,"range":{"start_line":289,"start_character":15,"end_line":289,"end_character":33},"updated":"2016-05-15 05:51:17.000000000","message":"I noticed that you haven\u0027t return request_id of some \"update\" functions.\nI think there are three http requests in this update function:\nline 263, line 284, line 289.\nIMO, we should return all of these three request_ids.","commit_id":"298adf04631dbada24415e08101bc0d52bbdee92"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"6773d00a45307e3a3754ef856f72445727e42b96","unresolved":false,"context_lines":[{"line_number":174,"context_line":"            url \u003d \u0027%s\u0026marker\u003d%s\u0027 % (url, kwargs[\u0027marker\u0027])"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"        for image, resp in paginate(url, page_size, limit):"},{"line_number":177,"context_line":"            yield utils.add_request_ids(image, resp)"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"    def get(self, image_id):"},{"line_number":180,"context_line":"        url \u003d \u0027/v2/images/%s\u0027 % image_id"}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_0bef791e","line":177,"updated":"2016-07-07 13:32:16.000000000","message":"We just can\u0027t afford this. While our default page size is 20 (see line 27), in mid-size cloud where you have lets say for the easy maths 50 000 images we add 2 500 request IDs to the return when admin pulls full image list. We must put this back to the design jar and shake again.","commit_id":"3ce35f4fd3a738ca3e63885a2eaae4b763c93c6a"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"cfa89a75234583a41af3b2d05c9cb6da8c87ef75","unresolved":false,"context_lines":[{"line_number":174,"context_line":"            url \u003d \u0027%s\u0026marker\u003d%s\u0027 % (url, kwargs[\u0027marker\u0027])"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"        for image, resp in paginate(url, page_size, limit):"},{"line_number":177,"context_line":"            yield utils.add_request_ids(image, resp)"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"    def get(self, image_id):"},{"line_number":180,"context_line":"        url \u003d \u0027/v2/images/%s\u0027 % image_id"}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_c1cd08b9","line":177,"in_reply_to":"1aa78d24_0bef791e","updated":"2016-07-14 13:53:50.000000000","message":"Hi Erno,\n\nTo overcome this issue, IMO we can only return one request-id to the caller","commit_id":"3ce35f4fd3a738ca3e63885a2eaae4b763c93c6a"}]}