)]}'
{"id":"openstack%2Fpython-glanceclient~316052","triplet_id":"openstack%2Fpython-glanceclient~master~Iaa35b79c13cf3dd53883f039a8f3416178a0f081","project":"openstack/python-glanceclient","branch":"master","topic":"bp/return-request-id-to-caller","hashtags":[],"change_id":"Iaa35b79c13cf3dd53883f039a8f3416178a0f081","subject":"WIP: Add request id to returned objects","status":"ABANDONED","created":"2016-05-13 12:07:17.000000000","updated":"2017-01-24 16:19:35.000000000","total_comment_count":4,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"36b9fad3f038d0a2edfa35f59fabf439ee3748e6","_number":316052,"virtual_id_number":316052,"owner":{"_account_id":10485,"name":"Ankit Agrawal","email":"ankitagrawal8188@gmail.com","username":"ankitagrawal"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},{"value":-1,"date":"2017-01-23 22:20:02.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":10485,"name":"Ankit Agrawal","email":"ankitagrawal8188@gmail.com","username":"ankitagrawal"},{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"_account_id":20105,"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","username":"caosf.fnst"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"rejected":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"all":[{"value":-2,"date":"2016-07-07 13:32:16.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":10485,"name":"Ankit Agrawal","email":"ankitagrawal8188@gmail.com","username":"ankitagrawal"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":20105,"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","username":"caosf.fnst"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":10485,"name":"Ankit Agrawal","email":"ankitagrawal8188@gmail.com","username":"ankitagrawal"},{"value":0,"date":"2016-07-07 12:53:39.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"_account_id":20105,"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","username":"caosf.fnst"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":2},"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":10485,"name":"Ankit Agrawal","email":"ankitagrawal8188@gmail.com","username":"ankitagrawal"},{"value":0,"permitted_voting_range":{"min":-1,"max":2},"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"_account_id":20105,"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","username":"caosf.fnst"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Top Priority / Holds Gate"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"_account_id":10485,"name":"Ankit Agrawal","email":"ankitagrawal8188@gmail.com","username":"ankitagrawal"},{"_account_id":20105,"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","username":"caosf.fnst"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-05-13 12:12:42.000000000","updated_by":{"_account_id":20105,"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","username":"caosf.fnst"},"reviewer":{"_account_id":20105,"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","username":"caosf.fnst"},"state":"REVIEWER"},{"updated":"2016-07-07 12:53:39.000000000","updated_by":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"reviewer":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"state":"REVIEWER"},{"updated":"2016-07-07 13:32:16.000000000","updated_by":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"reviewer":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"state":"REVIEWER"},{"updated":"2017-01-23 22:20:02.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"63d375e62780aa07bdcb55ea11456d92d84c5779","author":{"_account_id":10485,"name":"Ankit Agrawal","email":"ankitagrawal8188@gmail.com","username":"ankitagrawal"},"date":"2016-05-13 12:07:17.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"e87b993c776b116ca5164f4072460c8335f4a19e","author":{"_account_id":10485,"name":"Ankit Agrawal","email":"ankitagrawal8188@gmail.com","username":"ankitagrawal"},"date":"2016-05-13 12:12:02.000000000","message":"Patch Set 1:\n\nWe have proposed a patch [1] using hooks solution which works well for all the scenarios.\nNow I am proposing this patch as per the \"Cao\" and other community members suggestion to implemented RequestIDProxy object using \"wrapt\" module which works well as expected,\nexcept metadefs update APIs and raises TypeError while dump the data.\nTo overcome this issue I have added \"wrapped\" property to RequestIDProxy object to pass the original value to the update function in metadefs update APIs. Though it doesn\u0027t \nlooks appropriate to explicitly call \"wrapped\" for each update API call but its required to make RequestIDProxy object serializable.\n\n[1] https://review.openstack.org/#/c/261288/","accounts_in_message":[],"_revision_number":1},{"id":"5be80080085b7382946af0ddf7d07c755e89ab1b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-05-13 13:17:28.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-glanceclient-docs http://docs-draft.openstack.org/52/316052/1/check/gate-python-glanceclient-docs/417e9ef//doc/build/html/ : SUCCESS in 2m 05s\n- gate-python-glanceclient-pep8 http://logs.openstack.org/52/316052/1/check/gate-python-glanceclient-pep8/d8bf9d7/ : SUCCESS in 1m 34s\n- gate-python-glanceclient-python27 http://logs.openstack.org/52/316052/1/check/gate-python-glanceclient-python27/6b9a7d2/ : SUCCESS in 2m 09s\n- gate-python-glanceclient-python34 http://logs.openstack.org/52/316052/1/check/gate-python-glanceclient-python34/08261c3/ : SUCCESS in 2m 32s\n- gate-python-glanceclient-requirements http://logs.openstack.org/52/316052/1/check/gate-python-glanceclient-requirements/726a99e/ : SUCCESS in 1m 27s\n- gate-tempest-dsvm-neutron-src-python-glanceclient http://logs.openstack.org/52/316052/1/check/gate-tempest-dsvm-neutron-src-python-glanceclient/f7a6cd6/ : FAILURE in 58m 50s\n- gate-glanceclient-dsvm-functional http://logs.openstack.org/52/316052/1/check/gate-glanceclient-dsvm-functional/c5ec0ae/ : SUCCESS in 20m 41s","accounts_in_message":[],"_revision_number":1},{"id":"f5299303d98d7a0551ff3ecf4ee7cb63582e9fc6","author":{"_account_id":20105,"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","username":"caosf.fnst"},"date":"2016-05-15 02:20:00.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"e77272ccfb069e0f21d436a7dbaa75f4e3401f19","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-05-15 03:14:46.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-glanceclient-docs http://docs-draft.openstack.org/52/316052/1/check/gate-python-glanceclient-docs/c91fc8a//doc/build/html/ : SUCCESS in 3m 44s\n- gate-python-glanceclient-pep8 http://logs.openstack.org/52/316052/1/check/gate-python-glanceclient-pep8/e481142/ : SUCCESS in 2m 05s\n- gate-python-glanceclient-python27 http://logs.openstack.org/52/316052/1/check/gate-python-glanceclient-python27/d71bdb6/ : SUCCESS in 2m 12s\n- gate-python-glanceclient-python34 http://logs.openstack.org/52/316052/1/check/gate-python-glanceclient-python34/69926a3/ : SUCCESS in 2m 46s\n- gate-python-glanceclient-requirements http://logs.openstack.org/52/316052/1/check/gate-python-glanceclient-requirements/cf96c2d/ : SUCCESS in 1m 29s\n- gate-tempest-dsvm-neutron-src-python-glanceclient http://logs.openstack.org/52/316052/1/check/gate-tempest-dsvm-neutron-src-python-glanceclient/434be1f/ : SUCCESS in 54m 38s\n- gate-glanceclient-dsvm-functional http://logs.openstack.org/52/316052/1/check/gate-glanceclient-dsvm-functional/3d15c00/ : SUCCESS in 20m 14s","accounts_in_message":[],"_revision_number":1},{"id":"9907a3ec871c7fd34d5e54673dd0b8fe681238e1","author":{"_account_id":20105,"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","username":"caosf.fnst"},"date":"2016-05-15 05:51:17.000000000","message":"Patch Set 1:\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"f2eb246aad8897ed5d662712aa7a834ce2f4f246","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-06-29 16:05:04.000000000","message":"Patch Set 1: Verified-1\n\nMerge Failed.\n\nThis change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.","accounts_in_message":[],"_revision_number":1},{"id":"298b997361910ff57f975dc5d7820f50a9679cd8","author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"date":"2016-07-07 12:53:39.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"6773d00a45307e3a3754ef856f72445727e42b96","author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"date":"2016-07-07 13:32:16.000000000","message":"Patch Set 2: Code-Review-2\n\n(1 comment)\n\nWhile this likely works great in lab/devstack environment I don\u0027t think we really can afford this design as it is.\n\nBlocking it for now expecting glance specific spec for this so we can discuss the needs, design and implementations as it clearly needs to deviate from the original X-proj spec.","accounts_in_message":[],"_revision_number":2},{"id":"850006e92d18d2b6317e04b953cda96bb6db37d6","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-07-07 13:57:31.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-glanceclient-docs http://docs-draft.openstack.org/52/316052/2/check/gate-python-glanceclient-docs/621623c//doc/build/html/ : SUCCESS in 3m 13s\n- gate-python-glanceclient-pep8 http://logs.openstack.org/52/316052/2/check/gate-python-glanceclient-pep8/b2c8fc7/ : SUCCESS in 3m 08s\n- gate-python-glanceclient-python27 http://logs.openstack.org/52/316052/2/check/gate-python-glanceclient-python27/a2bf181/ : SUCCESS in 3m 42s\n- gate-python-glanceclient-python34 http://logs.openstack.org/52/316052/2/check/gate-python-glanceclient-python34/fdb3753/ : SUCCESS in 2m 42s\n- gate-python-glanceclient-python35-nv http://logs.openstack.org/52/316052/2/check/gate-python-glanceclient-python35-nv/bd28ba6/ : SUCCESS in 3m 57s (non-voting)\n- gate-python-glanceclient-requirements http://logs.openstack.org/52/316052/2/check/gate-python-glanceclient-requirements/b82d74e/ : SUCCESS in 1m 49s\n- gate-tempest-dsvm-neutron-src-python-glanceclient http://logs.openstack.org/52/316052/2/check/gate-tempest-dsvm-neutron-src-python-glanceclient/6afb212/ : SUCCESS in 1h 02m 10s\n- gate-glanceclient-dsvm-functional http://logs.openstack.org/52/316052/2/check/gate-glanceclient-dsvm-functional/50e63f0/ : SUCCESS in 23m 01s\n- gate-glanceclient-dsvm-functional-identity-v3-only-nv http://logs.openstack.org/52/316052/2/check/gate-glanceclient-dsvm-functional-identity-v3-only-nv/f57912e/ : FAILURE in 22m 15s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"2ba24dd4155f55c4d9bd977bab040d628cc525ee","author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"date":"2016-07-14 11:46:27.000000000","message":"Patch Set 2:\n\n\u003e (1 comment)\n \u003e \n \u003e While this likely works great in lab/devstack environment I don\u0027t\n \u003e think we really can afford this design as it is.\n \u003e \n \u003e Blocking it for now expecting glance specific spec for this so we\n \u003e can discuss the needs, design and implementations as it clearly\n \u003e needs to deviate from the original X-proj spec.\n\nHi Erno,\n\nThank you for review.\nIMO there is already a lite-specs registered for this\n\nhttps://bugs.launchpad.net/glance/+bug/1585917/comments/3\n\nstill there is a need to add a glance-specs?\n\nPlease suggest.","accounts_in_message":[],"_revision_number":2},{"id":"cfa89a75234583a41af3b2d05c9cb6da8c87ef75","author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"date":"2016-07-14 13:53:50.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"a157a853b86add5574a4f37c0fea47cf1bcc6838","author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"date":"2016-07-15 05:20:56.000000000","message":"Patch Set 2:\n\nlite-specs URL:\n\nhttps://launchpad.net/bugs/1525259","accounts_in_message":[],"_revision_number":2},{"id":"ce5f1128696b492d933a861762c7dc49078b741b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-01-23 22:20:02.000000000","message":"Patch Set 2: Verified-1\n\nMerge Failed.\n\nThis change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.","accounts_in_message":[],"_revision_number":2},{"id":"8576584af16950a5d7784a3a774bbff61d7c8ecf","author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"date":"2017-01-24 16:19:35.000000000","message":"Abandoned\n\nMarking this as \u0027abandoned\u0027, as I believe it was fixed by Change-Id: If8c0e0843270ff718a37ca2697afeb8da22aa3b1 , which is also marked Closes-Bug: #1525259.\n\nLet me know if I\u0027m incorrect about this.  Thanks!","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"3ce35f4fd3a738ca3e63885a2eaae4b763c93c6a","revisions":{"298adf04631dbada24415e08101bc0d52bbdee92":{"kind":"REWORK","_number":1,"created":"2016-05-13 12:07:17.000000000","uploader":{"_account_id":10485,"name":"Ankit Agrawal","email":"ankitagrawal8188@gmail.com","username":"ankitagrawal"},"ref":"refs/changes/52/316052/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/52/316052/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/52/316052/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/52/316052/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/52/316052/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/52/316052/1"}}},"commit":{"parents":[{"commit":"f39647ab47cb10af83a6861149f5897ed570f4a0","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/f39647ab47cb10af83a6861149f5897ed570f4a0"}]}],"author":{"name":"Ankit Agrawal","email":"ankit11.agrawal@nttdata.com","date":"2016-04-22 13:54:49.000000000","tz":0},"committer":{"name":"Ankit Agrawal","email":"ankit11.agrawal@nttdata.com","date":"2016-05-13 12:05:09.000000000","tz":330},"subject":"WIP: Add request id to returned objects","message":"WIP: Add request id to returned objects\n\nWrap existing objects returned from API\nusing wrapt.ObjectProxy to add request_ids\nproperty.\n\nImplements: blueprint return-request-id-to-caller\nChange-Id: Iaa35b79c13cf3dd53883f039a8f3416178a0f081\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/298adf04631dbada24415e08101bc0d52bbdee92"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/298adf04631dbada24415e08101bc0d52bbdee92"}]},"branch":"refs/heads/master"},"3ce35f4fd3a738ca3e63885a2eaae4b763c93c6a":{"kind":"REWORK","_number":2,"created":"2016-07-07 12:53:39.000000000","uploader":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"ref":"refs/changes/52/316052/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/52/316052/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/52/316052/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/52/316052/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/52/316052/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/52/316052/2"}}},"commit":{"parents":[{"commit":"f2c02830f67b443d04ffdf466cf8603745fbb301","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/f2c02830f67b443d04ffdf466cf8603745fbb301"}]}],"author":{"name":"Ankit Agrawal","email":"ankit11.agrawal@nttdata.com","date":"2016-04-22 13:54:49.000000000","tz":0},"committer":{"name":"Abhishek Kekane","email":"abhishek.kekane@nttdata.com","date":"2016-07-07 12:50:28.000000000","tz":330},"subject":"WIP: Add request id to returned objects","message":"WIP: Add request id to returned objects\n\nWrap existing objects returned from API\nusing wrapt.ObjectProxy to add request_ids\nproperty.\n\nImplements: blueprint return-request-id-to-caller\nChange-Id: Iaa35b79c13cf3dd53883f039a8f3416178a0f081\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/3ce35f4fd3a738ca3e63885a2eaae4b763c93c6a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/3ce35f4fd3a738ca3e63885a2eaae4b763c93c6a"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}