)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"442da36360b67ffd93aa90f621296c6cdf2c9515","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix \"Codec can\u0027t encode characters\""},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Added safe_encode \u0027utf-8\u0027 when converting image meta to headers."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: If9f8020220d2a0431b4241b38b9c83c09c0d75cb"},{"line_number":12,"context_line":"Closes-bug: #1574587"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"dab17558_9f3f2886","line":9,"updated":"2016-05-17 13:04:03.000000000","message":"May it\u0027s better to mention that we do it for SessionClient only?","commit_id":"fb5045514120906425ce3542c38490cac9194d5b"},{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"cf4e31de57cc0e2c1c652398cf93058585ec0c85","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Headers were encoded in HTTPclient. They are not encoded when"},{"line_number":10,"context_line":"we started to use SessionClient."},{"line_number":11,"context_line":"This commit adds method \"encode_headers\" for SessionClient."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: If9f8020220d2a0431b4241b38b9c83c09c0d75cb"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"bab6814e_a10a451f","line":11,"updated":"2016-05-19 15:34:39.000000000","message":"AFAIS this commit doesn\u0027t add method \"encode_headers\" for SessionClient. On the contrary, it removes this static method from HTTPClient and makes it a common function. \n\nSo, I would say \"\nHeaders were encoded in HTTPClient, but when glance client started to use SessionClient this functionality was lost.\n\nThis commit replaces static method \"encode_headers\" from HTTPClient and makes it a common function, that SessionClient can use when converting image meta to headers.\n\"","commit_id":"6efab7d27d5d2e9aed62c43e9bc37a39b79d4479"}],"glanceclient/common/http.py":[{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"442da36360b67ffd93aa90f621296c6cdf2c9515","unresolved":false,"context_lines":[{"line_number":306,"context_line":"        super(SessionClient, self).__init__(session, **kwargs)"},{"line_number":307,"context_line":""},{"line_number":308,"context_line":"    @staticmethod"},{"line_number":309,"context_line":"    def encode_headers(headers):"},{"line_number":310,"context_line":"        \"\"\"Encodes headers."},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"        Note: This should be used right before"}],"source_content_type":"text/x-python","patch_set":8,"id":"dab17558_1f8fb875","line":309,"updated":"2016-05-17 13:04:03.000000000","message":"You shouldn\u0027t add this code since you added similar function above.","commit_id":"fb5045514120906425ce3542c38490cac9194d5b"}],"glanceclient/v1/images.py":[{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"d275e497b08e17084e28d8b9f0153782cb62fb9b","unresolved":false,"context_lines":[{"line_number":100,"context_line":"        # that are not instance of basestring. All"},{"line_number":101,"context_line":"        # headers will be encoded later, before the"},{"line_number":102,"context_line":"        # request is sent."},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"        def to_str(value):"},{"line_number":105,"context_line":"            if not isinstance(value, six.string_types):"},{"line_number":106,"context_line":"                value \u003d str(value)"}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_37db52ef","line":103,"updated":"2016-05-13 13:06:23.000000000","message":"Unnecessary empty line","commit_id":"c74c21017d0afb4bd8c9ccc026783adcaa41135f"},{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"d275e497b08e17084e28d8b9f0153782cb62fb9b","unresolved":false,"context_lines":[{"line_number":104,"context_line":"        def to_str(value):"},{"line_number":105,"context_line":"            if not isinstance(value, six.string_types):"},{"line_number":106,"context_line":"                value \u003d str(value)"},{"line_number":107,"context_line":"            return encodeutils.safe_encode(value, encoding\u003d\u0027utf-8\u0027)"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"        for key, value in six.iteritems(fields_copy.pop(\u0027properties\u0027, {})):"},{"line_number":110,"context_line":"            headers[\u0027x-image-meta-property-%s\u0027 % key] \u003d to_str(value)"}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_3754f252","line":107,"range":{"start_line":107,"start_character":50,"end_line":107,"end_character":58},"updated":"2016-05-13 13:06:23.000000000","message":"Seems like this encoding is using by default https://github.com/openstack/oslo.utils/blob/master/oslo_utils/encodeutils.py#L67","commit_id":"c74c21017d0afb4bd8c9ccc026783adcaa41135f"}]}