)]}'
{"id":"openstack%2Fpython-glanceclient~319960","triplet_id":"openstack%2Fpython-glanceclient~master~I08d8d87fc0cc291f1b930b2c0cfc110ec8394131","project":"openstack/python-glanceclient","branch":"master","topic":"bug/1552533","hashtags":[],"change_id":"I08d8d87fc0cc291f1b930b2c0cfc110ec8394131","subject":"Revert \"Add last_request_id member to HTTPClient and SessionClient\"","status":"MERGED","created":"2016-05-23 14:14:11.000000000","updated":"2016-12-14 17:35:22.000000000","submitted":"2016-12-14 17:35:22.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"5f3e35efe22a84c4506ce7b4e204c3f5d3bc3029","_number":319960,"virtual_id_number":319960,"owner":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},{"value":0,"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},{"value":0,"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"value":0,"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},{"value":2,"date":"2016-12-14 17:35:22.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"all":[{"value":2,"date":"2016-12-06 15:22:17.000000000","_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},{"value":1,"date":"2016-05-23 21:12:55.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},{"value":1,"date":"2016-12-14 00:29:55.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"value":2,"date":"2016-12-14 16:20:09.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2016-12-08 17:29:52.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"all":[{"value":0,"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},{"value":0,"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},{"value":0,"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"value":1,"date":"2016-12-14 16:20:09.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},{"value":0,"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},{"value":0,"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"value":0,"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Top Priority / Holds Gate"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-05-23 21:12:55.000000000","updated_by":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"reviewer":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"state":"REVIEWER"},{"updated":"2016-12-06 15:22:17.000000000","updated_by":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"reviewer":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"state":"REVIEWER"},{"updated":"2016-12-08 17:29:52.000000000","updated_by":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"reviewer":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"state":"REVIEWER"},{"updated":"2016-12-14 00:29:55.000000000","updated_by":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"reviewer":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"state":"REVIEWER"},{"updated":"2016-12-14 16:20:09.000000000","updated_by":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"reviewer":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"state":"REVIEWER"},{"updated":"2016-12-14 17:35:22.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"54d3db4c4dc2c91b982208f23623a3ad636bfbe5","author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"date":"2016-05-23 14:15:14.000000000","message":"Patch Set 2: Published edit on patch set 1","accounts_in_message":[],"_revision_number":2},{"id":"5e2ba3ef7a2cbafe1accd2168acaeb8c90886150","author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"date":"2016-05-23 14:24:19.000000000","message":"Patch Set 2: Code-Review-1\n\nIf we need to use thread-local storage, why not update the code to do just that instead of reverting?","accounts_in_message":[],"_revision_number":2},{"id":"4ad45656042fc79c4ecfc4a0dfd284cdcf7b37eb","author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"date":"2016-05-23 14:28:20.000000000","message":"Patch Set 2:\n\nHi Ian,\n\neven if we use thread local storage there are some corner cases where we might get wrong request-id. We had this discussion in cross-project meetings and this solution was rejected in the same. Please refer cons in http://specs.openstack.org/openstack/openstack-specs/specs/return-request-id.html#alternatives","accounts_in_message":[],"_revision_number":2},{"id":"829017e2a527c1e29129b5fa35dd45fe56300cd5","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-05-23 16:36:09.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-glanceclient-docs http://docs-draft.openstack.org/60/319960/2/check/gate-python-glanceclient-docs/70bdafb//doc/build/html/ : SUCCESS in 2m 30s\n- gate-python-glanceclient-pep8 http://logs.openstack.org/60/319960/2/check/gate-python-glanceclient-pep8/da4aacb/ : SUCCESS in 2m 49s\n- gate-python-glanceclient-python27 http://logs.openstack.org/60/319960/2/check/gate-python-glanceclient-python27/6a31cfc/ : SUCCESS in 3m 12s\n- gate-python-glanceclient-python34 http://logs.openstack.org/60/319960/2/check/gate-python-glanceclient-python34/15ec788/ : SUCCESS in 3m 26s\n- gate-tempest-dsvm-neutron-src-python-glanceclient http://logs.openstack.org/60/319960/2/check/gate-tempest-dsvm-neutron-src-python-glanceclient/c39202b/ : SUCCESS in 1h 04m 31s\n- gate-glanceclient-dsvm-functional http://logs.openstack.org/60/319960/2/check/gate-glanceclient-dsvm-functional/f8a5d26/ : SUCCESS in 19m 40s","accounts_in_message":[],"_revision_number":2},{"id":"04cd530c634a97dc0098a713edc65538ed90acc3","author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"date":"2016-05-23 21:12:55.000000000","message":"Patch Set 2: Code-Review+1\n\nIan,\n\nI asked Abhishek to propose revert to the change after he confirmed to me that this is not suitable solution to fix the issue. We can discuss if there is straight forward way to do it right or if we want to release this and disregard the issues it introduces for now. As the change had not got into any release yet I think it\u0027s right thing to do to revert the buggy bugfix and do it right if we decide to do so.\n\nI\u0027m tentatively pro of this.","accounts_in_message":[],"_revision_number":2},{"id":"1e463204a26b0758db389b7574116eae16688b00","author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"date":"2016-12-01 14:27:52.000000000","message":"Patch Set 2:\n\nHi Devs,\n\nAs mentioned in the commit message we either need to revert this patch or add a fix to use thread local storage to avoid giving wrong information to user.\n\nIMO we should revert this patch as this design is already rejected in cross-project discussion and even adding a thread local storage will be liable to bugs where folk make two calls and then look at the wrong id or deletes where N calls are involved - that implies buffering lots of ids on the client, which implies an API for resetting it.","accounts_in_message":[],"_revision_number":2},{"id":"e03e5f8154844ab29b11782d13ce4170ba303685","author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"date":"2016-12-06 15:22:17.000000000","message":"Patch Set 2: Code-Review+2\n\nThank you for the explanation Abhishek \u0026 Erno. Sorry for the delay","accounts_in_message":[],"_revision_number":2},{"id":"2b8878e80650f2d3a675be044103b764181440df","author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"date":"2016-12-08 17:29:52.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"be09984a1e7125029a2c31a7f92236298d07ac9d","author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"date":"2016-12-14 00:29:55.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"f94f8c237328fd959ba4473efd3d1b2614cd8bad","author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"date":"2016-12-14 16:20:09.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1\n\nI agree with Erno\u0027s suggestion that we need to revert the buggy bugfix and work on a better solution.  Thanks, Abhishek.","accounts_in_message":[],"_revision_number":2},{"id":"9301a02cc73942ca10ff7122fc2d6eae1d3de85f","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-12-14 16:20:19.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"e2091570b21612815b08d34b76f991bbecdd016d","date":"2016-12-14 17:35:22.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":2},{"id":"f0188009d2babc3e3d3579b8e69f1c34ca8ecdbe","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-12-14 17:35:22.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-glanceclient-docs-ubuntu-xenial http://docs-draft.openstack.org/60/319960/2/gate/gate-python-glanceclient-docs-ubuntu-xenial/bd78efd//doc/build/html/ : SUCCESS in 4m 04s\n- gate-python-glanceclient-pep8-ubuntu-xenial http://logs.openstack.org/60/319960/2/gate/gate-python-glanceclient-pep8-ubuntu-xenial/45b401e/ : SUCCESS in 4m 35s\n- gate-python-glanceclient-python27-ubuntu-xenial http://logs.openstack.org/60/319960/2/gate/gate-python-glanceclient-python27-ubuntu-xenial/915ffa9/ : SUCCESS in 4m 00s\n- gate-tempest-dsvm-neutron-src-python-glanceclient-ubuntu-xenial http://logs.openstack.org/60/319960/2/gate/gate-tempest-dsvm-neutron-src-python-glanceclient-ubuntu-xenial/1d0b464/ : SUCCESS in 1h 14m 00s\n- gate-glanceclient-dsvm-functional-ubuntu-xenial http://logs.openstack.org/60/319960/2/gate/gate-glanceclient-dsvm-functional-ubuntu-xenial/b0100f3/ : SUCCESS in 34m 22s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"7d106c677adf247c37dbc34beae5a446765128a8","revisions":{"6f269918714580199e2f1eb7983f65ec87bdfb22":{"kind":"REWORK","_number":1,"created":"2016-05-23 14:14:11.000000000","uploader":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"ref":"refs/changes/60/319960/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/60/319960/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/60/319960/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/60/319960/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/60/319960/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/60/319960/1"}}},"commit":{"parents":[{"commit":"9e532db8b0f0ba537edef143a6f5380a2aaa1e4b","subject":"Add last_request_id member to HTTPClient and SessionClient","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/9e532db8b0f0ba537edef143a6f5380a2aaa1e4b"}]}],"author":{"name":"Abhishek Kekane","email":"abhishek.kekane@nttdata.com","date":"2016-05-23 14:14:11.000000000","tz":0},"committer":{"name":"Abhishek Kekane","email":"abhishek.kekane@nttdata.com","date":"2016-05-23 14:14:11.000000000","tz":0},"subject":"Revert \"Add last_request_id member to HTTPClient and SessionClient\"","message":"Revert \"Add last_request_id member to HTTPClient and SessionClient\"\n\nThis reverts commit 9e532db8b0f0ba537edef143a6f5380a2aaa1e4b.\n\nIf glanceclient is used in multi-threaded environment, then there is a possibility of getting invalid/wrong last request-id. To avoid this, need to use thread local storage to store last-request-id and add public method to return this request-id to caller.\n\nhttp://specs.openstack.org/openstack/openstack-specs/specs/return-request-id.html#alternatives\n\nChange-Id: I08d8d87fc0cc291f1b930b2c0cfc110ec8394131\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/6f269918714580199e2f1eb7983f65ec87bdfb22"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/6f269918714580199e2f1eb7983f65ec87bdfb22"}]},"branch":"refs/heads/master"},"7d106c677adf247c37dbc34beae5a446765128a8":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2016-05-23 14:15:14.000000000","uploader":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"ref":"refs/changes/60/319960/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/60/319960/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/60/319960/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/60/319960/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/60/319960/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/60/319960/2"}}},"commit":{"parents":[{"commit":"9e532db8b0f0ba537edef143a6f5380a2aaa1e4b","subject":"Add last_request_id member to HTTPClient and SessionClient","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/9e532db8b0f0ba537edef143a6f5380a2aaa1e4b"}]}],"author":{"name":"Abhishek Kekane","email":"abhishek.kekane@nttdata.com","date":"2016-05-23 14:14:11.000000000","tz":0},"committer":{"name":"Abhishek Kekane","email":"abhishek.kekane@nttdata.com","date":"2016-05-23 14:14:55.000000000","tz":0},"subject":"Revert \"Add last_request_id member to HTTPClient and SessionClient\"","message":"Revert \"Add last_request_id member to HTTPClient and SessionClient\"\n\nThis reverts commit 9e532db8b0f0ba537edef143a6f5380a2aaa1e4b.\n\nIf glanceclient is used in multi-threaded environment, then there is a\npossibility of getting invalid/wrong last request-id. To avoid this,\nneed to use thread local storage to store last-request-id and add\npublic method to return this request-id to caller.\n\nhttp://specs.openstack.org/openstack/openstack-specs/specs/return-request-id.html#alternatives\n\nChange-Id: I08d8d87fc0cc291f1b930b2c0cfc110ec8394131\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/7d106c677adf247c37dbc34beae5a446765128a8"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/7d106c677adf247c37dbc34beae5a446765128a8"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}