)]}'
{"id":"openstack%2Fpython-glanceclient~324046","triplet_id":"openstack%2Fpython-glanceclient~master~I8eced32f39d0c98e0b26014e7b2341ab6580ff01","project":"openstack/python-glanceclient","branch":"master","topic":"bug/1587999","hashtags":[],"change_id":"I8eced32f39d0c98e0b26014e7b2341ab6580ff01","subject":"Don\u0027t update tags every time","status":"MERGED","created":"2016-06-01 18:04:32.000000000","updated":"2016-08-19 06:10:14.000000000","submitted":"2016-08-08 09:09:22.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"b5d5b391e68b5e2b661da267b21567265abff2f2","_number":324046,"virtual_id_number":324046,"owner":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":16658,"name":"Darja Shakhray","email":"damalyavkina@gmail.com","username":"dshakhray"},{"value":0,"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},{"value":2,"date":"2016-08-08 09:09:22.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},{"value":0,"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},{"value":0,"_account_id":17116,"name":"Niall Bunting","email":"niall.bunting@hpe.com","username":"NiallBunting"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"recommended":{"_account_id":16658,"name":"Darja Shakhray","email":"damalyavkina@gmail.com","username":"dshakhray"},"all":[{"value":1,"date":"2016-06-28 10:19:23.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":16658,"name":"Darja Shakhray","email":"damalyavkina@gmail.com","username":"dshakhray"},{"value":2,"date":"2016-08-08 07:54:10.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2016-06-21 15:07:46.000000000","_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},{"value":2,"date":"2016-07-30 20:41:11.000000000","_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},{"value":1,"date":"2016-06-14 09:52:51.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":17116,"name":"Niall Bunting","email":"niall.bunting@hpe.com","username":"NiallBunting"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"all":[{"value":0,"_account_id":16658,"name":"Darja Shakhray","email":"damalyavkina@gmail.com","username":"dshakhray"},{"value":1,"date":"2016-08-08 07:54:10.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},{"value":0,"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},{"value":0,"_account_id":17116,"name":"Niall Bunting","email":"niall.bunting@hpe.com","username":"NiallBunting"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":16658,"name":"Darja Shakhray","email":"damalyavkina@gmail.com","username":"dshakhray"},{"value":0,"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},{"value":0,"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},{"value":0,"_account_id":17116,"name":"Niall Bunting","email":"niall.bunting@hpe.com","username":"NiallBunting"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Top Priority / Holds Gate"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},{"_account_id":16658,"name":"Darja Shakhray","email":"damalyavkina@gmail.com","username":"dshakhray"},{"_account_id":17116,"name":"Niall Bunting","email":"niall.bunting@hpe.com","username":"NiallBunting"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-06-14 09:52:51.000000000","updated_by":{"_account_id":17116,"name":"Niall Bunting","email":"niall.bunting@hpe.com","username":"NiallBunting"},"reviewer":{"_account_id":17116,"name":"Niall Bunting","email":"niall.bunting@hpe.com","username":"NiallBunting"},"state":"REVIEWER"},{"updated":"2016-06-21 15:07:46.000000000","updated_by":{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},"reviewer":{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},"state":"REVIEWER"},{"updated":"2016-06-28 10:19:23.000000000","updated_by":{"_account_id":16658,"name":"Darja Shakhray","email":"damalyavkina@gmail.com","username":"dshakhray"},"reviewer":{"_account_id":16658,"name":"Darja Shakhray","email":"damalyavkina@gmail.com","username":"dshakhray"},"state":"REVIEWER"},{"updated":"2016-07-30 20:41:11.000000000","updated_by":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"reviewer":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"state":"REVIEWER"},{"updated":"2016-08-08 07:54:10.000000000","updated_by":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"reviewer":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"state":"REVIEWER"},{"updated":"2016-08-08 09:09:22.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"9237fde5cf8e4c321521fedc38656b45c1fdba16","author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"date":"2016-06-01 18:04:32.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"7364f3602f2b5619cf40b549f67fc6cd49d7a10c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-06-01 20:43:36.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-glanceclient-docs http://docs-draft.openstack.org/46/324046/1/check/gate-python-glanceclient-docs/a08d9a6//doc/build/html/ : SUCCESS in 3m 00s\n- gate-python-glanceclient-pep8 http://logs.openstack.org/46/324046/1/check/gate-python-glanceclient-pep8/cc2ad95/ : SUCCESS in 6m 43s\n- gate-python-glanceclient-python27 http://logs.openstack.org/46/324046/1/check/gate-python-glanceclient-python27/6b6e7d2/ : SUCCESS in 2m 15s\n- gate-python-glanceclient-python34 http://logs.openstack.org/46/324046/1/check/gate-python-glanceclient-python34/d47acd9/ : SUCCESS in 4m 05s\n- gate-tempest-dsvm-neutron-src-python-glanceclient http://logs.openstack.org/46/324046/1/check/gate-tempest-dsvm-neutron-src-python-glanceclient/35519f1/ : SUCCESS in 1h 15m 15s\n- gate-glanceclient-dsvm-functional http://logs.openstack.org/46/324046/1/check/gate-glanceclient-dsvm-functional/3c00361/ : SUCCESS in 14m 49s","accounts_in_message":[],"_revision_number":1},{"id":"24c84249889021afc6ed9f99410dba4e27f2a8a2","author":{"_account_id":17116,"name":"Niall Bunting","email":"niall.bunting@hpe.com","username":"NiallBunting"},"date":"2016-06-14 09:52:51.000000000","message":"Patch Set 1: Code-Review+1\n\nTested and works for me.","accounts_in_message":[],"_revision_number":1},{"id":"ed2ea5c05c7522b05a73bfbbdf726e10ac94c682","author":{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},"date":"2016-06-21 15:07:46.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"b23c2f2f54bb03586d91a74c311bd6172cd4cf03","author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"date":"2016-06-21 16:25:53.000000000","message":"Patch Set 1: Code-Review-1\n\nIIRC we have discussed about this before. Client either should error out for the user or let the server to do the decision. The client should not just silently drop parts of the call.","accounts_in_message":[],"_revision_number":1},{"id":"82b9c4cb801b83237c9377eaaa01d3215e1ed515","author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"date":"2016-06-21 16:28:58.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"c6b40c2b26210cfac0647ef2982d771701f71960","author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"date":"2016-06-21 16:58:21.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"c149b6efe41c665126cc4ed32878f964c4d0c062","author":{"_account_id":16658,"name":"Darja Shakhray","email":"damalyavkina@gmail.com","username":"dshakhray"},"date":"2016-06-28 10:19:23.000000000","message":"Patch Set 1: Code-Review+1\n\nThanks for the fix of this bug)\nI do not believe that we need to write more tests because such scenarios have already checked, for example https://github.com/openstack/python-glanceclient/blob/master/glanceclient/tests/unit/v2/test_images.py#L1111 https://github.com/openstack/python-glanceclient/blob/master/glanceclient/tests/unit/v2/test_tags.py#L59","accounts_in_message":[],"_revision_number":1},{"id":"e6591a6ede89a688f31e786aabc4220eb2d66cb1","author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"date":"2016-07-30 20:41:11.000000000","message":"Patch Set 1: Code-Review+2\n\nLooks like a fine change to me.\n\nErno, is your concern addressed?","accounts_in_message":[],"_revision_number":1},{"id":"c5e02c8121c794fad5c5531dd6e136fabe84a914","author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"date":"2016-08-08 07:54:10.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\nYup, sorry, makes way more sense on the second read.","accounts_in_message":[],"_revision_number":1},{"id":"1dfab3624c73ce1d150bd7174af1879551444005","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-08-08 07:54:46.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"2ac981591685f4c177c0da6c0e5df15bee9e7851","date":"2016-08-08 09:09:22.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":1},{"id":"7517c3f402e2a8cdff3f0414657ea595fb19ecc2","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-08-08 09:09:22.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-glanceclient-docs-ubuntu-xenial http://docs-draft.openstack.org/46/324046/1/gate/gate-python-glanceclient-docs-ubuntu-xenial/b747b4e//doc/build/html/ : SUCCESS in 3m 33s\n- gate-python-glanceclient-pep8-ubuntu-xenial http://logs.openstack.org/46/324046/1/gate/gate-python-glanceclient-pep8-ubuntu-xenial/d4d41ab/ : SUCCESS in 2m 05s\n- gate-python-glanceclient-python27-ubuntu-xenial http://logs.openstack.org/46/324046/1/gate/gate-python-glanceclient-python27-ubuntu-xenial/0fe12b8/ : SUCCESS in 5m 03s\n- gate-python-glanceclient-python34 http://logs.openstack.org/46/324046/1/gate/gate-python-glanceclient-python34/b5acf6b/ : SUCCESS in 2m 20s\n- gate-tempest-dsvm-neutron-src-python-glanceclient http://logs.openstack.org/46/324046/1/gate/gate-tempest-dsvm-neutron-src-python-glanceclient/cda04ee/ : SUCCESS in 1h 13m 35s\n- gate-glanceclient-dsvm-functional http://logs.openstack.org/46/324046/1/gate/gate-glanceclient-dsvm-functional/1325027/ : SUCCESS in 31m 26s","accounts_in_message":[],"_revision_number":1},{"id":"ab3db4e2f5abd86175f408db3b61dd1ab1990793","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2016-08-19 06:10:14.000000000","message":"Patch Set 1: Reverted\n\nThis patchset was reverted in change: Ida826a2aa888beeb76dbe657b2ccd6cb088157ed","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"e77322c17931810f4029ef339a791f702f2f4580","revisions":{"e77322c17931810f4029ef339a791f702f2f4580":{"kind":"REWORK","_number":1,"created":"2016-06-01 18:04:32.000000000","uploader":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"ref":"refs/changes/46/324046/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/46/324046/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/46/324046/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/46/324046/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/46/324046/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/46/324046/1"}}},"commit":{"parents":[{"commit":"561c33ccf019b29e6613f58fb1d41de24e5da2f2","subject":"Merge \"[Trivial] Remove unnecessary executable privilege\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/561c33ccf019b29e6613f58fb1d41de24e5da2f2"}]}],"author":{"name":"Mike Fedosin","email":"mfedosin@mirantis.com","date":"2016-06-01 18:02:29.000000000","tz":180},"committer":{"name":"Mike Fedosin","email":"mfedosin@mirantis.com","date":"2016-06-01 18:02:29.000000000","tz":180},"subject":"Don\u0027t update tags every time","message":"Don\u0027t update tags every time\n\nThis code removes unnecessary PATCH requests\nfor tags updating if they were not modified.\n\nChange-Id: I8eced32f39d0c98e0b26014e7b2341ab6580ff01\nCloses-bug: 1587999\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/e77322c17931810f4029ef339a791f702f2f4580"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/e77322c17931810f4029ef339a791f702f2f4580"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}