)]}'
{"glanceclient/common/http.py":[{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"22c81cf2f16e146816f87acd540bfb5d336a4250","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"osprofiler_web \u003d importutils.try_import(\"osprofiler.web\")"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":41,"context_line":"USER_AGENT \u003d \u0027python-glanceclient\u0027"},{"line_number":42,"context_line":"CHUNKSIZE \u003d 1024 * 64  # 64kB"},{"line_number":43,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5a9d85d2_2d5f7742","side":"PARENT","line":40,"updated":"2016-06-21 11:56:59.000000000","message":"Why moving this?","commit_id":"46c3792feef6f36b31e9783724b914d6740b0f84"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"a1c407600eb5cb30584dd2e0137014b23dd41c65","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"osprofiler_web \u003d importutils.try_import(\"osprofiler.web\")"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":41,"context_line":"USER_AGENT \u003d \u0027python-glanceclient\u0027"},{"line_number":42,"context_line":"CHUNKSIZE \u003d 1024 * 64  # 64kB"},{"line_number":43,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5a9d85d2_bce0bacd","side":"PARENT","line":40,"in_reply_to":"5a9d85d2_2d5f7742","updated":"2016-06-21 12:06:18.000000000","message":"If we keep this as it is then we need to set LOG level to debug explicitly. I have made this so that we can pass logger from third-party applications (like nova) and the log level configured in third-party applications will be used in this case.","commit_id":"46c3792feef6f36b31e9783724b914d6740b0f84"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"1597c24dc8f43b37247d719d1774f571c8f95671","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"osprofiler_web \u003d importutils.try_import(\"osprofiler.web\")"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":41,"context_line":"USER_AGENT \u003d \u0027python-glanceclient\u0027"},{"line_number":42,"context_line":"CHUNKSIZE \u003d 1024 * 64  # 64kB"},{"line_number":43,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5a9d85d2_ff38743f","side":"PARENT","line":40,"in_reply_to":"5a9d85d2_bce0bacd","updated":"2016-06-21 12:18:07.000000000","message":"We should,\n\nThat\u0027s why oslo.logging provides the module logging levels.\nLike https://github.com/openstack/glance/blob/master/etc/glance-api.conf#L451-L453","commit_id":"46c3792feef6f36b31e9783724b914d6740b0f84"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"22c81cf2f16e146816f87acd540bfb5d336a4250","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        # log request-id for each api call"},{"line_number":124,"context_line":"        request_id \u003d resp.headers.get(\u0027x-openstack-request-id\u0027)"},{"line_number":125,"context_line":"        if request_id:"},{"line_number":126,"context_line":"            self.logger.debug(\u0027%(method)s call to %(service_name)s for \u0027"},{"line_number":127,"context_line":"                              \u0027%(url)s used request id \u0027"},{"line_number":128,"context_line":"                              \u0027%(response_request_id)s\u0027,"},{"line_number":129,"context_line":"                              {\u0027method\u0027: resp.request.method,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a9d85d2_c80fc186","line":126,"range":{"start_line":126,"start_character":50,"end_line":126,"end_character":66},"updated":"2016-06-21 11:56:59.000000000","message":"How about just spelling this out as it\u0027s fixed string anyways?","commit_id":"1bca2e546a9773a6d4fdd82cb410c6ecf0aae59d"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"a1c407600eb5cb30584dd2e0137014b23dd41c65","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        # log request-id for each api call"},{"line_number":124,"context_line":"        request_id \u003d resp.headers.get(\u0027x-openstack-request-id\u0027)"},{"line_number":125,"context_line":"        if request_id:"},{"line_number":126,"context_line":"            self.logger.debug(\u0027%(method)s call to %(service_name)s for \u0027"},{"line_number":127,"context_line":"                              \u0027%(url)s used request id \u0027"},{"line_number":128,"context_line":"                              \u0027%(response_request_id)s\u0027,"},{"line_number":129,"context_line":"                              {\u0027method\u0027: resp.request.method,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a9d85d2_1ce8eeb3","line":126,"range":{"start_line":126,"start_character":50,"end_line":126,"end_character":66},"in_reply_to":"5a9d85d2_c80fc186","updated":"2016-06-21 12:06:18.000000000","message":"agree, will fix it in next patch set.","commit_id":"1bca2e546a9773a6d4fdd82cb410c6ecf0aae59d"}]}