)]}'
{"id":"openstack%2Fpython-glanceclient~33327","triplet_id":"openstack%2Fpython-glanceclient~master~Ibb2c44df99ae5746e32695e69078737cc6b5aeeb","project":"openstack/python-glanceclient","branch":"master","topic":"bp/image-tools","hashtags":[],"change_id":"Ibb2c44df99ae5746e32695e69078737cc6b5aeeb","subject":"Move glance image service client from nova and cinder.","status":"ABANDONED","created":"2013-06-17 18:35:46.000000000","updated":"2013-08-17 06:03:06.000000000","total_comment_count":51,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"fa202ff9ceac140439da7d2ec71b7ed0b1bd60ee","_number":33327,"virtual_id_number":33327,"owner":{"_account_id":1726,"name":"Ghe Rivero","email":"ghe.rivero@gmail.com","username":"ghe.rivero"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"_account_id":5347,"name":"Eddie Sheffield","email":"eddie.sheffield@rackspace.com","username":"eddie-sheffield"},{"value":1,"date":"2013-08-06 11:56:13.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":7701,"name":"Amala Basha","email":"amala.alungal@RACKSPACE.COM","username":"amalabasha"},{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},{"_account_id":616,"name":"Mark Washenberger","email":"mark.washenberger@markwash.net","username":"markwash"},{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},{"_account_id":6493,"name":"John Bresnahan","email":"john@bresnahan.me","username":"jbresnah"},{"_account_id":1726,"name":"Ghe Rivero","email":"ghe.rivero@gmail.com","username":"ghe.rivero"},{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},{"_account_id":4463,"name":"iccha-sethi","email":"iccha.sethi@rackspace.com","username":"iccha-sethi"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"recommended":{"_account_id":5347,"name":"Eddie Sheffield","email":"eddie.sheffield@rackspace.com","username":"eddie-sheffield"},"all":[{"value":1,"date":"2013-08-08 14:19:11.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":5347,"name":"Eddie Sheffield","email":"eddie.sheffield@rackspace.com","username":"eddie-sheffield"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":7701,"name":"Amala Basha","email":"amala.alungal@RACKSPACE.COM","username":"amalabasha"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},{"value":-1,"date":"2013-08-08 19:59:24.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":616,"name":"Mark Washenberger","email":"mark.washenberger@markwash.net","username":"markwash"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},{"value":-2,"date":"2013-08-08 23:35:45.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":6493,"name":"John Bresnahan","email":"john@bresnahan.me","username":"jbresnah"},{"value":0,"date":"2013-08-09 09:56:49.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":1726,"name":"Ghe Rivero","email":"ghe.rivero@gmail.com","username":"ghe.rivero"},{"value":2,"date":"2013-08-08 12:45:21.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":4463,"name":"iccha-sethi","email":"iccha.sethi@rackspace.com","username":"iccha-sethi"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":5347,"name":"Eddie Sheffield","email":"eddie.sheffield@rackspace.com","username":"eddie-sheffield"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":7701,"name":"Amala Basha","email":"amala.alungal@RACKSPACE.COM","username":"amalabasha"},{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},{"date":"2013-08-08 19:59:24.000000000","_account_id":616,"name":"Mark Washenberger","email":"mark.washenberger@markwash.net","username":"markwash"},{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},{"date":"2013-08-08 23:35:45.000000000","_account_id":6493,"name":"John Bresnahan","email":"john@bresnahan.me","username":"jbresnah"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":1726,"name":"Ghe Rivero","email":"ghe.rivero@gmail.com","username":"ghe.rivero"},{"date":"2013-08-08 12:45:21.000000000","_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},{"_account_id":4463,"name":"iccha-sethi","email":"iccha.sethi@rackspace.com","username":"iccha-sethi"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"_account_id":5347,"name":"Eddie Sheffield","email":"eddie.sheffield@rackspace.com","username":"eddie-sheffield"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":7701,"name":"Amala Basha","email":"amala.alungal@RACKSPACE.COM","username":"amalabasha"},{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},{"_account_id":616,"name":"Mark Washenberger","email":"mark.washenberger@markwash.net","username":"markwash"},{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},{"_account_id":6493,"name":"John Bresnahan","email":"john@bresnahan.me","username":"jbresnah"},{"_account_id":1726,"name":"Ghe Rivero","email":"ghe.rivero@gmail.com","username":"ghe.rivero"},{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},{"_account_id":4463,"name":"iccha-sethi","email":"iccha.sethi@rackspace.com","username":"iccha-sethi"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Top Priority / Holds Gate"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},{"_account_id":616,"name":"Mark Washenberger","email":"mark.washenberger@markwash.net","username":"markwash"},{"_account_id":1726,"name":"Ghe Rivero","email":"ghe.rivero@gmail.com","username":"ghe.rivero"},{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},{"_account_id":4463,"name":"iccha-sethi","email":"iccha.sethi@rackspace.com","username":"iccha-sethi"},{"_account_id":5347,"name":"Eddie Sheffield","email":"eddie.sheffield@rackspace.com","username":"eddie-sheffield"},{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},{"_account_id":6493,"name":"John Bresnahan","email":"john@bresnahan.me","username":"jbresnah"},{"_account_id":7701,"name":"Amala Basha","email":"amala.alungal@RACKSPACE.COM","username":"amalabasha"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-06-26 16:00:21.000000000","updated_by":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"reviewer":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"state":"REVIEWER"},{"updated":"2013-07-08 15:34:17.000000000","updated_by":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"reviewer":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"state":"REVIEWER"},{"updated":"2013-07-16 18:50:51.000000000","updated_by":{"_account_id":4463,"name":"iccha-sethi","email":"iccha.sethi@rackspace.com","username":"iccha-sethi"},"reviewer":{"_account_id":4463,"name":"iccha-sethi","email":"iccha.sethi@rackspace.com","username":"iccha-sethi"},"state":"REVIEWER"},{"updated":"2013-07-16 19:46:28.000000000","updated_by":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"reviewer":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"state":"REVIEWER"},{"updated":"2013-07-29 10:43:02.000000000","updated_by":{"_account_id":7701,"name":"Amala Basha","email":"amala.alungal@RACKSPACE.COM","username":"amalabasha"},"reviewer":{"_account_id":7701,"name":"Amala Basha","email":"amala.alungal@RACKSPACE.COM","username":"amalabasha"},"state":"REVIEWER"},{"updated":"2013-08-06 11:56:13.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2013-08-08 12:45:21.000000000","updated_by":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"reviewer":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"state":"REVIEWER"},{"updated":"2013-08-08 14:19:11.000000000","updated_by":{"_account_id":5347,"name":"Eddie Sheffield","email":"eddie.sheffield@rackspace.com","username":"eddie-sheffield"},"reviewer":{"_account_id":5347,"name":"Eddie Sheffield","email":"eddie.sheffield@rackspace.com","username":"eddie-sheffield"},"state":"REVIEWER"},{"updated":"2013-08-08 19:59:24.000000000","updated_by":{"_account_id":616,"name":"Mark Washenberger","email":"mark.washenberger@markwash.net","username":"markwash"},"reviewer":{"_account_id":616,"name":"Mark Washenberger","email":"mark.washenberger@markwash.net","username":"markwash"},"state":"REVIEWER"},{"updated":"2013-08-08 23:35:45.000000000","updated_by":{"_account_id":6493,"name":"John Bresnahan","email":"john@bresnahan.me","username":"jbresnah"},"reviewer":{"_account_id":6493,"name":"John Bresnahan","email":"john@bresnahan.me","username":"jbresnah"},"state":"REVIEWER"}],"messages":[{"id":"f5bba0359e2795577d54aaa8af3cd72dac9f9634","author":{"_account_id":1726,"name":"Ghe Rivero","email":"ghe.rivero@gmail.com","username":"ghe.rivero"},"date":"2013-06-17 18:36:22.000000000","message":"Patch Set 1: Work In Progress\n\nMissing some tests and docstrings","accounts_in_message":[],"_revision_number":1},{"id":"3e9ecc844cfe2fb9dad874038cf270b3cbd3112f","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-06-17 18:48:03.000000000","message":"Patch Set 1: Doesn\u0027t seem to work\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGithub#Test_Failures\n\n- http://logs.openstack.org/33327/1/check/gate-python-glanceclient-requirements/38 : SUCCESS in 5s\n- http://logs.openstack.org/33327/1/check/gate-python-glanceclient-pep8/814 : SUCCESS in 44s\n- http://docs-draft.openstack.org/33327/1/check/gate-python-glanceclient-docs/746/doc/build/html/ : SUCCESS in 51s\n- http://logs.openstack.org/33327/1/check/gate-python-glanceclient-python26/809 : SUCCESS in 1m 35s\n- http://logs.openstack.org/33327/1/check/gate-python-glanceclient-python27/807 : SUCCESS in 52s\n- http://logs.openstack.org/33327/1/check/gate-tempest-devstack-vm-full/23966 : FAILURE in 12m 12s\n- http://logs.openstack.org/33327/1/check/gate-tempest-devstack-vm-postgres-full/23672 : FAILURE in 10m 32s\n- http://logs.openstack.org/33327/1/check/gate-tempest-devstack-vm-quantum/31394 : FAILURE in 12m 12s\n- http://logs.openstack.org/33327/1/check/gate-grenade-devstack-vm/10905 : FAILURE in 11m 23s (non-voting)\n","accounts_in_message":[],"_revision_number":1},{"id":"f2630c49209a7a103290899ab9e246d908054666","author":{"_account_id":1726,"name":"Ghe Rivero","email":"ghe.rivero@gmail.com","username":"ghe.rivero"},"date":"2013-06-17 18:58:57.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"c4d68159c1408973f55ba0619f97886d20edc26b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-06-17 19:38:42.000000000","message":"Patch Set 2: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/33327/2/check/gate-python-glanceclient-requirements/39 : SUCCESS in 4s\n- http://logs.openstack.org/33327/2/check/gate-python-glanceclient-pep8/815 : SUCCESS in 43s\n- http://docs-draft.openstack.org/33327/2/check/gate-python-glanceclient-docs/747/doc/build/html/ : SUCCESS in 49s\n- http://logs.openstack.org/33327/2/check/gate-python-glanceclient-python26/810 : SUCCESS in 1m 12s\n- http://logs.openstack.org/33327/2/check/gate-python-glanceclient-python27/808 : SUCCESS in 52s\n- http://logs.openstack.org/33327/2/check/gate-tempest-devstack-vm-full/23970 : SUCCESS in 39m 34s\n- http://logs.openstack.org/33327/2/check/gate-tempest-devstack-vm-postgres-full/23676 : SUCCESS in 39m 10s\n- http://logs.openstack.org/33327/2/check/gate-tempest-devstack-vm-quantum/31398 : SUCCESS in 19m 18s\n- http://logs.openstack.org/33327/2/check/gate-grenade-devstack-vm/10908 : FAILURE in 33m 09s (non-voting)\n","accounts_in_message":[],"_revision_number":2},{"id":"9778933898dced74b0a2e72035eb0895284944ee","author":{"_account_id":1726,"name":"Ghe Rivero","email":"ghe.rivero@gmail.com","username":"ghe.rivero"},"date":"2013-06-18 14:56:04.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"a755724111a8b7588241e69d4790c19195028701","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-06-18 15:39:27.000000000","message":"Patch Set 3: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/33327/3/check/gate-python-glanceclient-requirements/42 : SUCCESS in 7s\n- http://logs.openstack.org/33327/3/check/gate-python-glanceclient-pep8/820 : SUCCESS in 49s\n- http://docs-draft.openstack.org/33327/3/check/gate-python-glanceclient-docs/752/doc/build/html/ : SUCCESS in 54s\n- http://logs.openstack.org/33327/3/check/gate-python-glanceclient-python26/815 : SUCCESS in 1m 17s\n- http://logs.openstack.org/33327/3/check/gate-python-glanceclient-python27/813 : SUCCESS in 56s\n- http://logs.openstack.org/33327/3/check/gate-tempest-devstack-vm-full/24206 : SUCCESS in 40m 05s\n- http://logs.openstack.org/33327/3/check/gate-tempest-devstack-vm-postgres-full/23912 : SUCCESS in 43m 15s\n- http://logs.openstack.org/33327/3/check/gate-tempest-devstack-vm-quantum/31657 : SUCCESS in 18m 46s\n- http://logs.openstack.org/33327/3/check/gate-grenade-devstack-vm/11105 : FAILURE in 18m 24s (non-voting)\n","accounts_in_message":[],"_revision_number":3},{"id":"f994098f8782811be08901c2cd1eb4b9b258d1e5","author":{"_account_id":1726,"name":"Ghe Rivero","email":"ghe.rivero@gmail.com","username":"ghe.rivero"},"date":"2013-06-24 05:50:37.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"4b13ced3e9abca12b50a8e264ae97f154e36ead5","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-06-24 06:31:01.000000000","message":"Patch Set 4: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/33327/4/check/gate-python-glanceclient-requirements/43 : SUCCESS in 4s\n- http://logs.openstack.org/33327/4/check/gate-python-glanceclient-pep8/836 : SUCCESS in 45s\n- http://docs-draft.openstack.org/33327/4/check/gate-python-glanceclient-docs/768/doc/build/html/ : SUCCESS in 1m 33s\n- http://logs.openstack.org/33327/4/check/gate-python-glanceclient-python26/831 : SUCCESS in 1m 15s\n- http://logs.openstack.org/33327/4/check/gate-python-glanceclient-python27/829 : SUCCESS in 1m 13s\n- http://logs.openstack.org/33327/4/check/gate-tempest-devstack-vm-full/25696 : SUCCESS in 39m 15s\n- http://logs.openstack.org/33327/4/check/gate-tempest-devstack-vm-postgres-full/25402 : SUCCESS in 40m 17s\n- http://logs.openstack.org/33327/4/check/gate-tempest-devstack-vm-quantum/33278 : SUCCESS in 16m 28s\n- http://logs.openstack.org/33327/4/check/gate-grenade-devstack-vm/12360 : FAILURE in 20m 11s (non-voting)\n","accounts_in_message":[],"_revision_number":4},{"id":"8424820f02354a3b4dc5fd04b6bfb587eed354d0","author":{"_account_id":1726,"name":"Ghe Rivero","email":"ghe.rivero@gmail.com","username":"ghe.rivero"},"date":"2013-06-25 07:35:16.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"3ae39c50ea24d5b41c6f54cbb4a1a6e45d1cccbb","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-06-25 08:24:24.000000000","message":"Patch Set 5: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/33327/5/check/gate-python-glanceclient-pep8/838 : SUCCESS in 48s\n- http://docs-draft.openstack.org/33327/5/check/gate-python-glanceclient-docs/770/doc/build/html/ : SUCCESS in 52s\n- http://logs.openstack.org/33327/5/check/gate-python-glanceclient-python26/833 : SUCCESS in 1m 15s\n- http://logs.openstack.org/33327/5/check/gate-python-glanceclient-python27/831 : SUCCESS in 54s\n- http://logs.openstack.org/33327/5/check/gate-tempest-devstack-vm-full/25977 : SUCCESS in 49m 03s\n- http://logs.openstack.org/33327/5/check/gate-tempest-devstack-vm-postgres-full/25683 : SUCCESS in 40m 20s\n- http://logs.openstack.org/33327/5/check/gate-tempest-devstack-vm-quantum/33597 : SUCCESS in 15m 51s\n- http://logs.openstack.org/33327/5/check/gate-grenade-devstack-vm/12612 : FAILURE in 22m 10s (non-voting)\n","accounts_in_message":[],"_revision_number":5},{"id":"244bd679403aa9c90076be48a78f42f5e7590b92","author":{"_account_id":1726,"name":"Ghe Rivero","email":"ghe.rivero@gmail.com","username":"ghe.rivero"},"date":"2013-07-01 09:11:03.000000000","message":"Uploaded patch set 6.","accounts_in_message":[],"_revision_number":6},{"id":"16c7b24dc31273fdfd5c324e2573cc1d98880e30","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-07-01 10:05:19.000000000","message":"Patch Set 6: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/33327/6/check/gate-python-glanceclient-pep8/850 : SUCCESS in 46s\n- http://docs-draft.openstack.org/33327/6/check/gate-python-glanceclient-docs/782/doc/build/html/ : SUCCESS in 56s\n- http://logs.openstack.org/33327/6/check/gate-python-glanceclient-python26/845 : SUCCESS in 1m 48s\n- http://logs.openstack.org/33327/6/check/gate-python-glanceclient-python27/843 : SUCCESS in 58s\n- http://logs.openstack.org/33327/6/check/gate-tempest-devstack-vm-full/27472 : SUCCESS in 44m 04s\n- http://logs.openstack.org/33327/6/check/gate-tempest-devstack-vm-postgres-full/27178 : SUCCESS in 54m 09s\n- http://logs.openstack.org/33327/6/check/gate-tempest-devstack-vm-quantum/35272 : SUCCESS in 20m 09s\n- http://logs.openstack.org/33327/6/check/gate-grenade-devstack-vm/13924 : FAILURE in 19m 54s (non-voting)\n","accounts_in_message":[],"_revision_number":6},{"id":"8b704c5f51b7dbdf1bce5dace4f7fb8074172b83","author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"date":"2013-07-08 15:34:17.000000000","message":"Patch Set 6: (1 inline comment)\n\n","accounts_in_message":[],"_revision_number":6},{"id":"286554ed96700b8580063ae9c329d61d65296be4","author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"date":"2013-07-08 15:51:32.000000000","message":"Patch Set 6: (15 inline comments)\n\nHey,\n\nsome comments in-line!\n\nThere\u0027s also another thing I don\u0027t like and I\u0027d love to get your thoughts about it.\n\nThis patch registers config parameters when the modules are imported. IMHO, this behavior is 1. a bit rude 2. Conflict prone. In order to avoid that, would it make sense make the app call a register_configs function?\n\nAlso, I think those config parameters should be registered in a glance(client) group instead of using DEFAULT.\n\nThoughts?\n\nOne more thing, this patch is pointing to an OUTDATED dependency. \n\nThanks for the patch!","accounts_in_message":[],"_revision_number":6},{"id":"e344f1b58421b0decd525192876b4cd308b44235","author":{"_account_id":1726,"name":"Ghe Rivero","email":"ghe.rivero@gmail.com","username":"ghe.rivero"},"date":"2013-07-09 22:10:50.000000000","message":"Patch Set 6: (16 inline comments)\n\n","accounts_in_message":[],"_revision_number":6},{"id":"6de1718aa84dd282659177f65f2f048474cce251","author":{"_account_id":1726,"name":"Ghe Rivero","email":"ghe.rivero@gmail.com","username":"ghe.rivero"},"date":"2013-07-10 07:54:39.000000000","message":"Uploaded patch set 7.","accounts_in_message":[],"_revision_number":7},{"id":"f2a1cbd73f2dae48e8d346d72519a3a8843e27ea","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-07-10 08:38:49.000000000","message":"Patch Set 7: Doesn\u0027t seem to work\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGithub#Test_Failures\n\n- http://logs.openstack.org/33327/7/check/gate-python-glanceclient-pep8/875 : SUCCESS in 54s\n- http://docs-draft.openstack.org/33327/7/check/gate-python-glanceclient-docs/807/doc/build/html/ : SUCCESS in 1m 00s\n- http://logs.openstack.org/33327/7/check/gate-python-glanceclient-python26/870 : SUCCESS in 1m 37s\n- http://logs.openstack.org/33327/7/check/gate-python-glanceclient-python27/868 : SUCCESS in 1m 01s\n- http://logs.openstack.org/33327/7/check/gate-tempest-devstack-vm-full/30217 : SUCCESS in 42m 46s\n- http://logs.openstack.org/33327/7/check/gate-tempest-devstack-vm-postgres-full/29921 : SUCCESS in 44m 02s\n- http://logs.openstack.org/33327/7/check/gate-tempest-devstack-vm-neutron/1421 : FAILURE in 18m 14s\n- http://logs.openstack.org/33327/7/check/gate-grenade-devstack-vm/16376 : FAILURE in 24m 24s (non-voting)\n","accounts_in_message":[],"_revision_number":7},{"id":"017c2c7fd9e3d50ca6e6bc9de8e45b6772fff29e","author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"date":"2013-07-10 10:54:42.000000000","message":"Patch Set 7:\n\nrecheck no bug","accounts_in_message":[],"_revision_number":7},{"id":"f84646fbce422d17bda1f765e063ac774a812911","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-07-10 11:50:03.000000000","message":"Patch Set 7: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/33327/7/check/gate-python-glanceclient-pep8/877 : SUCCESS in 51s\n- http://docs-draft.openstack.org/33327/7/check/gate-python-glanceclient-docs/809/doc/build/html/ : SUCCESS in 58s\n- http://logs.openstack.org/33327/7/check/gate-python-glanceclient-python26/872 : SUCCESS in 1m 37s\n- http://logs.openstack.org/33327/7/check/gate-python-glanceclient-python27/870 : SUCCESS in 59s\n- http://logs.openstack.org/33327/7/check/gate-tempest-devstack-vm-full/30276 : SUCCESS in 42m 10s\n- http://logs.openstack.org/33327/7/check/gate-tempest-devstack-vm-postgres-full/29980 : SUCCESS in 54m 46s\n- http://logs.openstack.org/33327/7/check/gate-tempest-devstack-vm-neutron/1487 : SUCCESS in 17m 19s\n- http://logs.openstack.org/33327/7/check/gate-grenade-devstack-vm/16429 : FAILURE in 26m 04s (non-voting)\n","accounts_in_message":[],"_revision_number":7},{"id":"9fab717ee71ba86dba7e5b5aeb29b60d55ffab10","author":{"_account_id":4463,"name":"iccha-sethi","email":"iccha.sethi@rackspace.com","username":"iccha-sethi"},"date":"2013-07-16 18:50:51.000000000","message":"Patch Set 7: (2 inline comments)\n\n","accounts_in_message":[],"_revision_number":7},{"id":"c42540c4181178d8405307b50f4651e98b61b230","author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"date":"2013-07-16 19:46:28.000000000","message":"Patch Set 7:\n\n@Iccha,\nhttps://wiki.openstack.org/wiki/LegalIssuesFAQ#Copyright_Headers","accounts_in_message":[],"_revision_number":7},{"id":"dfbd3571c54795570c7276aa937bd81fba17ceb2","author":{"_account_id":1726,"name":"Ghe Rivero","email":"ghe.rivero@gmail.com","username":"ghe.rivero"},"date":"2013-07-17 06:54:14.000000000","message":"Patch Set 7: (1 inline comment)\n\n","accounts_in_message":[],"_revision_number":7},{"id":"f280dc1f22401508e57f796a60b615faefb90778","author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"date":"2013-07-19 09:08:44.000000000","message":"Patch Set 7: I would prefer that you didn\u0027t merge this\n\n(4 inline comments)\n\nHey,\n\nI added some other comments. \n\nThanks for working on this!","accounts_in_message":[],"_revision_number":7},{"id":"11d136784288c2086725b3e506d73015f484ce7f","author":{"_account_id":1726,"name":"Ghe Rivero","email":"ghe.rivero@gmail.com","username":"ghe.rivero"},"date":"2013-07-19 09:37:28.000000000","message":"Patch Set 7: (4 inline comments)\n\n","accounts_in_message":[],"_revision_number":7},{"id":"ae91d60d29ffe2cdb9c1d6651d05fd01fb777e2e","author":{"_account_id":1726,"name":"Ghe Rivero","email":"ghe.rivero@gmail.com","username":"ghe.rivero"},"date":"2013-07-19 09:40:28.000000000","message":"Uploaded patch set 8.","accounts_in_message":[],"_revision_number":8},{"id":"fad529f3072c8919ddce4f5deea41e277d638021","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-07-19 10:37:07.000000000","message":"Patch Set 8: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/33327/8/check/gate-python-glanceclient-pep8/922 : SUCCESS in 1m 43s\n- http://docs-draft.openstack.org/33327/8/check/gate-python-glanceclient-docs/854/doc/build/html/ : SUCCESS in 2m 13s\n- http://logs.openstack.org/33327/8/check/gate-python-glanceclient-python26/917 : SUCCESS in 2m 08s\n- http://logs.openstack.org/33327/8/check/gate-python-glanceclient-python27/915 : SUCCESS in 1m 52s\n- http://logs.openstack.org/33327/8/check/gate-tempest-devstack-vm-full/33799 : SUCCESS in 56m 31s\n- http://logs.openstack.org/33327/8/check/gate-tempest-devstack-vm-cells-full/1490 : FAILURE in 14m 36s (non-voting)\n- http://logs.openstack.org/33327/8/check/gate-tempest-devstack-vm-testr-full/343 : SUCCESS in 28m 53s (non-voting)\n- http://logs.openstack.org/33327/8/check/gate-tempest-devstack-vm-postgres-full/33489 : SUCCESS in 47m 32s\n- http://logs.openstack.org/33327/8/check/gate-tempest-devstack-vm-neutron/5554 : SUCCESS in 21m 35s (non-voting)\n- http://logs.openstack.org/33327/8/check/gate-grenade-devstack-vm/19533 : SUCCESS in 20m 57s\n","accounts_in_message":[],"_revision_number":8},{"id":"7251e28aeb600c2501dd23341bfa1443b9478e3d","author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"date":"2013-07-25 15:12:56.000000000","message":"Patch Set 8: (1 inline comment)\n\nLGTM!\n\nJust one tiny comment and this can land!","accounts_in_message":[],"_revision_number":8},{"id":"7b1cf58716ee643dae3ae6e5d208b663fa9df909","author":{"_account_id":1726,"name":"Ghe Rivero","email":"ghe.rivero@gmail.com","username":"ghe.rivero"},"date":"2013-07-26 07:39:49.000000000","message":"Patch Set 8: (1 inline comment)\n\n","accounts_in_message":[],"_revision_number":8},{"id":"f3d57a59740c61102ae8278b2aa31799627ea306","author":{"_account_id":1726,"name":"Ghe Rivero","email":"ghe.rivero@gmail.com","username":"ghe.rivero"},"date":"2013-07-26 10:29:18.000000000","message":"Uploaded patch set 9.","accounts_in_message":[],"_revision_number":9},{"id":"341f7d195b33d39d9fd6c9aa4d772f53764afd7f","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-07-26 11:17:35.000000000","message":"Patch Set 9: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/27/33327/9/check/gate-python-glanceclient-pep8/935 : SUCCESS in 1m 00s\n- http://docs-draft.openstack.org/27/33327/9/check/gate-python-glanceclient-docs/867/doc/build/html/ : SUCCESS in 1m 08s\n- http://logs.openstack.org/27/33327/9/check/gate-python-glanceclient-python26/930 : SUCCESS in 1m 35s\n- http://logs.openstack.org/27/33327/9/check/gate-python-glanceclient-python27/928 : SUCCESS in 1m 05s\n- http://logs.openstack.org/27/33327/9/check/gate-tempest-devstack-vm-full/35860 : SUCCESS in 47m 34s\n- http://logs.openstack.org/27/33327/9/check/gate-tempest-devstack-vm-cells-full/3127 : FAILURE in 15m 18s (non-voting)\n- http://logs.openstack.org/27/33327/9/check/gate-tempest-devstack-vm-testr-full/1953 : FAILURE in 28m 30s (non-voting)\n- http://logs.openstack.org/27/33327/9/check/gate-tempest-devstack-vm-postgres-full/35547 : SUCCESS in 48m 13s\n- http://logs.openstack.org/27/33327/9/check/gate-tempest-devstack-vm-neutron/7881 : FAILURE in 19m 28s (non-voting)\n- http://logs.openstack.org/27/33327/9/check/gate-grenade-devstack-vm/21421 : SUCCESS in 27m 12s\n","accounts_in_message":[],"_revision_number":9},{"id":"922599b3715dcf9b9d54f84b27b72671dbaf3959","author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"date":"2013-07-26 13:02:49.000000000","message":"Patch Set 9: Looks good to me (core reviewer)\n\nI think this is good to land!\n\nThanks and many more thanks to you, Ghe.","accounts_in_message":[],"_revision_number":9},{"id":"145a6dcf1a5ebb50840f9f73ac27901574f3efd6","author":{"_account_id":5347,"name":"Eddie Sheffield","email":"eddie.sheffield@rackspace.com","username":"eddie-sheffield"},"date":"2013-07-26 20:06:13.000000000","message":"Patch Set 9: I would prefer that you didn\u0027t merge this\n\n(2 inline comments)\n\nOverall I really like this direction. However I have a couple of concerns with the Glance V2 implementation. There are some fundamental differences compared to V1 and this service layer may need to do a bit more work in a couple of areas to present a common facade over both V1 and V2.\n\nOnes I notice offhand:\n- The service will need to make two calls to the client on behalf of the caller to handle a create with image data to simulate the V1 functionality.\n- V2 does not recognize purge_props so if purge_props is true it will need to fetch the existing image and create a PATCH request that explicity deletes or updates properties to achieve the same thing as the old purge_props.\n- It may be desirable to expose an upload function which would map to the V1 update and the V2 upload functions.","accounts_in_message":[],"_revision_number":9},{"id":"1fdc6c2ab8f7ff5780058fec2bd078b7f8b4c742","author":{"_account_id":1726,"name":"Ghe Rivero","email":"ghe.rivero@gmail.com","username":"ghe.rivero"},"date":"2013-07-29 10:12:35.000000000","message":"Patch Set 9: (2 inline comments)\n\nThanks for pointing this out. v2 support is still on progress (is not even complete on glanceclient but on the way).\n\nWill prepare an extra patch for the update and create method, and think about how to deal with the update/upload differences in v1/v2.","accounts_in_message":[],"_revision_number":9},{"id":"f40829c8ee5ac3e2f86e060db9124047b106db85","author":{"_account_id":7701,"name":"Amala Basha","email":"amala.alungal@RACKSPACE.COM","username":"amalabasha"},"date":"2013-07-29 10:44:38.000000000","message":"Patch Set 9: (1 inline comment)\n\nCheck inline","accounts_in_message":[],"_revision_number":9},{"id":"c4fbcdf14b3509a2122d13b68091008a334d6c59","author":{"_account_id":1726,"name":"Ghe Rivero","email":"ghe.rivero@gmail.com","username":"ghe.rivero"},"date":"2013-07-30 12:10:56.000000000","message":"Uploaded patch set 10.","accounts_in_message":[],"_revision_number":10},{"id":"65523084714e127d0fdab5e3c4e91339ee29f681","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-07-30 13:06:51.000000000","message":"Patch Set 10: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/27/33327/10/check/gate-python-glanceclient-pep8/948 : SUCCESS in 54s\n- http://docs-draft.openstack.org/27/33327/10/check/gate-python-glanceclient-docs/880/doc/build/html/ : SUCCESS in 56s\n- http://logs.openstack.org/27/33327/10/check/gate-python-glanceclient-python26/943 : SUCCESS in 1m 29s\n- http://logs.openstack.org/27/33327/10/check/gate-python-glanceclient-python27/941 : SUCCESS in 1m 04s\n- http://logs.openstack.org/27/33327/10/check/gate-tempest-devstack-vm-full/37334 : SUCCESS in 54m 45s\n- http://logs.openstack.org/27/33327/10/check/gate-tempest-devstack-vm-cells-full/4012 : FAILURE in 32m 57s (non-voting)\n- http://logs.openstack.org/27/33327/10/check/gate-tempest-devstack-vm-testr-full/2829 : FAILURE in 27m 28s (non-voting)\n- http://logs.openstack.org/27/33327/10/check/gate-tempest-devstack-vm-postgres-full/37010 : SUCCESS in 55m 45s\n- http://logs.openstack.org/27/33327/10/check/gate-tempest-devstack-vm-neutron/9438 : FAILURE in 16m 01s (non-voting)\n- http://logs.openstack.org/27/33327/10/check/gate-grenade-devstack-vm/22708 : SUCCESS in 26m 36s\n","accounts_in_message":[],"_revision_number":10},{"id":"8e64e833693b305adcefecae9dab6b70e7f3dc49","author":{"_account_id":1726,"name":"Ghe Rivero","email":"ghe.rivero@gmail.com","username":"ghe.rivero"},"date":"2013-07-30 13:11:47.000000000","message":"Patch Set 10: (1 inline comment)\n\nextra print.","accounts_in_message":[],"_revision_number":10},{"id":"b65ae40fc3235bb27056778467c5b13cd433fa04","author":{"_account_id":1726,"name":"Ghe Rivero","email":"ghe.rivero@gmail.com","username":"ghe.rivero"},"date":"2013-07-30 16:21:40.000000000","message":"Uploaded patch set 11.","accounts_in_message":[],"_revision_number":11},{"id":"cd7224da547e02a6ede75f13d0da07fbdc217060","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-07-30 17:14:47.000000000","message":"Patch Set 11: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/27/33327/11/check/gate-python-glanceclient-pep8/949 : SUCCESS in 53s\n- http://docs-draft.openstack.org/27/33327/11/check/gate-python-glanceclient-docs/881/doc/build/html/ : SUCCESS in 56s\n- http://logs.openstack.org/27/33327/11/check/gate-python-glanceclient-python26/944 : SUCCESS in 1m 29s\n- http://logs.openstack.org/27/33327/11/check/gate-python-glanceclient-python27/942 : SUCCESS in 1m 00s\n- http://logs.openstack.org/27/33327/11/check/gate-tempest-devstack-vm-full/37398 : SUCCESS in 46m 02s\n- http://logs.openstack.org/27/33327/11/check/gate-tempest-devstack-vm-cells-full/4064 : FAILURE in 25m 29s (non-voting)\n- http://logs.openstack.org/27/33327/11/check/gate-tempest-devstack-vm-testr-full/2880 : FAILURE in 27m 17s (non-voting)\n- http://logs.openstack.org/27/33327/11/check/gate-tempest-devstack-vm-postgres-full/37074 : SUCCESS in 52m 02s\n- http://logs.openstack.org/27/33327/11/check/gate-tempest-devstack-vm-neutron/9510 : FAILURE in 18m 52s (non-voting)\n- http://logs.openstack.org/27/33327/11/check/gate-grenade-devstack-vm/22769 : SUCCESS in 21m 46s\n","accounts_in_message":[],"_revision_number":11},{"id":"49aaa7c624c31733e10fce347bffb2d20bf9fd77","author":{"_account_id":1726,"name":"Ghe Rivero","email":"ghe.rivero@gmail.com","username":"ghe.rivero"},"date":"2013-08-01 10:21:15.000000000","message":"Uploaded patch set 12.","accounts_in_message":[],"_revision_number":12},{"id":"41d2d748d28f964dfa6764f3d6933b6241e6948a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-08-01 11:19:04.000000000","message":"Patch Set 12: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/27/33327/12/check/gate-python-glanceclient-pep8/c5b8d0a : SUCCESS in 48s\n- http://docs-draft.openstack.org/27/33327/12/check/gate-python-glanceclient-docs/a5b385a/doc/build/html/ : SUCCESS in 1m 32s\n- http://logs.openstack.org/27/33327/12/check/gate-python-glanceclient-python26/d02a941 : SUCCESS in 1m 45s\n- http://logs.openstack.org/27/33327/12/check/gate-python-glanceclient-python27/b346fd1 : SUCCESS in 56s\n- http://logs.openstack.org/27/33327/12/check/gate-tempest-devstack-vm-full/66ce7a7 : SUCCESS in 48m 53s\n- http://logs.openstack.org/27/33327/12/check/gate-tempest-devstack-vm-cells-full/edf2237 : FAILURE in 26m 28s (non-voting)\n- http://logs.openstack.org/27/33327/12/check/gate-tempest-devstack-vm-testr-full/2b59215 : SUCCESS in 28m 04s (non-voting)\n- http://logs.openstack.org/27/33327/12/check/gate-tempest-devstack-vm-postgres-full/0e28b41 : SUCCESS in 57m 44s\n- http://logs.openstack.org/27/33327/12/check/gate-tempest-devstack-vm-neutron/745d435 : FAILURE in 8m 41s (non-voting)\n- http://logs.openstack.org/27/33327/12/check/gate-grenade-devstack-vm/1be644e : SUCCESS in 24m 18s\n","accounts_in_message":[],"_revision_number":12},{"id":"ae9cad8f9746d7474a8368cbe5bc3b1b28a50842","author":{"_account_id":1726,"name":"Ghe Rivero","email":"ghe.rivero@gmail.com","username":"ghe.rivero"},"date":"2013-08-06 11:00:32.000000000","message":"Uploaded patch set 13.","accounts_in_message":[],"_revision_number":13},{"id":"68dfd1b1ae2abc473b4e9e357dc68babbe2a07e9","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-08-06 11:56:13.000000000","message":"Patch Set 13: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/27/33327/13/check/gate-python-glanceclient-pep8/8af0931 : SUCCESS in 48s\n- http://docs-draft.openstack.org/27/33327/13/check/gate-python-glanceclient-docs/9548c08/doc/build/html/ : SUCCESS in 52s\n- http://logs.openstack.org/27/33327/13/check/gate-python-glanceclient-python26/32f80d3 : SUCCESS in 1m 58s\n- http://logs.openstack.org/27/33327/13/check/gate-python-glanceclient-python27/3f0ed7e : SUCCESS in 58s\n- http://logs.openstack.org/27/33327/13/check/gate-tempest-devstack-vm-full/eb0f995 : SUCCESS in 43m 20s\n- http://logs.openstack.org/27/33327/13/check/gate-tempest-devstack-vm-cells-full/26bbff6 : FAILURE in 12m 07s (non-voting)\n- http://logs.openstack.org/27/33327/13/check/gate-tempest-devstack-vm-testr-full/aacb249 : FAILURE in 25m 40s (non-voting)\n- http://logs.openstack.org/27/33327/13/check/gate-tempest-devstack-vm-postgres-full/9b27958 : SUCCESS in 55m 36s\n- http://logs.openstack.org/27/33327/13/check/gate-tempest-devstack-vm-neutron/4aa8903 : SUCCESS in 22m 01s\n- http://logs.openstack.org/27/33327/13/check/gate-grenade-devstack-vm/e97510b : SUCCESS in 22m 16s\n","accounts_in_message":[],"_revision_number":13},{"id":"6954448bde742213fca9d0141dc0325c76ccf881","author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"date":"2013-08-08 12:45:21.000000000","message":"Patch Set 13: Looks good to me (core reviewer)\n\nIt looks good to me! I think we should let this patch land and implement missing features in separate patches.","accounts_in_message":[],"_revision_number":13},{"id":"109d174855bf2c11460b6e68451ce11ad73a9c3d","author":{"_account_id":5347,"name":"Eddie Sheffield","email":"eddie.sheffield@rackspace.com","username":"eddie-sheffield"},"date":"2013-08-08 14:19:11.000000000","message":"Patch Set 13: Looks good to me, but someone else must approve\n\nAs Flavio says, we\u0027ll fill in the remaining holes with separate patches. I think that\u0027s a good plan.","accounts_in_message":[],"_revision_number":13},{"id":"5d09e47d1c0c50a5f6b6f75b12abdf6714842cf9","author":{"_account_id":616,"name":"Mark Washenberger","email":"mark.washenberger@markwash.net","username":"markwash"},"date":"2013-08-08 19:59:24.000000000","message":"Patch Set 13: I would prefer that you didn\u0027t merge this\n\nAt the end of the day, I don\u0027t think glanceclient should be supporting this old interface from nova. It just doesn\u0027t really seem to be the right way to conceptualize a remote image service, and it tries to lump v2 and v1 together behind the same interface by default, which seems strange to me. \n\nSo I\u0027m in the camp that to share this code, we probably should put it in oslo.\n\nI apologize for the lateness of my review.","accounts_in_message":[],"_revision_number":13},{"id":"2184a96c4161ebff42417971338fe4e12eb30f6e","author":{"_account_id":616,"name":"Mark Washenberger","email":"mark.washenberger@markwash.net","username":"markwash"},"date":"2013-08-08 22:50:02.000000000","message":"Patch Set 13:\n\nAfter the glance-meeting today, I want to ask the ironic folks, what about this particular image service abstraction is better for them than using the client libraries glanceclient has right now?\n\nGoing through this review, it seems like an image service provides access to list, get, update, delete, download, and upload an image--these are all things that ironic could do directly using existing code in glanceclient. Is there any reason for ironic not to just use the existing code in glanceclient directly?","accounts_in_message":[],"_revision_number":13},{"id":"9cd185374fb701cb77f85fbb4f5d5f3c189738bf","author":{"_account_id":6493,"name":"John Bresnahan","email":"john@bresnahan.me","username":"jbresnah"},"date":"2013-08-08 23:35:45.000000000","message":"Patch Set 13: Do not merge\n\nPlease do not take the -2 too harshly.  I am willing to change my mind but I would really like these points addressed before this is merged.\n\nAs far as I understand it, the ImageService abstraction in Nova provided two things:\n\n1) An driver interface.  The same interface can be used to speak to S3 and possibly others.\n\n2) An alternative interface to the one provided by python-glanceclient.\n\n#1 clearly does not apply to the glance client.  It would not make a lot of sense to have the a glance client speak to S3.  That would be a broken abstraction.  Further, it would not make sense to have the interface to a storage system abstraction live inside of one of the implementation.  I could be wrong, but this patch appears to do this.  The question is, if this were moved here, what interface would the S3 driver implement?  It looks to me like it would inherit from glanceclient.common.service.ImageService, which seems broken.\n\nWRT #2 I have the same concerns as markwash.  Why not use  the API already offered by python-glanceclient?  There very well could be a good reason for this but I would like to frame the discussion more in those terms (ie: what is the current API missing), and less in the terms of \u0027nova and cinder repeat themselves\u0027.\n\nA final point is that the code added here is not in sync with the current nova code base.","accounts_in_message":[],"_revision_number":13},{"id":"16eaf635b508d8cec8f17658e735dacdd0baed05","author":{"_account_id":1726,"name":"Ghe Rivero","email":"ghe.rivero@gmail.com","username":"ghe.rivero"},"date":"2013-08-09 09:56:49.000000000","message":"Patch Set 13:\n\nAs I  understand it, there are some cases when is neccessary a wrapper like this:\n- glanceclient api v1 and v2 are different, and even how to use them differ. From an program point of view (nova, ironic..,) this can be an issue, and means they will have to duplicate the code. What is now in nova is even worse, because the mix v1 and v2 calls depending on what is needed. Having a wrapper on top of it, can facilitate a migration or version selection without having to care about it on the programs that use it. \n- This wrapper right now, covers the minimum basic image manipulation (crud) and that\u0027s just what is needed by cinder, ironic and nova programs, and only some corner cases are missing (like tags manipulation), but can be added after that.\n- If at some time, others storage services are added (like S3), creating a similar wrapper for those is feasible, and easy to integrate on programs.\n\nWhat this wrapper also add to the basic glanceclient is:\n- api calls can be retried a configured number of times\n- ensure that image service endpoint are correct, some params are properly json encoded/decoded, do some filters \n- On the roadmap: get that endpoint from keystone services endpoints\n\nOther issues:\n- These service is out of sync with the one in nova because, as said earlier, nova have a mix of v1 and v2 calls, and when porting it, this was replaced by differentiating both apis.\n- get_api_servers is a remain of the nova version, but I also agree that could be removed. HA should be done outside glance.\n\nThanks all for the feedback.","accounts_in_message":[],"_revision_number":13},{"id":"97be6d54007976f9de63d52e8ef3a966dfb50f8f","author":{"_account_id":616,"name":"Mark Washenberger","email":"mark.washenberger@markwash.net","username":"markwash"},"date":"2013-08-09 16:13:29.000000000","message":"Patch Set 13:\n\nGhe,\n\nCan Ironic just use v2? I don\u0027t know why it would need to use v1, but if there\u0027s a missing feature I\u0027d prefer to fix it in the v2 client rather than make a generic adapter that works with both v1 and v2. To me, v1 and v2 are different creatures and I don\u0027t see a reason for a new project to try to abstract out the similarities.\n\nThanks","accounts_in_message":[],"_revision_number":13},{"id":"c537d9b0d66655b7d3452a97d2d124882957b7aa","author":{"_account_id":6493,"name":"John Bresnahan","email":"john@bresnahan.me","username":"jbresnah"},"date":"2013-08-09 16:38:51.000000000","message":"Patch Set 13:\n\nGhe,\n\nThanks for the well thought out feedback!  It sounds like you have a set of feature request for glanceclient.\n\n1) a single interface for both v1 and v2\n2) a configurable number of retries\n3) better parameter checking\n\nThose seem like reasonable things (noting that Mark has a reasonable problem with #1).  However, this patch seems to be doing more than that.\n\nI don\u0027t think it would ever be appropriate to have an S3 (or any other non-glance protocol) client implementation inside of Glance client, thus I am not sure what the point of glanceclient.common.service.ImageService is.  From what it does in nova I have to assume its purpose is to provide an interface behind which you can implement many protocols.  As I mentioned that does not make sense in Glance client.\n\nAlso the part of nova which I was concerned with being in sync come from this patch: https://review.openstack.org/#/c/37817/","accounts_in_message":[],"_revision_number":13},{"id":"3ba9e3708b573cc65b7f6594f4e9edc0b566039a","author":{"_account_id":9,"name":"LaunchpadSync","username":"launchpadsync"},"date":"2013-08-17 06:03:06.000000000","message":"Patch Set 13: Abandoned\n\ncode review expired after 1 week of no activity after a negative review, it can be restored using the `Restore Change` button under the Patch Set on the web interface","accounts_in_message":[],"_revision_number":13},{"id":"2b5f847d0df96af455900061dbf389b108735afb","author":{"_account_id":9,"name":"LaunchpadSync","username":"launchpadsync"},"date":"2013-08-17 06:03:06.000000000","message":"Patch Set 13:\n\ncode review expired after 1 week of no activity after a negative review, it can be restored using the `Restore Change` button under the Patch Set on the web interface","accounts_in_message":[],"_revision_number":13}],"current_revision_number":13,"current_revision":"65490f15cb2923aaf021d26c0f9e2c8115dceb0c","revisions":{"4b073d9575109f10b07b44a04d7fede7cbe9cd85":{"kind":"REWORK","_number":1,"created":"2013-06-17 18:35:46.000000000","uploader":{"_account_id":1726,"name":"Ghe Rivero","email":"ghe.rivero@gmail.com","username":"ghe.rivero"},"ref":"refs/changes/27/33327/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/27/33327/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/27/33327/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/27/33327/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/27/33327/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/27/33327/1"}}},"commit":{"parents":[{"commit":"a7bc8fe9f6860e8573f02482372cabbae993e492","subject":"Merge \"python3: Introduce py33 to tox.ini\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/a7bc8fe9f6860e8573f02482372cabbae993e492"}]}],"author":{"name":"Ghe Rivero","email":"ghe@debian.org","date":"2013-06-17 08:31:28.000000000","tz":120},"committer":{"name":"Ghe Rivero","email":"ghe@debian.org","date":"2013-06-17 18:34:35.000000000","tz":120},"subject":"Move glance image service client from nova and cinder into python-glanceclient.","message":"Move glance image service client from nova and cinder into python-glanceclient.\n\nThis is now present in nova and cinder, and it will be also needed in ironic,\nso moving it into a common location.\n\nMost of the code was present on nova.image.glance and cincer.image.glance.\n\nglanceclient/exc.py \u003d\u003e nova.exception \u003c\u003d\u003e cinder.exception\n GlanceBaseException\n GlanceConnectionFailed\n ImageNotFound\n ImageNotAuthorized\n Invalid\n\nAdded new modules from openstack-common:\n jsonutils\n fixture\n context\n\nChange-Id: Ibb2c44df99ae5746e32695e69078737cc6b5aeeb\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/4b073d9575109f10b07b44a04d7fede7cbe9cd85"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/4b073d9575109f10b07b44a04d7fede7cbe9cd85"}]},"branch":"refs/heads/master"},"b3c6192e33c1614347f6b471974e33bb30a8681e":{"kind":"REWORK","_number":2,"created":"2013-06-17 18:58:57.000000000","uploader":{"_account_id":1726,"name":"Ghe Rivero","email":"ghe.rivero@gmail.com","username":"ghe.rivero"},"ref":"refs/changes/27/33327/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/27/33327/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/27/33327/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/27/33327/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/27/33327/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/27/33327/2"}}},"commit":{"parents":[{"commit":"a7bc8fe9f6860e8573f02482372cabbae993e492","subject":"Merge \"python3: Introduce py33 to tox.ini\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/a7bc8fe9f6860e8573f02482372cabbae993e492"}]}],"author":{"name":"Ghe Rivero","email":"ghe@debian.org","date":"2013-06-17 08:31:28.000000000","tz":120},"committer":{"name":"Ghe Rivero","email":"ghe@debian.org","date":"2013-06-17 18:57:51.000000000","tz":120},"subject":"Move glance image service client from nova and cinder into python-glanceclient.","message":"Move glance image service client from nova and cinder into python-glanceclient.\n\nThis is now present in nova and cinder, and it will be also needed in ironic,\nso moving it into a common location.\n\nMost of the code was present on nova.image.glance and cincer.image.glance.\n\nglanceclient/exc.py \u003d\u003e nova.exception \u003c\u003d\u003e cinder.exception\n GlanceBaseException\n GlanceConnectionFailed\n ImageNotFound\n ImageNotAuthorized\n Invalid\n\nAdded new modules from openstack-common:\n jsonutils\n fixture\n context\n\nChange-Id: Ibb2c44df99ae5746e32695e69078737cc6b5aeeb\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/b3c6192e33c1614347f6b471974e33bb30a8681e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/b3c6192e33c1614347f6b471974e33bb30a8681e"}]},"branch":"refs/heads/master"},"b95de67092a79479127ae240b923a355e2949cf0":{"kind":"REWORK","_number":3,"created":"2013-06-18 14:56:04.000000000","uploader":{"_account_id":1726,"name":"Ghe Rivero","email":"ghe.rivero@gmail.com","username":"ghe.rivero"},"ref":"refs/changes/27/33327/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/27/33327/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/27/33327/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/27/33327/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/27/33327/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/27/33327/3"}}},"commit":{"parents":[{"commit":"a7bc8fe9f6860e8573f02482372cabbae993e492","subject":"Merge \"python3: Introduce py33 to tox.ini\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/a7bc8fe9f6860e8573f02482372cabbae993e492"}]}],"author":{"name":"Ghe Rivero","email":"ghe@debian.org","date":"2013-06-17 08:31:28.000000000","tz":120},"committer":{"name":"Ghe Rivero","email":"ghe@debian.org","date":"2013-06-18 14:55:02.000000000","tz":120},"subject":"Move glance image service client from nova and cinder into python-glanceclient.","message":"Move glance image service client from nova and cinder into python-glanceclient.\n\nThis is now present in nova and cinder, and it will be also needed in ironic,\nso moving it into a common location.\n\nMost of the code was present on nova.image.glance and cincer.image.glance.\n\nglanceclient/exc.py \u003d\u003e nova.exception \u003c\u003d\u003e cinder.exception\n GlanceBaseException\n GlanceConnectionFailed\n ImageNotFound\n ImageNotAuthorized\n Invalid\n\nAdded new modules from openstack-common:\n jsonutils\n fixture\n context\n\nChange-Id: Ibb2c44df99ae5746e32695e69078737cc6b5aeeb\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/b95de67092a79479127ae240b923a355e2949cf0"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/b95de67092a79479127ae240b923a355e2949cf0"}]},"branch":"refs/heads/master"},"aa9550687b47e008f869aaaef2b18582f769efe1":{"kind":"REWORK","_number":4,"created":"2013-06-24 05:50:37.000000000","uploader":{"_account_id":1726,"name":"Ghe Rivero","email":"ghe.rivero@gmail.com","username":"ghe.rivero"},"ref":"refs/changes/27/33327/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/27/33327/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/27/33327/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/27/33327/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/27/33327/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/27/33327/4"}}},"commit":{"parents":[{"commit":"d8a537c7fe9b1e455831d05d9ba0ab67e03fb3a5","subject":"Removes extra slash on endpoints without a path","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/d8a537c7fe9b1e455831d05d9ba0ab67e03fb3a5"}]}],"author":{"name":"Ghe Rivero","email":"ghe@debian.org","date":"2013-06-17 08:31:28.000000000","tz":120},"committer":{"name":"Ghe Rivero","email":"ghe@debian.org","date":"2013-06-24 05:49:23.000000000","tz":120},"subject":"Move glance image service client from nova and cinder into python-glanceclient.","message":"Move glance image service client from nova and cinder into python-glanceclient.\n\nThis is now present in nova and cinder, and it will be also needed in ironic,\nso moving it into a common location.\n\nMost of the code was present on nova.image.glance and cincer.image.glance.\n\nglanceclient/exc.py \u003d\u003e nova.exception \u003c\u003d\u003e cinder.exception\n GlanceBaseException\n GlanceConnectionFailed\n ImageNotFound\n ImageNotAuthorized\n Invalid\n\nAdded new modules from openstack-common:\n jsonutils\n fixture\n context\n\nChange-Id: Ibb2c44df99ae5746e32695e69078737cc6b5aeeb\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/aa9550687b47e008f869aaaef2b18582f769efe1"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/aa9550687b47e008f869aaaef2b18582f769efe1"}]},"branch":"refs/heads/master"},"236d034a539648abbf940de06377d1b55d2741f6":{"kind":"REWORK","_number":5,"created":"2013-06-25 07:35:16.000000000","uploader":{"_account_id":1726,"name":"Ghe Rivero","email":"ghe.rivero@gmail.com","username":"ghe.rivero"},"ref":"refs/changes/27/33327/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/27/33327/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/27/33327/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/27/33327/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/27/33327/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/27/33327/5"}}},"commit":{"parents":[{"commit":"fdd2aace6e4bc27aab24dcdeb36d271a054d5780","subject":"Sync of new oslo-incubator libraries needed by image-tools.","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/fdd2aace6e4bc27aab24dcdeb36d271a054d5780"}]}],"author":{"name":"Ghe Rivero","email":"ghe@debian.org","date":"2013-06-17 08:31:28.000000000","tz":120},"committer":{"name":"Ghe Rivero","email":"ghe@debian.org","date":"2013-06-25 07:32:59.000000000","tz":120},"subject":"Move glance image service client from nova and cinder into python-glanceclient.","message":"Move glance image service client from nova and cinder into python-glanceclient.\n\nThis is now present in nova and cinder, and it will be also needed in ironic,\nso moving it into a common location.\n\nMost of the code was present on nova.image.glance and cincer.image.glance.\n\nglanceclient/exc.py \u003d\u003e nova.exception \u003c\u003d\u003e cinder.exception\n GlanceBaseException\n GlanceConnectionFailed\n ImageNotFound\n ImageNotAuthorized\n Invalid\n\nImplements: blueprint image-tools\n\nChange-Id: Ibb2c44df99ae5746e32695e69078737cc6b5aeeb\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/236d034a539648abbf940de06377d1b55d2741f6"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/236d034a539648abbf940de06377d1b55d2741f6"}]},"branch":"refs/heads/master"},"7748f2d4b509f45b45d765fdff169231ef1fcd73":{"kind":"REWORK","_number":6,"created":"2013-07-01 09:11:03.000000000","uploader":{"_account_id":1726,"name":"Ghe Rivero","email":"ghe.rivero@gmail.com","username":"ghe.rivero"},"ref":"refs/changes/27/33327/6","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/27/33327/6","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/27/33327/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/27/33327/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/27/33327/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/27/33327/6"}}},"commit":{"parents":[{"commit":"fdd2aace6e4bc27aab24dcdeb36d271a054d5780","subject":"Sync of new oslo-incubator libraries needed by image-tools.","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/fdd2aace6e4bc27aab24dcdeb36d271a054d5780"}]}],"author":{"name":"Ghe Rivero","email":"ghe@debian.org","date":"2013-06-17 08:31:28.000000000","tz":120},"committer":{"name":"Ghe Rivero","email":"ghe@debian.org","date":"2013-07-01 08:22:06.000000000","tz":120},"subject":"Move glance image service client from nova and cinder into python-glanceclient.","message":"Move glance image service client from nova and cinder into python-glanceclient.\n\nThis is now present in nova and cinder, and it will be also needed in ironic,\nso moving it into a common location.\n\nMost of the code was present on nova.image.glance and cincer.image.glance.\n\nglanceclient/exc.py \u003d\u003e nova.exception \u003c\u003d\u003e cinder.exception\n GlanceBaseException\n GlanceConnectionFailed\n ImageNotFound\n ImageNotAuthorized\n Invalid\n\nImplements: blueprint image-tools\n\nChange-Id: Ibb2c44df99ae5746e32695e69078737cc6b5aeeb\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/7748f2d4b509f45b45d765fdff169231ef1fcd73"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/7748f2d4b509f45b45d765fdff169231ef1fcd73"}]},"branch":"refs/heads/master"},"dd871998f41301ae20560993395e135e04cdc1d9":{"kind":"REWORK","_number":7,"created":"2013-07-10 07:54:39.000000000","uploader":{"_account_id":1726,"name":"Ghe Rivero","email":"ghe.rivero@gmail.com","username":"ghe.rivero"},"ref":"refs/changes/27/33327/7","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/27/33327/7","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/27/33327/7 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/27/33327/7 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/27/33327/7 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/27/33327/7"}}},"commit":{"parents":[{"commit":"cc4c281605ec3cbdee2085d25d7c60c50988c9cc","subject":"Sync of new oslo-incubator libraries needed by image-tools.","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/cc4c281605ec3cbdee2085d25d7c60c50988c9cc"}]}],"author":{"name":"Ghe Rivero","email":"ghe@debian.org","date":"2013-06-17 08:31:28.000000000","tz":120},"committer":{"name":"Ghe Rivero","email":"ghe.rivero@hp.com","date":"2013-07-10 07:53:42.000000000","tz":0},"subject":"Move glance image service client from nova and cinder.","message":"Move glance image service client from nova and cinder.\n\nThis is now present in nova and cinder, and it will be also needed in ironic,\nso moving it into a common location.\n\nMost of the code was present on nova.image.glance and cinder.image.glance.\n\nglanceclient/exc.py \u003d\u003e nova.exception \u003c\u003d\u003e cinder.exception\n GlanceBaseException\n GlanceConnectionFailed\n ImageNotFound\n ImageNotAuthorized\n Invalid\n\nImplements: blueprint image-tools\n\nChange-Id: Ibb2c44df99ae5746e32695e69078737cc6b5aeeb\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/dd871998f41301ae20560993395e135e04cdc1d9"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/dd871998f41301ae20560993395e135e04cdc1d9"}]},"branch":"refs/heads/master"},"4485c7c72bd8d854d69248bda76677226b966ea4":{"kind":"REWORK","_number":8,"created":"2013-07-19 09:40:28.000000000","uploader":{"_account_id":1726,"name":"Ghe Rivero","email":"ghe.rivero@gmail.com","username":"ghe.rivero"},"ref":"refs/changes/27/33327/8","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/27/33327/8","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/27/33327/8 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/27/33327/8 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/27/33327/8 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/27/33327/8"}}},"commit":{"parents":[{"commit":"b72b2b40e6c2bc471d779bbac50a33952a86c401","subject":"Sync of new oslo-incubator libraries needed by image-tools.","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/b72b2b40e6c2bc471d779bbac50a33952a86c401"}]}],"author":{"name":"Ghe Rivero","email":"ghe@debian.org","date":"2013-06-17 08:31:28.000000000","tz":120},"committer":{"name":"Ghe Rivero","email":"ghe.rivero@hp.com","date":"2013-07-19 09:35:18.000000000","tz":0},"subject":"Move glance image service client from nova and cinder.","message":"Move glance image service client from nova and cinder.\n\nThis is now present in nova and cinder, and it will be also needed in ironic,\nso moving it into a common location.\n\nMost of the code was present on nova.image.glance and cinder.image.glance.\n\nglanceclient/exc.py \u003d\u003e nova.exception \u003c\u003d\u003e cinder.exception\n GlanceBaseException\n GlanceConnectionFailed\n ImageNotFound\n ImageNotAuthorized\n Invalid\n\nImplements: blueprint image-tools\n\nChange-Id: Ibb2c44df99ae5746e32695e69078737cc6b5aeeb\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/4485c7c72bd8d854d69248bda76677226b966ea4"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/4485c7c72bd8d854d69248bda76677226b966ea4"}]},"branch":"refs/heads/master"},"9ca24cfc12eb97d639c61a473761737f34031a34":{"kind":"REWORK","_number":9,"created":"2013-07-26 10:29:18.000000000","uploader":{"_account_id":1726,"name":"Ghe Rivero","email":"ghe.rivero@gmail.com","username":"ghe.rivero"},"ref":"refs/changes/27/33327/9","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/27/33327/9","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/27/33327/9 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/27/33327/9 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/27/33327/9 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/27/33327/9"}}},"commit":{"parents":[{"commit":"b72b2b40e6c2bc471d779bbac50a33952a86c401","subject":"Sync of new oslo-incubator libraries needed by image-tools.","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/b72b2b40e6c2bc471d779bbac50a33952a86c401"}]}],"author":{"name":"Ghe Rivero","email":"ghe@debian.org","date":"2013-06-17 08:31:28.000000000","tz":120},"committer":{"name":"Ghe Rivero","email":"ghe.rivero@hp.com","date":"2013-07-26 10:29:05.000000000","tz":0},"subject":"Move glance image service client from nova and cinder.","message":"Move glance image service client from nova and cinder.\n\nThis is now present in nova and cinder, and it will be also needed in ironic,\nso moving it into a common location.\n\nMost of the code was present on nova.image.glance and cinder.image.glance.\n\nglanceclient/exc.py \u003d\u003e nova.exception \u003c\u003d\u003e cinder.exception\n GlanceBaseException\n GlanceConnectionFailed\n ImageNotFound\n ImageNotAuthorized\n Invalid\n\nImplements: blueprint image-tools\n\nChange-Id: Ibb2c44df99ae5746e32695e69078737cc6b5aeeb\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/9ca24cfc12eb97d639c61a473761737f34031a34"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/9ca24cfc12eb97d639c61a473761737f34031a34"}]},"branch":"refs/heads/master"},"42a66cb0021d8dd280734aba6690989e3cb700f7":{"kind":"REWORK","_number":10,"created":"2013-07-30 12:10:56.000000000","uploader":{"_account_id":1726,"name":"Ghe Rivero","email":"ghe.rivero@gmail.com","username":"ghe.rivero"},"ref":"refs/changes/27/33327/10","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/27/33327/10","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/27/33327/10 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/27/33327/10 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/27/33327/10 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/27/33327/10"}}},"commit":{"parents":[{"commit":"b72b2b40e6c2bc471d779bbac50a33952a86c401","subject":"Sync of new oslo-incubator libraries needed by image-tools.","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/b72b2b40e6c2bc471d779bbac50a33952a86c401"}]}],"author":{"name":"Ghe Rivero","email":"ghe@debian.org","date":"2013-06-17 08:31:28.000000000","tz":120},"committer":{"name":"Ghe Rivero","email":"ghe.rivero@hp.com","date":"2013-07-30 12:08:36.000000000","tz":0},"subject":"Move glance image service client from nova and cinder.","message":"Move glance image service client from nova and cinder.\n\nThis is now present in nova and cinder, and it will be also needed in ironic,\nso moving it into a common location.\n\nMost of the code was present on nova.image.glance and cinder.image.glance.\n\nglanceclient/exc.py \u003d\u003e nova.exception \u003c\u003d\u003e cinder.exception\n GlanceBaseException\n GlanceConnectionFailed\n ImageNotFound\n ImageNotAuthorized\n Invalid\n\nImplements: blueprint image-tools\n\nChange-Id: Ibb2c44df99ae5746e32695e69078737cc6b5aeeb\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/42a66cb0021d8dd280734aba6690989e3cb700f7"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/42a66cb0021d8dd280734aba6690989e3cb700f7"}]},"branch":"refs/heads/master"},"00556b076646aacb0cf73184a46a63e8d0b1992f":{"kind":"REWORK","_number":11,"created":"2013-07-30 16:21:40.000000000","uploader":{"_account_id":1726,"name":"Ghe Rivero","email":"ghe.rivero@gmail.com","username":"ghe.rivero"},"ref":"refs/changes/27/33327/11","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/27/33327/11","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/27/33327/11 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/27/33327/11 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/27/33327/11 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/27/33327/11"}}},"commit":{"parents":[{"commit":"b72b2b40e6c2bc471d779bbac50a33952a86c401","subject":"Sync of new oslo-incubator libraries needed by image-tools.","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/b72b2b40e6c2bc471d779bbac50a33952a86c401"}]}],"author":{"name":"Ghe Rivero","email":"ghe@debian.org","date":"2013-06-17 08:31:28.000000000","tz":120},"committer":{"name":"Ghe Rivero","email":"ghe.rivero@hp.com","date":"2013-07-30 16:06:21.000000000","tz":0},"subject":"Move glance image service client from nova and cinder.","message":"Move glance image service client from nova and cinder.\n\nThis is now present in nova and cinder, and it will be also needed in ironic,\nso moving it into a common location.\n\nMost of the code was present on nova.image.glance and cinder.image.glance.\n\nglanceclient/exc.py \u003d\u003e nova.exception \u003c\u003d\u003e cinder.exception\n GlanceBaseException\n GlanceConnectionFailed\n ImageNotFound\n ImageNotAuthorized\n Invalid\n\nImplements: blueprint image-tools\n\nChange-Id: Ibb2c44df99ae5746e32695e69078737cc6b5aeeb\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/00556b076646aacb0cf73184a46a63e8d0b1992f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/00556b076646aacb0cf73184a46a63e8d0b1992f"}]},"branch":"refs/heads/master"},"7c7dcc26d8b8ba955b43696064340a5e7c3b2bc4":{"kind":"REWORK","_number":12,"created":"2013-08-01 10:21:15.000000000","uploader":{"_account_id":1726,"name":"Ghe Rivero","email":"ghe.rivero@gmail.com","username":"ghe.rivero"},"ref":"refs/changes/27/33327/12","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/27/33327/12","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/27/33327/12 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/27/33327/12 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/27/33327/12 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/27/33327/12"}}},"commit":{"parents":[{"commit":"9dafa0a8287af5f0a61a4de09fa270d37967e3f9","subject":"Sync of new oslo-incubator libraries needed by image-tools.","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/9dafa0a8287af5f0a61a4de09fa270d37967e3f9"}]}],"author":{"name":"Ghe Rivero","email":"ghe@debian.org","date":"2013-06-17 08:31:28.000000000","tz":120},"committer":{"name":"Ghe Rivero","email":"ghe.rivero@hp.com","date":"2013-08-01 10:09:44.000000000","tz":0},"subject":"Move glance image service client from nova and cinder.","message":"Move glance image service client from nova and cinder.\n\nThis is now present in nova and cinder, and it will be also needed in ironic,\nso moving it into a common location.\n\nMost of the code was present on nova.image.glance and cinder.image.glance.\n\nglanceclient/exc.py \u003d\u003e nova.exception \u003c\u003d\u003e cinder.exception\n GlanceBaseException\n GlanceConnectionFailed\n ImageNotFound\n ImageNotAuthorized\n Invalid\n\nImplements: blueprint image-tools\n\nChange-Id: Ibb2c44df99ae5746e32695e69078737cc6b5aeeb\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/7c7dcc26d8b8ba955b43696064340a5e7c3b2bc4"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/7c7dcc26d8b8ba955b43696064340a5e7c3b2bc4"}]},"branch":"refs/heads/master"},"65490f15cb2923aaf021d26c0f9e2c8115dceb0c":{"kind":"REWORK","_number":13,"created":"2013-08-06 11:00:32.000000000","uploader":{"_account_id":1726,"name":"Ghe Rivero","email":"ghe.rivero@gmail.com","username":"ghe.rivero"},"ref":"refs/changes/27/33327/13","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/27/33327/13","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/27/33327/13 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/27/33327/13 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/27/33327/13 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/27/33327/13"}}},"commit":{"parents":[{"commit":"9dafa0a8287af5f0a61a4de09fa270d37967e3f9","subject":"Sync of new oslo-incubator libraries needed by image-tools.","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/9dafa0a8287af5f0a61a4de09fa270d37967e3f9"}]}],"author":{"name":"Ghe Rivero","email":"ghe@debian.org","date":"2013-06-17 08:31:28.000000000","tz":120},"committer":{"name":"Ghe Rivero","email":"ghe.rivero@hp.com","date":"2013-08-06 10:52:56.000000000","tz":0},"subject":"Move glance image service client from nova and cinder.","message":"Move glance image service client from nova and cinder.\n\nThis is now present in nova and cinder, and it will be also needed in ironic,\nso moving it into a common location.\n\nMost of the code was present on nova.image.glance and cinder.image.glance.\n\nglanceclient/exc.py \u003d\u003e nova.exception \u003c\u003d\u003e cinder.exception\n GlanceBaseException\n GlanceConnectionFailed\n ImageNotFound\n ImageNotAuthorized\n Invalid\n\nImplements: blueprint image-tools\n\nChange-Id: Ibb2c44df99ae5746e32695e69078737cc6b5aeeb\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/65490f15cb2923aaf021d26c0f9e2c8115dceb0c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/65490f15cb2923aaf021d26c0f9e2c8115dceb0c"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}