)]}'
{"id":"openstack%2Fpython-glanceclient~33464","triplet_id":"openstack%2Fpython-glanceclient~master~Ib651548ab4289295a9b92ee039b2aff2d08aba5f","project":"openstack/python-glanceclient","branch":"master","topic":"bug/1192229","hashtags":[],"change_id":"Ib651548ab4289295a9b92ee039b2aff2d08aba5f","subject":"Fix SSL certificate CNAME checking","status":"MERGED","created":"2013-06-18 15:36:36.000000000","updated":"2013-07-22 21:50:07.000000000","submitted":"2013-07-22 21:50:07.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":8,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"1a9f9522964628e2ca8d530c31ad556d12e04fdc","_number":33464,"virtual_id_number":33464,"owner":{"_account_id":7817,"name":"Thomas Leaman","email":"thomas.leaman@hp.com","username":"bugsduggan"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2013-07-22 21:50:07.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":308,"name":"Thierry Carrez","email":"thierry@openstack.org","username":"ttx"},{"value":0,"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},{"value":0,"_account_id":616,"name":"Mark Washenberger","email":"mark.washenberger@markwash.net","username":"markwash"},{"value":0,"_account_id":7817,"name":"Thomas Leaman","email":"thomas.leaman@hp.com","username":"bugsduggan"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":616,"name":"Mark Washenberger","email":"mark.washenberger@markwash.net","username":"markwash"},"recommended":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2013-07-15 09:15:52.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":308,"name":"Thierry Carrez","email":"thierry@openstack.org","username":"ttx"},{"value":1,"date":"2013-07-16 08:49:37.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},{"value":2,"date":"2013-07-22 20:18:43.000000000","_account_id":616,"name":"Mark Washenberger","email":"mark.washenberger@markwash.net","username":"markwash"},{"value":0,"_account_id":7817,"name":"Thomas Leaman","email":"thomas.leaman@hp.com","username":"bugsduggan"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":616,"name":"Mark Washenberger","email":"mark.washenberger@markwash.net","username":"markwash"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":308,"name":"Thierry Carrez","email":"thierry@openstack.org","username":"ttx"},{"value":0,"date":"2013-07-16 08:49:37.000000000","_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},{"value":1,"date":"2013-07-22 20:19:20.000000000","_account_id":616,"name":"Mark Washenberger","email":"mark.washenberger@markwash.net","username":"markwash"},{"value":0,"_account_id":7817,"name":"Thomas Leaman","email":"thomas.leaman@hp.com","username":"bugsduggan"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":308,"name":"Thierry Carrez","email":"thierry@openstack.org","username":"ttx"},{"value":0,"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},{"value":0,"_account_id":616,"name":"Mark Washenberger","email":"mark.washenberger@markwash.net","username":"markwash"},{"value":0,"_account_id":7817,"name":"Thomas Leaman","email":"thomas.leaman@hp.com","username":"bugsduggan"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Top Priority / Holds Gate"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":308,"name":"Thierry Carrez","email":"thierry@openstack.org","username":"ttx"},{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},{"_account_id":616,"name":"Mark Washenberger","email":"mark.washenberger@markwash.net","username":"markwash"},{"_account_id":7817,"name":"Thomas Leaman","email":"thomas.leaman@hp.com","username":"bugsduggan"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-07-15 09:15:52.000000000","updated_by":{"_account_id":308,"name":"Thierry Carrez","email":"thierry@openstack.org","username":"ttx"},"reviewer":{"_account_id":308,"name":"Thierry Carrez","email":"thierry@openstack.org","username":"ttx"},"state":"REVIEWER"},{"updated":"2013-07-16 08:49:37.000000000","updated_by":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"reviewer":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"state":"REVIEWER"},{"updated":"2013-07-22 20:19:20.000000000","updated_by":{"_account_id":616,"name":"Mark Washenberger","email":"mark.washenberger@markwash.net","username":"markwash"},"reviewer":{"_account_id":616,"name":"Mark Washenberger","email":"mark.washenberger@markwash.net","username":"markwash"},"state":"REVIEWER"},{"updated":"2013-07-22 21:50:07.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"2f99c86718a678ede2ef919fce277fd779071286","author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"date":"2013-06-18 16:08:32.000000000","message":"Patch Set 1:\n\nHi Tom, can you update the commit msg to say \u0027Fixes bug 1192220\u0027. This will automagically link to the bug. Thanks!","accounts_in_message":[],"_revision_number":1},{"id":"b13d52527f65a1c75b81d1a212035e5aa9e0efb6","author":{"_account_id":7817,"name":"Thomas Leaman","email":"thomas.leaman@hp.com","username":"bugsduggan"},"date":"2013-06-18 16:14:00.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"f768a73b263b262a31b38e8e21abf2833443aa0c","author":{"_account_id":5494,"name":"Trivial Rebase","email":"trivial-rebase@review.openstack.org","username":"trivial-rebase"},"date":"2013-06-18 16:14:06.000000000","message":"Patch Set 2:\n\nNew patchset patch-id matches previous patchset, but commit message has changed.","accounts_in_message":[],"_revision_number":2},{"id":"22a4179b26f2de345fed2df54675668527691291","author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"date":"2013-06-18 16:17:00.000000000","message":"Patch Set 2: (1 inline comment)\n\n","accounts_in_message":[],"_revision_number":2},{"id":"6e35cddeb1ee41e9ce4ad8b23ffb955e5ab14cd3","author":{"_account_id":7817,"name":"Thomas Leaman","email":"thomas.leaman@hp.com","username":"bugsduggan"},"date":"2013-06-18 16:18:43.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"110dec4b634a1b270ea13ead4415c55690c47cf7","author":{"_account_id":5494,"name":"Trivial Rebase","email":"trivial-rebase@review.openstack.org","username":"trivial-rebase"},"date":"2013-06-18 16:18:49.000000000","message":"Patch Set 3:\n\nNew patchset patch-id matches previous patchset, but commit message has changed.","accounts_in_message":[],"_revision_number":3},{"id":"740b36065e4f901840f315889ef8857ef71a2383","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-06-18 17:01:57.000000000","message":"Patch Set 3: Doesn\u0027t seem to work\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGithub#Test_Failures\n\n- http://logs.openstack.org/33464/3/check/gate-python-glanceclient-pep8/823 : FAILURE in 54s\n- http://docs-draft.openstack.org/33464/3/check/gate-python-glanceclient-docs/755/doc/build/html/ : SUCCESS in 1m 00s\n- http://logs.openstack.org/33464/3/check/gate-python-glanceclient-python26/818 : SUCCESS in 1m 39s\n- http://logs.openstack.org/33464/3/check/gate-python-glanceclient-python27/816 : SUCCESS in 1m 00s\n- http://logs.openstack.org/33464/3/check/gate-tempest-devstack-vm-full/24237 : SUCCESS in 42m 24s\n- http://logs.openstack.org/33464/3/check/gate-tempest-devstack-vm-postgres-full/23943 : SUCCESS in 41m 54s\n- http://logs.openstack.org/33464/3/check/gate-tempest-devstack-vm-quantum/31690 : FAILURE in 16m 08s\n- http://logs.openstack.org/33464/3/check/gate-grenade-devstack-vm/11131 : FAILURE in 43m 09s (non-voting)\n","accounts_in_message":[],"_revision_number":3},{"id":"10d5b88ca0cf0c2bb2a9f97459ebdbba644d980d","author":{"_account_id":7817,"name":"Thomas Leaman","email":"thomas.leaman@hp.com","username":"bugsduggan"},"date":"2013-06-19 10:23:23.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"c0aa85c3385f90d062b97d0647cc64b792b5f121","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-06-19 11:05:47.000000000","message":"Patch Set 4: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/33464/4/check/gate-python-glanceclient-pep8/824 : SUCCESS in 54s\n- http://docs-draft.openstack.org/33464/4/check/gate-python-glanceclient-docs/756/doc/build/html/ : SUCCESS in 1m 00s\n- http://logs.openstack.org/33464/4/check/gate-python-glanceclient-python26/819 : SUCCESS in 1m 27s\n- http://logs.openstack.org/33464/4/check/gate-python-glanceclient-python27/817 : SUCCESS in 1m 14s\n- http://logs.openstack.org/33464/4/check/gate-tempest-devstack-vm-full/24557 : SUCCESS in 39m 54s\n- http://logs.openstack.org/33464/4/check/gate-tempest-devstack-vm-postgres-full/24263 : SUCCESS in 42m 16s\n- http://logs.openstack.org/33464/4/check/gate-tempest-devstack-vm-quantum/32026 : SUCCESS in 19m 49s\n- http://logs.openstack.org/33464/4/check/gate-grenade-devstack-vm/11402 : FAILURE in 33m 51s (non-voting)\n","accounts_in_message":[],"_revision_number":4},{"id":"6b2c3cc03200c4858ce17bdcb1d0fe614f188101","author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"date":"2013-06-19 11:36:06.000000000","message":"Patch Set 4: Looks good to me, but someone else must approve\n\nGreat catch Tom!\n\nI\u0027ve done some functional testing:\n\nAfter the change this successfully complains about the common name:\n\n$ glance  -A XXX -U https://localhost:9292 image-show fdd4c129-4779-43e3-8ac0-072dc2692751\nHost \"localhost\" does not match x509 certificate contents: CommonName \"xxx.xxx.xxx\"\n\nUsing the --insecure flag allows the cert mis-match to be ignored as usual.","accounts_in_message":[],"_revision_number":4},{"id":"87b09c3c73a30caad9360ce2df229fad9b341a8b","author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"date":"2013-06-19 12:07:15.000000000","message":"Patch Set 4: I would prefer that you didn\u0027t merge this\n\n(1 inline comment)\n\nA minor nit -- just need to double check one of the comments.","accounts_in_message":[],"_revision_number":4},{"id":"e3bc9cd612d20a3a827eb01ff10d001a3e385a58","author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"date":"2013-06-19 12:23:15.000000000","message":"Patch Set 4:\n\nI set up a dud cert and with some debug ... it seems can \u00270\u0027 can be returned:\n\nXXX preverify_ok 0\n[(\u0027SSL routines\u0027, \u0027SSL3_GET_SERVER_CERTIFICATE\u0027, \u0027certificate verify failed\u0027)]","accounts_in_message":[],"_revision_number":4},{"id":"747ce47df118a77e84ff6c67df426723b46b5c50","author":{"_account_id":7817,"name":"Thomas Leaman","email":"thomas.leaman@hp.com","username":"bugsduggan"},"date":"2013-06-19 12:29:29.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"9bdf8943fc0dad07a0aede4b030e4e2df9c2083a","author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"date":"2013-06-19 12:33:24.000000000","message":"Patch Set 5: Looks good to me, but someone else must approve\n\nThanks Tom.","accounts_in_message":[],"_revision_number":5},{"id":"76ea552c213bb1514f193b6f4d10d51efbc9920c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-06-19 13:10:06.000000000","message":"Patch Set 5: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/33464/5/check/gate-python-glanceclient-pep8/825 : SUCCESS in 57s\n- http://docs-draft.openstack.org/33464/5/check/gate-python-glanceclient-docs/757/doc/build/html/ : SUCCESS in 53s\n- http://logs.openstack.org/33464/5/check/gate-python-glanceclient-python26/820 : SUCCESS in 1m 25s\n- http://logs.openstack.org/33464/5/check/gate-python-glanceclient-python27/818 : SUCCESS in 53s\n- http://logs.openstack.org/33464/5/check/gate-tempest-devstack-vm-full/24576 : SUCCESS in 38m 19s\n- http://logs.openstack.org/33464/5/check/gate-tempest-devstack-vm-postgres-full/24282 : SUCCESS in 40m 29s\n- http://logs.openstack.org/33464/5/check/gate-tempest-devstack-vm-quantum/32048 : SUCCESS in 18m 13s\n- http://logs.openstack.org/33464/5/check/gate-grenade-devstack-vm/11416 : FAILURE in 39m 58s (non-voting)\n","accounts_in_message":[],"_revision_number":5},{"id":"ede745dd9c37e15d33fb3743351d9bf84948af02","author":{"_account_id":308,"name":"Thierry Carrez","email":"thierry@openstack.org","username":"ttx"},"date":"2013-06-20 13:04:02.000000000","message":"Patch Set 5: I would prefer that you didn\u0027t merge this\n\n(1 inline comment)\n\n","accounts_in_message":[],"_revision_number":5},{"id":"c4b3153d15e6b5c73249507e62851ff763208499","author":{"_account_id":7817,"name":"Thomas Leaman","email":"thomas.leaman@hp.com","username":"bugsduggan"},"date":"2013-06-20 14:51:34.000000000","message":"Uploaded patch set 6.","accounts_in_message":[],"_revision_number":6},{"id":"437053053d291968af3deafcd9426029611830a3","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-06-20 15:41:51.000000000","message":"Patch Set 6: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/33464/6/check/gate-python-glanceclient-pep8/828 : SUCCESS in 58s\n- http://docs-draft.openstack.org/33464/6/check/gate-python-glanceclient-docs/760/doc/build/html/ : SUCCESS in 1m 11s\n- http://logs.openstack.org/33464/6/check/gate-python-glanceclient-python26/823 : SUCCESS in 1m 28s\n- http://logs.openstack.org/33464/6/check/gate-python-glanceclient-python27/821 : SUCCESS in 1m 07s\n- http://logs.openstack.org/33464/6/check/gate-tempest-devstack-vm-full/24998 : SUCCESS in 50m 12s\n- http://logs.openstack.org/33464/6/check/gate-tempest-devstack-vm-postgres-full/24704 : SUCCESS in 41m 03s\n- http://logs.openstack.org/33464/6/check/gate-tempest-devstack-vm-quantum/32509 : SUCCESS in 19m 29s\n- http://logs.openstack.org/33464/6/check/gate-grenade-devstack-vm/11743 : FAILURE in 11m 34s (non-voting)\n","accounts_in_message":[],"_revision_number":6},{"id":"d882280ebc85104558d6ec5e74b544af4d136752","author":{"_account_id":308,"name":"Thierry Carrez","email":"thierry@openstack.org","username":"ttx"},"date":"2013-06-20 15:42:38.000000000","message":"Patch Set 6: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":6},{"id":"e7cb52286d2caac9cfed924a28b6dc712ccc1b93","author":{"_account_id":616,"name":"Mark Washenberger","email":"mark.washenberger@markwash.net","username":"markwash"},"date":"2013-06-20 18:58:41.000000000","message":"Patch Set 6: (1 inline comment)\n\nThis looks good, just one note inline that I\u0027d like to hear back from you guys about.","accounts_in_message":[],"_revision_number":6},{"id":"f09eb5949dec26b7dacd23abf09ac432f919d66f","author":{"_account_id":308,"name":"Thierry Carrez","email":"thierry@openstack.org","username":"ttx"},"date":"2013-06-21 07:31:57.000000000","message":"Patch Set 6: (1 inline comment)\n\n","accounts_in_message":[],"_revision_number":6},{"id":"1be1e78e0268b37d69ea69166eb25270cdfc424f","author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"date":"2013-06-24 16:25:42.000000000","message":"Patch Set 6: (1 inline comment)\n\n","accounts_in_message":[],"_revision_number":6},{"id":"4e65f1fbe0289bb8f9fe25a96a753c0894d57f63","author":{"_account_id":7817,"name":"Thomas Leaman","email":"thomas.leaman@hp.com","username":"bugsduggan"},"date":"2013-07-01 12:17:06.000000000","message":"Uploaded patch set 7.","accounts_in_message":[],"_revision_number":7},{"id":"b01bddd16ed3050680ef7924f51df21ec82948e9","author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"date":"2013-07-01 12:32:15.000000000","message":"Patch Set 7: Looks good to me, but someone else must approve\n\nThanks Tom.","accounts_in_message":[],"_revision_number":7},{"id":"854f5f77eeca3bbeea4918dc08dac85ead32b920","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-07-01 13:01:29.000000000","message":"Patch Set 7: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/33464/7/check/gate-python-glanceclient-pep8/851 : SUCCESS in 47s\n- http://docs-draft.openstack.org/33464/7/check/gate-python-glanceclient-docs/783/doc/build/html/ : SUCCESS in 50s\n- http://logs.openstack.org/33464/7/check/gate-python-glanceclient-python26/846 : SUCCESS in 1m 12s\n- http://logs.openstack.org/33464/7/check/gate-python-glanceclient-python27/844 : SUCCESS in 56s\n- http://logs.openstack.org/33464/7/check/gate-tempest-devstack-vm-full/27522 : SUCCESS in 41m 39s\n- http://logs.openstack.org/33464/7/check/gate-tempest-devstack-vm-postgres-full/27228 : SUCCESS in 44m 16s\n- http://logs.openstack.org/33464/7/check/gate-tempest-devstack-vm-quantum/35328 : SUCCESS in 16m 46s\n- http://logs.openstack.org/33464/7/check/gate-grenade-devstack-vm/13958 : FAILURE in 20m 05s (non-voting)\n","accounts_in_message":[],"_revision_number":7},{"id":"510b01fd40c343138ee7f1193d4d0e56400100ef","author":{"_account_id":308,"name":"Thierry Carrez","email":"thierry@openstack.org","username":"ttx"},"date":"2013-07-01 16:13:53.000000000","message":"Patch Set 7: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":7},{"id":"f7b808e13bac73c2ad45dd73817d9827a86d6e61","author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"date":"2013-07-10 15:31:15.000000000","message":"Patch Set 7: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":7},{"id":"02a0a990a4e4bab2010eae47e3d1fa26491c5434","author":{"_account_id":616,"name":"Mark Washenberger","email":"mark.washenberger@markwash.net","username":"markwash"},"date":"2013-07-12 17:32:28.000000000","message":"Patch Set 7: I would prefer that you didn\u0027t merge this\n\nSome notes coming very soon.","accounts_in_message":[],"_revision_number":7},{"id":"d864f62448226027b93e47e839b41d98cd5e9974","author":{"_account_id":616,"name":"Mark Washenberger","email":"mark.washenberger@markwash.net","username":"markwash"},"date":"2013-07-12 17:45:15.000000000","message":"Patch Set 7: (2 inline comments)\n\nPlease see notes inline. I just want to make sure this bug is fixed as robustly as possible and that future readers will have a clear idea what is going on.","accounts_in_message":[],"_revision_number":7},{"id":"6e06e2618307f6ce19c3a0bfb4877ae4144ceae7","author":{"_account_id":7817,"name":"Thomas Leaman","email":"thomas.leaman@hp.com","username":"bugsduggan"},"date":"2013-07-15 08:50:54.000000000","message":"Uploaded patch set 8.","accounts_in_message":[],"_revision_number":8},{"id":"3343598f763353022631edd7328ac97578af5891","author":{"_account_id":308,"name":"Thierry Carrez","email":"thierry@openstack.org","username":"ttx"},"date":"2013-07-15 09:15:52.000000000","message":"Patch Set 8: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":8},{"id":"0f8b6d4b136f31b12650bc69f7c5aa404e36f572","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-07-15 09:34:47.000000000","message":"Patch Set 8: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/33464/8/check/gate-python-glanceclient-pep8/889 : SUCCESS in 1m 04s\n- http://docs-draft.openstack.org/33464/8/check/gate-python-glanceclient-docs/821/doc/build/html/ : SUCCESS in 1m 51s\n- http://logs.openstack.org/33464/8/check/gate-python-glanceclient-python26/884 : SUCCESS in 1m 36s\n- http://logs.openstack.org/33464/8/check/gate-python-glanceclient-python27/882 : SUCCESS in 1m 12s\n- http://logs.openstack.org/33464/8/check/gate-tempest-devstack-vm-full/32073 : SUCCESS in 43m 46s\n- http://logs.openstack.org/33464/8/check/gate-tempest-devstack-vm-cells-full/224 : FAILURE in 15m 30s (non-voting)\n- http://logs.openstack.org/33464/8/check/gate-tempest-devstack-vm-postgres-full/31765 : SUCCESS in 41m 25s\n- http://logs.openstack.org/33464/8/check/gate-tempest-devstack-vm-neutron/3535 : SUCCESS in 21m 24s (non-voting)\n- http://logs.openstack.org/33464/8/check/gate-grenade-devstack-vm/18020 : SUCCESS in 25m 17s (non-voting)\n","accounts_in_message":[],"_revision_number":8},{"id":"27378c3bcfa52434026f51feee492f44eb77e8fc","author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"date":"2013-07-16 08:49:37.000000000","message":"Patch Set 8: Looks good to me, but someone else must approve\n\nMark, thanks for your considered comments on ps7.","accounts_in_message":[],"_revision_number":8},{"id":"23e9d776ff2bd7eaf741181e9fd97c34733e4a2d","author":{"_account_id":616,"name":"Mark Washenberger","email":"mark.washenberger@markwash.net","username":"markwash"},"date":"2013-07-22 20:18:43.000000000","message":"Patch Set 8: Looks good to me (core reviewer)\n\nGreat, thanks!","accounts_in_message":[],"_revision_number":8},{"id":"fd3cf2df2c71bc61f46c30f57d7e3d14c42d01a3","author":{"_account_id":616,"name":"Mark Washenberger","email":"mark.washenberger@markwash.net","username":"markwash"},"date":"2013-07-22 20:19:20.000000000","message":"Patch Set 8: Approved\n\n","accounts_in_message":[],"_revision_number":8},{"id":"9042514923dc24e3915dc6c1dcc2634d78cefa15","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-07-22 20:20:47.000000000","message":"Patch Set 8: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":8},{"id":"27f3a1abd0117bc3b578c9038fde22873e60f458","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-07-22 21:50:07.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":8},{"id":"7ab86c93cd3cb56a7b8c856fd018652fe9578b55","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-07-22 21:50:07.000000000","message":"Patch Set 8: Verified\n\nBuild succeeded.\n\n- http://docs-draft.openstack.org/64/33464/8/gate/gate-python-glanceclient-docs/858/doc/build/html/ : SUCCESS in 1m 54s\n- http://logs.openstack.org/64/33464/8/gate/gate-python-glanceclient-pep8/926 : SUCCESS in 1m 17s\n- http://logs.openstack.org/64/33464/8/gate/gate-python-glanceclient-python26/921 : SUCCESS in 2m 01s\n- http://logs.openstack.org/64/33464/8/gate/gate-python-glanceclient-python27/919 : SUCCESS in 1m 21s\n- http://logs.openstack.org/64/33464/8/gate/gate-tempest-devstack-vm-full/34514 : SUCCESS in 48m 17s\n- http://logs.openstack.org/64/33464/8/gate/gate-tempest-devstack-vm-postgres-full/34204 : SUCCESS in 1h 00m 36s\n- http://logs.openstack.org/64/33464/8/gate/gate-tempest-devstack-vm-neutron/6338 : SUCCESS in 21m 31s (non-voting)\n- http://logs.openstack.org/64/33464/8/gate/gate-grenade-devstack-vm/20196 : SUCCESS in 28m 46s\n","accounts_in_message":[],"_revision_number":8}],"current_revision_number":8,"current_revision":"822cd64c0718b46a065abbb8709f6b466d12e708","revisions":{"7b38005a45e5c74f19b582ddad0af3fad67aa1e2":{"kind":"REWORK","_number":1,"created":"2013-06-18 15:36:36.000000000","uploader":{"_account_id":7817,"name":"Thomas Leaman","email":"thomas.leaman@hp.com","username":"bugsduggan"},"ref":"refs/changes/64/33464/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/64/33464/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/64/33464/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/64/33464/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/64/33464/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/64/33464/1"}}},"commit":{"parents":[{"commit":"c120aff87fa3d7ee8a53ec7a655389d069d88187","subject":"Merge \"Fix problem where image data is not read from a pipe.\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/c120aff87fa3d7ee8a53ec7a655389d069d88187"}]}],"author":{"name":"Thomas Leaman","email":"thomas.leaman@hp.com","date":"2013-06-18 15:34:45.000000000","tz":0},"committer":{"name":"Thomas Leaman","email":"thomas.leaman@hp.com","date":"2013-06-18 15:34:45.000000000","tz":0},"subject":"Allow preverify_ok to be checked correctly","message":"Allow preverify_ok to be checked correctly\n\n\u0027preverify_ok is True\u0027 will always return false\nchanged to \u0027preverify_ok \u003d\u003d True\u0027\n\nChange-Id: Ib651548ab4289295a9b92ee039b2aff2d08aba5f\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/7b38005a45e5c74f19b582ddad0af3fad67aa1e2"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/7b38005a45e5c74f19b582ddad0af3fad67aa1e2"}]},"branch":"refs/heads/master"},"18554037d4d33befbe7cb34eb1896adc7fed30fa":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2013-06-18 16:14:00.000000000","uploader":{"_account_id":7817,"name":"Thomas Leaman","email":"thomas.leaman@hp.com","username":"bugsduggan"},"ref":"refs/changes/64/33464/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/64/33464/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/64/33464/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/64/33464/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/64/33464/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/64/33464/2"}}},"commit":{"parents":[{"commit":"c120aff87fa3d7ee8a53ec7a655389d069d88187","subject":"Merge \"Fix problem where image data is not read from a pipe.\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/c120aff87fa3d7ee8a53ec7a655389d069d88187"}]}],"author":{"name":"Thomas Leaman","email":"thomas.leaman@hp.com","date":"2013-06-18 15:34:45.000000000","tz":0},"committer":{"name":"Thomas Leaman","email":"thomas.leaman@hp.com","date":"2013-06-18 16:11:12.000000000","tz":0},"subject":"Allow preverify_ok to be checked correctly","message":"Allow preverify_ok to be checked correctly\n\n\u0027preverify_ok is True\u0027 will always return false\nchanged to \u0027preverify_ok \u003d\u003d True\u0027\n\nFixes bug 1192229\n\nChange-Id: Ib651548ab4289295a9b92ee039b2aff2d08aba5f\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/18554037d4d33befbe7cb34eb1896adc7fed30fa"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/18554037d4d33befbe7cb34eb1896adc7fed30fa"}]},"branch":"refs/heads/master"},"92b368cebac6286c5cbc184d5855d2ee6b518184":{"kind":"NO_CODE_CHANGE","_number":3,"created":"2013-06-18 16:18:43.000000000","uploader":{"_account_id":7817,"name":"Thomas Leaman","email":"thomas.leaman@hp.com","username":"bugsduggan"},"ref":"refs/changes/64/33464/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/64/33464/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/64/33464/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/64/33464/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/64/33464/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/64/33464/3"}}},"commit":{"parents":[{"commit":"c120aff87fa3d7ee8a53ec7a655389d069d88187","subject":"Merge \"Fix problem where image data is not read from a pipe.\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/c120aff87fa3d7ee8a53ec7a655389d069d88187"}]}],"author":{"name":"Thomas Leaman","email":"thomas.leaman@hp.com","date":"2013-06-18 15:34:45.000000000","tz":0},"committer":{"name":"Thomas Leaman","email":"thomas.leaman@hp.com","date":"2013-06-18 16:18:06.000000000","tz":0},"subject":"Fix SSL certificate CNAME checking","message":"Fix SSL certificate CNAME checking\n\n\u0027preverify_ok is True\u0027 will always return false\nchanged to \u0027preverify_ok \u003d\u003d True\u0027\n\nFixes bug 1192229\n\nChange-Id: Ib651548ab4289295a9b92ee039b2aff2d08aba5f\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/92b368cebac6286c5cbc184d5855d2ee6b518184"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/92b368cebac6286c5cbc184d5855d2ee6b518184"}]},"branch":"refs/heads/master"},"1bb7e98df3d4026405306237770379ed3d5ba3cc":{"kind":"REWORK","_number":4,"created":"2013-06-19 10:23:23.000000000","uploader":{"_account_id":7817,"name":"Thomas Leaman","email":"thomas.leaman@hp.com","username":"bugsduggan"},"ref":"refs/changes/64/33464/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/64/33464/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/64/33464/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/64/33464/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/64/33464/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/64/33464/4"}}},"commit":{"parents":[{"commit":"c120aff87fa3d7ee8a53ec7a655389d069d88187","subject":"Merge \"Fix problem where image data is not read from a pipe.\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/c120aff87fa3d7ee8a53ec7a655389d069d88187"}]}],"author":{"name":"Thomas Leaman","email":"thomas.leaman@hp.com","date":"2013-06-18 15:34:45.000000000","tz":0},"committer":{"name":"Thomas Leaman","email":"thomas.leaman@hp.com","date":"2013-06-19 10:20:28.000000000","tz":0},"subject":"Fix SSL certificate CNAME checking","message":"Fix SSL certificate CNAME checking\n\nCurrently, accessing a host via ip address will pass SSL verification;\nthe CNAME is not checked as intended as part of verify_callback.\n\n\u0027preverify_ok is True\u0027 will always return false (int/bool comparison).\npreverify_ok will be 1 if preverification has passed, \u003e1 otherwise.\n\nFixes bug 1192229\n\nChange-Id: Ib651548ab4289295a9b92ee039b2aff2d08aba5f\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/1bb7e98df3d4026405306237770379ed3d5ba3cc"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/1bb7e98df3d4026405306237770379ed3d5ba3cc"}]},"branch":"refs/heads/master"},"1be3301885633f21dd58cb2f7a62f1ba76f34520":{"kind":"REWORK","_number":5,"created":"2013-06-19 12:29:29.000000000","uploader":{"_account_id":7817,"name":"Thomas Leaman","email":"thomas.leaman@hp.com","username":"bugsduggan"},"ref":"refs/changes/64/33464/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/64/33464/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/64/33464/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/64/33464/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/64/33464/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/64/33464/5"}}},"commit":{"parents":[{"commit":"c120aff87fa3d7ee8a53ec7a655389d069d88187","subject":"Merge \"Fix problem where image data is not read from a pipe.\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/c120aff87fa3d7ee8a53ec7a655389d069d88187"}]}],"author":{"name":"Thomas Leaman","email":"thomas.leaman@hp.com","date":"2013-06-18 15:34:45.000000000","tz":0},"committer":{"name":"Thomas Leaman","email":"thomas.leaman@hp.com","date":"2013-06-19 12:29:10.000000000","tz":0},"subject":"Fix SSL certificate CNAME checking","message":"Fix SSL certificate CNAME checking\n\nCurrently, accessing a host via ip address will pass SSL verification;\nthe CNAME is not checked as intended as part of verify_callback.\n\n\u0027preverify_ok is True\u0027 will always return false (int/bool comparison).\npreverify_ok will be 1 if preverification has passed.\n\nFixes bug 1192229\n\nChange-Id: Ib651548ab4289295a9b92ee039b2aff2d08aba5f\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/1be3301885633f21dd58cb2f7a62f1ba76f34520"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/1be3301885633f21dd58cb2f7a62f1ba76f34520"}]},"branch":"refs/heads/master"},"8fbff324e4c3de3a77b13cf7e0125614334a7c42":{"kind":"REWORK","_number":6,"created":"2013-06-20 14:51:34.000000000","uploader":{"_account_id":7817,"name":"Thomas Leaman","email":"thomas.leaman@hp.com","username":"bugsduggan"},"ref":"refs/changes/64/33464/6","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/64/33464/6","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/64/33464/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/64/33464/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/64/33464/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/64/33464/6"}}},"commit":{"parents":[{"commit":"c120aff87fa3d7ee8a53ec7a655389d069d88187","subject":"Merge \"Fix problem where image data is not read from a pipe.\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/c120aff87fa3d7ee8a53ec7a655389d069d88187"}]}],"author":{"name":"Thomas Leaman","email":"thomas.leaman@hp.com","date":"2013-06-18 15:34:45.000000000","tz":0},"committer":{"name":"Thomas Leaman","email":"thomas.leaman@hp.com","date":"2013-06-20 14:51:28.000000000","tz":0},"subject":"Fix SSL certificate CNAME checking","message":"Fix SSL certificate CNAME checking\n\nCurrently, accessing a host via ip address will pass SSL verification;\nthe CNAME is not checked as intended as part of verify_callback.\n\n\u0027preverify_ok is True\u0027 will always return false (int/bool comparison).\npreverify_ok will be 1 if preverification has passed.\n\nFixes bug 1192229\n\nChange-Id: Ib651548ab4289295a9b92ee039b2aff2d08aba5f\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/8fbff324e4c3de3a77b13cf7e0125614334a7c42"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/8fbff324e4c3de3a77b13cf7e0125614334a7c42"}]},"branch":"refs/heads/master"},"511a6d293bcf55055f56cc9d79f6f14348d583f9":{"kind":"REWORK","_number":7,"created":"2013-07-01 12:17:06.000000000","uploader":{"_account_id":7817,"name":"Thomas Leaman","email":"thomas.leaman@hp.com","username":"bugsduggan"},"ref":"refs/changes/64/33464/7","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/64/33464/7","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/64/33464/7 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/64/33464/7 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/64/33464/7 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/64/33464/7"}}},"commit":{"parents":[{"commit":"c120aff87fa3d7ee8a53ec7a655389d069d88187","subject":"Merge \"Fix problem where image data is not read from a pipe.\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/c120aff87fa3d7ee8a53ec7a655389d069d88187"}]}],"author":{"name":"Thomas Leaman","email":"thomas.leaman@hp.com","date":"2013-06-18 15:34:45.000000000","tz":0},"committer":{"name":"Thomas Leaman","email":"thomas.leaman@hp.com","date":"2013-07-01 12:16:54.000000000","tz":0},"subject":"Fix SSL certificate CNAME checking","message":"Fix SSL certificate CNAME checking\n\nCurrently, accessing a host via ip address will pass SSL verification;\nthe CNAME is not checked as intended as part of verify_callback.\n\n\u0027preverify_ok is True\u0027 will always return false (int/bool comparison).\npreverify_ok will be 1 if preverification has passed.\n\nFixes bug 1192229\n\nChange-Id: Ib651548ab4289295a9b92ee039b2aff2d08aba5f\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/511a6d293bcf55055f56cc9d79f6f14348d583f9"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/511a6d293bcf55055f56cc9d79f6f14348d583f9"}]},"branch":"refs/heads/master"},"822cd64c0718b46a065abbb8709f6b466d12e708":{"kind":"REWORK","_number":8,"created":"2013-07-15 08:50:54.000000000","uploader":{"_account_id":7817,"name":"Thomas Leaman","email":"thomas.leaman@hp.com","username":"bugsduggan"},"ref":"refs/changes/64/33464/8","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/64/33464/8","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/64/33464/8 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/64/33464/8 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/64/33464/8 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/64/33464/8"}}},"commit":{"parents":[{"commit":"842720801550ff335122b2f2e4837a18aed25081","subject":"Merge \"Rename invalid domain name to be RFC compliant.\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/842720801550ff335122b2f2e4837a18aed25081"}]}],"author":{"name":"Thomas Leaman","email":"thomas.leaman@hp.com","date":"2013-06-18 15:34:45.000000000","tz":0},"committer":{"name":"Thomas Leaman","email":"thomas.leaman@hp.com","date":"2013-07-15 08:50:17.000000000","tz":0},"subject":"Fix SSL certificate CNAME checking","message":"Fix SSL certificate CNAME checking\n\nCurrently, accessing a host via ip address will pass SSL verification;\nthe CNAME is not checked as intended as part of verify_callback.\n\n\u0027preverify_ok is True\u0027 will always return false (int/bool comparison).\npreverify_ok will be 1 if preverification has passed.\n\nFixes bug 1192229\n\nChange-Id: Ib651548ab4289295a9b92ee039b2aff2d08aba5f\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/822cd64c0718b46a065abbb8709f6b466d12e708"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/822cd64c0718b46a065abbb8709f6b466d12e708"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}