)]}'
{"id":"openstack%2Fpython-glanceclient~33884","triplet_id":"openstack%2Fpython-glanceclient~master~I3a973da3b962c7572ae0f61f6996bdd1f0048339","project":"openstack/python-glanceclient","branch":"master","topic":"bug/1179392","hashtags":[],"change_id":"I3a973da3b962c7572ae0f61f6996bdd1f0048339","subject":"HTTPS response issues","status":"MERGED","created":"2013-06-20 21:02:28.000000000","updated":"2013-07-24 22:11:08.000000000","submitted":"2013-07-24 22:11:08.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"07c84bd3d5e4e2f7a15c3d21e888b19e27b69c97","_number":33884,"virtual_id_number":33884,"owner":{"_account_id":5313,"name":"David Peraza","email":"david_peraza@persistentsys.com","username":"dperaza"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":5313,"name":"David Peraza","email":"david_peraza@persistentsys.com","username":"dperaza"},{"value":2,"date":"2013-07-24 22:11:08.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},{"value":0,"_account_id":616,"name":"Mark Washenberger","email":"mark.washenberger@markwash.net","username":"markwash"},{"value":0,"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},{"value":0,"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"all":[{"value":0,"_account_id":5313,"name":"David Peraza","email":"david_peraza@persistentsys.com","username":"dperaza"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2013-07-22 15:36:08.000000000","_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},{"value":2,"date":"2013-07-24 20:25:14.000000000","_account_id":616,"name":"Mark Washenberger","email":"mark.washenberger@markwash.net","username":"markwash"},{"value":0,"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},{"value":0,"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":616,"name":"Mark Washenberger","email":"mark.washenberger@markwash.net","username":"markwash"},"all":[{"value":0,"_account_id":5313,"name":"David Peraza","email":"david_peraza@persistentsys.com","username":"dperaza"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"date":"2013-07-22 15:36:08.000000000","_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},{"value":1,"date":"2013-07-24 20:25:14.000000000","_account_id":616,"name":"Mark Washenberger","email":"mark.washenberger@markwash.net","username":"markwash"},{"value":0,"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},{"value":0,"date":"2013-07-23 07:14:06.000000000","_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":5313,"name":"David Peraza","email":"david_peraza@persistentsys.com","username":"dperaza"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},{"value":0,"_account_id":616,"name":"Mark Washenberger","email":"mark.washenberger@markwash.net","username":"markwash"},{"value":0,"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},{"value":0,"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Top Priority / Holds Gate"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},{"_account_id":616,"name":"Mark Washenberger","email":"mark.washenberger@markwash.net","username":"markwash"},{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},{"_account_id":5313,"name":"David Peraza","email":"david_peraza@persistentsys.com","username":"dperaza"},{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-07-18 09:37:07.000000000","updated_by":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"reviewer":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"state":"REVIEWER"},{"updated":"2013-07-22 15:36:08.000000000","updated_by":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"reviewer":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"state":"REVIEWER"},{"updated":"2013-07-23 07:14:06.000000000","updated_by":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"reviewer":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"state":"REVIEWER"},{"updated":"2013-07-24 20:25:14.000000000","updated_by":{"_account_id":616,"name":"Mark Washenberger","email":"mark.washenberger@markwash.net","username":"markwash"},"reviewer":{"_account_id":616,"name":"Mark Washenberger","email":"mark.washenberger@markwash.net","username":"markwash"},"state":"REVIEWER"},{"updated":"2013-07-24 22:11:08.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"0902ea18eacbc5d083d5a6f1218411b1389554ba","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-06-20 21:55:35.000000000","message":"Patch Set 1: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/33884/1/check/gate-python-glanceclient-pep8/830 : SUCCESS in 43s\n- http://docs-draft.openstack.org/33884/1/check/gate-python-glanceclient-docs/762/doc/build/html/ : SUCCESS in 47s\n- http://logs.openstack.org/33884/1/check/gate-python-glanceclient-python26/825 : SUCCESS in 1m 40s\n- http://logs.openstack.org/33884/1/check/gate-python-glanceclient-python27/823 : SUCCESS in 48s\n- http://logs.openstack.org/33884/1/check/gate-tempest-devstack-vm-full/25135 : SUCCESS in 51m 21s\n- http://logs.openstack.org/33884/1/check/gate-tempest-devstack-vm-postgres-full/24841 : SUCCESS in 42m 42s\n- http://logs.openstack.org/33884/1/check/gate-tempest-devstack-vm-quantum/32658 : SUCCESS in 18m 11s\n- http://logs.openstack.org/33884/1/check/gate-grenade-devstack-vm/11869 : FAILURE in 40m 27s (non-voting)\n","accounts_in_message":[],"_revision_number":1},{"id":"7c380f0fab173446d123b7e0ce7bae2d3443dcdb","author":{"_account_id":5313,"name":"David Peraza","email":"david_peraza@persistentsys.com","username":"dperaza"},"date":"2013-06-26 21:12:46.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"710938af4bac4f1dba79bd002e97c82fb10b1533","author":{"_account_id":5313,"name":"David Peraza","email":"david_peraza@persistentsys.com","username":"dperaza"},"date":"2013-06-26 22:07:20.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"2b40f841289a936593e9fd68f7742bcfdb683001","author":{"_account_id":5313,"name":"David Peraza","email":"david_peraza@persistentsys.com","username":"dperaza"},"date":"2013-06-26 22:13:16.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"194cd012dbc36bbdfe560f7a09169dba577113d4","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-06-26 23:00:15.000000000","message":"Patch Set 4: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/33884/4/check/gate-python-glanceclient-pep8/842 : SUCCESS in 45s\n- http://docs-draft.openstack.org/33884/4/check/gate-python-glanceclient-docs/774/doc/build/html/ : SUCCESS in 51s\n- http://logs.openstack.org/33884/4/check/gate-python-glanceclient-python26/837 : SUCCESS in 1m 21s\n- http://logs.openstack.org/33884/4/check/gate-python-glanceclient-python27/835 : SUCCESS in 55s\n- http://logs.openstack.org/33884/4/check/gate-tempest-devstack-vm-full/26592 : SUCCESS in 42m 15s\n- http://logs.openstack.org/33884/4/check/gate-tempest-devstack-vm-postgres-full/26298 : SUCCESS in 46m 54s\n- http://logs.openstack.org/33884/4/check/gate-tempest-devstack-vm-quantum/34252 : SUCCESS in 18m 07s\n- http://logs.openstack.org/33884/4/check/gate-grenade-devstack-vm/13145 : FAILURE in 21m 58s (non-voting)\n","accounts_in_message":[],"_revision_number":4},{"id":"4ed57c74983afef59dbf563b11d3d88f7fc3fa34","author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"date":"2013-06-27 10:10:35.000000000","message":"Patch Set 4:\n\nDavid, thanks for your patch.\n\nI wonder if this should be pushed up as two distinct patches -- one for the float fix and one for the close fix?","accounts_in_message":[],"_revision_number":4},{"id":"11dbf3284fe4fc0f7e69e3d81077b2f6ee505cfe","author":{"_account_id":5313,"name":"David Peraza","email":"david_peraza@persistentsys.com","username":"dperaza"},"date":"2013-06-27 18:35:11.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"462892dbdb6332e13f700bd4714b689ac5aee52b","author":{"_account_id":5313,"name":"David Peraza","email":"david_peraza@persistentsys.com","username":"dperaza"},"date":"2013-06-27 18:38:07.000000000","message":"Uploaded patch set 6.","accounts_in_message":[],"_revision_number":6},{"id":"21584c337bf383179d3292957a9a7ab20588989e","author":{"_account_id":5494,"name":"Trivial Rebase","email":"trivial-rebase@review.openstack.org","username":"trivial-rebase"},"date":"2013-06-27 18:38:14.000000000","message":"Patch Set 6:\n\nNew patchset patch-id matches previous patchset, but whitespace content has changed.","accounts_in_message":[],"_revision_number":6},{"id":"ba7cf71429df61d912e6d5e426914e5c846f8728","author":{"_account_id":5313,"name":"David Peraza","email":"david_peraza@persistentsys.com","username":"dperaza"},"date":"2013-06-27 19:06:39.000000000","message":"Patch Set 6:\n\nStuart, I\u0027m OK braking into two patches if folks feel strong about it, the change for the warning is a one char change, small enough to bundle with this","accounts_in_message":[],"_revision_number":6},{"id":"c96d22d310863ba74804eaf6fb8fb6f811d5ddf0","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-06-27 19:30:28.000000000","message":"Patch Set 6: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/33884/6/check/gate-python-glanceclient-pep8/845 : SUCCESS in 52s\n- http://docs-draft.openstack.org/33884/6/check/gate-python-glanceclient-docs/777/doc/build/html/ : SUCCESS in 55s\n- http://logs.openstack.org/33884/6/check/gate-python-glanceclient-python26/840 : SUCCESS in 1m 11s\n- http://logs.openstack.org/33884/6/check/gate-python-glanceclient-python27/838 : SUCCESS in 57s\n- http://logs.openstack.org/33884/6/check/gate-tempest-devstack-vm-full/26879 : SUCCESS in 52m 12s\n- http://logs.openstack.org/33884/6/check/gate-tempest-devstack-vm-postgres-full/26585 : SUCCESS in 49m 11s\n- http://logs.openstack.org/33884/6/check/gate-tempest-devstack-vm-quantum/34573 : SUCCESS in 16m 57s\n- http://logs.openstack.org/33884/6/check/gate-grenade-devstack-vm/13388 : FAILURE in 25m 27s (non-voting)\n","accounts_in_message":[],"_revision_number":6},{"id":"dcdfdbbaffc28ecabea4c719c3dacfc805b49c5b","author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"date":"2013-07-01 13:19:16.000000000","message":"Patch Set 6:\n\nHi David,\n\nWould you be able to suggest a way for me to reproduce \nthe .close problem?\n\n(If possible I\u0027d like to do this testing on Ubuntu -- should that be possible or is the behaviour specific to CentOS/Fedora?)\n\nThanks.","accounts_in_message":[],"_revision_number":6},{"id":"878d0967a582bedd4c50793ae6b0105146b0db55","author":{"_account_id":5313,"name":"David Peraza","email":"david_peraza@persistentsys.com","username":"dperaza"},"date":"2013-07-01 14:41:35.000000000","message":"Patch Set 6:\n\nI\u0027ve been able to replicate on RHEL image with endpoint setup with ssl. That is you are accessing glance server over HTTPs. Calls to HTTPResponse will access the file associated with socket, if socket is closed prior to reads from http response, you should get the (9, Bad file descriptor) error. This fix simply delays the socket close until the file associated with socket is closed through the response.close call.","accounts_in_message":[],"_revision_number":6},{"id":"324a6050ad6f5df0f78d885ca6adac794a1f0b1c","author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"date":"2013-07-01 14:49:13.000000000","message":"Patch Set 6:\n\nHi David,\n\nI\u0027m making requests to a https glance server (running on Ubuntu) but am not able to reproduce the bad file descripter behaviour.\n\nIs there anything in particular I can do to ensure that the\nsocket is closed prior to reads from http response (the required condition to reproduce the failure)? \n\nThanks.","accounts_in_message":[],"_revision_number":6},{"id":"40df559451186236e69e829600c68ce7f03572cf","author":{"_account_id":5313,"name":"David Peraza","email":"david_peraza@persistentsys.com","username":"dperaza"},"date":"2013-07-01 17:13:31.000000000","message":"Patch Set 6:\n\nI think the easiest thing to do to replicate is to run glanceclient in little rhel VM. I think reference counting might be different in rhel and ubuntu and that is why there is some timing difference, another thing that might be different is that ubuntu precise or up will come with phython 2.7 by default, rhel 6.4 still comes with python 2.6","accounts_in_message":[],"_revision_number":6},{"id":"910b9e5190ed3a3c3b72b65d2ba0f50a13999760","author":{"_account_id":5313,"name":"David Peraza","email":"david_peraza@persistentsys.com","username":"dperaza"},"date":"2013-07-01 17:18:53.000000000","message":"Patch Set 6:\n\nStuart, something else I notice is that my header back from and image list response returns connection: close as one of the headers which is what then causes the will_close var in httplib to be set to true and the HTTPConnection.close to be called before HTTPResponse is returned back.","accounts_in_message":[],"_revision_number":6},{"id":"cb652f389529764e2dbff263d90f0369a3105997","author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"date":"2013-07-08 15:32:23.000000000","message":"Patch Set 6:\n\nDavid,\n\nThanks for the additional info. A bit short on time to test this right now, but its on my todo list.","accounts_in_message":[],"_revision_number":6},{"id":"766a6142f6c3365f4823f6714e341038dbf3d9ad","author":{"_account_id":5313,"name":"David Peraza","email":"david_peraza@persistentsys.com","username":"dperaza"},"date":"2013-07-16 14:16:27.000000000","message":"Patch Set 6:\n\nStuart, any luck replicating this one? We consistently hit these in our RHEL 6.4 systems","accounts_in_message":[],"_revision_number":6},{"id":"b3ba165432f3537052e3e5d29b0aa75ec735f5a1","author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"date":"2013-07-18 09:37:07.000000000","message":"Patch Set 6:\n\nhttps://bugs.launchpad.net/python-glanceclient/+bug/1179392/comments/14","accounts_in_message":[],"_revision_number":6},{"id":"f552951eb585c8adc32eb0260b309425e28ae0d0","author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"date":"2013-07-18 15:41:31.000000000","message":"Patch Set 6:\n\nDavid,\n\nI hacked my glance-api to inject \u0027Connection: close\u0027 into the set of headers returned back to an image-list:\n\nThis gave me:\n\n$ glance -k -A XXX -U https://localhost:9292 image-list\nCould not decode response body as JSON\nstring indices must be integers, not str\n\nIs this the same behaviour as you\u0027re seeing?","accounts_in_message":[],"_revision_number":6},{"id":"73eb2603e2fe4a25655ca88dc9cfd4d0291b7365","author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"date":"2013-07-18 15:47:49.000000000","message":"Patch Set 6:\n\nApplying the patch makes image-list work again.\n\nIf you can confirm that I reproduced I\u0027m good to +1 here.","accounts_in_message":[],"_revision_number":6},{"id":"7cbc29a89081904bef65d60367abfc275efad9b3","author":{"_account_id":5313,"name":"David Peraza","email":"david_peraza@persistentsys.com","username":"dperaza"},"date":"2013-07-18 17:27:07.000000000","message":"Patch Set 6:\n\nStuart, no what we see is a socket error 9 like this:\n\n(9, \u0027Bad file descriptor\u0027)","accounts_in_message":[],"_revision_number":6},{"id":"77afcec0b3f84d4dc3b9bf2f21950d124930d285","author":{"_account_id":5313,"name":"David Peraza","email":"david_peraza@persistentsys.com","username":"dperaza"},"date":"2013-07-18 18:03:38.000000000","message":"Patch Set 6:\n\nStuart and Paul https://bugs.launchpad.net/python-glanceclient/+bug/1179392/comments/15\n\nCan you try running glance client with the --insecure flag?","accounts_in_message":[],"_revision_number":6},{"id":"31442a44e5dfa83354f3d688663cf3e7b35e05bf","author":{"_account_id":5313,"name":"David Peraza","email":"david_peraza@persistentsys.com","username":"dperaza"},"date":"2013-07-18 20:14:14.000000000","message":"Patch Set 6:\n\nDetails on systems where we see this issue https://bugs.launchpad.net/python-glanceclient/+bug/1179392/comments/16, we actually run into this in havana.","accounts_in_message":[],"_revision_number":6},{"id":"71aca1fbd911b68d83f617460a83473a10c3fe9f","author":{"_account_id":5313,"name":"David Peraza","email":"david_peraza@persistentsys.com","username":"dperaza"},"date":"2013-07-18 20:27:40.000000000","message":"Patch Set 6:\n\nStuart, one way you can simulate is by hacking def _check_close(self): under httplib to always return True regardless of header connection. That will cause this line to always evaluate true under HTTPResponse\n\n# will the connection close at the end of the response?\n        self.will_close \u003d self._check_close()","accounts_in_message":[],"_revision_number":6},{"id":"777f308cbcca63e42ef19b6c9d8f8e6dea57202d","author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"date":"2013-07-19 09:37:39.000000000","message":"Patch Set 6:\n\nDavid,\n\nMaking my change (to context.py to add the \u0027Connection: close\u0027 header), this time on Fedora, reproduced:\n\n$ glance -A `cat token` -U https://localhost:9292 -k image-list\n(9, \u0027Bad file descriptor\u0027)\n\n\nLooking again at this context.py hack running on Ubuntu with strace I see that I\u0027m also getting EBADF:\n\nread(3, 0x16da453, 5)                   \u003d -1 EBADF (Bad file descriptor)\n\nit happens to be a read rather than a write -- hence the different symptom.","accounts_in_message":[],"_revision_number":6},{"id":"fa467dca66cabc725f00a91794eae3d406258225","author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"date":"2013-07-19 09:44:50.000000000","message":"Patch Set 6:\n\nSo based on the observation that the presence of a \"connection: close\" header is enough to make the client fall over, I think it should be possible to add a functional test for this.","accounts_in_message":[],"_revision_number":6},{"id":"136a3e0e607a3ffc3a9dcba44d1ac97e98575d4e","author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"date":"2013-07-19 09:52:39.000000000","message":"Patch Set 6:\n\nPaul,\n\nI think there\u0027s a gap generally in https testing (both on the server and client side). Based on the pain being experienced by the RHAT based distros by this bug I\u0027d be inclined to accept this fix without gating it on the more general https testing issue.\n\nDavid,\n\nI\u0027m going to do a little more functional testing (on Ubuntu) to verify the fix. Expect something back from me soon.","accounts_in_message":[],"_revision_number":6},{"id":"ebfeb58f16004f2ec6aeee77c7423ddddf7a6957","author":{"_account_id":5313,"name":"David Peraza","email":"david_peraza@persistentsys.com","username":"dperaza"},"date":"2013-07-19 20:40:51.000000000","message":"Patch Set 6:\n\nGreat to hear back for you Stuart and Paul, will be alert for feedback on this","accounts_in_message":[],"_revision_number":6},{"id":"7ff4ba1170921b91cb8dd4c842d93e9444c1f8bf","author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"date":"2013-07-22 14:40:16.000000000","message":"Patch Set 6: (1 inline comment)\n\nDavid,\n\nI\u0027ve run some more functional tests with this patch on Ubuntu (without the connection:close header), just to check for any regression: mainly parallel uploads/downloads/deletes. All looks fine.\n\nIf you think its appropriate to make the minor comment change I can +1 for you.\n\nAlso, I pinged Flavio -- he may be interested seeing as this issue affects redhat.","accounts_in_message":[],"_revision_number":6},{"id":"8668e4c361a87ce7e556c10b9126754bf2450dc1","author":{"_account_id":5313,"name":"David Peraza","email":"david_peraza@persistentsys.com","username":"dperaza"},"date":"2013-07-22 15:33:39.000000000","message":"Uploaded patch set 7.","accounts_in_message":[],"_revision_number":7},{"id":"83180991d778c8df9503aded87381c10888448bb","author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"date":"2013-07-22 15:36:08.000000000","message":"Patch Set 7: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":7},{"id":"5c4620b105e54c8ee27c41d36051ec73bc6cc5b7","author":{"_account_id":5313,"name":"David Peraza","email":"david_peraza@persistentsys.com","username":"dperaza"},"date":"2013-07-22 15:36:27.000000000","message":"Patch Set 6: (1 inline comment)\n\nThanks for your review","accounts_in_message":[],"_revision_number":6},{"id":"f0e9f863af6ac188f2b8a7ecffacf15e9fcd6f3a","author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"date":"2013-07-22 15:38:44.000000000","message":"Patch Set 7:\n\nThanks for your patch :-)","accounts_in_message":[],"_revision_number":7},{"id":"a74a637fc4a0b60a617a751a41525678204db21a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-07-22 17:50:47.000000000","message":"Patch Set 7: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/84/33884/7/check/gate-python-glanceclient-pep8/924 : SUCCESS in 1m 23s\n- http://docs-draft.openstack.org/84/33884/7/check/gate-python-glanceclient-docs/856/doc/build/html/ : SUCCESS in 50s\n- http://logs.openstack.org/84/33884/7/check/gate-python-glanceclient-python26/919 : SUCCESS in 1m 16s\n- http://logs.openstack.org/84/33884/7/check/gate-python-glanceclient-python27/917 : SUCCESS in 53s\n- http://logs.openstack.org/84/33884/7/check/gate-tempest-devstack-vm-full/34429 : SUCCESS in 47m 21s\n- http://logs.openstack.org/84/33884/7/check/gate-tempest-devstack-vm-cells-full/2002 : FAILURE in 15m 34s (non-voting)\n- http://logs.openstack.org/84/33884/7/check/gate-tempest-devstack-vm-testr-full/848 : SUCCESS in 31m 17s (non-voting)\n- http://logs.openstack.org/84/33884/7/check/gate-tempest-devstack-vm-postgres-full/34119 : SUCCESS in 46m 55s\n- http://logs.openstack.org/84/33884/7/check/gate-tempest-devstack-vm-neutron/6244 : SUCCESS in 19m 28s (non-voting)\n- http://logs.openstack.org/84/33884/7/check/gate-grenade-devstack-vm/20116 : SUCCESS in 27m 17s\n","accounts_in_message":[],"_revision_number":7},{"id":"463dab124f4feda4d90bd85e9743ff0f8bb76653","author":{"_account_id":616,"name":"Mark Washenberger","email":"mark.washenberger@markwash.net","username":"markwash"},"date":"2013-07-24 20:25:14.000000000","message":"Patch Set 7: Looks good to me (core reviewer); Approved\n\n","accounts_in_message":[],"_revision_number":7},{"id":"55e12293c6b193fd32508d5b034bc10892aca7aa","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-07-24 20:25:15.000000000","message":"Patch Set 7: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":7},{"id":"6bc319911423714e26a5c42aa419b8714ab7571d","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-07-24 22:11:08.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":7},{"id":"7feee83cedf8f20aae45132893d37bf804ca7e80","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-07-24 22:11:08.000000000","message":"Patch Set 7: Verified\n\nBuild succeeded.\n\n- http://docs-draft.openstack.org/84/33884/7/gate/gate-python-glanceclient-docs/862/doc/build/html/ : SUCCESS in 1m 28s\n- http://logs.openstack.org/84/33884/7/gate/gate-python-glanceclient-pep8/930 : SUCCESS in 49s\n- http://logs.openstack.org/84/33884/7/gate/gate-python-glanceclient-python26/925 : SUCCESS in 1m 39s\n- http://logs.openstack.org/84/33884/7/gate/gate-python-glanceclient-python27/923 : SUCCESS in 54s\n- http://logs.openstack.org/84/33884/7/gate/gate-tempest-devstack-vm-full/35272 : SUCCESS in 46m 32s\n- http://logs.openstack.org/84/33884/7/gate/gate-tempest-devstack-vm-postgres-full/34960 : SUCCESS in 47m 11s\n- http://logs.openstack.org/84/33884/7/gate/gate-tempest-devstack-vm-neutron/7204 : SUCCESS in 23m 01s (non-voting)\n- http://logs.openstack.org/84/33884/7/gate/gate-grenade-devstack-vm/20893 : SUCCESS in 24m 08s\n","accounts_in_message":[],"_revision_number":7}],"current_revision_number":7,"current_revision":"5d90740f33d80db5559becc0cc619d965a4bb292","revisions":{"beed7f5edaeb7feae71a1f1fdc514f13723c4408":{"kind":"REWORK","_number":1,"created":"2013-06-20 21:02:28.000000000","uploader":{"_account_id":5313,"name":"David Peraza","email":"david_peraza@persistentsys.com","username":"dperaza"},"ref":"refs/changes/84/33884/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/84/33884/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/84/33884/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/84/33884/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/84/33884/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/84/33884/1"}}},"commit":{"parents":[{"commit":"c120aff87fa3d7ee8a53ec7a655389d069d88187","subject":"Merge \"Fix problem where image data is not read from a pipe.\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/c120aff87fa3d7ee8a53ec7a655389d069d88187"}]}],"author":{"name":"David Peraza","email":"dperaza@linux.vnet.ibm.com","date":"2013-06-20 20:53:08.000000000","tz":0},"committer":{"name":"David Peraza","email":"dperaza@linux.vnet.ibm.com","date":"2013-06-20 21:02:27.000000000","tz":0},"subject":"Provides the expected struc format for https timeout","message":"Provides the expected struc format for https timeout\n\nFixes bug 1179392\n\nglanceclient.common.http.HTTPClient.get_connection_kwargs method\nexplicitly sets the timeout to be a float, while struc.pack is\nstill using LL as the format string which means 2 Long Integers.\nSetting format string to fL which mean a float followed by Long\nInteger.\n\nChange-Id: I3a973da3b962c7572ae0f61f6996bdd1f0048339\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/beed7f5edaeb7feae71a1f1fdc514f13723c4408"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/beed7f5edaeb7feae71a1f1fdc514f13723c4408"}]},"branch":"refs/heads/master"},"11e580be6b6856cdaffac522efa3d906bac08780":{"kind":"REWORK","_number":2,"created":"2013-06-26 21:12:46.000000000","uploader":{"_account_id":5313,"name":"David Peraza","email":"david_peraza@persistentsys.com","username":"dperaza"},"ref":"refs/changes/84/33884/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/84/33884/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/84/33884/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/84/33884/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/84/33884/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/84/33884/2"}}},"commit":{"parents":[{"commit":"d8a537c7fe9b1e455831d05d9ba0ab67e03fb3a5","subject":"Removes extra slash on endpoints without a path","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/d8a537c7fe9b1e455831d05d9ba0ab67e03fb3a5"}]}],"author":{"name":"David Peraza","email":"dperaza@linux.vnet.ibm.com","date":"2013-06-20 20:53:08.000000000","tz":0},"committer":{"name":"David Peraza","email":"dperaza@linux.vnet.ibm.com","date":"2013-06-26 21:05:09.000000000","tz":0},"subject":"HTTPS response issues","message":"HTTPS response issues\n\nFixes bug 1179392\n\nglanceclient.common.http.HTTPClient.get_connection_kwargs method\nexplicitly sets the timeout to be a float, while struc.pack is\nstill using LL as the format string which means 2 Long Integers.\nSetting format string to fL which mean a float followed by Long\nInteger.\n\nAlso, Bad file descriptor error is caused by socket being closed\nto soon. Added a close() implementation to VerifiedHTTPSConnection\nwhich will remove reference to socket before returning call to\nbase HTTPConnection.close(). This will avoid socket to be closed\nbefore response body is read. Socket will close when response\nclose is called.\n\nChange-Id: I3a973da3b962c7572ae0f61f6996bdd1f0048339\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/11e580be6b6856cdaffac522efa3d906bac08780"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/11e580be6b6856cdaffac522efa3d906bac08780"}]},"branch":"refs/heads/master"},"f7e6a15f3e9447a000650b7379996d2e20eb1882":{"kind":"REWORK","_number":3,"created":"2013-06-26 22:07:20.000000000","uploader":{"_account_id":5313,"name":"David Peraza","email":"david_peraza@persistentsys.com","username":"dperaza"},"ref":"refs/changes/84/33884/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/84/33884/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/84/33884/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/84/33884/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/84/33884/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/84/33884/3"}}},"commit":{"parents":[{"commit":"d8a537c7fe9b1e455831d05d9ba0ab67e03fb3a5","subject":"Removes extra slash on endpoints without a path","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/d8a537c7fe9b1e455831d05d9ba0ab67e03fb3a5"}]}],"author":{"name":"David Peraza","email":"dperaza@linux.vnet.ibm.com","date":"2013-06-20 20:53:08.000000000","tz":0},"committer":{"name":"David Peraza","email":"dperaza@linux.vnet.ibm.com","date":"2013-06-26 22:07:11.000000000","tz":0},"subject":"HTTPS response issues","message":"HTTPS response issues\n\nFixes bug 1179392\n\nglanceclient.common.http.HTTPClient.get_connection_kwargs method\nexplicitly sets the timeout to be a float, while struc.pack is\nstill using LL as the format string which means 2 Long Integers.\nSetting format string to fL which mean a float followed by Long\nInteger.\n\nAlso, Bad file descriptor error is caused by socket being closed\nto soon. Added a close() implementation to VerifiedHTTPSConnection\nwhich will remove reference to socket before returning call to\nbase HTTPConnection.close(). This will avoid socket to be closed\nbefore response body is read. Socket will close when response\nclose is called.\n\nChange-Id: I3a973da3b962c7572ae0f61f6996bdd1f0048339\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/f7e6a15f3e9447a000650b7379996d2e20eb1882"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/f7e6a15f3e9447a000650b7379996d2e20eb1882"}]},"branch":"refs/heads/master"},"39c00d8906d1e381469082e76e98011277db30a6":{"kind":"REWORK","_number":4,"created":"2013-06-26 22:13:16.000000000","uploader":{"_account_id":5313,"name":"David Peraza","email":"david_peraza@persistentsys.com","username":"dperaza"},"ref":"refs/changes/84/33884/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/84/33884/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/84/33884/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/84/33884/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/84/33884/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/84/33884/4"}}},"commit":{"parents":[{"commit":"d8a537c7fe9b1e455831d05d9ba0ab67e03fb3a5","subject":"Removes extra slash on endpoints without a path","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/d8a537c7fe9b1e455831d05d9ba0ab67e03fb3a5"}]}],"author":{"name":"David Peraza","email":"dperaza@linux.vnet.ibm.com","date":"2013-06-20 20:53:08.000000000","tz":0},"committer":{"name":"David Peraza","email":"dperaza@linux.vnet.ibm.com","date":"2013-06-26 22:13:08.000000000","tz":0},"subject":"HTTPS response issues","message":"HTTPS response issues\n\nFixes bug 1179392\n\nglanceclient.common.http.HTTPClient.get_connection_kwargs method\nexplicitly sets the timeout to be a float, while struc.pack is\nstill using LL as the format string which means 2 Long Integers.\nSetting format string to fL which mean a float followed by Long\nInteger.\n\nAlso, Bad file descriptor error is caused by socket being closed\nto soon. Added a close() implementation to VerifiedHTTPSConnection\nwhich will remove reference to socket before returning call to\nbase HTTPConnection.close(). This will avoid socket to be closed\nbefore response body is read. Socket will close when response\nclose is called.\n\nChange-Id: I3a973da3b962c7572ae0f61f6996bdd1f0048339\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/39c00d8906d1e381469082e76e98011277db30a6"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/39c00d8906d1e381469082e76e98011277db30a6"}]},"branch":"refs/heads/master"},"2da750e13bc3adbb02f341ea3c3e4cbbeb1e0abc":{"kind":"REWORK","_number":5,"created":"2013-06-27 18:35:11.000000000","uploader":{"_account_id":5313,"name":"David Peraza","email":"david_peraza@persistentsys.com","username":"dperaza"},"ref":"refs/changes/84/33884/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/84/33884/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/84/33884/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/84/33884/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/84/33884/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/84/33884/5"}}},"commit":{"parents":[{"commit":"d8a537c7fe9b1e455831d05d9ba0ab67e03fb3a5","subject":"Removes extra slash on endpoints without a path","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/d8a537c7fe9b1e455831d05d9ba0ab67e03fb3a5"}]}],"author":{"name":"David Peraza","email":"dperaza@linux.vnet.ibm.com","date":"2013-06-20 20:53:08.000000000","tz":0},"committer":{"name":"David Peraza","email":"dperaza@linux.vnet.ibm.com","date":"2013-06-27 18:34:57.000000000","tz":0},"subject":"HTTPS response issues","message":"HTTPS response issues\n\nFixes bug 1179392\n\nglanceclient.common.http.HTTPClient.get_connection_kwargs method\nexplicitly sets the timeout to be a float, while struc.pack is\nstill using LL as the format string which means 2 Long Integers.\nSetting format string to fL which mean a float followed by Long\nInteger.\n\nAlso, Bad file descriptor error is caused by socket being closed\nto soon. Added a close() implementation to VerifiedHTTPSConnection\nwhich will remove reference to socket before returning call to\nbase HTTPConnection.close(). This will avoid socket to be closed\nbefore response body is read. Socket will close when response\nclose is called.\n\nChange-Id: I3a973da3b962c7572ae0f61f6996bdd1f0048339\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/2da750e13bc3adbb02f341ea3c3e4cbbeb1e0abc"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/2da750e13bc3adbb02f341ea3c3e4cbbeb1e0abc"}]},"branch":"refs/heads/master"},"c9642058539267a20bc34dcf97c6b4dc37007eb9":{"kind":"REWORK","_number":6,"created":"2013-06-27 18:38:07.000000000","uploader":{"_account_id":5313,"name":"David Peraza","email":"david_peraza@persistentsys.com","username":"dperaza"},"ref":"refs/changes/84/33884/6","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/84/33884/6","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/84/33884/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/84/33884/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/84/33884/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/84/33884/6"}}},"commit":{"parents":[{"commit":"d8a537c7fe9b1e455831d05d9ba0ab67e03fb3a5","subject":"Removes extra slash on endpoints without a path","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/d8a537c7fe9b1e455831d05d9ba0ab67e03fb3a5"}]}],"author":{"name":"David Peraza","email":"dperaza@linux.vnet.ibm.com","date":"2013-06-20 20:53:08.000000000","tz":0},"committer":{"name":"David Peraza","email":"dperaza@linux.vnet.ibm.com","date":"2013-06-27 18:38:00.000000000","tz":0},"subject":"HTTPS response issues","message":"HTTPS response issues\n\nFixes bug 1179392\n\nglanceclient.common.http.HTTPClient.get_connection_kwargs method\nexplicitly sets the timeout to be a float, while struc.pack is\nstill using LL as the format string which means 2 Long Integers.\nSetting format string to fL which mean a float followed by Long\nInteger.\n\nAlso, Bad file descriptor error is caused by socket being closed\nto soon. Added a close() implementation to VerifiedHTTPSConnection\nwhich will remove reference to socket before returning call to\nbase HTTPConnection.close(). This will avoid socket to be closed\nbefore response body is read. Socket will close when response\nclose is called.\n\nChange-Id: I3a973da3b962c7572ae0f61f6996bdd1f0048339\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/c9642058539267a20bc34dcf97c6b4dc37007eb9"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/c9642058539267a20bc34dcf97c6b4dc37007eb9"}]},"branch":"refs/heads/master"},"5d90740f33d80db5559becc0cc619d965a4bb292":{"kind":"REWORK","_number":7,"created":"2013-07-22 15:33:39.000000000","uploader":{"_account_id":5313,"name":"David Peraza","email":"david_peraza@persistentsys.com","username":"dperaza"},"ref":"refs/changes/84/33884/7","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/84/33884/7","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/84/33884/7 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/84/33884/7 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/84/33884/7 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/84/33884/7"}}},"commit":{"parents":[{"commit":"093064caa8335e5190170bf6b1d6af60841485cd","subject":"Merge \"Increase default page_size value\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/093064caa8335e5190170bf6b1d6af60841485cd"}]}],"author":{"name":"David Peraza","email":"dperaza@linux.vnet.ibm.com","date":"2013-06-20 20:53:08.000000000","tz":0},"committer":{"name":"David Peraza","email":"dperaza@linux.vnet.ibm.com","date":"2013-07-22 15:33:38.000000000","tz":0},"subject":"HTTPS response issues","message":"HTTPS response issues\n\nFixes bug 1179392\n\nglanceclient.common.http.HTTPClient.get_connection_kwargs method\nexplicitly sets the timeout to be a float, while struc.pack is\nstill using LL as the format string which means 2 Long Integers.\nSetting format string to fL which mean a float followed by Long\nInteger.\n\nAlso, Bad file descriptor error is caused by socket being closed\nto soon. Added a close() implementation to VerifiedHTTPSConnection\nwhich will remove reference to socket before returning call to\nbase HTTPConnection.close(). This will avoid socket to be closed\nbefore response body is read. Socket will close when response\nclose is called.\n\nChange-Id: I3a973da3b962c7572ae0f61f6996bdd1f0048339\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/5d90740f33d80db5559becc0cc619d965a4bb292"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/5d90740f33d80db5559becc0cc619d965a4bb292"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}