)]}'
{"id":"openstack%2Fpython-glanceclient~352857","triplet_id":"openstack%2Fpython-glanceclient~master~I0e7f3fa276266e1194c0627db8c7b58e84af2eef","project":"openstack/python-glanceclient","branch":"master","topic":"equfalse","hashtags":[],"change_id":"I0e7f3fa276266e1194c0627db8c7b58e84af2eef","subject":"Change assertEqual into assertFalse or assertTrue","status":"ABANDONED","created":"2016-08-09 11:21:01.000000000","updated":"2016-08-15 14:44:15.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"b8d4b17b0e978100d328f3267f5df37bccd38eb0","_number":352857,"virtual_id_number":352857,"owner":{"_account_id":22834,"name":"liwei","email":"wei.li@easystack.cn","username":"liwei1"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},{"date":"2016-08-12 01:49:34.000000000","_account_id":22834,"name":"liwei","email":"wei.li@easystack.cn","username":"liwei1"},{"_account_id":16658,"name":"Darja Shakhray","email":"damalyavkina@gmail.com","username":"dshakhray"},{"value":1,"date":"2016-08-10 03:18:45.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},{"_account_id":17116,"name":"Niall Bunting","email":"niall.bunting@hpe.com","username":"NiallBunting"},{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"rejected":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"recommended":{"_account_id":16658,"name":"Darja Shakhray","email":"damalyavkina@gmail.com","username":"dshakhray"},"disliked":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"all":[{"value":-1,"date":"2016-08-12 08:40:31.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22834,"name":"liwei","email":"wei.li@easystack.cn","username":"liwei1"},{"value":1,"date":"2016-08-10 12:16:47.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":16658,"name":"Darja Shakhray","email":"damalyavkina@gmail.com","username":"dshakhray"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"date":"2016-08-12 21:24:24.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},{"value":-1,"date":"2016-08-11 15:49:22.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":17116,"name":"Niall Bunting","email":"niall.bunting@hpe.com","username":"NiallBunting"},{"value":-2,"date":"2016-08-12 21:23:18.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":22834,"name":"liwei","email":"wei.li@easystack.cn","username":"liwei1"},{"_account_id":16658,"name":"Darja Shakhray","email":"damalyavkina@gmail.com","username":"dshakhray"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},{"_account_id":17116,"name":"Niall Bunting","email":"niall.bunting@hpe.com","username":"NiallBunting"},{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":2},"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},{"_account_id":22834,"name":"liwei","email":"wei.li@easystack.cn","username":"liwei1"},{"_account_id":16658,"name":"Darja Shakhray","email":"damalyavkina@gmail.com","username":"dshakhray"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},{"_account_id":17116,"name":"Niall Bunting","email":"niall.bunting@hpe.com","username":"NiallBunting"},{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Top Priority / Holds Gate"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},{"_account_id":16658,"name":"Darja Shakhray","email":"damalyavkina@gmail.com","username":"dshakhray"},{"_account_id":17116,"name":"Niall Bunting","email":"niall.bunting@hpe.com","username":"NiallBunting"},{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},{"_account_id":22834,"name":"liwei","email":"wei.li@easystack.cn","username":"liwei1"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-08-10 03:18:45.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2016-08-10 12:16:47.000000000","updated_by":{"_account_id":16658,"name":"Darja Shakhray","email":"damalyavkina@gmail.com","username":"dshakhray"},"reviewer":{"_account_id":16658,"name":"Darja Shakhray","email":"damalyavkina@gmail.com","username":"dshakhray"},"state":"REVIEWER"},{"updated":"2016-08-11 15:49:22.000000000","updated_by":{"_account_id":17116,"name":"Niall Bunting","email":"niall.bunting@hpe.com","username":"NiallBunting"},"reviewer":{"_account_id":17116,"name":"Niall Bunting","email":"niall.bunting@hpe.com","username":"NiallBunting"},"state":"REVIEWER"},{"updated":"2016-08-12 08:40:31.000000000","updated_by":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"reviewer":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"state":"REVIEWER"},{"updated":"2016-08-12 21:23:18.000000000","updated_by":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"reviewer":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"state":"REVIEWER"},{"updated":"2016-08-12 21:24:24.000000000","updated_by":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"reviewer":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"state":"REVIEWER"}],"messages":[{"id":"6e85ef7052459c5379b967d679aeeae7827d401d","author":{"_account_id":22834,"name":"liwei","email":"wei.li@easystack.cn","username":"liwei1"},"date":"2016-08-09 11:21:01.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"43c370cecc67de4d0e5d0f3a3c036b6bc91cd449","author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"date":"2016-08-09 13:23:50.000000000","message":"Patch Set 1: Code-Review-1\n\nThis makes sense but we missed the following occurrences  \n\nhttps://github.com/openstack/python-glanceclient/blob/master/glanceclient/tests/unit/v1/test_image_members.py#L70\nhttps://github.com/openstack/python-glanceclient/blob/master/glanceclient/tests/unit/v1/test_image_members.py#L85\nhttps://github.com/openstack/python-glanceclient/blob/master/glanceclient/tests/unit/test_shell.py#L848","accounts_in_message":[],"_revision_number":1},{"id":"02c1cb83c06f57b673e872be2cb8403041b0308f","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-08-09 13:25:03.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-glanceclient-docs-ubuntu-xenial http://docs-draft.openstack.org/57/352857/1/check/gate-python-glanceclient-docs-ubuntu-xenial/1a80430//doc/build/html/ : SUCCESS in 2m 59s\n- gate-python-glanceclient-pep8-ubuntu-xenial http://logs.openstack.org/57/352857/1/check/gate-python-glanceclient-pep8-ubuntu-xenial/518d1e6/ : SUCCESS in 6m 27s\n- gate-python-glanceclient-python27-ubuntu-xenial http://logs.openstack.org/57/352857/1/check/gate-python-glanceclient-python27-ubuntu-xenial/ff69681/ : SUCCESS in 2m 26s\n- gate-python-glanceclient-python34 http://logs.openstack.org/57/352857/1/check/gate-python-glanceclient-python34/d7c3d7b/ : SUCCESS in 3m 28s\n- gate-python-glanceclient-python35-nv http://logs.openstack.org/57/352857/1/check/gate-python-glanceclient-python35-nv/838a1c0/ : SUCCESS in 3m 11s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-glanceclient http://logs.openstack.org/57/352857/1/check/gate-tempest-dsvm-neutron-src-python-glanceclient/06a4f98/ : SUCCESS in 1h 09m 51s\n- gate-glanceclient-dsvm-functional http://logs.openstack.org/57/352857/1/check/gate-glanceclient-dsvm-functional/04b0920/ : SUCCESS in 40m 14s\n- gate-glanceclient-dsvm-functional-identity-v3-only-nv http://logs.openstack.org/57/352857/1/check/gate-glanceclient-dsvm-functional-identity-v3-only-nv/1bea1d4/ : FAILURE in 32m 03s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"f080056d89af3ca3ba39201845fc193856352db6","author":{"_account_id":22834,"name":"liwei","email":"wei.li@easystack.cn","username":"liwei1"},"date":"2016-08-10 01:31:10.000000000","message":"Patch Set 1:\n\nthanks for your reminder. Sorry, I\u0027m late reply.","accounts_in_message":[],"_revision_number":1},{"id":"546a3c2cfdf432c6c12d69fd3d2c27ea498d6099","author":{"_account_id":22834,"name":"liwei","email":"wei.li@easystack.cn","username":"liwei1"},"date":"2016-08-10 01:34:45.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"449af61d4a2663483fb3f69e92e88a4be17f8cd3","author":{"_account_id":22834,"name":"liwei","email":"wei.li@easystack.cn","username":"liwei1"},"date":"2016-08-10 01:51:04.000000000","message":"Uploaded patch set 3: Commit message was updated.","accounts_in_message":[],"_revision_number":3},{"id":"a4d4ef0e23a54e25c245f33a99a87f6c1990f2f3","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-08-10 03:18:45.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-glanceclient-docs-ubuntu-xenial http://docs-draft.openstack.org/57/352857/3/check/gate-python-glanceclient-docs-ubuntu-xenial/91598e6//doc/build/html/ : SUCCESS in 3m 00s\n- gate-python-glanceclient-pep8-ubuntu-xenial http://logs.openstack.org/57/352857/3/check/gate-python-glanceclient-pep8-ubuntu-xenial/7e5f154/ : SUCCESS in 3m 18s\n- gate-python-glanceclient-python27-ubuntu-xenial http://logs.openstack.org/57/352857/3/check/gate-python-glanceclient-python27-ubuntu-xenial/b6e5071/ : SUCCESS in 3m 16s\n- gate-python-glanceclient-python34 http://logs.openstack.org/57/352857/3/check/gate-python-glanceclient-python34/bbb9ecc/ : SUCCESS in 3m 21s\n- gate-python-glanceclient-python35-nv http://logs.openstack.org/57/352857/3/check/gate-python-glanceclient-python35-nv/7b52c16/ : SUCCESS in 12m 52s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-glanceclient http://logs.openstack.org/57/352857/3/check/gate-tempest-dsvm-neutron-src-python-glanceclient/fe972f4/ : SUCCESS in 1h 27m 21s\n- gate-glanceclient-dsvm-functional http://logs.openstack.org/57/352857/3/check/gate-glanceclient-dsvm-functional/41114f8/ : SUCCESS in 22m 25s\n- gate-glanceclient-dsvm-functional-identity-v3-only-nv http://logs.openstack.org/57/352857/3/check/gate-glanceclient-dsvm-functional-identity-v3-only-nv/7870450/ : FAILURE in 26m 56s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"7a951f7c469aa650f6a9b6331490fb64350c0e10","author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"date":"2016-08-10 04:05:26.000000000","message":"Patch Set 3: Code-Review+1","accounts_in_message":[],"_revision_number":3},{"id":"25cc5000475e44edb82eb97778490471e70987ee","author":{"_account_id":16658,"name":"Darja Shakhray","email":"damalyavkina@gmail.com","username":"dshakhray"},"date":"2016-08-10 12:16:47.000000000","message":"Patch Set 3: Code-Review+1","accounts_in_message":[],"_revision_number":3},{"id":"16d6f6f3dbd9c6679f0829c8a8d04362b5e7bfba","author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"date":"2016-08-10 22:21:46.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"c76b9862110d7c26261b09bc88a8cc0458a10543","author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"date":"2016-08-10 22:22:42.000000000","message":"Patch Set 3: Code-Review+1","accounts_in_message":[],"_revision_number":3},{"id":"b411e54a0b7f222e7d06964b03cd9a59f4d6b051","author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"date":"2016-08-10 23:20:26.000000000","message":"Patch Set 3: Code-Review+1\n\nLooks like I wasn\u0027t paying attention. We usually don\u0027t allow the changes attempted in this patch as they are not type safe. Well, unless there is a good argument to go ahead with it.\n\nPlease see \nhttp://docs.openstack.org/developer/glance/contributing/minor-code-changes.html#tests\n\nLet me know if there\u0027s a good reason to go ahead with this.","accounts_in_message":[],"_revision_number":3},{"id":"89b095311e45e931fc06da4de5b503c19e164bbe","author":{"_account_id":17116,"name":"Niall Bunting","email":"niall.bunting@hpe.com","username":"NiallBunting"},"date":"2016-08-11 15:49:22.000000000","message":"Patch Set 3: Code-Review-1\n\nI agree with Hemanth, that we shouldn\u0027t do this as it weakens the tests.","accounts_in_message":[],"_revision_number":3},{"id":"a05d806a9d949ef564c86c54a4a595ea63efbd9f","author":{"_account_id":22834,"name":"liwei","email":"wei.li@easystack.cn","username":"liwei1"},"date":"2016-08-12 01:49:34.000000000","message":"Patch Set 3:\n\nSorry,I have view some information, but still do not understand \nwhy would weaken the test. Can you explain it.Thanks :).I think the \ntest is also maintained by the developer.Code readability is proved \nand the namber of parameters is reduced.It looks like good.","accounts_in_message":[],"_revision_number":3},{"id":"9617032f148542a2535ef20936ee4b61453052d3","author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"date":"2016-08-12 08:40:31.000000000","message":"Patch Set 3: Code-Review-1\n\nEven less keen to touch anything v1 related.","accounts_in_message":[],"_revision_number":3},{"id":"7b88b6d69ae88480fd066184f68739d814aa66ea","author":{"_account_id":17116,"name":"Niall Bunting","email":"niall.bunting@hpe.com","username":"NiallBunting"},"date":"2016-08-12 09:32:41.000000000","message":"Patch Set 3:\n\n@Li \n\nI have put this together for you: http://paste.openstack.org/show/555945/\n\nTry each line of the runTest method and it should become more apparent.","accounts_in_message":[],"_revision_number":3},{"id":"a2d699ff61e714b1f9d7cf3e2cb8fb6f839f3549","author":{"_account_id":17116,"name":"Niall Bunting","email":"niall.bunting@hpe.com","username":"NiallBunting"},"date":"2016-08-12 09:34:55.000000000","message":"Patch Set 3:\n\nhttps://docs.python.org/3/library/unittest.html#unittest.TestCase.assertTrue also mentioned in the documentation.","accounts_in_message":[],"_revision_number":3},{"id":"77d4044dd725929c8d989c4c83bb445cd3609525","author":{"_account_id":22834,"name":"liwei","email":"wei.li@easystack.cn","username":"liwei1"},"date":"2016-08-12 10:47:20.000000000","message":"Patch Set 3:\n\nThanks for your answer.that made me learn a lot. :)","accounts_in_message":[],"_revision_number":3},{"id":"31869baaf230376c75139704c4f59676ff5bf4d4","author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"date":"2016-08-12 21:23:18.000000000","message":"Patch Set 3: Code-Review-2\n\nThanks for the explanation, Niall.\n\n@Li Wei,\nIf you are convinced, can we abandon this change please?","accounts_in_message":[],"_revision_number":3},{"id":"a3b558619a3d84ab53cac6df2291aafcda6e9075","author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"date":"2016-08-12 21:24:24.000000000","message":"Patch Set 3: -Code-Review","accounts_in_message":[],"_revision_number":3},{"id":"fa3c20dfbebb34a3cc7c404641c48942604e2b15","author":{"_account_id":22834,"name":"liwei","email":"wei.li@easystack.cn","username":"liwei1"},"date":"2016-08-12 23:06:57.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":3},{"id":"150fdf3454ed188385cb0046285961e76fbea0d4","author":{"_account_id":17116,"name":"Niall Bunting","email":"niall.bunting@hpe.com","username":"NiallBunting"},"date":"2016-08-15 09:09:43.000000000","message":"Patch Set 3:\n\n@Hemanth I\u0027m adding it to the docs here: https://review.openstack.org/#/c/354659/","accounts_in_message":[],"_revision_number":3},{"id":"2930f8980732590871d2daac756bb632739864c2","author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"date":"2016-08-15 14:44:15.000000000","message":"Patch Set 3:\n\n\u003e @Hemanth I\u0027m adding it to the docs here: https://review.openstack.org/#/c/354659/\n\nThanks, Niall. Will review that patch.","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"a24007d430db641240a8306f5fffbbb76478fc7a","revisions":{"fb40505c0467de03b9a96c314d63ef903869cff1":{"kind":"REWORK","_number":1,"created":"2016-08-09 11:21:01.000000000","uploader":{"_account_id":22834,"name":"liwei","email":"wei.li@easystack.cn","username":"liwei1"},"ref":"refs/changes/57/352857/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/57/352857/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/57/352857/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/57/352857/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/57/352857/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/57/352857/1"}}},"commit":{"parents":[{"commit":"7936f173c046c07e31fb0d662e863dbd9ee60b61","subject":"Merge \"Don\u0027t update tags every time\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/7936f173c046c07e31fb0d662e863dbd9ee60b61"}]}],"author":{"name":"Li Wei","email":"wei.li@easystack.cn","date":"2016-08-09 11:16:58.000000000","tz":480},"committer":{"name":"Li Wei","email":"wei.li@easystack.cn","date":"2016-08-09 11:16:58.000000000","tz":480},"subject":"Change assertEqual into assertFalse","message":"Change assertEqual into assertFalse\n\nWe can use assertFalse instead of assertEqual to improve\ncode readability and reduce the namber of parameters.\n\nChange-Id: I0e7f3fa276266e1194c0627db8c7b58e84af2eef\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/fb40505c0467de03b9a96c314d63ef903869cff1"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/fb40505c0467de03b9a96c314d63ef903869cff1"}]},"branch":"refs/heads/master"},"88136e84b458745d9e6fce159e565a36d94d055a":{"kind":"REWORK","_number":2,"created":"2016-08-10 01:34:45.000000000","uploader":{"_account_id":22834,"name":"liwei","email":"wei.li@easystack.cn","username":"liwei1"},"ref":"refs/changes/57/352857/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/57/352857/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/57/352857/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/57/352857/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/57/352857/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/57/352857/2"}}},"commit":{"parents":[{"commit":"7936f173c046c07e31fb0d662e863dbd9ee60b61","subject":"Merge \"Don\u0027t update tags every time\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/7936f173c046c07e31fb0d662e863dbd9ee60b61"}]}],"author":{"name":"Li Wei","email":"wei.li@easystack.cn","date":"2016-08-09 11:16:58.000000000","tz":480},"committer":{"name":"Li Wei","email":"wei.li@easystack.cn","date":"2016-08-10 01:34:12.000000000","tz":480},"subject":"Change assertEqual into assertFalse","message":"Change assertEqual into assertFalse\n\nWe can use assertFalse instead of assertEqual to improve\ncode readability and reduce the namber of parameters.\n\nChange-Id: I0e7f3fa276266e1194c0627db8c7b58e84af2eef\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/88136e84b458745d9e6fce159e565a36d94d055a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/88136e84b458745d9e6fce159e565a36d94d055a"}]},"branch":"refs/heads/master"},"a24007d430db641240a8306f5fffbbb76478fc7a":{"kind":"NO_CODE_CHANGE","_number":3,"created":"2016-08-10 01:51:04.000000000","uploader":{"_account_id":22834,"name":"liwei","email":"wei.li@easystack.cn","username":"liwei1"},"ref":"refs/changes/57/352857/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/57/352857/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/57/352857/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/57/352857/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/57/352857/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/57/352857/3"}}},"commit":{"parents":[{"commit":"7936f173c046c07e31fb0d662e863dbd9ee60b61","subject":"Merge \"Don\u0027t update tags every time\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/7936f173c046c07e31fb0d662e863dbd9ee60b61"}]}],"author":{"name":"Li Wei","email":"wei.li@easystack.cn","date":"2016-08-09 11:16:58.000000000","tz":480},"committer":{"name":"Li Wei","email":"wei.li@easystack.cn","date":"2016-08-10 01:49:49.000000000","tz":480},"subject":"Change assertEqual into assertFalse or assertTrue","message":"Change assertEqual into assertFalse or assertTrue\n\nWe can use assertFalse or assertTrue instead of assertEqual to improve\ncode readability and reduce the namber of parameters.\n\nChange-Id: I0e7f3fa276266e1194c0627db8c7b58e84af2eef\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/a24007d430db641240a8306f5fffbbb76478fc7a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/a24007d430db641240a8306f5fffbbb76478fc7a"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}