)]}'
{"glanceclient/v2/shell.py":[{"author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"change_message_id":"7012d201383077a17504115052ea0b55f39c7471","unresolved":false,"context_lines":[{"line_number":26,"context_line":"@utils.arg(\u0027--owner\u0027, metavar\u003d\u0027\u003cOWNER\u003e\u0027,"},{"line_number":27,"context_line":"           help\u003d\u0027Display images owned by \u003cOWNER\u003e.\u0027)"},{"line_number":28,"context_line":"@utils.arg(\u0027--checksum\u0027, metavar\u003d\u0027\u003cCHECKSUM\u003e\u0027,"},{"line_number":29,"context_line":"           help\u003d\u0027Display image matching the checksum\u0027)"},{"line_number":30,"context_line":"def do_image_list(gc, args):"},{"line_number":31,"context_line":"    \"\"\"List images you can access.\"\"\""},{"line_number":32,"context_line":"    filter_keys \u003d [\u0027visibility\u0027, \u0027member_status\u0027, \u0027owner\u0027, \u0027checksum\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAP3%2F%2F9Vw%3D","line":29,"updated":"2013-07-08 15:24:28.000000000","message":"Minor nit: image -\u003e images","commit_id":"d2fd42f979e1ed1aafadc7eb9354bff839c858cd"}],"tests/v2/test_images.py":[{"author":{"_account_id":7780,"name":"Jared Culp","email":"jared.culp@rackspace.com","username":"jaredculp"},"change_message_id":"77e494759be7faab401b252116445537fe1ec9d0","unresolved":false,"context_lines":[{"line_number":260,"context_line":"        fake_id \u003d \u00273a4560a1-e585-443e-9b39-553b46ec92d1\u0027"},{"line_number":261,"context_line":"        filters \u003d {\u0027filters\u0027: dict([(\u0027checksum\u0027, _CHCKSUM)])}"},{"line_number":262,"context_line":"        images \u003d list(self.controller.list(**filters))"},{"line_number":263,"context_line":"        self.assertEqual(images[0].id, \u0027%s\u0027 % fake_id)"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"    def test_list_images_for_bogus_owner(self):"},{"line_number":266,"context_line":"        filters \u003d {\u0027filters\u0027: dict([(\u0027owner\u0027, _BOGUS_ID)])}"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAP3%2F%2F17w%3D","line":263,"updated":"2013-07-10 15:14:00.000000000","message":"Maybe also:\nself.assertEqual(images.length, 1) ?","commit_id":"2c695176f6a7790fca2a00ece5e705547df4bdf7"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"599a3976ab3a4c2d190c88584214158b03770630","unresolved":false,"context_lines":[{"line_number":260,"context_line":"        fake_id \u003d \u00273a4560a1-e585-443e-9b39-553b46ec92d1\u0027"},{"line_number":261,"context_line":"        filters \u003d {\u0027filters\u0027: dict([(\u0027checksum\u0027, _CHCKSUM)])}"},{"line_number":262,"context_line":"        images \u003d list(self.controller.list(**filters))"},{"line_number":263,"context_line":"        self.assertEqual(images[0].id, \u0027%s\u0027 % fake_id)"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"    def test_list_images_for_bogus_owner(self):"},{"line_number":266,"context_line":"        filters \u003d {\u0027filters\u0027: dict([(\u0027owner\u0027, _BOGUS_ID)])}"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAP3%2F%2F154%3D","line":263,"in_reply_to":"AAAAP3%2F%2F17w%3D","updated":"2013-07-10 15:16:28.000000000","message":"we should check for multiple images here. and asset length as well as correctly pointed by Jared","commit_id":"2c695176f6a7790fca2a00ece5e705547df4bdf7"},{"author":{"_account_id":7780,"name":"Jared Culp","email":"jared.culp@rackspace.com","username":"jaredculp"},"change_message_id":"304df63b0d0415c3c28cd8c2ca50ed53bc2d2e4c","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"_CHCKSUM \u003d \u002793264c3edf5972c9f1cb309543d38a5c\u0027"},{"line_number":25,"context_line":"_CHKSUM1 \u003d \u002754264c3edf5972c9f1cb309453d38a46\u0027"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"_BOGUS_ID \u003d \u002763e7f218-29de-4477-abdc-8db7c9533188\u0027"},{"line_number":28,"context_line":"_EVERYTHING_ID \u003d \u0027802cbbb7-0379-4c38-853f-37302b5e3d29\u0027"},{"line_number":29,"context_line":"_OWNED_IMAGE_ID \u003d \u0027a4963502-acc7-42ba-ad60-5aa0962b7faf\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAP3%2F%2FyfU%3D","line":26,"updated":"2013-07-11 13:22:24.000000000","message":"These names are inconsistent.","commit_id":"16f6d3e9d2c6e66a83283ca3893ca325ec1eb711"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"7fe1f3679c105631f8dfff053a06e496f8c30608","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"_CHCKSUM \u003d \u002793264c3edf5972c9f1cb309543d38a5c\u0027"},{"line_number":25,"context_line":"_CHKSUM1 \u003d \u002754264c3edf5972c9f1cb309453d38a46\u0027"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"_BOGUS_ID \u003d \u002763e7f218-29de-4477-abdc-8db7c9533188\u0027"},{"line_number":28,"context_line":"_EVERYTHING_ID \u003d \u0027802cbbb7-0379-4c38-853f-37302b5e3d29\u0027"},{"line_number":29,"context_line":"_OWNED_IMAGE_ID \u003d \u0027a4963502-acc7-42ba-ad60-5aa0962b7faf\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAP3%2F%2Fwpw%3D","line":26,"in_reply_to":"AAAAP3%2F%2Fx5s%3D","updated":"2013-07-11 20:43:14.000000000","message":"isn\u0027t pep8 giving you a 79 words limit/line? (though this is a femtonit)","commit_id":"16f6d3e9d2c6e66a83283ca3893ca325ec1eb711"},{"author":{"_account_id":7701,"name":"Amala Basha","email":"amala.alungal@RACKSPACE.COM","username":"amalabasha"},"change_message_id":"2387f3a10b1c2410379368554f7307c478c3382c","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"_CHCKSUM \u003d \u002793264c3edf5972c9f1cb309543d38a5c\u0027"},{"line_number":25,"context_line":"_CHKSUM1 \u003d \u002754264c3edf5972c9f1cb309453d38a46\u0027"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"_BOGUS_ID \u003d \u002763e7f218-29de-4477-abdc-8db7c9533188\u0027"},{"line_number":28,"context_line":"_EVERYTHING_ID \u003d \u0027802cbbb7-0379-4c38-853f-37302b5e3d29\u0027"},{"line_number":29,"context_line":"_OWNED_IMAGE_ID \u003d \u0027a4963502-acc7-42ba-ad60-5aa0962b7faf\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAP3%2F%2Fx5s%3D","line":26,"in_reply_to":"AAAAP3%2F%2FyfU%3D","updated":"2013-07-11 15:37:26.000000000","message":"I had to settle for this coz of pep8 restrictions for line size limit","commit_id":"16f6d3e9d2c6e66a83283ca3893ca325ec1eb711"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"7fe1f3679c105631f8dfff053a06e496f8c30608","unresolved":false,"context_lines":[{"line_number":283,"context_line":"        filters \u003d {\u0027filters\u0027: dict([(\u0027checksum\u0027, _CHCKSUM)])}"},{"line_number":284,"context_line":"        images \u003d list(self.controller.list(**filters))"},{"line_number":285,"context_line":"        self.assertEqual(images[0].id, \u0027%s\u0027 % fake_id)"},{"line_number":286,"context_line":"        self.assertEquals(1, len(images))"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"    def test_list_images_for_checksum_multiple_images(self):"},{"line_number":289,"context_line":"        fake_id1 \u003d \u00272a4560b2-e585-443e-9b39-553b46ec92d1\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAP3%2F%2Fwok%3D","line":286,"updated":"2013-07-11 20:43:14.000000000","message":"same as below","commit_id":"16f6d3e9d2c6e66a83283ca3893ca325ec1eb711"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"7fe1f3679c105631f8dfff053a06e496f8c30608","unresolved":false,"context_lines":[{"line_number":292,"context_line":"        images \u003d list(self.controller.list(**filters))"},{"line_number":293,"context_line":"        self.assertEqual(images[0].id, \u0027%s\u0027 % fake_id1)"},{"line_number":294,"context_line":"        self.assertEqual(images[1].id, \u0027%s\u0027 % fake_id2)"},{"line_number":295,"context_line":"        self.assertEquals(2, len(images))"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"    def test_list_images_for_wrong_checksum(self):"},{"line_number":298,"context_line":"        filters \u003d {\u0027filters\u0027: dict([(\u0027checksum\u0027, \u0027wrong\u0027)])}"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAP3%2F%2FwpA%3D","line":295,"updated":"2013-07-11 20:43:14.000000000","message":"it would be great if you asserted for the len(images) first in that case if a test fails, we can pin point the bug. Having to asset here almost seems implicitly done above.","commit_id":"16f6d3e9d2c6e66a83283ca3893ca325ec1eb711"}]}