)]}'
{"glanceclient/v2/images.py":[{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"eb926b6ec0f3e244350a39fdaf18915037ff5cc7","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import warlock"},{"line_number":17,"context_line":"import urllib"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from glanceclient.common import utils"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAP3%2F%2F9pY%3D","line":16,"updated":"2013-07-08 14:06:30.000000000","message":"this import should be bellow urllib and there should be an empty line between them.","commit_id":"d9c61ee6cb7672eac22eeeb0fb0414de8d6a6246"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"eb926b6ec0f3e244350a39fdaf18915037ff5cc7","unresolved":false,"context_lines":[{"line_number":103,"context_line":"                raise TypeError(e.message)"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"        resp, body \u003d self.http_client.json_request(\u0027POST\u0027, url, body\u003dimage)"},{"line_number":106,"context_line":"        body.pop(\u0027self\u0027, None)"},{"line_number":107,"context_line":"        return self.model(**body)"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    def update(self, image_id, **kwargs):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAP3%2F%2F9pA%3D","line":106,"updated":"2013-07-08 14:06:30.000000000","message":"why is there a \u0027self\u0027 in the body dict? and why does it have to be removed? \n\nSounds like something that should be fixed somewhere.","commit_id":"d9c61ee6cb7672eac22eeeb0fb0414de8d6a6246"},{"author":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"change_message_id":"8f98c922e2b76cc3e97b942418f6eb28327b88af","unresolved":false,"context_lines":[{"line_number":103,"context_line":"                raise TypeError(e.message)"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"        resp, body \u003d self.http_client.json_request(\u0027POST\u0027, url, body\u003dimage)"},{"line_number":106,"context_line":"        body.pop(\u0027self\u0027, None)"},{"line_number":107,"context_line":"        return self.model(**body)"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    def update(self, image_id, **kwargs):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAP3%2F%2F7v8%3D","line":106,"in_reply_to":"AAAAP3%2F%2F9pA%3D","updated":"2013-07-09 01:30:38.000000000","message":"Looks like it\u0027s removing the \u0027self\u0027 link for pagination. It must conflict in model as a kwarg. I get \"__init__() got multiple values for keyword argument \u0027self\u0027\" when i remove that line. Maybe we just add waldons note here as well and fix that separately?\n\nAbove, waldon has a note saying :\n#NOTE(bcwaldon): remove \u0027self\u0027 for now until we have an elegant\n# way to pass it into the model constructor without conflict\n\t            image.pop(\u0027self\u0027, None)","commit_id":"d9c61ee6cb7672eac22eeeb0fb0414de8d6a6246"},{"author":{"_account_id":4463,"name":"iccha-sethi","email":"iccha.sethi@rackspace.com","username":"iccha-sethi"},"change_message_id":"723a3af1c12df1520be65a4fa4614d774c1444f1","unresolved":false,"context_lines":[{"line_number":102,"context_line":"            #NOTE(esheffield): if the additionalProperties are anything other"},{"line_number":103,"context_line":"            # than \u0027string\u0027 the setattr will likely fail with a TypeError"},{"line_number":104,"context_line":"            if self.schema.is_base_property(key) is False and \\"},{"line_number":105,"context_line":"                    self.schema.get_additionalProperties_type() \u003d\u003d \u0027string\u0027:"},{"line_number":106,"context_line":"                value \u003d str(value)"},{"line_number":107,"context_line":"            try:"},{"line_number":108,"context_line":"                setattr(image, key, value)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAQn%2F%2F5u4%3D","line":105,"updated":"2013-07-19 14:57:00.000000000","message":"just curious, do u think this addresses a very specific case ? or do u think this is good enough for now? \nalso did u or the cinder ppl get to try this patch out?","commit_id":"3a1c0bc8dce9243fb020df0e71be5093ac6ebdbe"},{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"73a882b9682bbe951de78b05fdbf067458f3ae5e","unresolved":false,"context_lines":[{"line_number":101,"context_line":"            try:"},{"line_number":102,"context_line":"                setattr(image, key, value)"},{"line_number":103,"context_line":"            except warlock.InvalidOperation, e:"},{"line_number":104,"context_line":"                raise TypeError(e.message)"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"        resp, body \u003d self.http_client.json_request(\u0027POST\u0027, url, body\u003dimage)"},{"line_number":107,"context_line":"        #NOTE(esheffield): remove \u0027self\u0027 for now until we have an elegant"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAQn%2F%2FrPo%3D","line":104,"updated":"2013-07-25 09:50:11.000000000","message":"was just reviewing https://review.openstack.org/#/c/38532/ which removes an instance of e.message due to it been deprecated.  does that apply here too?","commit_id":"eb7e130464dcaa83b5b5748aa80aae525c45a63a"}]}