)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"7c59fe506cea30eb0fd00cf1c4743cd586b0700f","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     bhagyashris \u003cbhagyashri.shewale@nttdata.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-08-26 15:45:22 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Replace functions \u0027Dict.get\u0027 and \u0027del\u0027 with \u0027Dict.pop\u0027"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Refactoring code: Making dict to use single instruction: pop()"},{"line_number":10,"context_line":"rather than two instructions: get() and del, giving the codes a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a461143_72b722f5","line":7,"updated":"2017-01-30 16:35:57.000000000","message":"The `dict` class is not named `Dict`.","commit_id":"6178d4366a73a14f004f3c1bb9a9c5ebb7d98209"}],"glanceclient/common/http.py":[{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"7c59fe506cea30eb0fd00cf1c4743cd586b0700f","unresolved":false,"context_lines":[{"line_number":141,"context_line":"        self.auth_token \u003d kwargs.get(\u0027token\u0027)"},{"line_number":142,"context_line":"        self.language_header \u003d kwargs.get(\u0027language_header\u0027)"},{"line_number":143,"context_line":"        self.last_request_id \u003d None"},{"line_number":144,"context_line":"        if self.identity_headers:"},{"line_number":145,"context_line":"            if self.identity_headers.get(\u0027X-Auth-Token\u0027):"},{"line_number":146,"context_line":"                self.auth_token \u003d self.identity_headers.pop(\u0027X-Auth-Token\u0027)"},{"line_number":147,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a461143_92d00e21","line":144,"updated":"2017-01-30 16:35:57.000000000","message":"Bhagyarshri, then why not\n\n    if self.identity_headers:\n        self.auth_token \u003d self.identity_headers.pop(\u0027X-Auth-Token\u0027, self.auth_token)\n\nThat way we default to what was passed in. That\u0027s still significantly better than what we have here in which we waste a lot of time digging into the dictionary.","commit_id":"6178d4366a73a14f004f3c1bb9a9c5ebb7d98209"},{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"b60e20796f4a76290095cb448ed89daaae1c99ea","unresolved":false,"context_lines":[{"line_number":141,"context_line":"        self.auth_token \u003d kwargs.get(\u0027token\u0027)"},{"line_number":142,"context_line":"        self.language_header \u003d kwargs.get(\u0027language_header\u0027)"},{"line_number":143,"context_line":"        self.last_request_id \u003d None"},{"line_number":144,"context_line":"        if self.identity_headers:"},{"line_number":145,"context_line":"            if self.identity_headers.get(\u0027X-Auth-Token\u0027):"},{"line_number":146,"context_line":"                self.auth_token \u003d self.identity_headers.pop(\u0027X-Auth-Token\u0027)"},{"line_number":147,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5a3905b3_75fd01b0","line":144,"updated":"2017-01-24 17:07:57.000000000","message":"This should be further simplified to:\n\n    if self.identity_headers:\n        self.auth_token \u003d self.identity_headers.pop(\u0027X-Auth-Token\u0027, None)\n\nSince self.auth_token is ostensibly defaulting to None","commit_id":"6178d4366a73a14f004f3c1bb9a9c5ebb7d98209"},{"author":{"_account_id":20182,"name":"Bhagyashri Shewale","email":"bshewale@redhat.com","username":"bhagyashris"},"change_message_id":"3adc54ad0643a2e42bfa1c4d39acce9a6aa06fab","unresolved":false,"context_lines":[{"line_number":141,"context_line":"        self.auth_token \u003d kwargs.get(\u0027token\u0027)"},{"line_number":142,"context_line":"        self.language_header \u003d kwargs.get(\u0027language_header\u0027)"},{"line_number":143,"context_line":"        self.last_request_id \u003d None"},{"line_number":144,"context_line":"        if self.identity_headers:"},{"line_number":145,"context_line":"            if self.identity_headers.get(\u0027X-Auth-Token\u0027):"},{"line_number":146,"context_line":"                self.auth_token \u003d self.identity_headers.pop(\u0027X-Auth-Token\u0027)"},{"line_number":147,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a461143_1acfe129","line":144,"in_reply_to":"5a3905b3_75fd01b0","updated":"2017-01-30 12:49:55.000000000","message":"Hi Ian, Thanks for review,\n\nIn this case self.auth_token will be set to None even if kwargs has \u0027token\u0027. Please refer line #141","commit_id":"6178d4366a73a14f004f3c1bb9a9c5ebb7d98209"}]}
