)]}'
{"id":"openstack%2Fpython-glanceclient~361851","triplet_id":"openstack%2Fpython-glanceclient~master~Idb21df37c287fdff24c29153676f82544f735297","project":"openstack/python-glanceclient","branch":"master","topic":"use_dict.pop","hashtags":[],"change_id":"Idb21df37c287fdff24c29153676f82544f735297","subject":"Replace functions \u0027dict.get\u0027 and \u0027del\u0027 with \u0027dict.pop\u0027","status":"MERGED","created":"2016-08-29 06:01:05.000000000","updated":"2017-03-06 17:09:00.000000000","submitted":"2017-03-06 17:09:00.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":4,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"ef53b5fb2b4d2afa94d8043c87e97644540fdb06","_number":361851,"virtual_id_number":361851,"owner":{"_account_id":20182,"name":"Bhagyashri Shewale","email":"bshewale@redhat.com","username":"bhagyashris"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},{"value":0,"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},{"value":2,"date":"2017-03-06 17:09:00.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},{"value":0,"_account_id":20182,"name":"Bhagyashri Shewale","email":"bshewale@redhat.com","username":"bhagyashris"},{"value":0,"_account_id":25357,"name":"Dhananjay More Patil","email":"morepatil1875@gmail.com","username":"morepatil"},{"value":0,"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"all":[{"value":0,"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},{"value":2,"date":"2017-03-06 15:10:42.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},{"value":0,"_account_id":20182,"name":"Bhagyashri Shewale","email":"bshewale@redhat.com","username":"bhagyashris"},{"value":1,"date":"2017-03-05 15:51:22.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":25357,"name":"Dhananjay More Patil","email":"morepatil1875@gmail.com","username":"morepatil"},{"value":2,"date":"2017-03-06 15:54:59.000000000","_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"all":[{"value":0,"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},{"value":0,"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},{"value":0,"_account_id":20182,"name":"Bhagyashri Shewale","email":"bshewale@redhat.com","username":"bhagyashris"},{"value":0,"_account_id":25357,"name":"Dhananjay More Patil","email":"morepatil1875@gmail.com","username":"morepatil"},{"value":1,"date":"2017-03-06 15:54:59.000000000","_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},{"value":0,"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},{"value":0,"_account_id":20182,"name":"Bhagyashri Shewale","email":"bshewale@redhat.com","username":"bhagyashris"},{"value":0,"_account_id":25357,"name":"Dhananjay More Patil","email":"morepatil1875@gmail.com","username":"morepatil"},{"value":0,"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Top Priority / Holds Gate"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},{"_account_id":20182,"name":"Bhagyashri Shewale","email":"bshewale@redhat.com","username":"bhagyashris"},{"_account_id":25357,"name":"Dhananjay More Patil","email":"morepatil1875@gmail.com","username":"morepatil"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-01-23 09:31:37.000000000","updated_by":{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},"reviewer":{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},"state":"REVIEWER"},{"updated":"2017-01-24 17:07:57.000000000","updated_by":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"reviewer":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"state":"REVIEWER"},{"updated":"2017-03-05 15:51:22.000000000","updated_by":{"_account_id":25357,"name":"Dhananjay More Patil","email":"morepatil1875@gmail.com","username":"morepatil"},"reviewer":{"_account_id":25357,"name":"Dhananjay More Patil","email":"morepatil1875@gmail.com","username":"morepatil"},"state":"REVIEWER"},{"updated":"2017-03-06 15:10:42.000000000","updated_by":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"reviewer":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"state":"REVIEWER"},{"updated":"2017-03-06 15:54:59.000000000","updated_by":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"reviewer":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"state":"REVIEWER"},{"updated":"2017-03-06 17:09:00.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"8916496edf48085c330e2b26b26018c0611fbbcd","author":{"_account_id":20182,"name":"Bhagyashri Shewale","email":"bshewale@redhat.com","username":"bhagyashris"},"date":"2016-08-29 06:01:05.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"6099496b5bb84c963bebece605fa8b4333ed0aef","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-08-29 07:08:28.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-glanceclient-docs-ubuntu-xenial http://docs-draft.openstack.org/51/361851/1/check/gate-python-glanceclient-docs-ubuntu-xenial/f953917//doc/build/html/ : SUCCESS in 2m 28s\n- gate-python-glanceclient-pep8-ubuntu-xenial http://logs.openstack.org/51/361851/1/check/gate-python-glanceclient-pep8-ubuntu-xenial/185556a/ : SUCCESS in 2m 12s\n- gate-python-glanceclient-python27-ubuntu-xenial http://logs.openstack.org/51/361851/1/check/gate-python-glanceclient-python27-ubuntu-xenial/353d58b/ : SUCCESS in 3m 37s\n- gate-python-glanceclient-python34 http://logs.openstack.org/51/361851/1/check/gate-python-glanceclient-python34/b4db640/ : SUCCESS in 2m 29s\n- gate-python-glanceclient-python35-nv http://logs.openstack.org/51/361851/1/check/gate-python-glanceclient-python35-nv/f673fd3/ : SUCCESS in 4m 05s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-glanceclient http://logs.openstack.org/51/361851/1/check/gate-tempest-dsvm-neutron-src-python-glanceclient/51f3b34/ : SUCCESS in 1h 06m 58s\n- gate-glanceclient-dsvm-functional http://logs.openstack.org/51/361851/1/check/gate-glanceclient-dsvm-functional/fccbfef/ : SUCCESS in 22m 24s\n- gate-glanceclient-dsvm-functional-identity-v3-only-nv http://logs.openstack.org/51/361851/1/check/gate-glanceclient-dsvm-functional-identity-v3-only-nv/b9ccd57/ : FAILURE in 28m 37s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"b60e20796f4a76290095cb448ed89daaae1c99ea","author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"date":"2017-01-24 17:07:57.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"3adc54ad0643a2e42bfa1c4d39acce9a6aa06fab","author":{"_account_id":20182,"name":"Bhagyashri Shewale","email":"bshewale@redhat.com","username":"bhagyashris"},"date":"2017-01-30 12:49:55.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"7c59fe506cea30eb0fd00cf1c4743cd586b0700f","author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"date":"2017-01-30 16:35:57.000000000","message":"Patch Set 1:\n\n(2 comments)\n\nThis is not a \"TrivialFix\". There is no bug here. This is a \"TrivialRefactoring\" or a \"TrivialChange\" or whatever else you want to call it. But don\u0027t call it a fix.","accounts_in_message":[],"_revision_number":1},{"id":"6fc0adff6cc8c9afb01af3db2ae5d6ab7ee52915","author":{"_account_id":20182,"name":"Bhagyashri Shewale","email":"bshewale@redhat.com","username":"bhagyashris"},"date":"2017-01-31 06:36:50.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"dbea01cebb6798beedec273b7a536e1d87823ad6","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-01-31 07:31:27.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-glanceclient-docs-ubuntu-xenial http://docs-draft.openstack.org/51/361851/2/check/gate-python-glanceclient-docs-ubuntu-xenial/ae1736d//doc/build/html/ : SUCCESS in 2m 27s\n- gate-python-glanceclient-pep8-ubuntu-xenial http://logs.openstack.org/51/361851/2/check/gate-python-glanceclient-pep8-ubuntu-xenial/ed90227/ : SUCCESS in 2m 26s\n- gate-python-glanceclient-python27-ubuntu-xenial http://logs.openstack.org/51/361851/2/check/gate-python-glanceclient-python27-ubuntu-xenial/b343200/ : SUCCESS in 3m 17s\n- gate-python-glanceclient-python35 http://logs.openstack.org/51/361851/2/check/gate-python-glanceclient-python35/9da2792/ : SUCCESS in 2m 21s\n- gate-tempest-dsvm-neutron-src-python-glanceclient-ubuntu-xenial http://logs.openstack.org/51/361851/2/check/gate-tempest-dsvm-neutron-src-python-glanceclient-ubuntu-xenial/91fe1dc/ : SUCCESS in 53m 33s\n- gate-glanceclient-dsvm-functional-ubuntu-xenial http://logs.openstack.org/51/361851/2/check/gate-glanceclient-dsvm-functional-ubuntu-xenial/292caea/ : SUCCESS in 18m 39s\n- gate-glanceclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv http://logs.openstack.org/51/361851/2/check/gate-glanceclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv/088385c/ : FAILURE in 17m 42s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"cfe82e58d62b0653febd3f7a5f80512907c98f57","author":{"_account_id":25357,"name":"Dhananjay More Patil","email":"morepatil1875@gmail.com","username":"morepatil"},"date":"2017-03-05 15:51:22.000000000","message":"Patch Set 2: Code-Review+1\n\nLGTM","accounts_in_message":[],"_revision_number":2},{"id":"370e8a48998fbf9d3627af8022b8c9a7bf782458","author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"date":"2017-03-06 15:10:42.000000000","message":"Patch Set 2: Code-Review+2\n\nLooks like it preserves the original logic.","accounts_in_message":[],"_revision_number":2},{"id":"c5df1d0b6a55ff20ecf6223461e5e91f72ae12bb","author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"date":"2017-03-06 15:54:59.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1\n\nLGTM, thanks!","accounts_in_message":[],"_revision_number":2},{"id":"d3c948354aa67b9f01359bf0661bda4b12ae435a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-03-06 15:55:09.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"da651d56d4b2894ac7ee30fbf1a7720fcb55c9f8","date":"2017-03-06 17:09:00.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":2},{"id":"429f0fc004d2b99bfce73b5fd26360aa46802ca9","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-03-06 17:09:00.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-glanceclient-docs-ubuntu-xenial http://docs-draft.openstack.org/51/361851/2/gate/gate-python-glanceclient-docs-ubuntu-xenial/520df37//doc/build/html/ : SUCCESS in 3m 30s\n- gate-python-glanceclient-pep8-ubuntu-xenial http://logs.openstack.org/51/361851/2/gate/gate-python-glanceclient-pep8-ubuntu-xenial/bf2ee9b/ : SUCCESS in 3m 44s\n- gate-python-glanceclient-python27-ubuntu-xenial http://logs.openstack.org/51/361851/2/gate/gate-python-glanceclient-python27-ubuntu-xenial/88257eb/ : SUCCESS in 3m 23s\n- gate-python-glanceclient-python35 http://logs.openstack.org/51/361851/2/gate/gate-python-glanceclient-python35/3f6700a/ : SUCCESS in 3m 50s\n- gate-tempest-dsvm-neutron-src-python-glanceclient-ubuntu-xenial http://logs.openstack.org/51/361851/2/gate/gate-tempest-dsvm-neutron-src-python-glanceclient-ubuntu-xenial/11c4c43/ : SUCCESS in 1h 13m 33s\n- gate-glanceclient-dsvm-functional-ubuntu-xenial http://logs.openstack.org/51/361851/2/gate/gate-glanceclient-dsvm-functional-ubuntu-xenial/e95325d/ : SUCCESS in 31m 28s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"6740f570963d742f4f62bccbd9d8da301982712f","revisions":{"6178d4366a73a14f004f3c1bb9a9c5ebb7d98209":{"kind":"REWORK","_number":1,"created":"2016-08-29 06:01:05.000000000","uploader":{"_account_id":20182,"name":"Bhagyashri Shewale","email":"bshewale@redhat.com","username":"bhagyashris"},"ref":"refs/changes/51/361851/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/51/361851/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/51/361851/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/51/361851/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/51/361851/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/51/361851/1"}}},"commit":{"parents":[{"commit":"d4196325eb05dadfaf62d8facbd8c6fe50f72166","subject":"Merge \"Revert \"Don\u0027t update tags every time\"\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/d4196325eb05dadfaf62d8facbd8c6fe50f72166"}]}],"author":{"name":"bhagyashris","email":"bhagyashri.shewale@nttdata.com","date":"2016-08-26 10:12:57.000000000","tz":330},"committer":{"name":"bhagyashris","email":"bhagyashri.shewale@nttdata.com","date":"2016-08-26 10:15:22.000000000","tz":330},"subject":"Replace functions \u0027Dict.get\u0027 and \u0027del\u0027 with \u0027Dict.pop\u0027","message":"Replace functions \u0027Dict.get\u0027 and \u0027del\u0027 with \u0027Dict.pop\u0027\n\nRefactoring code: Making dict to use single instruction: pop()\nrather than two instructions: get() and del, giving the codes a\nformat that carries through.\n\nTrivialFix\n\nChange-Id: Idb21df37c287fdff24c29153676f82544f735297\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/6178d4366a73a14f004f3c1bb9a9c5ebb7d98209"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/6178d4366a73a14f004f3c1bb9a9c5ebb7d98209"}]},"branch":"refs/heads/master"},"6740f570963d742f4f62bccbd9d8da301982712f":{"kind":"REWORK","_number":2,"created":"2017-01-31 06:36:50.000000000","uploader":{"_account_id":20182,"name":"Bhagyashri Shewale","email":"bshewale@redhat.com","username":"bhagyashris"},"ref":"refs/changes/51/361851/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/51/361851/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/51/361851/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/51/361851/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/51/361851/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/51/361851/2"}}},"commit":{"parents":[{"commit":"c1f54742f9ed61cd33e1f20342583bee07f1dfae","subject":"Merge \"Replace dict.iteritems() with dict.items()\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/c1f54742f9ed61cd33e1f20342583bee07f1dfae"}]}],"author":{"name":"bhagyashris","email":"bhagyashri.shewale@nttdata.com","date":"2016-08-26 10:12:57.000000000","tz":330},"committer":{"name":"bhagyashris","email":"bhagyashri.shewale@nttdata.com","date":"2017-01-31 04:39:28.000000000","tz":330},"subject":"Replace functions \u0027dict.get\u0027 and \u0027del\u0027 with \u0027dict.pop\u0027","message":"Replace functions \u0027dict.get\u0027 and \u0027del\u0027 with \u0027dict.pop\u0027\n\nRefactoring code: Making dict to use single instruction: pop()\nrather than two instructions: get() and del, giving the codes a\nformat that carries through.\n\nTrivialRefactoring\n\nChange-Id: Idb21df37c287fdff24c29153676f82544f735297\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/6740f570963d742f4f62bccbd9d8da301982712f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/6740f570963d742f4f62bccbd9d8da301982712f"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}