)]}'
{"id":"openstack%2Fpython-glanceclient~396084","triplet_id":"openstack%2Fpython-glanceclient~master~Ida7b9321af7572bfceaa4d2067456f43fba3312c","project":"openstack/python-glanceclient","branch":"master","topic":"bug/1605444","hashtags":[],"change_id":"Ida7b9321af7572bfceaa4d2067456f43fba3312c","subject":"Null value of image property name should not allowed","status":"ABANDONED","created":"2016-11-10 10:31:22.000000000","updated":"2017-07-20 16:11:19.000000000","total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"bff97fb4f44c20efeab9d417ec19ac5afa986d71","_number":396084,"virtual_id_number":396084,"owner":{"_account_id":24101,"name":"Jaspreet Singh Rawel","email":"jaspreetsinghrawel@gmail.com","username":"jaspreetrawel"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},{"value":-1,"date":"2017-01-23 22:20:01.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":24101,"name":"Jaspreet Singh Rawel","email":"jaspreetsinghrawel@gmail.com","username":"jaspreetrawel"},{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},{"_account_id":23755,"name":"Arvinder Singh","email":"arvinder.09@gmail.com"},{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},{"_account_id":23886,"name":"NITIN GUPTA","email":"nitin291989@gmail.com","username":"nitin-29-gupta"},{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"_account_id":24123,"name":"Kuldeep Khandelwal","email":"kk.openstack@gmail.com","username":"kk-openstack"},{"_account_id":20477,"name":"Jabbar Ali","email":"jabbar.ali@gmail.com","username":"jabbar-ali"},{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"rejected":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},{"value":-2,"date":"2017-01-24 15:48:05.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":24101,"name":"Jaspreet Singh Rawel","email":"jaspreetsinghrawel@gmail.com","username":"jaspreetrawel"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":23755,"name":"Arvinder Singh","email":"arvinder.09@gmail.com"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":23886,"name":"NITIN GUPTA","email":"nitin291989@gmail.com","username":"nitin-29-gupta"},{"value":-2,"date":"2016-11-23 14:29:38.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":24123,"name":"Kuldeep Khandelwal","email":"kk.openstack@gmail.com","username":"kk-openstack"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":20477,"name":"Jabbar Ali","email":"jabbar.ali@gmail.com","username":"jabbar-ali"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":24101,"name":"Jaspreet Singh Rawel","email":"jaspreetsinghrawel@gmail.com","username":"jaspreetrawel"},{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},{"_account_id":23755,"name":"Arvinder Singh","email":"arvinder.09@gmail.com"},{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},{"_account_id":23886,"name":"NITIN GUPTA","email":"nitin291989@gmail.com","username":"nitin-29-gupta"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"_account_id":24123,"name":"Kuldeep Khandelwal","email":"kk.openstack@gmail.com","username":"kk-openstack"},{"_account_id":20477,"name":"Jabbar Ali","email":"jabbar.ali@gmail.com","username":"jabbar-ali"},{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},{"value":0,"permitted_voting_range":{"min":-1,"max":2},"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":24101,"name":"Jaspreet Singh Rawel","email":"jaspreetsinghrawel@gmail.com","username":"jaspreetrawel"},{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},{"_account_id":23755,"name":"Arvinder Singh","email":"arvinder.09@gmail.com"},{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},{"_account_id":23886,"name":"NITIN GUPTA","email":"nitin291989@gmail.com","username":"nitin-29-gupta"},{"value":0,"permitted_voting_range":{"min":-1,"max":2},"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"_account_id":24123,"name":"Kuldeep Khandelwal","email":"kk.openstack@gmail.com","username":"kk-openstack"},{"_account_id":20477,"name":"Jabbar Ali","email":"jabbar.ali@gmail.com","username":"jabbar-ali"},{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Top Priority / Holds Gate"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},{"_account_id":20477,"name":"Jabbar Ali","email":"jabbar.ali@gmail.com","username":"jabbar-ali"},{"_account_id":23755,"name":"Arvinder Singh","email":"arvinder.09@gmail.com"},{"_account_id":23886,"name":"NITIN GUPTA","email":"nitin291989@gmail.com","username":"nitin-29-gupta"},{"_account_id":24101,"name":"Jaspreet Singh Rawel","email":"jaspreetsinghrawel@gmail.com","username":"jaspreetrawel"},{"_account_id":24123,"name":"Kuldeep Khandelwal","email":"kk.openstack@gmail.com","username":"kk-openstack"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-11-11 12:02:29.000000000","updated_by":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"reviewer":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"state":"REVIEWER"},{"updated":"2016-11-11 12:23:28.000000000","updated_by":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"reviewer":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"state":"REVIEWER"},{"updated":"2016-11-11 12:33:24.000000000","updated_by":{"_account_id":23755,"name":"Arvinder Singh","email":"arvinder.09@gmail.com"},"reviewer":{"_account_id":23755,"name":"Arvinder Singh","email":"arvinder.09@gmail.com"},"state":"REVIEWER"},{"updated":"2016-11-11 12:33:30.000000000","updated_by":{"_account_id":24123,"name":"Kuldeep Khandelwal","email":"kk.openstack@gmail.com","username":"kk-openstack"},"reviewer":{"_account_id":24123,"name":"Kuldeep Khandelwal","email":"kk.openstack@gmail.com","username":"kk-openstack"},"state":"REVIEWER"},{"updated":"2016-11-11 12:33:33.000000000","updated_by":{"_account_id":23886,"name":"NITIN GUPTA","email":"nitin291989@gmail.com","username":"nitin-29-gupta"},"reviewer":{"_account_id":23886,"name":"NITIN GUPTA","email":"nitin291989@gmail.com","username":"nitin-29-gupta"},"state":"REVIEWER"},{"updated":"2016-11-11 15:04:07.000000000","updated_by":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"reviewer":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"state":"REVIEWER"},{"updated":"2016-11-11 15:58:21.000000000","updated_by":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"reviewer":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"state":"REVIEWER"},{"updated":"2016-11-11 20:01:26.000000000","updated_by":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"reviewer":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"state":"REVIEWER"},{"updated":"2016-11-12 15:56:58.000000000","updated_by":{"_account_id":20477,"name":"Jabbar Ali","email":"jabbar.ali@gmail.com","username":"jabbar-ali"},"reviewer":{"_account_id":20477,"name":"Jabbar Ali","email":"jabbar.ali@gmail.com","username":"jabbar-ali"},"state":"REVIEWER"},{"updated":"2016-11-14 02:32:51.000000000","updated_by":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"reviewer":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"state":"REVIEWER"},{"updated":"2017-01-23 22:20:01.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2017-01-24 15:48:05.000000000","updated_by":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"reviewer":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"state":"REVIEWER"}],"messages":[{"id":"cba95ba8760f1d4acafd080ed902d0bf91eeaf68","author":{"_account_id":24101,"name":"Jaspreet Singh Rawel","email":"jaspreetsinghrawel@gmail.com","username":"jaspreetrawel"},"date":"2016-11-10 10:31:22.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"33705cf6d68e3338b8e377ea65744c11491006e5","author":{"_account_id":24101,"name":"Jaspreet Singh Rawel","email":"jaspreetsinghrawel@gmail.com","username":"jaspreetrawel"},"date":"2016-11-10 10:42:21.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"5e2a95cabf8480baec8d32687f1f9aaade5dd428","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-11-10 11:26:30.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-glanceclient-docs-ubuntu-xenial http://docs-draft.openstack.org/84/396084/2/check/gate-python-glanceclient-docs-ubuntu-xenial/d1255ec//doc/build/html/ : SUCCESS in 2m 18s\n- gate-python-glanceclient-pep8-ubuntu-xenial http://logs.openstack.org/84/396084/2/check/gate-python-glanceclient-pep8-ubuntu-xenial/7f17564/ : SUCCESS in 2m 28s\n- gate-python-glanceclient-python27-ubuntu-xenial http://logs.openstack.org/84/396084/2/check/gate-python-glanceclient-python27-ubuntu-xenial/862af54/ : SUCCESS in 2m 39s\n- gate-python-glanceclient-python34 http://logs.openstack.org/84/396084/2/check/gate-python-glanceclient-python34/aaf8b8d/ : SUCCESS in 2m 30s\n- gate-python-glanceclient-python35-nv http://logs.openstack.org/84/396084/2/check/gate-python-glanceclient-python35-nv/841475c/ : SUCCESS in 2m 28s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-glanceclient http://logs.openstack.org/84/396084/2/check/gate-tempest-dsvm-neutron-src-python-glanceclient/0f08f8d/ : SUCCESS in 43m 54s\n- gate-glanceclient-dsvm-functional http://logs.openstack.org/84/396084/2/check/gate-glanceclient-dsvm-functional/a1655ff/ : SUCCESS in 14m 04s\n- gate-glanceclient-dsvm-functional-identity-v3-only-nv http://logs.openstack.org/84/396084/2/check/gate-glanceclient-dsvm-functional-identity-v3-only-nv/d3f9b63/ : FAILURE in 14m 45s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"99423f02b58a3feed964f522bd91c3cf8909330e","author":{"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},"date":"2016-11-10 21:52:44.000000000","message":"Patch Set 2: Code-Review-1\n\n(1 comment)\n\nThis really requires a unit test.","accounts_in_message":[],"_revision_number":2},{"id":"f1cca2f986c2221916b73e19c9690fb8870bbbf2","author":{"_account_id":24101,"name":"Jaspreet Singh Rawel","email":"jaspreetsinghrawel@gmail.com","username":"jaspreetrawel"},"date":"2016-11-11 11:57:10.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"af4e4421782561af36d92c19ebcb8b630ebc2323","author":{"_account_id":24101,"name":"Jaspreet Singh Rawel","email":"jaspreetsinghrawel@gmail.com","username":"jaspreetrawel"},"date":"2016-11-11 12:01:06.000000000","message":"Patch Set 3:\n\n@Alexander: Added the unit tests.","accounts_in_message":[],"_revision_number":3},{"id":"53d7bc109903e4de03aa6aceeccb4295fe727044","author":{"_account_id":24101,"name":"Jaspreet Singh Rawel","email":"jaspreetsinghrawel@gmail.com","username":"jaspreetrawel"},"date":"2016-11-11 12:01:51.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"b67a3ef00f74612fc3b615d80fa3d09ac36ff92b","author":{"_account_id":24101,"name":"Jaspreet Singh Rawel","email":"jaspreetsinghrawel@gmail.com","username":"jaspreetrawel"},"date":"2016-11-11 12:20:21.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"d5ba95c5294bae97c3d4bf14672b95a171ee7071","author":{"_account_id":24101,"name":"Jaspreet Singh Rawel","email":"jaspreetsinghrawel@gmail.com","username":"jaspreetrawel"},"date":"2016-11-11 12:22:47.000000000","message":"Patch Set 2:\n\nUploaded another patch after fixing pep8 issues","accounts_in_message":[],"_revision_number":2},{"id":"a46998511928effebc473eb65480537a184af23e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-11-11 14:41:23.000000000","message":"Patch Set 4: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-glanceclient-docs-ubuntu-xenial http://docs-draft.openstack.org/84/396084/4/check/gate-python-glanceclient-docs-ubuntu-xenial/c39c626//doc/build/html/ : SUCCESS in 2m 56s\n- gate-python-glanceclient-pep8-ubuntu-xenial http://logs.openstack.org/84/396084/4/check/gate-python-glanceclient-pep8-ubuntu-xenial/d24cea2/ : SUCCESS in 2m 44s\n- gate-python-glanceclient-python27-ubuntu-xenial http://logs.openstack.org/84/396084/4/check/gate-python-glanceclient-python27-ubuntu-xenial/d817c64/ : SUCCESS in 3m 03s\n- gate-python-glanceclient-python34 http://logs.openstack.org/84/396084/4/check/gate-python-glanceclient-python34/7d3fbca/ : SUCCESS in 3m 27s\n- gate-python-glanceclient-python35-nv http://logs.openstack.org/84/396084/4/check/gate-python-glanceclient-python35-nv/4f76093/ : SUCCESS in 3m 11s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-glanceclient http://logs.openstack.org/84/396084/4/check/gate-tempest-dsvm-neutron-src-python-glanceclient/a2b5c0d/ : SUCCESS in 1h 26m 24s\n- gate-glanceclient-dsvm-functional http://logs.openstack.org/84/396084/4/check/gate-glanceclient-dsvm-functional/d4bf180/ : SUCCESS in 29m 52s\n- gate-glanceclient-dsvm-functional-identity-v3-only-nv http://logs.openstack.org/84/396084/4/check/gate-glanceclient-dsvm-functional-identity-v3-only-nv/c8ff143/ : FAILURE in 29m 38s (non-voting)","accounts_in_message":[],"_revision_number":4},{"id":"9d683ca9aa239a1f5fca385615b953c67a799e0c","author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"date":"2016-11-11 15:04:07.000000000","message":"Patch Set 4: Code-Review-2\n\nIt\u0027s not python-glanceclient\u0027s job to decide what is allowed and what is not allowed. As these are allowed values in our API schema we should not introduce artificial limitations in the client. Specially name is something that is definitely not required and we should not break that.","accounts_in_message":[],"_revision_number":4},{"id":"4c03c89d81e2ff13db77b3d59ba97913cc1a221c","author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"date":"2016-11-11 15:58:21.000000000","message":"Patch Set 4: Code-Review-1\n\nI absolutely agree with Erno and I\u0027ve taken the extra measure of marking the bug as Invalid.","accounts_in_message":[],"_revision_number":4},{"id":"ffa6bd4c0d0cc8dee69fc079dc6d3c11cf8e4200","author":{"_account_id":24101,"name":"Jaspreet Singh Rawel","email":"jaspreetsinghrawel@gmail.com","username":"jaspreetrawel"},"date":"2016-11-11 17:27:30.000000000","message":"Patch Set 4:\n\nroot@controller:/home/ubuntu# glance image-show 367fc434-1eee-4b01-8dba-580452ca7dff \n+------------------+--------------------------------------+\n| Property         | Value                                |\n+------------------+--------------------------------------+\n| checksum         | ee1eca47dc88f4879d8a229cc70a07c6     |\n| container_format | bare                                 |\n| created_at       | 2016-11-09T18:02:08Z                 |\n| disk_format      | qcow2                                |\n| id               | 367fc434-1eee-4b01-8dba-580452ca7dff |\n| min_disk         | 0                                    |\n| min_ram          | 0                                    |\n| name             | ОБРАЗ                                |\n| owner            | abe83ae828434fa9917bcee3d80a2fc7     |\n| protected        | False                                |\n| size             | 13287936                             |\n| status           | active                               |\n| tags             | []                                   |\n| updated_at       | 2016-11-11T17:03:55Z                 |\n| virtual_size     | None                                 |\n| visibility       | public                               |\n+------------------+--------------------------------------+\nroot@controller:/home/ubuntu# \nroot@controller:/home/ubuntu# \nroot@controller:/home/ubuntu# glance image-update 367fc434-1eee-4b01-8dba-580452ca7dff --property \u003d\n+------------------+--------------------------------------+\n| Property         | Value                                |\n+------------------+--------------------------------------+\n|                  |                                      |\n| checksum         | ee1eca47dc88f4879d8a229cc70a07c6     |\n| container_format | bare                                 |\n| created_at       | 2016-11-09T18:02:08Z                 |\n| disk_format      | qcow2                                |\n| id               | 367fc434-1eee-4b01-8dba-580452ca7dff |\n| min_disk         | 0                                    |\n| min_ram          | 0                                    |\n| name             | ОБРАЗ                                |\n| owner            | abe83ae828434fa9917bcee3d80a2fc7     |\n| protected        | False                                |\n| size             | 13287936                             |\n| status           | active                               |\n| tags             | []                                   |\n| updated_at       | 2016-11-11T17:04:14Z                 |\n| virtual_size     | None                                 |\n| visibility       | public                               |\n+------------------+--------------------------------------+\nroot@controller:/home/ubuntu# glance image-update 367fc434-1eee-4b01-8dba-580452ca7dff --remove-property \u0027\u0027\n+------------------+--------------------------------------+\n| Property         | Value                                |\n+------------------+--------------------------------------+\n| checksum         | ee1eca47dc88f4879d8a229cc70a07c6     |\n| container_format | bare                                 |\n| created_at       | 2016-11-09T18:02:08Z                 |\n| disk_format      | qcow2                                |\n| id               | 367fc434-1eee-4b01-8dba-580452ca7dff |\n| min_disk         | 0                                    |\n| min_ram          | 0                                    |\n| name             | ОБРАЗ                                |\n| owner            | abe83ae828434fa9917bcee3d80a2fc7     |\n| protected        | False                                |\n| size             | 13287936                             |\n| status           | active                               |\n| tags             | []                                   |\n| updated_at       | 2016-11-11T17:04:18Z                 |\n| virtual_size     | None                                 |\n| visibility       | public                               |\n+------------------+--------------------------------------+\nroot@controller:/home/ubuntu# \n\nI think here it is meaningless for user to add an image property having a null name. As per my understanding, the only way going further is to remove that property using the command \"glance image-update 367fc434-1eee-4b01-8dba-580452ca7dff --remove-property \u0027\u0027\" as indicated above. So, is this acceptable behaviour? Please suggest further.","accounts_in_message":[],"_revision_number":4},{"id":"8cf6108f91e96ba1edcbc00f4847ce06600788fe","author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"date":"2016-11-11 18:20:59.000000000","message":"Patch Set 4: Code-Review-1\n\n\u003e I think here it is meaningless for user to add an image property\n \u003e having a null name. As per my understanding, the only way going\n \u003e further is to remove that property using the command \"glance\n \u003e image-update 367fc434-1eee-4b01-8dba-580452ca7dff --remove-property\n \u003e \u0027\u0027\" as indicated above. So, is this acceptable behaviour? Please\n \u003e suggest further.\n\nAre you wanting to remove the property \"name\" from an image? If so, you can\u0027t do that. \u0027name\u0027 is a core/base property. A user can only add/remove extra properties.\n\nAnd, I agree with Erno and Ian on their assessment. Nothing more to add.","accounts_in_message":[],"_revision_number":4},{"id":"ccacc5da72c224dfc398816c10e03a18de662baa","author":{"_account_id":24101,"name":"Jaspreet Singh Rawel","email":"jaspreetsinghrawel@gmail.com","username":"jaspreetrawel"},"date":"2016-11-11 18:38:41.000000000","message":"Patch Set 4:\n\nNo Hemanth, I think this change was misunderstood.\nThe glance client currently allows the below.\n\n\"glance image-update 367fc434-1eee-4b01-8dba-580452ca7dff --property \u003d\u0027abcd\u0027\"\n\nThe above means that for the image ID \"367fc434-1eee-4b01-8dba-580452ca7dff\", the glance client is trying to add a property \u0027\u0027 which has a value \u0027abcd\u0027. Now if you do image-show, an additional entry will be shown where the \"Property\" column will be blank (showing nothing) and \"Value\" column will show \u0027abcd\u0027. See the first row in the below command output.\n\nroot@controller:/home/ubuntu# glance image-show 367fc434-1eee-4b01-8dba-580452ca7dff \n+------------------+--------------------------------------+\n| Property         | Value                                |\n+------------------+--------------------------------------+\n|                  | abcd                                 |\n| checksum         | ee1eca47dc88f4879d8a229cc70a07c6     |\n| container_format | bare                                 |\n| created_at       | 2016-11-09T18:02:08Z                 |\n| disk_format      | qcow2                                |\n| id               | 367fc434-1eee-4b01-8dba-580452ca7dff |\n| min_disk         | 0                                    |\n| min_ram          | 0                                    |\n| name             | ОБРАЗ                                |\n| owner            | abe83ae828434fa9917bcee3d80a2fc7     |\n| protected        | False                                |\n| size             | 13287936                             |\n| status           | active                               |\n| tags             | []                                   |\n| updated_at       | 2016-11-11T17:03:55Z                 |\n| virtual_size     | None                                 |\n| visibility       | public                               |\n+------------------+--------------------------------------+\nroot@controller:/home/ubuntu# \n\n\nThe change that I did restricts the user from using a null value for key of property.","accounts_in_message":[],"_revision_number":4},{"id":"0ea1cf420a9771d878dbe34170ff78861f7f46fb","author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"date":"2016-11-11 18:43:58.000000000","message":"Patch Set 4:\n\nThere seems to be a misunderstanding here.  On the reviewers\u0027 side, we\u0027re talking about the name of an image property, not the image (core) property \u0027name\u0027.  On Jaspreet\u0027s side, I\u0027m pretty sure the value isn\u0027t null, it\u0027s an empty string.  (Jaspreet, please check in the glance database and report back on what\u0027s in the cell for that value.)\n\nThis does seem to be something worth fixing, i.e., I really doubt the usefulness of having key:value pairs with no key.  I suspect that it\u0027s only showing up now because the glanceclient is using v2 by default, which is going to allow you to pass stuff to the API via json (like a key consisting only of whitespace) that wouldn\u0027t have been possible when the key name was part of an HTTP header.","accounts_in_message":[],"_revision_number":4},{"id":"0c405fe263a9737480370468fe257a6f2549c8b2","author":{"_account_id":24101,"name":"Jaspreet Singh Rawel","email":"jaspreetsinghrawel@gmail.com","username":"jaspreetrawel"},"date":"2016-11-11 19:19:26.000000000","message":"Patch Set 4:\n\nBefore my code changes, I added two extra properties for image a109d73c-331f-4b30-b2f0-36cda7875560. Please see the database snapshot below in that case as requested by Brian.\n\nMariaDB [glance]\u003e select * from image_properties;\n+----+--------------------------------------+------------+----------+---------------------+---------------------+---------------------+---------+\n| id | image_id                             | name       | value    | created_at          | updated_at          | deleted_at          | deleted |\n+----+--------------------------------------+------------+----------+---------------------+---------------------+---------------------+---------+\n|  1 | a109d73c-331f-4b30-b2f0-36cda7875560 |            |          | 2016-11-09 18:59:31 | 2016-11-10 09:19:08 | NULL                |       0 |\n|  2 | a109d73c-331f-4b30-b2f0-36cda7875560 | whocreated | jaspreet | 2016-11-09 19:01:10 | 2016-11-09 19:01:10 | NULL                |       0 |\n+----+--------------------------------------+------------+----------+---------------------+---------------------+---------------------+---------+\n2 rows in set (0.00 sec)\n\nMariaDB [glance]\u003e \nMariaDB [glance]\u003e \nMariaDB [glance]\u003e Bye\nroot@controller:/home/ubuntu# \nroot@controller:/home/ubuntu# \nroot@controller:/home/ubuntu# glance image-show a109d73c-331f-4b30-b2f0-36cda7875560\n+------------------+--------------------------------------+\n| Property         | Value                                |\n+------------------+--------------------------------------+\n|                  |                                      |\n| checksum         | ee1eca47dc88f4879d8a229cc70a07c6     |\n| container_format | bare                                 |\n| created_at       | 2016-09-09T06:50:30Z                 |\n| disk_format      | qcow2                                |\n| id               | a109d73c-331f-4b30-b2f0-36cda7875560 |\n| min_disk         | 0                                    |\n| min_ram          | 0                                    |\n| name             | cirros                               |\n| owner            | abe83ae828434fa9917bcee3d80a2fc7     |\n| protected        | False                                |\n| size             | 13287936                             |\n| status           | active                               |\n| tags             | []                                   |\n| updated_at       | 2016-11-10T09:19:08Z                 |\n| virtual_size     | None                                 |\n| visibility       | public                               |\n| whocreated       | jaspreet                             |\n+------------------+--------------------------------------+\nroot@controller:/home/ubuntu#","accounts_in_message":[],"_revision_number":4},{"id":"27b632e0f1d5ec98e5564e92b7ff14221639cc39","author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"date":"2016-11-11 20:01:26.000000000","message":"Patch Set 4: -Code-Review\n\nLooks like I dis misunderstand this. Withdrawing my -1.\nWill review this again.","accounts_in_message":[],"_revision_number":4},{"id":"894329842f7ce0364f6706168d684b5d76ce0fdf","author":{"_account_id":20477,"name":"Jabbar Ali","email":"jabbar.ali@gmail.com","username":"jabbar-ali"},"date":"2016-11-13 13:35:24.000000000","message":"Patch Set 4:\n\nPlease elaborate - scenario where this problem is visible in the commit message.","accounts_in_message":[],"_revision_number":4},{"id":"d056a0915a5720c3c09400e31647549b8adbf9d1","author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"date":"2016-11-14 02:32:51.000000000","message":"Patch Set 4: Code-Review-1\n\nI agree with @Jaspreet here that an image\u0027s property named \"\" is meaningless. But I think that the base reason is that Glance accepted the empty string \"\" for the property \u0027s key.  So it\u0027s better to fix this at server side.","accounts_in_message":[],"_revision_number":4},{"id":"8163bf64406091ce0efd070960c7289030106961","author":{"_account_id":24101,"name":"Jaspreet Singh Rawel","email":"jaspreetsinghrawel@gmail.com","username":"jaspreetrawel"},"date":"2016-11-15 07:41:49.000000000","message":"Patch Set 4:\n\nRequesting you all to agree to a common solution so that I can implement the same including Wang\u0027s question on whether this change is to be done on server or client side.\nThank you all in advance.","accounts_in_message":[],"_revision_number":4},{"id":"97b515405aca107a984217444a1b0b0f17b00e33","author":{"_account_id":24101,"name":"Jaspreet Singh Rawel","email":"jaspreetsinghrawel@gmail.com","username":"jaspreetrawel"},"date":"2016-11-15 07:54:37.000000000","message":"Uploaded patch set 5: Commit message was updated.","accounts_in_message":[],"_revision_number":5},{"id":"0bcae6eb740e95eea2e6618b9c8467ef47dc9700","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-11-15 08:38:12.000000000","message":"Patch Set 5: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-glanceclient-docs-ubuntu-xenial http://docs-draft.openstack.org/84/396084/5/check/gate-python-glanceclient-docs-ubuntu-xenial/97d5f3f//doc/build/html/ : SUCCESS in 3m 33s\n- gate-python-glanceclient-pep8-ubuntu-xenial http://logs.openstack.org/84/396084/5/check/gate-python-glanceclient-pep8-ubuntu-xenial/fbdd70b/ : SUCCESS in 2m 14s\n- gate-python-glanceclient-python27-ubuntu-xenial http://logs.openstack.org/84/396084/5/check/gate-python-glanceclient-python27-ubuntu-xenial/0ca1bca/ : SUCCESS in 3m 32s\n- gate-python-glanceclient-python34 http://logs.openstack.org/84/396084/5/check/gate-python-glanceclient-python34/e79f013/ : SUCCESS in 2m 33s\n- gate-python-glanceclient-python35-nv http://logs.openstack.org/84/396084/5/check/gate-python-glanceclient-python35-nv/0d548f0/ : SUCCESS in 2m 29s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-glanceclient http://logs.openstack.org/84/396084/5/check/gate-tempest-dsvm-neutron-src-python-glanceclient/f3a82ee/ : SUCCESS in 43m 22s\n- gate-glanceclient-dsvm-functional http://logs.openstack.org/84/396084/5/check/gate-glanceclient-dsvm-functional/8c95a72/ : SUCCESS in 16m 15s\n- gate-glanceclient-dsvm-functional-identity-v3-only-nv http://logs.openstack.org/84/396084/5/check/gate-glanceclient-dsvm-functional-identity-v3-only-nv/b9bd22a/ : FAILURE in 15m 17s (non-voting)","accounts_in_message":[],"_revision_number":5},{"id":"50735ae35b23728dc6a3df1dc4c178455ebfc1aa","author":{"_account_id":24101,"name":"Jaspreet Singh Rawel","email":"jaspreetsinghrawel@gmail.com","username":"jaspreetrawel"},"date":"2016-11-23 14:29:38.000000000","message":"Uploaded patch set 6: Patch Set 5 was rebased.","accounts_in_message":[],"_revision_number":6},{"id":"c8461acefd790ca185cb0aaea245eb830defffc5","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-11-23 15:14:55.000000000","message":"Patch Set 6: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-glanceclient-docs-ubuntu-xenial http://docs-draft.openstack.org/84/396084/6/check/gate-python-glanceclient-docs-ubuntu-xenial/e98bc32//doc/build/html/ : SUCCESS in 3m 10s\n- gate-python-glanceclient-pep8-ubuntu-xenial http://logs.openstack.org/84/396084/6/check/gate-python-glanceclient-pep8-ubuntu-xenial/f899587/ : SUCCESS in 3m 21s\n- gate-python-glanceclient-python27-ubuntu-xenial http://logs.openstack.org/84/396084/6/check/gate-python-glanceclient-python27-ubuntu-xenial/68e25eb/ : SUCCESS in 2m 40s\n- gate-python-glanceclient-python34 http://logs.openstack.org/84/396084/6/check/gate-python-glanceclient-python34/cc2e645/ : SUCCESS in 2m 41s\n- gate-python-glanceclient-python35-nv http://logs.openstack.org/84/396084/6/check/gate-python-glanceclient-python35-nv/5b7fc81/ : SUCCESS in 3m 04s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-glanceclient http://logs.openstack.org/84/396084/6/check/gate-tempest-dsvm-neutron-src-python-glanceclient/4abf458/ : SUCCESS in 44m 58s\n- gate-glanceclient-dsvm-functional http://logs.openstack.org/84/396084/6/check/gate-glanceclient-dsvm-functional/67ac82a/ : SUCCESS in 15m 58s\n- gate-glanceclient-dsvm-functional-identity-v3-only-nv http://logs.openstack.org/84/396084/6/check/gate-glanceclient-dsvm-functional-identity-v3-only-nv/2504ad1/ : FAILURE in 35m 58s (non-voting)","accounts_in_message":[],"_revision_number":6},{"id":"7059e6113ab083e0fd9555e3f2c45a1c0d1843ae","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-01-23 22:20:01.000000000","message":"Patch Set 6: Verified-1\n\nMerge Failed.\n\nThis change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.","accounts_in_message":[],"_revision_number":6},{"id":"e16bc47d879abfc69165ef617e936aef52af8867","author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"date":"2017-01-24 15:48:05.000000000","message":"Patch Set 6: Code-Review-2\n\nJaspreet, I have invalidated this bug.  Please see my comments on the bug.  If you disagree, feel free to bring this up at the weekly Glance meeting.\n\nThanks for your attention to glanceclient!","accounts_in_message":[],"_revision_number":6},{"id":"4ffd1ef9acd39e2428343c836371369209aaccd7","author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"date":"2017-07-20 16:11:19.000000000","message":"Abandoned\n\nAbandoning due to inactivity.","accounts_in_message":[],"_revision_number":6}],"current_revision_number":6,"current_revision":"780868b4222317215cd9e5425a836e4d43dc8b54","revisions":{"c1bda9bfc06a59aab6d91815e5d14b570dfd4479":{"kind":"REWORK","_number":1,"created":"2016-11-10 10:31:22.000000000","uploader":{"_account_id":24101,"name":"Jaspreet Singh Rawel","email":"jaspreetsinghrawel@gmail.com","username":"jaspreetrawel"},"ref":"refs/changes/84/396084/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/84/396084/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/84/396084/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/84/396084/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/84/396084/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/84/396084/1"}}},"commit":{"parents":[{"commit":"bdf2aebe12aa239badc583712aae195f33e990cf","subject":"Merge \"Updated from global requirements\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/bdf2aebe12aa239badc583712aae195f33e990cf"}]}],"author":{"name":"Jaspreet Singh Rawel","email":"jaspreetsinghrawel@gmail.com","date":"2016-11-10 10:09:21.000000000","tz":330},"committer":{"name":"Jaspreet Singh Rawel","email":"jaspreetsinghrawel@gmail.com","date":"2016-11-10 10:26:48.000000000","tz":330},"subject":"Null value of image property name should not allowed","message":"Null value of image property name should not allowed\n\nCurrently the image-update function accepts a null value for\nthe property key name. This should not be allowed.\n\nCloses-Bug: 1605444\n\nChange-Id: Ida7b9321af7572bfceaa4d2067456f43fba3312c\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/c1bda9bfc06a59aab6d91815e5d14b570dfd4479"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/c1bda9bfc06a59aab6d91815e5d14b570dfd4479"}]},"branch":"refs/heads/master"},"e4cae1001b27235084650da5cce6dab5bdc23d3f":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2016-11-10 10:42:21.000000000","uploader":{"_account_id":24101,"name":"Jaspreet Singh Rawel","email":"jaspreetsinghrawel@gmail.com","username":"jaspreetrawel"},"ref":"refs/changes/84/396084/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/84/396084/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/84/396084/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/84/396084/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/84/396084/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/84/396084/2"}}},"commit":{"parents":[{"commit":"bdf2aebe12aa239badc583712aae195f33e990cf","subject":"Merge \"Updated from global requirements\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/bdf2aebe12aa239badc583712aae195f33e990cf"}]}],"author":{"name":"Jaspreet Singh Rawel","email":"jaspreetsinghrawel@gmail.com","date":"2016-11-10 10:09:21.000000000","tz":330},"committer":{"name":"Jaspreet Singh Rawel","email":"jaspreetsinghrawel@gmail.com","date":"2016-11-10 10:41:04.000000000","tz":330},"subject":"Null value of image property name should not allowed","message":"Null value of image property name should not allowed\n\nCurrently the image-create and image-update functions accept\na null value for the name of property. This should not be allowed.\n\nCloses-Bug: 1605444\n\nChange-Id: Ida7b9321af7572bfceaa4d2067456f43fba3312c\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/e4cae1001b27235084650da5cce6dab5bdc23d3f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/e4cae1001b27235084650da5cce6dab5bdc23d3f"}]},"branch":"refs/heads/master"},"135edcd4312d8fcf8b7a00f3abea1261331a4c38":{"kind":"REWORK","_number":3,"created":"2016-11-11 11:57:10.000000000","uploader":{"_account_id":24101,"name":"Jaspreet Singh Rawel","email":"jaspreetsinghrawel@gmail.com","username":"jaspreetrawel"},"ref":"refs/changes/84/396084/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/84/396084/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/84/396084/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/84/396084/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/84/396084/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/84/396084/3"}}},"commit":{"parents":[{"commit":"bdf2aebe12aa239badc583712aae195f33e990cf","subject":"Merge \"Updated from global requirements\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/bdf2aebe12aa239badc583712aae195f33e990cf"}]}],"author":{"name":"Jaspreet Singh Rawel","email":"jaspreetsinghrawel@gmail.com","date":"2016-11-10 10:09:21.000000000","tz":330},"committer":{"name":"Jaspreet Singh Rawel","email":"jaspreetsinghrawel@gmail.com","date":"2016-11-11 11:56:48.000000000","tz":330},"subject":"Null value of image property name should not allowed","message":"Null value of image property name should not allowed\n\nCurrently the image-create and image-update functions accept\na null value for the name of property. This should not be allowed.\n\nCloses-Bug: 1605444\n\nChange-Id: Ida7b9321af7572bfceaa4d2067456f43fba3312c\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/135edcd4312d8fcf8b7a00f3abea1261331a4c38"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/135edcd4312d8fcf8b7a00f3abea1261331a4c38"}]},"branch":"refs/heads/master"},"4cd55de65874c4674bfacde54a9e7ea4f54a2d35":{"kind":"REWORK","_number":4,"created":"2016-11-11 12:20:21.000000000","uploader":{"_account_id":24101,"name":"Jaspreet Singh Rawel","email":"jaspreetsinghrawel@gmail.com","username":"jaspreetrawel"},"ref":"refs/changes/84/396084/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/84/396084/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/84/396084/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/84/396084/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/84/396084/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/84/396084/4"}}},"commit":{"parents":[{"commit":"bdf2aebe12aa239badc583712aae195f33e990cf","subject":"Merge \"Updated from global requirements\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/bdf2aebe12aa239badc583712aae195f33e990cf"}]}],"author":{"name":"Jaspreet Singh Rawel","email":"jaspreetsinghrawel@gmail.com","date":"2016-11-10 10:09:21.000000000","tz":330},"committer":{"name":"Jaspreet Singh Rawel","email":"jaspreetsinghrawel@gmail.com","date":"2016-11-11 12:20:04.000000000","tz":330},"subject":"Null value of image property name should not allowed","message":"Null value of image property name should not allowed\n\nCurrently the image-create and image-update functions accept\na null value for the name of property. This should not be allowed.\n\nCloses-Bug: 1605444\n\nChange-Id: Ida7b9321af7572bfceaa4d2067456f43fba3312c\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/4cd55de65874c4674bfacde54a9e7ea4f54a2d35"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/4cd55de65874c4674bfacde54a9e7ea4f54a2d35"}]},"branch":"refs/heads/master"},"016a02e8a3f021eeb634b77cc1494767fcc87749":{"kind":"NO_CODE_CHANGE","_number":5,"created":"2016-11-15 07:54:37.000000000","uploader":{"_account_id":24101,"name":"Jaspreet Singh Rawel","email":"jaspreetsinghrawel@gmail.com","username":"jaspreetrawel"},"ref":"refs/changes/84/396084/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/84/396084/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/84/396084/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/84/396084/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/84/396084/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/84/396084/5"}}},"commit":{"parents":[{"commit":"bdf2aebe12aa239badc583712aae195f33e990cf","subject":"Merge \"Updated from global requirements\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/bdf2aebe12aa239badc583712aae195f33e990cf"}]}],"author":{"name":"Jaspreet Singh Rawel","email":"jaspreetsinghrawel@gmail.com","date":"2016-11-10 10:09:21.000000000","tz":330},"committer":{"name":"Jaspreet Singh Rawel","email":"jaspreetsinghrawel@gmail.com","date":"2016-11-15 07:44:57.000000000","tz":330},"subject":"Null value of image property name should not allowed","message":"Null value of image property name should not allowed\n\nCurrently the image-create and image-update functions accept\na null value for the name of image property. This should not be allowed.\nFor example, the below command will add or update an extra image property\nnamed \"\" which is meaningless and should not be allowed.\n\n\"glance image-update 367fc434-1eee-4b01-8dba-580452ca7dff --property \u003d\"\n\nCloses-Bug: 1605444\n\nChange-Id: Ida7b9321af7572bfceaa4d2067456f43fba3312c\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/016a02e8a3f021eeb634b77cc1494767fcc87749"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/016a02e8a3f021eeb634b77cc1494767fcc87749"}]},"branch":"refs/heads/master"},"780868b4222317215cd9e5425a836e4d43dc8b54":{"kind":"TRIVIAL_REBASE","_number":6,"created":"2016-11-23 14:29:38.000000000","uploader":{"_account_id":24101,"name":"Jaspreet Singh Rawel","email":"jaspreetsinghrawel@gmail.com","username":"jaspreetrawel"},"ref":"refs/changes/84/396084/6","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/84/396084/6","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/84/396084/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/84/396084/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/84/396084/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/84/396084/6"}}},"commit":{"parents":[{"commit":"993d45293c38515279b5bffe02d60e43be0f1c68","subject":"Merge \"Add Apache 2.0 license to source file\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/993d45293c38515279b5bffe02d60e43be0f1c68"}]}],"author":{"name":"Jaspreet Singh Rawel","email":"jaspreetsinghrawel@gmail.com","date":"2016-11-10 10:09:21.000000000","tz":330},"committer":{"name":"Jaspreet Singh Rawel","email":"jaspreetsinghrawel@gmail.com","date":"2016-11-23 14:29:19.000000000","tz":330},"subject":"Null value of image property name should not allowed","message":"Null value of image property name should not allowed\n\nCurrently the image-create and image-update functions accept\na null value for the name of image property. This should not be allowed.\nFor example, the below command will add or update an extra image property\nnamed \"\" which is meaningless and should not be allowed.\n\n\"glance image-update 367fc434-1eee-4b01-8dba-580452ca7dff --property \u003d\"\n\nCloses-Bug: 1605444\n\nChange-Id: Ida7b9321af7572bfceaa4d2067456f43fba3312c\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/780868b4222317215cd9e5425a836e4d43dc8b54"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/780868b4222317215cd9e5425a836e4d43dc8b54"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}