)]}'
{"id":"openstack%2Fpython-glanceclient~400586","triplet_id":"openstack%2Fpython-glanceclient~master~I841bebeda38814235079429eca0b1e5fd2f04dae","project":"openstack/python-glanceclient","branch":"master","topic":"trivial_bug","hashtags":[],"change_id":"I841bebeda38814235079429eca0b1e5fd2f04dae","subject":"Validate input args before trying image download","status":"MERGED","created":"2016-11-22 08:25:12.000000000","updated":"2017-07-26 14:15:35.000000000","submitted":"2017-07-26 14:15:35.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"b0d333e12a4e4707d11b5e3421b4157a7d409e5e","_number":400586,"virtual_id_number":400586,"owner":{"_account_id":18494,"name":"Ravi Shekhar Jethani","email":"rsjethani@gmail.com","username":"rsjethani"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},{"value":0,"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},{"value":2,"date":"2017-07-26 14:15:34.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"value":0,"_account_id":8871,"name":"Elastic Recheck","username":"elasticrecheck"},{"value":0,"_account_id":18494,"name":"Ravi Shekhar Jethani","email":"rsjethani@gmail.com","username":"rsjethani"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"all":[{"value":2,"date":"2017-07-25 14:35:38.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},{"value":2,"date":"2017-07-26 12:42:10.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2017-07-24 11:07:19.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"value":0,"_account_id":8871,"name":"Elastic Recheck","username":"elasticrecheck"},{"value":0,"_account_id":18494,"name":"Ravi Shekhar Jethani","email":"rsjethani@gmail.com","username":"rsjethani"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"all":[{"value":0,"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},{"value":1,"date":"2017-07-26 12:54:06.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"value":0,"_account_id":8871,"name":"Elastic Recheck","username":"elasticrecheck"},{"value":0,"_account_id":18494,"name":"Ravi Shekhar Jethani","email":"rsjethani@gmail.com","username":"rsjethani"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},{"value":0,"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"value":0,"_account_id":8871,"name":"Elastic Recheck","username":"elasticrecheck"},{"value":0,"_account_id":18494,"name":"Ravi Shekhar Jethani","email":"rsjethani@gmail.com","username":"rsjethani"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Top Priority / Holds Gate"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},{"_account_id":8871,"name":"Elastic Recheck","username":"elasticrecheck"},{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"_account_id":18494,"name":"Ravi Shekhar Jethani","email":"rsjethani@gmail.com","username":"rsjethani"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-06-01 10:38:18.000000000","updated_by":{"_account_id":8871,"name":"Elastic Recheck","username":"elasticrecheck"},"reviewer":{"_account_id":8871,"name":"Elastic Recheck","username":"elasticrecheck"},"state":"REVIEWER"},{"updated":"2017-07-24 11:07:19.000000000","updated_by":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"reviewer":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"state":"REVIEWER"},{"updated":"2017-07-25 14:35:38.000000000","updated_by":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"reviewer":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"state":"REVIEWER"},{"updated":"2017-07-26 12:54:06.000000000","updated_by":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"reviewer":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"state":"REVIEWER"},{"updated":"2017-07-26 14:15:34.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"e80ce311e9f32df48b4c8307de35f2e96dd112ba","author":{"_account_id":18494,"name":"Ravi Shekhar Jethani","email":"rsjethani@gmail.com","username":"rsjethani"},"date":"2016-11-22 08:25:12.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"8b3ea826f19243f2e777a8fed030fc86368088d6","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-11-22 09:10:39.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-glanceclient-docs-ubuntu-xenial http://docs-draft.openstack.org/86/400586/1/check/gate-python-glanceclient-docs-ubuntu-xenial/e8cae89//doc/build/html/ : SUCCESS in 2m 12s\n- gate-python-glanceclient-pep8-ubuntu-xenial http://logs.openstack.org/86/400586/1/check/gate-python-glanceclient-pep8-ubuntu-xenial/43f1e0d/ : SUCCESS in 2m 27s\n- gate-python-glanceclient-python27-ubuntu-xenial http://logs.openstack.org/86/400586/1/check/gate-python-glanceclient-python27-ubuntu-xenial/21ab355/ : SUCCESS in 3m 36s\n- gate-python-glanceclient-python34 http://logs.openstack.org/86/400586/1/check/gate-python-glanceclient-python34/6507b31/ : SUCCESS in 2m 32s\n- gate-python-glanceclient-python35-nv http://logs.openstack.org/86/400586/1/check/gate-python-glanceclient-python35-nv/009c471/ : SUCCESS in 2m 27s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-glanceclient http://logs.openstack.org/86/400586/1/check/gate-tempest-dsvm-neutron-src-python-glanceclient/0fab8b3/ : SUCCESS in 45m 13s\n- gate-glanceclient-dsvm-functional http://logs.openstack.org/86/400586/1/check/gate-glanceclient-dsvm-functional/fd1d738/ : SUCCESS in 15m 47s\n- gate-glanceclient-dsvm-functional-identity-v3-only-nv http://logs.openstack.org/86/400586/1/check/gate-glanceclient-dsvm-functional-identity-v3-only-nv/9484115/ : FAILURE in 33m 40s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"86bdc9465c0a68db4f51326a43b7a1dcdd0cdd28","author":{"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},"date":"2016-11-28 20:13:14.000000000","message":"Patch Set 1: Code-Review+1\n\nLooks to me like a good optimization. Thanks.","accounts_in_message":[],"_revision_number":1},{"id":"999bbaea6e8508308b71edd76b1553de88593c7c","author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"date":"2016-12-02 08:54:02.000000000","message":"Patch Set 1: Code-Review-1\n\nwhat if someone downloads image like \n\nglance image-download \u003cimage-id\u003e \u003e\u003e file\n\nit will not allow this anymore, right?","accounts_in_message":[],"_revision_number":1},{"id":"3871fb5a81b99ea64614edfc22b6ff8a393a214c","author":{"_account_id":18494,"name":"Ravi Shekhar Jethani","email":"rsjethani@gmail.com","username":"rsjethani"},"date":"2016-12-02 10:05:24.000000000","message":"Patch Set 1:\n\n@Abhishek\n\nIt works!!!","accounts_in_message":[],"_revision_number":1},{"id":"5d051072f3f41fe4f329d70426ed7077f23243a6","author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"date":"2016-12-02 10:25:38.000000000","message":"Patch Set 1: Code-Review+1\n\nlooks good to me","accounts_in_message":[],"_revision_number":1},{"id":"d1bd4decfe46c0d8e5b8cc4d5b0978ce46ceb0ff","author":{"_account_id":18494,"name":"Ravi Shekhar Jethani","email":"rsjethani@gmail.com","username":"rsjethani"},"date":"2017-01-25 11:18:45.000000000","message":"Patch Set 2: Patch Set 1 was rebased","accounts_in_message":[],"_revision_number":1},{"id":"cd77bbfb8be99bdadc5a814c51cb3cd7facfdbaf","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-01-25 12:59:10.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-glanceclient-docs-ubuntu-xenial http://docs-draft.openstack.org/86/400586/2/check/gate-python-glanceclient-docs-ubuntu-xenial/5b0e4f8//doc/build/html/ : SUCCESS in 4m 06s\n- gate-python-glanceclient-pep8-ubuntu-xenial http://logs.openstack.org/86/400586/2/check/gate-python-glanceclient-pep8-ubuntu-xenial/136af28/ : SUCCESS in 3m 39s\n- gate-python-glanceclient-python27-ubuntu-xenial http://logs.openstack.org/86/400586/2/check/gate-python-glanceclient-python27-ubuntu-xenial/78feb26/ : SUCCESS in 3m 23s\n- gate-python-glanceclient-python35 http://logs.openstack.org/86/400586/2/check/gate-python-glanceclient-python35/4983255/ : SUCCESS in 3m 18s\n- gate-tempest-dsvm-neutron-src-python-glanceclient-ubuntu-xenial http://logs.openstack.org/86/400586/2/check/gate-tempest-dsvm-neutron-src-python-glanceclient-ubuntu-xenial/bcdcd87/ : SUCCESS in 57m 39s\n- gate-glanceclient-dsvm-functional-ubuntu-xenial http://logs.openstack.org/86/400586/2/check/gate-glanceclient-dsvm-functional-ubuntu-xenial/7cfa430/ : SUCCESS in 18m 26s\n- gate-glanceclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv http://logs.openstack.org/86/400586/2/check/gate-glanceclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv/625bdc9/ : FAILURE in 17m 08s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"af876116a58ef28854b59b59ebef25549137ffb6","author":{"_account_id":18494,"name":"Ravi Shekhar Jethani","email":"rsjethani@gmail.com","username":"rsjethani"},"date":"2017-06-01 10:29:02.000000000","message":"Patch Set 3: Published edit on patch set 2","accounts_in_message":[],"_revision_number":3},{"id":"c45d2f0b34f013efd3987579693c0e9fe14ed84d","author":{"_account_id":18494,"name":"Ravi Shekhar Jethani","email":"rsjethani@gmail.com","username":"rsjethani"},"date":"2017-06-01 10:30:01.000000000","message":"Patch Set 4: Patch Set 3 was rebased","accounts_in_message":[],"_revision_number":3},{"id":"c559fc1c7325547f4589ff98c9bf2f3796cd0e86","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-06-01 10:37:25.000000000","message":"Patch Set 4: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-glanceclient-docs-ubuntu-xenial http://logs.openstack.org/86/400586/4/check/gate-python-glanceclient-docs-ubuntu-xenial/baf3195/ : FAILURE in 3m 17s\n- gate-python-glanceclient-pep8-ubuntu-xenial http://logs.openstack.org/86/400586/4/check/gate-python-glanceclient-pep8-ubuntu-xenial/5c7dd0a/ : SUCCESS in 2m 29s\n- gate-python-glanceclient-python27-ubuntu-xenial http://logs.openstack.org/86/400586/4/check/gate-python-glanceclient-python27-ubuntu-xenial/3ba3c55/ : FAILURE in 1m 28s\n- gate-python-glanceclient-python35 http://logs.openstack.org/86/400586/4/check/gate-python-glanceclient-python35/047dec3/ : FAILURE in 1m 29s\n- gate-tempest-dsvm-neutron-src-python-glanceclient-ubuntu-xenial http://logs.openstack.org/86/400586/4/check/gate-tempest-dsvm-neutron-src-python-glanceclient-ubuntu-xenial/895a2e6/ : FAILURE in 1m 09s\n- gate-glanceclient-dsvm-functional-ubuntu-xenial http://logs.openstack.org/86/400586/4/check/gate-glanceclient-dsvm-functional-ubuntu-xenial/3e3d6ba/ : FAILURE in 1m 03s\n- gate-glanceclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv http://logs.openstack.org/86/400586/4/check/gate-glanceclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv/086f035/ : FAILURE in 39s (non-voting)","accounts_in_message":[],"_revision_number":4},{"id":"beefcc6a4d7048893007ec0e140073689394dc67","author":{"_account_id":8871,"name":"Elastic Recheck","username":"elasticrecheck"},"date":"2017-06-01 10:38:18.000000000","message":"Patch Set 4:\n\nI noticed jenkins failed, I think you hit bug(s):\n\n- gate-glanceclient-dsvm-functional-ubuntu-xenial: https://bugs.launchpad.net/bugs/1497006\n- gate-python-glanceclient-docs-ubuntu-xenial: unrecognized error\n- gate-python-glanceclient-python27-ubuntu-xenial: unrecognized error\n- gate-python-glanceclient-python35: unrecognized error\n- gate-tempest-dsvm-neutron-src-python-glanceclient-ubuntu-xenial: https://bugs.launchpad.net/bugs/1497006\n\nSome of the tests failed in a way that we did not understand. Please help us classify these issues so that they can be part of Elastic Recheck http://status.openstack.org/elastic-recheck/\nFor more details on this and other bugs, please see http://status.openstack.org/elastic-recheck/","accounts_in_message":[],"_revision_number":4},{"id":"5550900c3b77678c65364c3eee6126199b7b79d8","author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"date":"2017-07-20 16:08:09.000000000","message":"Patch Set 4:\n\nrecheck","accounts_in_message":[],"_revision_number":4},{"id":"f3dbd44d1b7047c8a5753af6a4d1966ec088301b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-07-20 17:28:51.000000000","message":"Patch Set 4: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-glanceclient-docs-ubuntu-xenial http://docs-draft.openstack.org/86/400586/4/check/gate-python-glanceclient-docs-ubuntu-xenial/5dd8114//doc/build/html/ : SUCCESS in 9m 45s\n- gate-python-glanceclient-pep8-ubuntu-xenial http://logs.openstack.org/86/400586/4/check/gate-python-glanceclient-pep8-ubuntu-xenial/ef5f4e4/ : SUCCESS in 5m 38s\n- gate-python-glanceclient-python27-ubuntu-xenial http://logs.openstack.org/86/400586/4/check/gate-python-glanceclient-python27-ubuntu-xenial/9b1f8ec/ : SUCCESS in 11m 15s\n- gate-python-glanceclient-python35 http://logs.openstack.org/86/400586/4/check/gate-python-glanceclient-python35/7525626/ : SUCCESS in 5m 41s\n- gate-tempest-dsvm-neutron-src-python-glanceclient-ubuntu-xenial http://logs.openstack.org/86/400586/4/check/gate-tempest-dsvm-neutron-src-python-glanceclient-ubuntu-xenial/504913e/ : SUCCESS in 1h 19m 45s\n- gate-glanceclient-dsvm-functional-ubuntu-xenial http://logs.openstack.org/86/400586/4/check/gate-glanceclient-dsvm-functional-ubuntu-xenial/a3d44db/ : SUCCESS in 18m 08s\n- gate-glanceclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv http://logs.openstack.org/86/400586/4/check/gate-glanceclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv/dd0386f/ : FAILURE in 34m 58s (non-voting)","accounts_in_message":[],"_revision_number":4},{"id":"9ea0350b0b9ee02547e6c849dbcd8aaee4b0da5e","author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"date":"2017-07-21 04:53:10.000000000","message":"Patch Set 4: Code-Review-1\n\nits better to have a small unit test to cover this change.","accounts_in_message":[],"_revision_number":4},{"id":"df637a91253d54239de64ce65bfa147e1ed12851","author":{"_account_id":18494,"name":"Ravi Shekhar Jethani","email":"rsjethani@gmail.com","username":"rsjethani"},"date":"2017-07-24 09:26:39.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"67de7780ff3284ecf895a2895dccc8948781e003","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-07-24 10:56:49.000000000","message":"Patch Set 5: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-glanceclient-docs-ubuntu-xenial http://docs-draft.openstack.org/86/400586/5/check/gate-python-glanceclient-docs-ubuntu-xenial/ef191f2//doc/build/html/ : SUCCESS in 4m 20s\n- gate-python-glanceclient-pep8-ubuntu-xenial http://logs.openstack.org/86/400586/5/check/gate-python-glanceclient-pep8-ubuntu-xenial/73b69cb/ : SUCCESS in 4m 35s\n- gate-python-glanceclient-python27-ubuntu-xenial http://logs.openstack.org/86/400586/5/check/gate-python-glanceclient-python27-ubuntu-xenial/d74a317/ : SUCCESS in 2m 33s\n- gate-python-glanceclient-python35 http://logs.openstack.org/86/400586/5/check/gate-python-glanceclient-python35/1e4f193/ : SUCCESS in 4m 50s\n- gate-tempest-dsvm-neutron-src-python-glanceclient-ubuntu-xenial http://logs.openstack.org/86/400586/5/check/gate-tempest-dsvm-neutron-src-python-glanceclient-ubuntu-xenial/289096c/ : SUCCESS in 1h 28m 24s\n- gate-glanceclient-dsvm-functional-ubuntu-xenial http://logs.openstack.org/86/400586/5/check/gate-glanceclient-dsvm-functional-ubuntu-xenial/1263d73/ : SUCCESS in 22m 37s\n- gate-glanceclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv http://logs.openstack.org/86/400586/5/check/gate-glanceclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv/b99fcdd/ : FAILURE in 15m 30s (non-voting)","accounts_in_message":[],"_revision_number":5},{"id":"de268e4c3b16a7b58ddf4fd5684cec78aafe468c","author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"date":"2017-07-24 11:07:19.000000000","message":"Patch Set 5: Code-Review+2\n\nThank you Ravi, this looks better now!!","accounts_in_message":[],"_revision_number":5},{"id":"8088d1d95a6519e9b6497150802e4c516c32cdf6","author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"date":"2017-07-25 14:35:38.000000000","message":"Patch Set 5: Code-Review+2\n\nThis looks like a good change.  I can\u0027t think of any use case for doing an image download with no file and no redirection ... usually, people do that by mistake and ^C the mess that floods their screen, and then make the call again using redirection.\n\nAnd thanks for adding the test.\n\nNot approving workflow right now to give people time to think of a use-case that we\u0027ll be disabling with this change.","accounts_in_message":[],"_revision_number":5},{"id":"098d398614b085a3830109be736d0a9fde28d90e","author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"date":"2017-07-26 12:42:10.000000000","message":"Patch Set 5: Code-Review+2\n\nDumping the image content to the screen was prevented on change 583adc34 which introduced this check that was now moved from the bottom to the beginning of the function.\n\nBased on our fail early principles this is definitely welcome change.","accounts_in_message":[],"_revision_number":5},{"id":"dc11030cc0b0337320aba77966e7792af66dfd32","author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"date":"2017-07-26 12:54:06.000000000","message":"Patch Set 5: Workflow+1","accounts_in_message":[],"_revision_number":5},{"id":"edbe8d80ea5d13238d89b623e5fe60e65bd892d6","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-07-26 12:54:19.000000000","message":"Patch Set 5: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":5},{"id":"7f608232c018b22cd1ba9ab8ff742ec18e89ad56","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-07-26 14:15:34.000000000","message":"Patch Set 5: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-glanceclient-docs-ubuntu-xenial http://docs-draft.openstack.org/86/400586/5/gate/gate-python-glanceclient-docs-ubuntu-xenial/d585754//doc/build/html/ : SUCCESS in 2m 24s\n- gate-python-glanceclient-pep8-ubuntu-xenial http://logs.openstack.org/86/400586/5/gate/gate-python-glanceclient-pep8-ubuntu-xenial/c5fbf69/ : SUCCESS in 5m 16s\n- gate-python-glanceclient-python27-ubuntu-xenial http://logs.openstack.org/86/400586/5/gate/gate-python-glanceclient-python27-ubuntu-xenial/9f7a3cc/ : SUCCESS in 4m 15s\n- gate-python-glanceclient-python35 http://logs.openstack.org/86/400586/5/gate/gate-python-glanceclient-python35/19c0ca1/ : SUCCESS in 2m 35s\n- gate-tempest-dsvm-neutron-src-python-glanceclient-ubuntu-xenial http://logs.openstack.org/86/400586/5/gate/gate-tempest-dsvm-neutron-src-python-glanceclient-ubuntu-xenial/38659e2/ : SUCCESS in 1h 20m 27s\n- gate-glanceclient-dsvm-functional-ubuntu-xenial http://logs.openstack.org/86/400586/5/gate/gate-glanceclient-dsvm-functional-ubuntu-xenial/5780adf/ : SUCCESS in 23m 32s","accounts_in_message":[],"_revision_number":5},{"id":"e720c1c2c01b55a70b51cede60822c29187ce5a0","date":"2017-07-26 14:15:35.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":5}],"current_revision_number":5,"current_revision":"1df55dd952fe52c1c1fc2583326d017275b01ddc","revisions":{"48518f1df0ca77cafd4ec181a667de63932e5299":{"kind":"REWORK","_number":1,"created":"2016-11-22 08:25:12.000000000","uploader":{"_account_id":18494,"name":"Ravi Shekhar Jethani","email":"rsjethani@gmail.com","username":"rsjethani"},"ref":"refs/changes/86/400586/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/86/400586/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/86/400586/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/86/400586/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/86/400586/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/86/400586/1"}}},"commit":{"parents":[{"commit":"993d45293c38515279b5bffe02d60e43be0f1c68","subject":"Merge \"Add Apache 2.0 license to source file\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/993d45293c38515279b5bffe02d60e43be0f1c68"}]}],"author":{"name":"Ravi Shekhar Jethani","email":"rsjethani@gmail.com","date":"2016-10-18 08:13:06.000000000","tz":330},"committer":{"name":"Ravi Shekhar Jethani","email":"rsjethani@gmail.com","date":"2016-11-22 08:25:07.000000000","tz":330},"subject":"Validate input args before trying image download","message":"Validate input args before trying image download\n\nCurrently client is contacting glance service even if the\ncaller has niether specified any redirection nor \u0027--file\u0027\noption. This unnecessary request although isn\u0027t causing\nany critical issue but can be avoided by simply doing\ninput validation first.\n\nTrivialFix\n\nChange-Id: I841bebeda38814235079429eca0b1e5fd2f04dae\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/48518f1df0ca77cafd4ec181a667de63932e5299"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/48518f1df0ca77cafd4ec181a667de63932e5299"}]},"branch":"refs/heads/master"},"9fe9f68894938f0c9e44549213f09e704db982c7":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2017-01-25 11:18:45.000000000","uploader":{"_account_id":18494,"name":"Ravi Shekhar Jethani","email":"rsjethani@gmail.com","username":"rsjethani"},"ref":"refs/changes/86/400586/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/86/400586/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/86/400586/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/86/400586/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/86/400586/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/86/400586/2"}}},"commit":{"parents":[{"commit":"c1f54742f9ed61cd33e1f20342583bee07f1dfae","subject":"Merge \"Replace dict.iteritems() with dict.items()\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/c1f54742f9ed61cd33e1f20342583bee07f1dfae"}]}],"author":{"name":"Ravi Shekhar Jethani","email":"rsjethani@gmail.com","date":"2016-10-18 08:13:06.000000000","tz":330},"committer":{"name":"Ravi Shekhar Jethani","email":"rsjethani@gmail.com","date":"2017-01-25 11:18:45.000000000","tz":0},"subject":"Validate input args before trying image download","message":"Validate input args before trying image download\n\nCurrently client is contacting glance service even if the\ncaller has niether specified any redirection nor \u0027--file\u0027\noption. This unnecessary request although isn\u0027t causing\nany critical issue but can be avoided by simply doing\ninput validation first.\n\nTrivialFix\n\nChange-Id: I841bebeda38814235079429eca0b1e5fd2f04dae\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/9fe9f68894938f0c9e44549213f09e704db982c7"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/9fe9f68894938f0c9e44549213f09e704db982c7"}]},"branch":"refs/heads/master"},"34a494d66f71e230ad92f8840876d90e51c88419":{"kind":"NO_CODE_CHANGE","_number":3,"created":"2017-06-01 10:29:02.000000000","uploader":{"_account_id":18494,"name":"Ravi Shekhar Jethani","email":"rsjethani@gmail.com","username":"rsjethani"},"ref":"refs/changes/86/400586/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/86/400586/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/86/400586/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/86/400586/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/86/400586/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/86/400586/3"}}},"commit":{"parents":[{"commit":"c1f54742f9ed61cd33e1f20342583bee07f1dfae","subject":"Merge \"Replace dict.iteritems() with dict.items()\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/c1f54742f9ed61cd33e1f20342583bee07f1dfae"}]}],"author":{"name":"Ravi Shekhar Jethani","email":"rsjethani@gmail.com","date":"2016-10-18 08:13:06.000000000","tz":330},"committer":{"name":"Ravi Shekhar Jethani","email":"rsjethani@gmail.com","date":"2017-06-01 10:28:42.000000000","tz":0},"subject":"Validate input args before trying image download","message":"Validate input args before trying image download\n\nCurrently client is contacting glance service even if the\ncaller has niether specified any redirection nor \u0027--file\u0027\noption. This unnecessary request although isn\u0027t causing\nany critical issues but can be avoided by simply doing\ninput validation first.\n\nTrivialFix\n\nChange-Id: I841bebeda38814235079429eca0b1e5fd2f04dae\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/34a494d66f71e230ad92f8840876d90e51c88419"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/34a494d66f71e230ad92f8840876d90e51c88419"}]},"branch":"refs/heads/master"},"943869c09cbb36a2d2d306c459978cfdd260cb07":{"kind":"TRIVIAL_REBASE","_number":4,"created":"2017-06-01 10:30:01.000000000","uploader":{"_account_id":18494,"name":"Ravi Shekhar Jethani","email":"rsjethani@gmail.com","username":"rsjethani"},"ref":"refs/changes/86/400586/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/86/400586/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/86/400586/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/86/400586/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/86/400586/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/86/400586/4"}}},"commit":{"parents":[{"commit":"60c06d526c228de314ad659bda57c42750852ef9","subject":"Downloading image with --progress fails","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/60c06d526c228de314ad659bda57c42750852ef9"}]}],"author":{"name":"Ravi Shekhar Jethani","email":"rsjethani@gmail.com","date":"2016-10-18 08:13:06.000000000","tz":330},"committer":{"name":"Ravi Shekhar Jethani","email":"rsjethani@gmail.com","date":"2017-06-01 10:30:01.000000000","tz":0},"subject":"Validate input args before trying image download","message":"Validate input args before trying image download\n\nCurrently client is contacting glance service even if the\ncaller has niether specified any redirection nor \u0027--file\u0027\noption. This unnecessary request although isn\u0027t causing\nany critical issues but can be avoided by simply doing\ninput validation first.\n\nTrivialFix\n\nChange-Id: I841bebeda38814235079429eca0b1e5fd2f04dae\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/943869c09cbb36a2d2d306c459978cfdd260cb07"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/943869c09cbb36a2d2d306c459978cfdd260cb07"}]},"branch":"refs/heads/master"},"1df55dd952fe52c1c1fc2583326d017275b01ddc":{"kind":"REWORK","_number":5,"created":"2017-07-24 09:26:39.000000000","uploader":{"_account_id":18494,"name":"Ravi Shekhar Jethani","email":"rsjethani@gmail.com","username":"rsjethani"},"ref":"refs/changes/86/400586/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/86/400586/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/86/400586/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/86/400586/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/86/400586/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/86/400586/5"}}},"commit":{"parents":[{"commit":"a6e0cdf46d5fad2c6eb65d828af6734681d10cc1","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/a6e0cdf46d5fad2c6eb65d828af6734681d10cc1"}]}],"author":{"name":"Ravi Shekhar Jethani","email":"rsjethani@gmail.com","date":"2016-10-18 08:13:06.000000000","tz":330},"committer":{"name":"Ravi Shekhar Jethani","email":"rsjethani@gmail.com","date":"2017-07-24 09:24:57.000000000","tz":330},"subject":"Validate input args before trying image download","message":"Validate input args before trying image download\n\nCurrently client is contacting glance service even if the\ncaller has niether specified any redirection nor \u0027--file\u0027\noption. This unnecessary request although isn\u0027t causing\nany critical issues but can be avoided by simply doing\ninput validation first.\n\nTrivialFix\n\nChange-Id: I841bebeda38814235079429eca0b1e5fd2f04dae\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/1df55dd952fe52c1c1fc2583326d017275b01ddc"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/1df55dd952fe52c1c1fc2583326d017275b01ddc"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}