)]}'
{"glanceclient/shell.py":[{"author":{"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},"change_message_id":"53a37edd3d09ba6262fe3e1ac9b6db05ac68129b","unresolved":false,"context_lines":[{"line_number":667,"context_line":""},{"line_number":668,"context_line":"def main():"},{"line_number":669,"context_line":"    try:"},{"line_number":670,"context_line":"        # Fix for Bug#1533090"},{"line_number":671,"context_line":"        # As suggested, modified the code to make it just like the way"},{"line_number":672,"context_line":"        # it is being done in case of keystone client"},{"line_number":673,"context_line":"        argv \u003d [a for a in sys.argv[1:]]"},{"line_number":674,"context_line":"        OpenStackImagesShell().main(argv)"},{"line_number":675,"context_line":"    except KeyboardInterrupt:"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a74a57a_2f6987f9","line":672,"range":{"start_line":670,"start_character":0,"end_line":672,"end_character":53},"updated":"2016-11-28 21:09:51.000000000","message":"nit: this comment should be more descriptive instead of simply referencing keystone client.","commit_id":"f95a0bb5fdef557ee23cdb4b10a0420bc4fdf8e1"},{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"55223c784dd07a320af7af117e1f165e6b29528a","unresolved":false,"context_lines":[{"line_number":670,"context_line":"        # Fix for Bug#1533090"},{"line_number":671,"context_line":"        # As suggested, modified the code to make it just like the way"},{"line_number":672,"context_line":"        # it is being done in case of keystone client"},{"line_number":673,"context_line":"        argv \u003d [a for a in sys.argv[1:]]"},{"line_number":674,"context_line":"        OpenStackImagesShell().main(argv)"},{"line_number":675,"context_line":"    except KeyboardInterrupt:"},{"line_number":676,"context_line":"        utils.exit(\u0027... terminating glance client\u0027, exit_code\u003d130)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a71b18c_06fe3105","line":673,"updated":"2016-12-07 20:53:52.000000000","message":"Not only is Alex right that this should be a *far* more descriptive and *explanatory* comment, what you\u0027re doing here is dubious at best.\n\nWe undoubtedly were decoding the arguments for a reason. Granted it appears we didn\u0027t have tests around that so it\u0027s hard to determine *why*. Absent failing tests or an explanation in the form of a comment, we can look at the git-blame for information. The line this replaces was added in a8a7c689 which modified the line updated in b818826420a383e733ec40881ff436595ca57cc8. That was after 7818387d4ac4c4a20899fc4470da86c5bcabf183 updated us to oslo.utils. Finally, after that we can find commit 55cb4f4473a6fc429524e7c4848379013a4d2d1d which explains:\n\n    Currently glanceclient doesn\u0027t support non-ASCII characters for images\n    names and properties (names and values as well).\n\n    [...]\n\n    The major change is that all inputs will be decoded and will kept as\n    such inside the client\u0027s functions and will then be encoded before\n    being printed / sent out the client.\n\nSo we can see that decoding everything is in fact *necessary* even if we don\u0027t have tests asserting that.\n\nEven if we hadn\u0027t been able to so quickly dive through our git history to determine that or had found it wasn\u0027t necessary, you still should have instead done\n\n    OpenStackImagesShell().main(sys.argv[1:])\n\nThat way instead of making two lists you only made one new one in memory.","commit_id":"f95a0bb5fdef557ee23cdb4b10a0420bc4fdf8e1"}]}