)]}'
{"id":"openstack%2Fpython-glanceclient~419807","triplet_id":"openstack%2Fpython-glanceclient~master~Ieb263dedba66294070e56a3ca937bb8351dbd53d","project":"openstack/python-glanceclient","branch":"master","topic":"ploop_disk_format","hashtags":[],"change_id":"Ieb263dedba66294070e56a3ca937bb8351dbd53d","subject":"Add ploop to supported disk_formats","status":"ABANDONED","created":"2017-01-13 08:19:30.000000000","updated":"2017-01-23 01:36:31.000000000","total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"893f85fc62674dce625e00ad7e32a14c6045e377","_number":419807,"virtual_id_number":419807,"owner":{"_account_id":20146,"name":"yuyafei","email":"yu.yafei@foxmail.com","username":"yuyafei"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},{"value":1,"date":"2017-01-13 09:21:58.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"rejected":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"all":[{"value":-2,"date":"2017-01-20 19:20:57.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},{"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":2},"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},{"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Top Priority / Holds Gate"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-01-13 09:21:58.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2017-01-20 19:20:57.000000000","updated_by":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"reviewer":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"state":"REVIEWER"}],"messages":[{"id":"b62b8f670715cc02d200760832efe821ff0bd254","author":{"_account_id":20146,"name":"yuyafei","email":"yu.yafei@foxmail.com","username":"yuyafei"},"date":"2017-01-13 08:19:30.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"245d991e68da9873151a42a5051f1bdc7287b54b","author":{"_account_id":20146,"name":"yuyafei","email":"yu.yafei@foxmail.com","username":"yuyafei"},"date":"2017-01-13 08:20:10.000000000","message":"Topic changed from master_ploop to ploop_disk_format","accounts_in_message":[],"_revision_number":1},{"id":"f9fbad8f1461dea14e5d9a103c0755eebbff8a85","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-01-13 09:21:58.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-glanceclient-docs-ubuntu-xenial http://docs-draft.openstack.org/07/419807/1/check/gate-python-glanceclient-docs-ubuntu-xenial/d308759//doc/build/html/ : SUCCESS in 3m 54s\n- gate-python-glanceclient-pep8-ubuntu-xenial http://logs.openstack.org/07/419807/1/check/gate-python-glanceclient-pep8-ubuntu-xenial/77b44cc/ : SUCCESS in 2m 23s\n- gate-python-glanceclient-python27-ubuntu-xenial http://logs.openstack.org/07/419807/1/check/gate-python-glanceclient-python27-ubuntu-xenial/c99474f/ : SUCCESS in 2m 23s\n- gate-python-glanceclient-python35 http://logs.openstack.org/07/419807/1/check/gate-python-glanceclient-python35/96c9f61/ : SUCCESS in 3m 03s\n- gate-tempest-dsvm-neutron-src-python-glanceclient-ubuntu-xenial http://logs.openstack.org/07/419807/1/check/gate-tempest-dsvm-neutron-src-python-glanceclient-ubuntu-xenial/1f3f15e/ : SUCCESS in 1h 01m 22s\n- gate-glanceclient-dsvm-functional-ubuntu-xenial http://logs.openstack.org/07/419807/1/check/gate-glanceclient-dsvm-functional-ubuntu-xenial/566c972/ : SUCCESS in 31m 17s\n- gate-glanceclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv http://logs.openstack.org/07/419807/1/check/gate-glanceclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv/09fea24/ : FAILURE in 18m 26s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"e5586c8e4bfb17c76618c4cc5bcdb60cdd99b1af","author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"date":"2017-01-13 15:20:03.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)\n\nOne nit inline.\n\nAlso, please add some tests so that we don\u0027t get a regression if someone drops \u0027ploop\u0027 from the schema by mistake.  You can look at the commit for when \u0027vhdx\u0027 disk_format was added for an example: Change-Id: I7d82d4a4bdb180a53e86552f6f6b3bed908e6dc0\n\nFinally, my last comment here is more something to think about than a requirement for this patch ... I\u0027m hoping maybe you\u0027ll have some ideas.  There\u0027s got to be a better way to do this.  The tests I\u0027m asking you to add make sure that the local glanceclient copy of the image schema is accurate with respect to the glanceclient code, but they don\u0027t check that the glanceclient copy of the image schema is in fact an accurate copy of what\u0027s currently in glance.  It would be good if we could automate this instead of relying on helpful people like yourself to notice that the schemas have gone out of sync.  But this should probably be done in a separate patch, anyway.","accounts_in_message":[],"_revision_number":1},{"id":"156d8366bac351d4792e591cb2cd9323ff8f100c","author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"date":"2017-01-18 15:21:59.000000000","message":"Patch Set 1:\n\nDuplicated by https://review.openstack.org/#/c/421868/","accounts_in_message":[],"_revision_number":1},{"id":"fbd8fd3150e991b880b74b2dd993adc2be7a6246","author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"date":"2017-01-20 19:20:57.000000000","message":"Patch Set 1: Code-Review-2\n\nEvgeny made you a co-author on https://review.openstack.org/#/c/421868/ , so please abandon this patch (the other patch already has tests).  Thanks!","accounts_in_message":[],"_revision_number":1},{"id":"893f85fc62674dce625e00ad7e32a14c6045e377","author":{"_account_id":20146,"name":"yuyafei","email":"yu.yafei@foxmail.com","username":"yuyafei"},"date":"2017-01-23 01:36:31.000000000","message":"Abandoned\n\nhttps://review.openstack.org/#/c/421868/","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"3764477062a73afe68c8a22643a8ff03721fe30b","revisions":{"3764477062a73afe68c8a22643a8ff03721fe30b":{"kind":"REWORK","_number":1,"created":"2017-01-13 08:19:30.000000000","uploader":{"_account_id":20146,"name":"yuyafei","email":"yu.yafei@foxmail.com","username":"yuyafei"},"ref":"refs/changes/07/419807/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/07/419807/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/07/419807/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/07/419807/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/07/419807/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/07/419807/1"}}},"commit":{"parents":[{"commit":"efb5e2aa32db3f36557abdb1ddf85709b116e746","subject":"Add vhdx in disk_format","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/efb5e2aa32db3f36557abdb1ddf85709b116e746"}]}],"author":{"name":"yuyafei","email":"yu.yafei@zte.com.cn","date":"2017-01-13 08:40:58.000000000","tz":480},"committer":{"name":"yuyafei","email":"yu.yafei@zte.com.cn","date":"2017-01-13 08:42:58.000000000","tz":480},"subject":"Add ploop to supported disk_formats","message":"Add ploop to supported disk_formats\n\nSupported ploop  disk_formats has been successfully merged\ninto glance.\nId:Ice74c4bf9ed2efae519930f33b2fa2b3c162e8c4\n\nChange-Id: Ieb263dedba66294070e56a3ca937bb8351dbd53d\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/3764477062a73afe68c8a22643a8ff03721fe30b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/3764477062a73afe68c8a22643a8ff03721fe30b"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}