)]}'
{"glanceclient/v1/shell.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"d1ce14f26ca720a0453cd1a25feff88e5dec21cf","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"CONTAINER_FORMATS \u003d \u0027Acceptable formats: ami, ari, aki, bare, and ovf.\u0027"},{"line_number":33,"context_line":"DISK_FORMATS \u003d (\u0027Acceptable formats: ami, ari, aki, vhd, vmdk, raw, \u0027"},{"line_number":34,"context_line":"                \u0027qcow2, vdi, iso and ploop.\u0027)"},{"line_number":35,"context_line":"DATA_FIELDS \u003d (\u0027location\u0027, \u0027copy_from\u0027, \u0027file\u0027)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"_bool_strict \u003d functools.partial(strutils.bool_from_string, strict\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a3c09a3_aea4854a","line":34,"range":{"start_line":34,"start_character":29,"end_line":34,"end_character":37},"updated":"2017-01-18 15:21:22.000000000","message":"Also, if you do hard code it, openstack style is that a comma is required between \u0027iso\u0027 and \u0027and\u0027.","commit_id":"05768536980c51a1916af70299efe7398a32f89d"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"d1ce14f26ca720a0453cd1a25feff88e5dec21cf","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"CONTAINER_FORMATS \u003d \u0027Acceptable formats: ami, ari, aki, bare, and ovf.\u0027"},{"line_number":33,"context_line":"DISK_FORMATS \u003d (\u0027Acceptable formats: ami, ari, aki, vhd, vmdk, raw, \u0027"},{"line_number":34,"context_line":"                \u0027qcow2, vdi, iso and ploop.\u0027)"},{"line_number":35,"context_line":"DATA_FIELDS \u003d (\u0027location\u0027, \u0027copy_from\u0027, \u0027file\u0027)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"_bool_strict \u003d functools.partial(strutils.bool_from_string, strict\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a3c09a3_6e529d68","line":34,"updated":"2017-01-18 15:21:22.000000000","message":"Note that DISK_FORMATS is out of sync with the schema--it\u0027s missing vhdx, which apparently got missed in Change-Id: I7d82d4a4bdb180a53e86552f6f6b3bed908e6dc0\n\nI think CONTAINER_FORMATS is also outdated (it\u0027s missing docker)\n\nI realize that this isn\u0027t your fault, but is there a way we can pull the list of acceptable values from the local schema instead of hard-coding it here, so we can avoid having to worry about this in the future?","commit_id":"05768536980c51a1916af70299efe7398a32f89d"},{"author":{"_account_id":21284,"name":"Pavel Gluschak (scsnow)","email":"pglushchak@virtuozzo.com","username":"scsnow"},"change_message_id":"a493ab302f0fa5a401687ec9addf3d1b8b41d9fb","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"CONTAINER_FORMATS \u003d \u0027Acceptable formats: ami, ari, aki, bare, and ovf.\u0027"},{"line_number":33,"context_line":"DISK_FORMATS \u003d (\u0027Acceptable formats: ami, ari, aki, vhd, vmdk, raw, \u0027"},{"line_number":34,"context_line":"                \u0027qcow2, vdi, iso and ploop.\u0027)"},{"line_number":35,"context_line":"DATA_FIELDS \u003d (\u0027location\u0027, \u0027copy_from\u0027, \u0027file\u0027)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"_bool_strict \u003d functools.partial(strutils.bool_from_string, strict\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a3905b3_ab1441f5","line":34,"range":{"start_line":34,"start_character":29,"end_line":34,"end_character":37},"in_reply_to":"5a3905b3_1bb05ddd","updated":"2017-01-19 15:35:13.000000000","message":"I agree, that referencing v2 image schema in v1 code is not a good idea. So I suggest to leave things as is.\nA small nit from my side. We may want to update container and disk formats here with missing values mentioned by Brian. And define DISK_FORMATS as string rather that tuple with a single value.","commit_id":"05768536980c51a1916af70299efe7398a32f89d"},{"author":{"_account_id":13431,"name":"Evgeny Antyshev","email":"eantyshev@gmail.com","username":"eantyshev"},"change_message_id":"794b58e73ed071ddfbdb86a7683e14fd19e7e385","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"CONTAINER_FORMATS \u003d \u0027Acceptable formats: ami, ari, aki, bare, and ovf.\u0027"},{"line_number":33,"context_line":"DISK_FORMATS \u003d (\u0027Acceptable formats: ami, ari, aki, vhd, vmdk, raw, \u0027"},{"line_number":34,"context_line":"                \u0027qcow2, vdi, iso and ploop.\u0027)"},{"line_number":35,"context_line":"DATA_FIELDS \u003d (\u0027location\u0027, \u0027copy_from\u0027, \u0027file\u0027)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"_bool_strict \u003d functools.partial(strutils.bool_from_string, strict\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a3905b3_1bb05ddd","line":34,"range":{"start_line":34,"start_character":29,"end_line":34,"end_character":37},"in_reply_to":"7a3c09a3_aea4854a","updated":"2017-01-19 14:30:03.000000000","message":"The file is really outdated, but it is probably because of glance v1 api being deprecated (hence, hardly worth much effort). I would prefer to not touch it at all, if this is an option here.\n\nSo, I would just fix it to conform to the doc style.","commit_id":"05768536980c51a1916af70299efe7398a32f89d"}]}