)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"411300480304e318df81e0ea6c01e53ff2aaede5","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Above log will be logged twice on the console."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Removed logging of x-openstack-request-id in case of SessionClient as it"},{"line_number":28,"context_line":"is already logged in keystoneauth1. x-openstack-request-id will only be"},{"line_number":29,"context_line":"logged once on console if HTTPClient is used."},{"line_number":30,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5a3905b3_261ca7c0","line":27,"range":{"start_line":27,"start_character":53,"end_line":27,"end_character":66},"updated":"2017-01-21 16:01:32.000000000","message":"does this only work because SessionClient does not extend _BaseClient?","commit_id":"1151a203d592f321f8c4206f6432bf6c6551a2aa"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"3e75eeaaa5f553ec09b88534974afcf32d9aeb10","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Above log will be logged twice on the console."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Removed logging of x-openstack-request-id in case of SessionClient as it"},{"line_number":28,"context_line":"is already logged in keystoneauth1. x-openstack-request-id will only be"},{"line_number":29,"context_line":"logged once on console if HTTPClient is used."},{"line_number":30,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5a3905b3_5ba778bc","line":27,"range":{"start_line":27,"start_character":53,"end_line":27,"end_character":66},"in_reply_to":"5a3905b3_261ca7c0","updated":"2017-01-24 06:33:49.000000000","message":"Hi Steve,\n\nBoth SessionClient and HTTPClient are extending \u0027_BaseHTTPClient\u0027 class that\u0027s why earlier we had made changes in handel_response method so that it will log request-id for both SessionClient and HTTPClient.\n\nNow as this request-id is already logged in keystoneauth1 there is no need to log it again in case of SessionClient is used in glanceclient. So we have moved that code out of \u0027_BaseHTTPClient\u0027 handle_response method to HTTPClient.\n\nPlease let me know if you have any questions about the same.","commit_id":"1151a203d592f321f8c4206f6432bf6c6551a2aa"}]}