)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},"change_message_id":"070a356315f3e2c8e60c90c6dc4303288cfb5dc5","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2017-02-06 11:41:14 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Added a check for the length of the tag to be less than 255"},{"line_number":8,"context_line":"Closes-Bug: #1640442"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Change-Id: Ifb21efef189f87a9f5e36f5e1941089d854b1022"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bff0334d_a522c1b7","line":8,"updated":"2017-04-11 17:26:12.000000000","message":"you need a blank line after the title, before the Closes-Bug line","commit_id":"a7628ef49dcfe19931c7130eecc9e88f63a45718"}],"glanceclient/v2/image_tags.py":[{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"bae0d6c7a406adbff4bd33023d9a42033ff0dba8","unresolved":false,"context_lines":[{"line_number":42,"context_line":"            resp, body \u003d self.http_client.put(url)"},{"line_number":43,"context_line":"            return (resp, body), resp"},{"line_number":44,"context_line":"        else:"},{"line_number":45,"context_line":"            utils.exit(\u0027Tag length should be less than 256\u0027)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    @utils.add_req_id_to_object()"},{"line_number":48,"context_line":"    def delete(self, image_id, tag_value):"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f231b9d_eac6689a","line":45,"updated":"2017-06-15 16:21:19.000000000","message":"It will be funny if Nova or any other service executes this code :) \n\nIt should be \"raise exc.HTTPBadRequest(\u0027Tag length should be less than 256\u0027)\", not utils.exit","commit_id":"d76777f97a1365fdafb47467aa17600c409118ba"},{"author":{"_account_id":20401,"name":"M V P Nitesh","email":"parimalanitesh@gmail.com","username":"mvpnitesh"},"change_message_id":"3f45737754278b7430b8cbdf42376146eefcff50","unresolved":false,"context_lines":[{"line_number":42,"context_line":"            resp, body \u003d self.http_client.put(url)"},{"line_number":43,"context_line":"            return (resp, body), resp"},{"line_number":44,"context_line":"        else:"},{"line_number":45,"context_line":"            utils.exit(\u0027Tag length should be less than 256\u0027)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    @utils.add_req_id_to_object()"},{"line_number":48,"context_line":"    def delete(self, image_id, tag_value):"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f231b9d_8ee376d9","line":45,"in_reply_to":"7f231b9d_eac6689a","updated":"2017-06-16 05:13:05.000000000","message":"Mike thanks for the review, i\u0027ll change it and i\u0027ll put a new patch.","commit_id":"d76777f97a1365fdafb47467aa17600c409118ba"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"9995844c1c8ce71ca455029c4b57557d79817c3f","unresolved":false,"context_lines":[{"line_number":43,"context_line":"            resp, body \u003d self.http_client.put(url)"},{"line_number":44,"context_line":"            return (resp, body), resp"},{"line_number":45,"context_line":"        else:"},{"line_number":46,"context_line":"            raise exc.HTTPBadRequest(\u0027Tag length should be less than 256\u0027)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    @utils.add_req_id_to_object()"},{"line_number":49,"context_line":"    def delete(self, image_id, tag_value):"}],"source_content_type":"text/x-python","patch_set":4,"id":"7f231b9d_78c33658","line":46,"range":{"start_line":46,"start_character":37,"end_line":46,"end_character":38},"updated":"2017-06-16 13:18:48.000000000","message":"Exception messages should use the _() translation marker.","commit_id":"49c15a7995c659fb9b699901763115514747086d"},{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"c0128acc4a9162901bddf98479324c8b7d28d2fe","unresolved":false,"context_lines":[{"line_number":43,"context_line":"            resp, body \u003d self.http_client.put(url)"},{"line_number":44,"context_line":"            return (resp, body), resp"},{"line_number":45,"context_line":"        else:"},{"line_number":46,"context_line":"            raise exc.HTTPBadRequest(\u0027Tag length should be less than 256\u0027)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    @utils.add_req_id_to_object()"},{"line_number":49,"context_line":"    def delete(self, image_id, tag_value):"}],"source_content_type":"text/x-python","patch_set":4,"id":"7f231b9d_ab44cb74","line":46,"range":{"start_line":46,"start_character":37,"end_line":46,"end_character":38},"in_reply_to":"7f231b9d_78c33658","updated":"2017-06-16 21:00:09.000000000","message":"I think that this is not an option in this case. Usually such lines are not translated in clients:\n\nFor instance: https://github.com/openstack/python-glanceclient/blob/master/glanceclient/v2/images.py#L160-L161","commit_id":"49c15a7995c659fb9b699901763115514747086d"},{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"321c990574ec5e8e7b718eaa172aa68b5a3dda20","unresolved":false,"context_lines":[{"line_number":43,"context_line":"            resp, body \u003d self.http_client.put(url)"},{"line_number":44,"context_line":"            return (resp, body), resp"},{"line_number":45,"context_line":"        else:"},{"line_number":46,"context_line":"            raise exc.HTTPBadRequest(_(\u0027Tag length should be less than 256\u0027))"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    @utils.add_req_id_to_object()"},{"line_number":49,"context_line":"    def delete(self, image_id, tag_value):"}],"source_content_type":"text/x-python","patch_set":5,"id":"7f231b9d_3d6b3ef1","line":46,"updated":"2017-06-19 15:16:21.000000000","message":"Previous patch was correct :) You shouldn\u0027t use _ here, because these exceptions are not translated. Example: https://github.com/openstack/python-glanceclient/blob/master/glanceclient/v2/images.py#L160-L161\n\nBut if you decided to use _ you have to import it first, like here: https://github.com/openstack/python-glanceclient/blob/60c06d526c228de314ad659bda57c42750852ef9/glanceclient/common/utils.py#L41","commit_id":"215448afff1a5436773d49d65aa288df6c6e9a1d"},{"author":{"_account_id":20401,"name":"M V P Nitesh","email":"parimalanitesh@gmail.com","username":"mvpnitesh"},"change_message_id":"3e3b09d20fae49731e4ff0948f0d453386168c97","unresolved":false,"context_lines":[{"line_number":43,"context_line":"            resp, body \u003d self.http_client.put(url)"},{"line_number":44,"context_line":"            return (resp, body), resp"},{"line_number":45,"context_line":"        else:"},{"line_number":46,"context_line":"            raise exc.HTTPBadRequest(_(\u0027Tag length should be less than 256\u0027))"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    @utils.add_req_id_to_object()"},{"line_number":49,"context_line":"    def delete(self, image_id, tag_value):"}],"source_content_type":"text/x-python","patch_set":5,"id":"7f231b9d_e2050b16","line":46,"in_reply_to":"7f231b9d_3d6b3ef1","updated":"2017-06-20 05:57:28.000000000","message":"Actually on seeing Sean comment i\u0027ve changed it. I\u0027ll revert back the code and i\u0027ll put a new patch","commit_id":"215448afff1a5436773d49d65aa288df6c6e9a1d"}]}