)]}'
{"id":"openstack%2Fpython-glanceclient~430581","triplet_id":"openstack%2Fpython-glanceclient~master~I71c13040318eca6e5ed993e8aa03f8003986a71c","project":"openstack/python-glanceclient","branch":"master","topic":"six.iteritems","hashtags":[],"change_id":"I71c13040318eca6e5ed993e8aa03f8003986a71c","subject":"Replace six.iteritems() with .items()","status":"MERGED","created":"2017-02-08 06:31:01.000000000","updated":"2017-06-28 14:49:38.000000000","submitted":"2017-06-28 14:49:38.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"00c6601b6a720b08352131e5c0d2bdaf4f779684","_number":430581,"virtual_id_number":430581,"owner":{"_account_id":12736,"name":"Xuepeng Ji","email":"ji.xuepeng@zte.com.cn","username":"jixuepeng"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},{"value":0,"_account_id":25571,"name":"Rajat Sharma","email":"rajat.sharma@india.nec.com","username":"rajat29"},{"value":2,"date":"2017-06-28 14:49:38.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"value":0,"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"recommended":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"all":[{"value":1,"date":"2017-06-14 15:25:44.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":2,"date":"2017-06-28 13:29:38.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},{"value":-1,"date":"2017-06-14 04:33:48.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":25571,"name":"Rajat Sharma","email":"rajat.sharma@india.nec.com","username":"rajat29"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2017-06-12 13:21:09.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"value":2,"date":"2017-06-01 13:06:26.000000000","_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"all":[{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":1,"date":"2017-06-28 13:29:38.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},{"value":0,"_account_id":25571,"name":"Rajat Sharma","email":"rajat.sharma@india.nec.com","username":"rajat29"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"value":0,"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},{"value":0,"_account_id":25571,"name":"Rajat Sharma","email":"rajat.sharma@india.nec.com","username":"rajat29"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"value":0,"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Top Priority / Holds Gate"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"_account_id":25571,"name":"Rajat Sharma","email":"rajat.sharma@india.nec.com","username":"rajat29"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-06-01 13:06:26.000000000","updated_by":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"reviewer":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"state":"REVIEWER"},{"updated":"2017-06-12 13:21:09.000000000","updated_by":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"reviewer":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"state":"REVIEWER"},{"updated":"2017-06-14 04:33:48.000000000","updated_by":{"_account_id":25571,"name":"Rajat Sharma","email":"rajat.sharma@india.nec.com","username":"rajat29"},"reviewer":{"_account_id":25571,"name":"Rajat Sharma","email":"rajat.sharma@india.nec.com","username":"rajat29"},"state":"REVIEWER"},{"updated":"2017-06-14 15:25:44.000000000","updated_by":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"reviewer":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"state":"REVIEWER"},{"updated":"2017-06-28 13:29:38.000000000","updated_by":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"reviewer":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"state":"REVIEWER"},{"updated":"2017-06-28 14:49:38.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"e18452c9709db2a7d156be681dacfbe0652cc62f","author":{"_account_id":12736,"name":"Xuepeng Ji","email":"ji.xuepeng@zte.com.cn","username":"jixuepeng"},"date":"2017-02-08 06:31:01.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"b3ee3e7f98e066d8334133cb4f1d28cb1ee518aa","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-02-08 08:03:11.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-glanceclient-docs-ubuntu-xenial http://docs-draft.openstack.org/81/430581/1/check/gate-python-glanceclient-docs-ubuntu-xenial/1371ecc//doc/build/html/ : SUCCESS in 2m 26s\n- gate-python-glanceclient-pep8-ubuntu-xenial http://logs.openstack.org/81/430581/1/check/gate-python-glanceclient-pep8-ubuntu-xenial/2ae81f1/ : SUCCESS in 2m 29s\n- gate-python-glanceclient-python27-ubuntu-xenial http://logs.openstack.org/81/430581/1/check/gate-python-glanceclient-python27-ubuntu-xenial/b82544a/ : SUCCESS in 2m 10s\n- gate-python-glanceclient-python35 http://logs.openstack.org/81/430581/1/check/gate-python-glanceclient-python35/3fab72e/ : SUCCESS in 2m 08s\n- gate-tempest-dsvm-neutron-src-python-glanceclient-ubuntu-xenial http://logs.openstack.org/81/430581/1/check/gate-tempest-dsvm-neutron-src-python-glanceclient-ubuntu-xenial/65ed3a8/ : SUCCESS in 1h 30m 40s\n- gate-glanceclient-dsvm-functional-ubuntu-xenial http://logs.openstack.org/81/430581/1/check/gate-glanceclient-dsvm-functional-ubuntu-xenial/cb9ce32/ : SUCCESS in 16m 29s\n- gate-glanceclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv http://logs.openstack.org/81/430581/1/check/gate-glanceclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv/780ca98/ : FAILURE in 18m 27s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"d267cbc0fedc6cbecc816f8aeffba72bed3ca44c","author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"date":"2017-06-01 13:06:26.000000000","message":"Patch Set 1: Code-Review+2\n\nI have no objections :) Thanks!","accounts_in_message":[],"_revision_number":1},{"id":"44d82363ad56b4c979f3eb5e4e301f7b3c27ae27","author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"date":"2017-06-12 13:21:09.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"d36f21e307a970a51ee97764f8daae9e273234ae","author":{"_account_id":25571,"name":"Rajat Sharma","email":"rajat.sharma@india.nec.com","username":"rajat29"},"date":"2017-06-14 04:33:48.000000000","message":"Patch Set 1: Code-Review-1\n\nDuplicate Patch\nhttps://review.openstack.org/#/c/451757/","accounts_in_message":[],"_revision_number":1},{"id":"15a9b0882c10615caf3d0d53ccb399321aade235","author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"date":"2017-06-14 11:42:42.000000000","message":"Patch Set 1:\n\nRajat, I think this one was uploaded earlier (Feb, 8 vs Mar, 30). Plus it\u0027s more complete, because it also fixes glanceclient/tests/unit/v2/test_metadefs_objects.py\n\nI\u0027m going to -2 on #451757 to prevent future confusions.","accounts_in_message":[],"_revision_number":1},{"id":"c792ca00bd80bb147c2960579f214c303ad8d5cf","author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"date":"2017-06-14 15:25:44.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"901992e7d0fab1131b2ad1ce838ac2703c051afd","author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"date":"2017-06-14 15:42:14.000000000","message":"Patch Set 1:\n\nJust to note, this was started here: https://review.openstack.org/#/c/334128/\n\nBut that one is very limited in what it\u0027s covering and it has not been updated for a very long time, so I think we should proceed with this patch.","accounts_in_message":[],"_revision_number":1},{"id":"1c13479e0fba21b9e82f4d0a857f9f535578bf86","author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"date":"2017-06-28 13:29:38.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"20fbaaef1efe9f3114b55ecd1c146792c649f2bc","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-06-28 13:29:48.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"5c523d5bb90c0ac4dbd9ad76d05c1cee7580a457","date":"2017-06-28 14:49:38.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":1},{"id":"69b6a8e782804c598e86bc862f97530a4e9b3d53","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-06-28 14:49:38.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-glanceclient-docs-ubuntu-xenial http://docs-draft.openstack.org/81/430581/1/gate/gate-python-glanceclient-docs-ubuntu-xenial/3b88dd3//doc/build/html/ : SUCCESS in 4m 14s\n- gate-python-glanceclient-pep8-ubuntu-xenial http://logs.openstack.org/81/430581/1/gate/gate-python-glanceclient-pep8-ubuntu-xenial/64fafeb/ : SUCCESS in 4m 45s\n- gate-python-glanceclient-python27-ubuntu-xenial http://logs.openstack.org/81/430581/1/gate/gate-python-glanceclient-python27-ubuntu-xenial/56356d2/ : SUCCESS in 2m 47s\n- gate-python-glanceclient-python35 http://logs.openstack.org/81/430581/1/gate/gate-python-glanceclient-python35/8c0785d/ : SUCCESS in 4m 52s\n- gate-tempest-dsvm-neutron-src-python-glanceclient-ubuntu-xenial http://logs.openstack.org/81/430581/1/gate/gate-tempest-dsvm-neutron-src-python-glanceclient-ubuntu-xenial/91a4ee0/ : SUCCESS in 1h 18m 32s\n- gate-glanceclient-dsvm-functional-ubuntu-xenial http://logs.openstack.org/81/430581/1/gate/gate-glanceclient-dsvm-functional-ubuntu-xenial/9080ed3/ : SUCCESS in 16m 00s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"5fca39dbde82d4cf836fa666b549b606f7ccdb7f","revisions":{"5fca39dbde82d4cf836fa666b549b606f7ccdb7f":{"kind":"REWORK","_number":1,"created":"2017-02-08 06:31:01.000000000","uploader":{"_account_id":12736,"name":"Xuepeng Ji","email":"ji.xuepeng@zte.com.cn","username":"jixuepeng"},"ref":"refs/changes/81/430581/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/81/430581/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/81/430581/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/81/430581/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/81/430581/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/81/430581/1"}}},"commit":{"parents":[{"commit":"c1f54742f9ed61cd33e1f20342583bee07f1dfae","subject":"Merge \"Replace dict.iteritems() with dict.items()\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/c1f54742f9ed61cd33e1f20342583bee07f1dfae"}]}],"author":{"name":"ji-xuepeng","email":"ji.xuepeng@zte.com.cn","date":"2017-02-08 08:27:54.000000000","tz":480},"committer":{"name":"ji-xuepeng","email":"ji.xuepeng@zte.com.cn","date":"2017-02-08 08:33:46.000000000","tz":480},"subject":"Replace six.iteritems() with .items()","message":"Replace six.iteritems() with .items()\n\n1.As mentioned in [1], we should avoid usingg\nsix.iteritems to achieve iterators. We can\nuse dict.items instead, as it will return\niterators in PY3 as well. And dict.items/keys\nwill more readable. 2.In py2, the performance\nabout list should be negligible, see the link [2].\n[1] https://wiki.openstack.org/wiki/Python3\n[2] http://lists.openstack.org/pipermail/openstack-dev/2015-June/066391.html\n\nChange-Id: I71c13040318eca6e5ed993e8aa03f8003986a71c\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/5fca39dbde82d4cf836fa666b549b606f7ccdb7f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/5fca39dbde82d4cf836fa666b549b606f7ccdb7f"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}