)]}'
{"id":"openstack%2Fpython-glanceclient~450424","triplet_id":"openstack%2Fpython-glanceclient~master~I183d412516d0c427d6f958ffe90a43a8e5e5a1a7","project":"openstack/python-glanceclient","branch":"master","topic":"bug/1676550","hashtags":[],"change_id":"I183d412516d0c427d6f958ffe90a43a8e5e5a1a7","subject":"[WIP] Use encode_headers() after setting common headers in SessionClient","status":"ABANDONED","created":"2017-03-27 19:13:06.000000000","updated":"2017-12-02 20:11:20.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"6ac64d9c1d4edb6197b361f6e9bead9e36a2bce1","_number":450424,"virtual_id_number":450424,"owner":{"_account_id":18335,"name":"Pushkar Umaranikar","email":"pushkar.umaranikar@intel.com","username":"pushkarumaranikar"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"date":"2017-03-28 16:04:39.000000000","_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},{"value":-1,"date":"2017-05-24 22:38:45.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"date":"2017-03-28 17:26:11.000000000","_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},{"date":"2017-03-28 21:27:31.000000000","_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"all":[{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":-1,"date":"2017-05-22 12:56:52.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":2},"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Top Priority / Holds Gate"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-03-28 16:04:39.000000000","updated_by":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"reviewer":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"state":"REVIEWER"},{"updated":"2017-03-28 17:26:11.000000000","updated_by":{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},"reviewer":{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},"state":"REVIEWER"},{"updated":"2017-03-28 21:27:31.000000000","updated_by":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"reviewer":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"state":"REVIEWER"},{"updated":"2017-05-22 12:56:52.000000000","updated_by":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"reviewer":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"state":"REVIEWER"},{"updated":"2017-05-24 22:38:45.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"4f7693b6d1653e48f86774cf1e2d7f2b9fffd7a3","author":{"_account_id":18335,"name":"Pushkar Umaranikar","email":"pushkar.umaranikar@intel.com","username":"pushkarumaranikar"},"date":"2017-03-27 19:13:06.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"0d8cdf51740127666725663180be4d2ce9d28de5","author":{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},"date":"2017-03-27 19:23:18.000000000","message":"Patch Set 1:\n\ndoes this overlap with https://review.openstack.org/#/c/396816/\nand bug #1641239 ?","accounts_in_message":[],"_revision_number":1},{"id":"cfcac9d7533edddefd69d349d58f970a686860fd","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-03-27 20:34:15.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-glanceclient-docs-ubuntu-xenial http://docs-draft.openstack.org/24/450424/1/check/gate-python-glanceclient-docs-ubuntu-xenial/a0cf973//doc/build/html/ : SUCCESS in 3m 53s\n- gate-python-glanceclient-pep8-ubuntu-xenial http://logs.openstack.org/24/450424/1/check/gate-python-glanceclient-pep8-ubuntu-xenial/5787cf6/ : SUCCESS in 4m 18s\n- gate-python-glanceclient-python27-ubuntu-xenial http://logs.openstack.org/24/450424/1/check/gate-python-glanceclient-python27-ubuntu-xenial/c443ede/ : SUCCESS in 4m 01s\n- gate-python-glanceclient-python35 http://logs.openstack.org/24/450424/1/check/gate-python-glanceclient-python35/dbc274b/ : SUCCESS in 4m 10s\n- gate-tempest-dsvm-neutron-src-python-glanceclient-ubuntu-xenial http://logs.openstack.org/24/450424/1/check/gate-tempest-dsvm-neutron-src-python-glanceclient-ubuntu-xenial/3380d2e/ : SUCCESS in 1h 19m 13s\n- gate-glanceclient-dsvm-functional-ubuntu-xenial http://logs.openstack.org/24/450424/1/check/gate-glanceclient-dsvm-functional-ubuntu-xenial/d19cf08/ : SUCCESS in 17m 19s\n- gate-glanceclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv http://logs.openstack.org/24/450424/1/check/gate-glanceclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv/1107fef/ : FAILURE in 25m 30s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"925e5721846781c294d2621d5bb50fa8ad083a7a","author":{"_account_id":18335,"name":"Pushkar Umaranikar","email":"pushkar.umaranikar@intel.com","username":"pushkarumaranikar"},"date":"2017-03-28 15:18:21.000000000","message":"Patch Set 2: Published edit on patch set 1","accounts_in_message":[],"_revision_number":2},{"id":"de2f4abcfdf1dd2c34aac2fc04fa5a93d91ab1b3","author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"date":"2017-03-28 16:04:39.000000000","message":"Patch Set 2:\n\nIt looks like this does overlap with https://review.openstack.org/#/c/396816/ \n\nSince there\u0027s been no action on that other patch since December, I\u0027ve asked Pushkar to take that patch over.  Completing that patch should take care of the issue addressed by this one.","accounts_in_message":[],"_revision_number":2},{"id":"03d324756338774f51b7c05d383a4f236651158c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-03-28 16:45:00.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-glanceclient-docs-ubuntu-xenial http://docs-draft.openstack.org/24/450424/2/check/gate-python-glanceclient-docs-ubuntu-xenial/f43b2c0//doc/build/html/ : SUCCESS in 6m 10s\n- gate-python-glanceclient-pep8-ubuntu-xenial http://logs.openstack.org/24/450424/2/check/gate-python-glanceclient-pep8-ubuntu-xenial/0c91081/ : SUCCESS in 7m 29s\n- gate-python-glanceclient-python27-ubuntu-xenial http://logs.openstack.org/24/450424/2/check/gate-python-glanceclient-python27-ubuntu-xenial/770a94a/ : SUCCESS in 7m 46s\n- gate-python-glanceclient-python35 http://logs.openstack.org/24/450424/2/check/gate-python-glanceclient-python35/97af265/ : SUCCESS in 4m 24s\n- gate-tempest-dsvm-neutron-src-python-glanceclient-ubuntu-xenial http://logs.openstack.org/24/450424/2/check/gate-tempest-dsvm-neutron-src-python-glanceclient-ubuntu-xenial/4832e23/ : SUCCESS in 1h 15m 21s\n- gate-glanceclient-dsvm-functional-ubuntu-xenial http://logs.openstack.org/24/450424/2/check/gate-glanceclient-dsvm-functional-ubuntu-xenial/605b33f/ : SUCCESS in 23m 33s\n- gate-glanceclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv http://logs.openstack.org/24/450424/2/check/gate-glanceclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv/eb80271/ : FAILURE in 22m 07s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"7791ad75ac677429655b7a86124d332bfe9c28be","author":{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},"date":"2017-03-28 17:26:11.000000000","message":"Patch Set 2:\n\nI can contact the author of the other patch to be sure but he won\u0027t mind if Pushkar adopts it. Carlos just switched jobs, but the patch went inactive because there were no core reviewers who could spare the time at the end of the year / cycle.","accounts_in_message":[],"_revision_number":2},{"id":"82f6edf6e6e8471fad0feeecb64d8dea96037208","author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"date":"2017-03-28 21:27:31.000000000","message":"Patch Set 2:\n\nYeah, I had reviewed Carlos patch end of last year and had suggested what Pushkar has now (carlos had that in his PS 13).\nMaybe Pushkar can co-author and continue the work there in Idf6079b32f70bc171f5016467048e917d42f296d?","accounts_in_message":[],"_revision_number":2},{"id":"b68e9eb10c365d609f5ffc156009f6746e78e90c","author":{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},"date":"2017-03-28 21:37:52.000000000","message":"Patch Set 2:\n\nCarlos just confirmed with me, out of band, that he\u0027s happy with a co-author on his patch.","accounts_in_message":[],"_revision_number":2},{"id":"b012a00079eee5f55f518958ab2b337fdcdc7c7e","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2017-05-22 12:56:52.000000000","message":"Patch Set 2: Code-Review-1\n\nI\u0027ve picked up https://review.openstack.org/#/c/396816/ - can we proceed there, or should I shift the change to this one?","accounts_in_message":[],"_revision_number":2},{"id":"7601d89773056d57cbb3d68bfe4b18c3df1e70ab","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-05-24 22:38:45.000000000","message":"Patch Set 2: Verified-1\n\nMerge Failed.\n\nThis change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.","accounts_in_message":[],"_revision_number":2},{"id":"f3f476d3c018692371f820328e0ac1d8e0eb2937","author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"date":"2017-12-02 20:11:20.000000000","message":"Abandoned\n\nSomething equivalent to this change was included in https://review.openstack.org/#/c/396816/ , which has merged.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"4b1df62e25e5bfe09c2de060e149adb16e213359","revisions":{"30ca857e053ec80b833aa62a1a2e7f40be827f8b":{"kind":"REWORK","_number":1,"created":"2017-03-27 19:13:06.000000000","uploader":{"_account_id":18335,"name":"Pushkar Umaranikar","email":"pushkar.umaranikar@intel.com","username":"pushkarumaranikar"},"ref":"refs/changes/24/450424/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/24/450424/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/24/450424/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/24/450424/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/24/450424/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/24/450424/1"}}},"commit":{"parents":[{"commit":"ba46e69eeeb100528b1d29836f055feed043ef95","subject":"Merge \"Replace functions \u0027dict.get\u0027 and \u0027del\u0027 with \u0027dict.pop\u0027\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/ba46e69eeeb100528b1d29836f055feed043ef95"}]}],"author":{"name":"Pushkar Umaranikar","email":"pushkar.umaranikar@intel.com","date":"2017-03-27 19:05:54.000000000","tz":0},"committer":{"name":"Pushkar Umaranikar","email":"pushkar.umaranikar@intel.com","date":"2017-03-27 19:13:06.000000000","tz":0},"subject":"Use encode_headers() after setting common headers in SessionClient","message":"Use encode_headers() after setting common headers in SessionClient\n\nencode_headers convert headers parameters to byte string.\nIn _set_common_request_kwargs() method, we try to get content-type\nfrom header as a string value. This method does not set for\nbyte string.\n\nHence, for python 3.x, _set_common_request_kwargs() adds content-type\nto header even if custom content-type is set in the request.\n\nThis results in unsupported media type exception when glance client\nis used with keystoneauth and python 3.x\n\nThis change addresses this problem by calling encode headers after\nsetting common header params in SessionClient.\n\nChange-Id: I183d412516d0c427d6f958ffe90a43a8e5e5a1a7\nCloses-Bug: #1676550\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/30ca857e053ec80b833aa62a1a2e7f40be827f8b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/30ca857e053ec80b833aa62a1a2e7f40be827f8b"}]},"branch":"refs/heads/master"},"4b1df62e25e5bfe09c2de060e149adb16e213359":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2017-03-28 15:18:21.000000000","uploader":{"_account_id":18335,"name":"Pushkar Umaranikar","email":"pushkar.umaranikar@intel.com","username":"pushkarumaranikar"},"ref":"refs/changes/24/450424/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/24/450424/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/24/450424/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/24/450424/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/24/450424/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/24/450424/2"}}},"commit":{"parents":[{"commit":"ba46e69eeeb100528b1d29836f055feed043ef95","subject":"Merge \"Replace functions \u0027dict.get\u0027 and \u0027del\u0027 with \u0027dict.pop\u0027\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/ba46e69eeeb100528b1d29836f055feed043ef95"}]}],"author":{"name":"Pushkar Umaranikar","email":"pushkar.umaranikar@intel.com","date":"2017-03-27 19:05:54.000000000","tz":0},"committer":{"name":"Pushkar Umaranikar","email":"pushkar.umaranikar@intel.com","date":"2017-03-28 15:18:16.000000000","tz":0},"subject":"[WIP] Use encode_headers() after setting common headers in SessionClient","message":"[WIP] Use encode_headers() after setting common headers in SessionClient\n\nencode_headers convert headers parameters to byte string.\nIn _set_common_request_kwargs() method, we try to get content-type\nfrom header as a string value. This method does not set for\nbyte string.\n\nHence, for python 3.x, _set_common_request_kwargs() adds content-type\nto header even if custom content-type is set in the request.\n\nThis results in unsupported media type exception when glance client\nis used with keystoneauth and python 3.x\n\nThis change addresses this problem by calling encode headers after\nsetting common header params in SessionClient.\n\nChange-Id: I183d412516d0c427d6f958ffe90a43a8e5e5a1a7\nCloses-Bug: #1676550\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/4b1df62e25e5bfe09c2de060e149adb16e213359"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/4b1df62e25e5bfe09c2de060e149adb16e213359"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}