)]}'
{"id":"openstack%2Fpython-glanceclient~451757","triplet_id":"openstack%2Fpython-glanceclient~master~Icca4416565e3a771f577d065204b419c9e61590c","project":"openstack/python-glanceclient","branch":"master","topic":"replace_six_iteritems","hashtags":[],"change_id":"Icca4416565e3a771f577d065204b419c9e61590c","subject":"Replace six.iteritems() with .items()","status":"ABANDONED","created":"2017-03-30 10:55:14.000000000","updated":"2017-06-14 12:55:09.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"429b011608a3476892c14cf261993833be5b4805","_number":451757,"virtual_id_number":451757,"owner":{"_account_id":20401,"name":"M V P Nitesh","email":"parimalanitesh@gmail.com","username":"mvpnitesh"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":1,"date":"2017-03-30 12:13:33.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"rejected":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":-2,"date":"2017-06-14 11:43:29.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Top Priority / Holds Gate"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-03-30 12:13:33.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2017-06-14 11:43:29.000000000","updated_by":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"reviewer":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"state":"REVIEWER"}],"messages":[{"id":"ce55a28282569ec8590a2dcb15e95d80be6bb3b8","author":{"_account_id":20401,"name":"M V P Nitesh","email":"parimalanitesh@gmail.com","username":"mvpnitesh"},"date":"2017-03-30 10:55:14.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"daf37d74762830f6ad007b9e80674e3a2b124d83","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-03-30 12:13:33.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-glanceclient-docs-ubuntu-xenial http://docs-draft.openstack.org/57/451757/1/check/gate-python-glanceclient-docs-ubuntu-xenial/fef3bc7//doc/build/html/ : SUCCESS in 2m 16s\n- gate-python-glanceclient-pep8-ubuntu-xenial http://logs.openstack.org/57/451757/1/check/gate-python-glanceclient-pep8-ubuntu-xenial/cb1869c/ : SUCCESS in 3m 42s\n- gate-python-glanceclient-python27-ubuntu-xenial http://logs.openstack.org/57/451757/1/check/gate-python-glanceclient-python27-ubuntu-xenial/92317e5/ : SUCCESS in 4m 10s\n- gate-python-glanceclient-python35 http://logs.openstack.org/57/451757/1/check/gate-python-glanceclient-python35/5c1b6a0/ : SUCCESS in 2m 15s\n- gate-tempest-dsvm-neutron-src-python-glanceclient-ubuntu-xenial http://logs.openstack.org/57/451757/1/check/gate-tempest-dsvm-neutron-src-python-glanceclient-ubuntu-xenial/e41ca04/ : SUCCESS in 1h 15m 48s\n- gate-glanceclient-dsvm-functional-ubuntu-xenial http://logs.openstack.org/57/451757/1/check/gate-glanceclient-dsvm-functional-ubuntu-xenial/cab5d50/ : SUCCESS in 30m 20s\n- gate-glanceclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv http://logs.openstack.org/57/451757/1/check/gate-glanceclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv/bd80cfe/ : FAILURE in 17m 31s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"ac755be76091616475513489a437e4aecb2fd695","author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"date":"2017-06-14 11:43:29.000000000","message":"Patch Set 1: Code-Review-2\n\nDuplicate of https://review.openstack.org/#/c/430581/1","accounts_in_message":[],"_revision_number":1},{"id":"7dc76f7aba6dced834a61c59cd6eb4a70cef64e5","author":{"_account_id":20401,"name":"M V P Nitesh","email":"parimalanitesh@gmail.com","username":"mvpnitesh"},"date":"2017-06-14 12:55:09.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"90dec2b8c0521147085b68eb0776ec28f1234e5b","revisions":{"90dec2b8c0521147085b68eb0776ec28f1234e5b":{"kind":"REWORK","_number":1,"created":"2017-03-30 10:55:14.000000000","uploader":{"_account_id":20401,"name":"M V P Nitesh","email":"parimalanitesh@gmail.com","username":"mvpnitesh"},"ref":"refs/changes/57/451757/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/57/451757/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/57/451757/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/57/451757/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/57/451757/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/57/451757/1"}}},"commit":{"parents":[{"commit":"ba46e69eeeb100528b1d29836f055feed043ef95","subject":"Merge \"Replace functions \u0027dict.get\u0027 and \u0027del\u0027 with \u0027dict.pop\u0027\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/ba46e69eeeb100528b1d29836f055feed043ef95"}]}],"author":{"name":"M V P Nitesh","email":"m.nitesh@nectechnologies.in","date":"2017-03-30 10:52:10.000000000","tz":330},"committer":{"name":"M V P Nitesh","email":"m.nitesh@nectechnologies.in","date":"2017-03-30 10:53:15.000000000","tz":330},"subject":"Replace six.iteritems() with .items()","message":"Replace six.iteritems() with .items()\n\n1.As mentioned in [1], we should avoid using six.iteritems to achieve\niterators. We can use dict.items instead, as it will return iterators\nin PY3 as well. And dict.items/keys will more readable.\n2.In py2, the performance about list should be negligible, see the\nlink [2].\n[1] https://wiki.openstack.org/wiki/Python3\n[2] http://lists.openstack.org/pipermail/openstack-dev/2015-June/066391.html\n\nChange-Id: Icca4416565e3a771f577d065204b419c9e61590c\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/90dec2b8c0521147085b68eb0776ec28f1234e5b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/90dec2b8c0521147085b68eb0776ec28f1234e5b"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}