)]}'
{"id":"openstack%2Fpython-glanceclient~474047","triplet_id":"openstack%2Fpython-glanceclient~master~Ibb5e5f848c5632f7c1895c47b8c1a938f2c746c3","project":"openstack/python-glanceclient","branch":"master","topic":"fixtest","hashtags":[],"change_id":"Ibb5e5f848c5632f7c1895c47b8c1a938f2c746c3","subject":"Replace assertTrue(isinstance()) with assertIsInstance()","status":"MERGED","created":"2017-06-14 04:05:16.000000000","updated":"2017-06-30 21:03:45.000000000","submitted":"2017-06-30 21:03:45.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"87a459352a33d6bfa7b3fb42686aa2f64790cdb4","_number":474047,"virtual_id_number":474047,"owner":{"_account_id":26072,"name":"Van Hung Pham","email":"vanhung.pham@outlook.com","username":"hungpv"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":2,"date":"2017-06-30 21:03:45.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"value":0,"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"recommended":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"all":[{"value":1,"date":"2017-06-14 15:31:24.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2017-06-30 19:44:27.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"value":2,"date":"2017-06-14 11:35:03.000000000","_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"all":[{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2017-06-30 19:44:27.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"value":0,"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"value":0,"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Top Priority / Holds Gate"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-06-14 11:35:03.000000000","updated_by":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"reviewer":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"state":"REVIEWER"},{"updated":"2017-06-14 15:31:24.000000000","updated_by":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"reviewer":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"state":"REVIEWER"},{"updated":"2017-06-30 19:44:27.000000000","updated_by":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"reviewer":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"state":"REVIEWER"},{"updated":"2017-06-30 21:03:45.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"9f852cd0da012fb37c8cb0ba7cf021454c640505","author":{"_account_id":26072,"name":"Van Hung Pham","email":"vanhung.pham@outlook.com","username":"hungpv"},"date":"2017-06-14 04:05:16.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"e29c7f5feecc5086a19d470ed5ecbe4f6d5025f5","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-06-14 05:29:07.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-glanceclient-docs-ubuntu-xenial http://docs-draft.openstack.org/47/474047/1/check/gate-python-glanceclient-docs-ubuntu-xenial/babdf7e//doc/build/html/ : SUCCESS in 3m 23s\n- gate-python-glanceclient-pep8-ubuntu-xenial http://logs.openstack.org/47/474047/1/check/gate-python-glanceclient-pep8-ubuntu-xenial/acf48c0/ : SUCCESS in 2m 46s\n- gate-python-glanceclient-python27-ubuntu-xenial http://logs.openstack.org/47/474047/1/check/gate-python-glanceclient-python27-ubuntu-xenial/d5a73b7/ : SUCCESS in 2m 26s\n- gate-python-glanceclient-python35 http://logs.openstack.org/47/474047/1/check/gate-python-glanceclient-python35/f14a85f/ : SUCCESS in 3m 57s\n- gate-tempest-dsvm-neutron-src-python-glanceclient-ubuntu-xenial http://logs.openstack.org/47/474047/1/check/gate-tempest-dsvm-neutron-src-python-glanceclient-ubuntu-xenial/1ad72af/ : SUCCESS in 1h 22m 22s\n- gate-glanceclient-dsvm-functional-ubuntu-xenial http://logs.openstack.org/47/474047/1/check/gate-glanceclient-dsvm-functional-ubuntu-xenial/c55a274/ : SUCCESS in 17m 55s\n- gate-glanceclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv http://logs.openstack.org/47/474047/1/check/gate-glanceclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv/8c25f2d/ : FAILURE in 25m 20s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"d22bb63a7a82ac44a62a18869968f5ddd557adaf","author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"date":"2017-06-14 11:35:03.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"480a6a54b1b29641552fa6486d458b12d9b34126","author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"date":"2017-06-14 15:31:24.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"01c433e111b5797bb26adcfb91b953ff45162c6b","author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"date":"2017-06-30 19:44:27.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"9fe31e8960a90d0a058b12cb272fbc025e629c7f","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-06-30 19:44:37.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"dea7accc4e35134beae9833dbfbb1fd8f2e9beee","date":"2017-06-30 21:03:45.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":1},{"id":"c5239af5f30615ac3a8b6ff96a8c750e2fd8bec7","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-06-30 21:03:45.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-glanceclient-docs-ubuntu-xenial http://docs-draft.openstack.org/47/474047/1/gate/gate-python-glanceclient-docs-ubuntu-xenial/1cdf7f2//doc/build/html/ : SUCCESS in 5m 44s\n- gate-python-glanceclient-pep8-ubuntu-xenial http://logs.openstack.org/47/474047/1/gate/gate-python-glanceclient-pep8-ubuntu-xenial/3881a1c/ : SUCCESS in 3m 35s\n- gate-python-glanceclient-python27-ubuntu-xenial http://logs.openstack.org/47/474047/1/gate/gate-python-glanceclient-python27-ubuntu-xenial/4f73d2e/ : SUCCESS in 3m 59s\n- gate-python-glanceclient-python35 http://logs.openstack.org/47/474047/1/gate/gate-python-glanceclient-python35/0e3f438/ : SUCCESS in 2m 25s\n- gate-tempest-dsvm-neutron-src-python-glanceclient-ubuntu-xenial http://logs.openstack.org/47/474047/1/gate/gate-tempest-dsvm-neutron-src-python-glanceclient-ubuntu-xenial/56759da/ : SUCCESS in 1h 18m 30s\n- gate-glanceclient-dsvm-functional-ubuntu-xenial http://logs.openstack.org/47/474047/1/gate/gate-glanceclient-dsvm-functional-ubuntu-xenial/4ba18e5/ : SUCCESS in 23m 09s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"7791110b2fe4b01dc58078ce3358b4b8a5ead0f4","revisions":{"7791110b2fe4b01dc58078ce3358b4b8a5ead0f4":{"kind":"REWORK","_number":1,"created":"2017-06-14 04:05:16.000000000","uploader":{"_account_id":26072,"name":"Van Hung Pham","email":"vanhung.pham@outlook.com","username":"hungpv"},"ref":"refs/changes/47/474047/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/47/474047/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/47/474047/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/47/474047/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/47/474047/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/47/474047/1"}}},"commit":{"parents":[{"commit":"d3d405cfb21a2405fb1f300cc235b1d0ce8d8ae7","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/d3d405cfb21a2405fb1f300cc235b1d0ce8d8ae7"}]}],"author":{"name":"Van Hung Pham","email":"hungpv@vn.fujitsu.com","date":"2017-06-14 04:03:10.000000000","tz":420},"committer":{"name":"Van Hung Pham","email":"hungpv@vn.fujitsu.com","date":"2017-06-14 04:03:10.000000000","tz":420},"subject":"Replace assertTrue(isinstance()) with assertIsInstance()","message":"Replace assertTrue(isinstance()) with assertIsInstance()\n\nSome of tests use different method of assertTrue(isinstance(A, B))\nor assertEqual(type(A), B). The correct way is to use\nassertIsInstance(A, B) provided by test tools.\n\nChange-Id: Ibb5e5f848c5632f7c1895c47b8c1a938f2c746c3\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/7791110b2fe4b01dc58078ce3358b4b8a5ead0f4"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/7791110b2fe4b01dc58078ce3358b4b8a5ead0f4"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}