)]}'
{"glanceclient/v2/images.py":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"86c991b2c586868f208f9eac213bd223ea07230f","unresolved":false,"context_lines":[{"line_number":239,"context_line":"        return self.http_client.get(url)"},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"    @utils.add_req_id_to_object()"},{"line_number":242,"context_line":"    def stage(self, image_id, image_data):"},{"line_number":243,"context_line":"        \"\"\"Upload the data to image staging."},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"        :param image_id: ID of the image to upload data for."}],"source_content_type":"text/x-python","patch_set":4,"id":"ff346bd7_cc1c3515","line":242,"updated":"2017-07-25 12:50:15.000000000","message":"image_size is not accepted here.","commit_id":"364af173f90b58d22d678619fa4ccd18f79cb054"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"a49efe42781f358e43c30dba566073ee9413706a","unresolved":false,"context_lines":[{"line_number":239,"context_line":"        return self.http_client.get(url)"},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"    @utils.add_req_id_to_object()"},{"line_number":242,"context_line":"    def stage(self, image_id, image_data):"},{"line_number":243,"context_line":"        \"\"\"Upload the data to image staging."},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"        :param image_id: ID of the image to upload data for."}],"source_content_type":"text/x-python","patch_set":4,"id":"ff346bd7_32cc3abb","line":242,"in_reply_to":"ff346bd7_cc1c3515","updated":"2017-07-25 13:40:38.000000000","message":"Correct,\n\nAs specified in the upload, it\u0027s not used and provided there for backwards compatibility, we do not need to do it here for that reason.","commit_id":"364af173f90b58d22d678619fa4ccd18f79cb054"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"86c991b2c586868f208f9eac213bd223ea07230f","unresolved":false,"context_lines":[{"line_number":255,"context_line":"        \"\"\"Import Image via method.\"\"\""},{"line_number":256,"context_line":"        url \u003d \u0027/v2/images/%s/import\u0027 % image_id"},{"line_number":257,"context_line":"        data \u003d {\u0027import_method\u0027: method}"},{"line_number":258,"context_line":"        return self.http_client.post(url, data)"},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"    @utils.add_req_id_to_object()"},{"line_number":261,"context_line":"    def delete(self, image_id):"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff346bd7_2c006167","line":258,"range":{"start_line":258,"start_character":42,"end_line":258,"end_character":46},"updated":"2017-07-25 12:50:15.000000000","message":"doubtful about this parameter, post just accept url or image as optional argument.","commit_id":"364af173f90b58d22d678619fa4ccd18f79cb054"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"a49efe42781f358e43c30dba566073ee9413706a","unresolved":false,"context_lines":[{"line_number":255,"context_line":"        \"\"\"Import Image via method.\"\"\""},{"line_number":256,"context_line":"        url \u003d \u0027/v2/images/%s/import\u0027 % image_id"},{"line_number":257,"context_line":"        data \u003d {\u0027import_method\u0027: method}"},{"line_number":258,"context_line":"        return self.http_client.post(url, data)"},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"    @utils.add_req_id_to_object()"},{"line_number":261,"context_line":"    def delete(self, image_id):"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff346bd7_12037675","line":258,"range":{"start_line":258,"start_character":42,"end_line":258,"end_character":46},"in_reply_to":"ff346bd7_2c006167","updated":"2017-07-25 13:40:38.000000000","message":"nice catch","commit_id":"364af173f90b58d22d678619fa4ccd18f79cb054"}],"glanceclient/v2/shell.py":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"86c991b2c586868f208f9eac213bd223ea07230f","unresolved":false,"context_lines":[{"line_number":121,"context_line":"    if file_name is not None and os.access(file_name, os.R_OK) is False:"},{"line_number":122,"context_line":"        utils.exit(\"File %s does not exist or user does not have read \""},{"line_number":123,"context_line":"                   \"privileges to it\" % file_name)"},{"line_number":124,"context_line":"    import_methods \u003d _get_import_info().get(\u0027import-methods\u0027)"},{"line_number":125,"context_line":"    if file_name and (not import_methods or"},{"line_number":126,"context_line":"                      \u0027glance-direct\u0027 not in import_methods.get(\u0027value\u0027)):"},{"line_number":127,"context_line":"        utils.exit(\"No suitable import method available for direct upload, \""}],"source_content_type":"text/x-python","patch_set":4,"id":"ff346bd7_213e2ada","line":124,"range":{"start_line":124,"start_character":21,"end_line":124,"end_character":39},"updated":"2017-07-25 12:50:15.000000000","message":"need to pass \u0027gc\u0027 here","commit_id":"364af173f90b58d22d678619fa4ccd18f79cb054"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"a49efe42781f358e43c30dba566073ee9413706a","unresolved":false,"context_lines":[{"line_number":121,"context_line":"    if file_name is not None and os.access(file_name, os.R_OK) is False:"},{"line_number":122,"context_line":"        utils.exit(\"File %s does not exist or user does not have read \""},{"line_number":123,"context_line":"                   \"privileges to it\" % file_name)"},{"line_number":124,"context_line":"    import_methods \u003d _get_import_info().get(\u0027import-methods\u0027)"},{"line_number":125,"context_line":"    if file_name and (not import_methods or"},{"line_number":126,"context_line":"                      \u0027glance-direct\u0027 not in import_methods.get(\u0027value\u0027)):"},{"line_number":127,"context_line":"        utils.exit(\"No suitable import method available for direct upload, \""}],"source_content_type":"text/x-python","patch_set":4,"id":"ff346bd7_92b3e64d","line":124,"range":{"start_line":124,"start_character":21,"end_line":124,"end_character":39},"in_reply_to":"ff346bd7_213e2ada","updated":"2017-07-25 13:40:38.000000000","message":"Nope, the _get_import_info function is defined below just above _obect_show. Currently it\u0027s just cleaning the response out of what gc.get_import_info() returns for easy print. When we get to extend the discovery capabilities from the API, that\u0027s the place where to process that.","commit_id":"364af173f90b58d22d678619fa4ccd18f79cb054"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"86c991b2c586868f208f9eac213bd223ea07230f","unresolved":false,"context_lines":[{"line_number":122,"context_line":"        utils.exit(\"File %s does not exist or user does not have read \""},{"line_number":123,"context_line":"                   \"privileges to it\" % file_name)"},{"line_number":124,"context_line":"    import_methods \u003d _get_import_info().get(\u0027import-methods\u0027)"},{"line_number":125,"context_line":"    if file_name and (not import_methods or"},{"line_number":126,"context_line":"                      \u0027glance-direct\u0027 not in import_methods.get(\u0027value\u0027)):"},{"line_number":127,"context_line":"        utils.exit(\"No suitable import method available for direct upload, \""},{"line_number":128,"context_line":"                   \"please use image-create instead.\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff346bd7_e108222e","line":125,"range":{"start_line":125,"start_character":4,"end_line":125,"end_character":16},"updated":"2017-07-25 12:50:15.000000000","message":"no need to check file_name again as it is already checked","commit_id":"364af173f90b58d22d678619fa4ccd18f79cb054"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"a49efe42781f358e43c30dba566073ee9413706a","unresolved":false,"context_lines":[{"line_number":122,"context_line":"        utils.exit(\"File %s does not exist or user does not have read \""},{"line_number":123,"context_line":"                   \"privileges to it\" % file_name)"},{"line_number":124,"context_line":"    import_methods \u003d _get_import_info().get(\u0027import-methods\u0027)"},{"line_number":125,"context_line":"    if file_name and (not import_methods or"},{"line_number":126,"context_line":"                      \u0027glance-direct\u0027 not in import_methods.get(\u0027value\u0027)):"},{"line_number":127,"context_line":"        utils.exit(\"No suitable import method available for direct upload, \""},{"line_number":128,"context_line":"                   \"please use image-create instead.\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff346bd7_477c9eea","line":125,"range":{"start_line":125,"start_character":4,"end_line":125,"end_character":16},"in_reply_to":"ff346bd7_e108222e","updated":"2017-07-25 13:40:38.000000000","message":"Not true,\n\nThese two conditions are special case _if_ the file has been provided. For early fail, the first one checks that the file is actually accesible and this second one verifies that glance actually provides staging \u0027glance-direct\u0027 _if_ the file is provided as that\u0027s the only option we currently can handle.\n\nThe image create without the file provided will create just image in queued state regardless which create function has been used.","commit_id":"364af173f90b58d22d678619fa4ccd18f79cb054"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"86c991b2c586868f208f9eac213bd223ea07230f","unresolved":false,"context_lines":[{"line_number":322,"context_line":"def do_import_info(gc):"},{"line_number":323,"context_line":"    \"\"\"Print import methods available from Glance.\"\"\""},{"line_number":324,"context_line":"    try:"},{"line_number":325,"context_line":"        import_info \u003d _get_import_info()"},{"line_number":326,"context_line":"    except exc.HTTPNotFound:"},{"line_number":327,"context_line":"        utils.exit(\u0027Target Glance does not support Image Import workflow\u0027)"},{"line_number":328,"context_line":"    else:"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff346bd7_0c0c7d39","line":325,"range":{"start_line":325,"start_character":22,"end_line":325,"end_character":40},"updated":"2017-07-25 12:50:15.000000000","message":"need to pass \u0027gc\u0027 here","commit_id":"364af173f90b58d22d678619fa4ccd18f79cb054"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"a49efe42781f358e43c30dba566073ee9413706a","unresolved":false,"context_lines":[{"line_number":322,"context_line":"def do_import_info(gc):"},{"line_number":323,"context_line":"    \"\"\"Print import methods available from Glance.\"\"\""},{"line_number":324,"context_line":"    try:"},{"line_number":325,"context_line":"        import_info \u003d _get_import_info()"},{"line_number":326,"context_line":"    except exc.HTTPNotFound:"},{"line_number":327,"context_line":"        utils.exit(\u0027Target Glance does not support Image Import workflow\u0027)"},{"line_number":328,"context_line":"    else:"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff346bd7_273bdaeb","line":325,"range":{"start_line":325,"start_character":22,"end_line":325,"end_character":40},"in_reply_to":"ff346bd7_0c0c7d39","updated":"2017-07-25 13:40:38.000000000","message":"Ditto","commit_id":"364af173f90b58d22d678619fa4ccd18f79cb054"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"86c991b2c586868f208f9eac213bd223ea07230f","unresolved":false,"context_lines":[{"line_number":418,"context_line":"           help\u003d_(\u0027ID of image to import.\u0027))"},{"line_number":419,"context_line":"def do_image_import(gc, args):"},{"line_number":420,"context_line":"    try:"},{"line_number":421,"context_line":"        gc.image_import(args.id, args.method)"},{"line_number":422,"context_line":"    except exc.HTTPNotFound:"},{"line_number":423,"context_line":"        utils.exit(\u0027Target Glance does not support Image Import workflow\u0027)"},{"line_number":424,"context_line":"    else:"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff346bd7_ec949946","line":421,"range":{"start_line":421,"start_character":33,"end_line":421,"end_character":44},"updated":"2017-07-25 12:50:15.000000000","message":"no argument defined as method in args list above, this will give error as well.","commit_id":"364af173f90b58d22d678619fa4ccd18f79cb054"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"86c991b2c586868f208f9eac213bd223ea07230f","unresolved":false,"context_lines":[{"line_number":418,"context_line":"           help\u003d_(\u0027ID of image to import.\u0027))"},{"line_number":419,"context_line":"def do_image_import(gc, args):"},{"line_number":420,"context_line":"    try:"},{"line_number":421,"context_line":"        gc.image_import(args.id, args.method)"},{"line_number":422,"context_line":"    except exc.HTTPNotFound:"},{"line_number":423,"context_line":"        utils.exit(\u0027Target Glance does not support Image Import workflow\u0027)"},{"line_number":424,"context_line":"    else:"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff346bd7_a18d7ad4","line":421,"range":{"start_line":421,"start_character":8,"end_line":421,"end_character":23},"updated":"2017-07-25 12:50:15.000000000","message":"this should be gc.images.image_import","commit_id":"364af173f90b58d22d678619fa4ccd18f79cb054"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"a49efe42781f358e43c30dba566073ee9413706a","unresolved":false,"context_lines":[{"line_number":418,"context_line":"           help\u003d_(\u0027ID of image to import.\u0027))"},{"line_number":419,"context_line":"def do_image_import(gc, args):"},{"line_number":420,"context_line":"    try:"},{"line_number":421,"context_line":"        gc.image_import(args.id, args.method)"},{"line_number":422,"context_line":"    except exc.HTTPNotFound:"},{"line_number":423,"context_line":"        utils.exit(\u0027Target Glance does not support Image Import workflow\u0027)"},{"line_number":424,"context_line":"    else:"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff346bd7_d23baec5","line":421,"range":{"start_line":421,"start_character":8,"end_line":421,"end_character":23},"in_reply_to":"ff346bd7_a18d7ad4","updated":"2017-07-25 13:40:38.000000000","message":"Done","commit_id":"364af173f90b58d22d678619fa4ccd18f79cb054"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"a49efe42781f358e43c30dba566073ee9413706a","unresolved":false,"context_lines":[{"line_number":418,"context_line":"           help\u003d_(\u0027ID of image to import.\u0027))"},{"line_number":419,"context_line":"def do_image_import(gc, args):"},{"line_number":420,"context_line":"    try:"},{"line_number":421,"context_line":"        gc.image_import(args.id, args.method)"},{"line_number":422,"context_line":"    except exc.HTTPNotFound:"},{"line_number":423,"context_line":"        utils.exit(\u0027Target Glance does not support Image Import workflow\u0027)"},{"line_number":424,"context_line":"    else:"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff346bd7_b24a6a52","line":421,"range":{"start_line":421,"start_character":33,"end_line":421,"end_character":44},"in_reply_to":"ff346bd7_ec949946","updated":"2017-07-25 13:40:38.000000000","message":"Done","commit_id":"364af173f90b58d22d678619fa4ccd18f79cb054"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"ffc1828cbe33478ef249945f9b6f0bb0d9a9866a","unresolved":false,"context_lines":[{"line_number":104,"context_line":"           help\u003d_(\u0027Show upload progress bar.\u0027))"},{"line_number":105,"context_line":"@utils.on_data_require_fields(DATA_FIELDS)"},{"line_number":106,"context_line":"def do_image_create_via_import(gc, args):"},{"line_number":107,"context_line":"    \"\"\"EXPERIMENTAL: Create a new image via image import.\"\"\""},{"line_number":108,"context_line":"    schema \u003d gc.schemas.get(\"image\")"},{"line_number":109,"context_line":"    _args \u003d [(x[0].replace(\u0027-\u0027, \u0027_\u0027), x[1]) for x in vars(args).items()]"},{"line_number":110,"context_line":"    fields \u003d dict(filter(lambda x: x[1] is not None and"}],"source_content_type":"text/x-python","patch_set":8,"id":"ff346bd7_d42b4592","line":107,"updated":"2017-07-27 13:52:46.000000000","message":"My suggestion may be too verbose, but it would be good if this read:\n\n\"\"\"EXPERIMENTAL. This command may be renamed or removed.\n   Create a new image via image import.\"\"\"","commit_id":"6abf10069e8c733ca5d50934662f61a9f835618a"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"dba16518fa6da8943c11754fdef9c5ef70609ea7","unresolved":false,"context_lines":[{"line_number":104,"context_line":"           help\u003d_(\u0027Show upload progress bar.\u0027))"},{"line_number":105,"context_line":"@utils.on_data_require_fields(DATA_FIELDS)"},{"line_number":106,"context_line":"def do_image_create_via_import(gc, args):"},{"line_number":107,"context_line":"    \"\"\"EXPERIMENTAL: Create a new image via image import.\"\"\""},{"line_number":108,"context_line":"    schema \u003d gc.schemas.get(\"image\")"},{"line_number":109,"context_line":"    _args \u003d [(x[0].replace(\u0027-\u0027, \u0027_\u0027), x[1]) for x in vars(args).items()]"},{"line_number":110,"context_line":"    fields \u003d dict(filter(lambda x: x[1] is not None and"}],"source_content_type":"text/x-python","patch_set":8,"id":"ff346bd7_0f453343","line":107,"in_reply_to":"ff346bd7_0cfd41b0","updated":"2017-07-27 15:10:41.000000000","message":"Forgot to add that we discussed this at today\u0027s glance meeting and decided that the current text is OK here, we\u0027ll add an additional explanation to the docs.","commit_id":"6abf10069e8c733ca5d50934662f61a9f835618a"},{"author":{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},"change_message_id":"1c18ae909ffab95da7c47c725741aadd18bdbd75","unresolved":false,"context_lines":[{"line_number":104,"context_line":"           help\u003d_(\u0027Show upload progress bar.\u0027))"},{"line_number":105,"context_line":"@utils.on_data_require_fields(DATA_FIELDS)"},{"line_number":106,"context_line":"def do_image_create_via_import(gc, args):"},{"line_number":107,"context_line":"    \"\"\"EXPERIMENTAL: Create a new image via image import.\"\"\""},{"line_number":108,"context_line":"    schema \u003d gc.schemas.get(\"image\")"},{"line_number":109,"context_line":"    _args \u003d [(x[0].replace(\u0027-\u0027, \u0027_\u0027), x[1]) for x in vars(args).items()]"},{"line_number":110,"context_line":"    fields \u003d dict(filter(lambda x: x[1] is not None and"}],"source_content_type":"text/x-python","patch_set":8,"id":"ff346bd7_ef92f256","line":107,"in_reply_to":"ff346bd7_d42b4592","updated":"2017-07-27 14:05:57.000000000","message":"how about LOG.warning here?","commit_id":"6abf10069e8c733ca5d50934662f61a9f835618a"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"482537565741dcc64d58a28043fab2d42188eb9d","unresolved":false,"context_lines":[{"line_number":104,"context_line":"           help\u003d_(\u0027Show upload progress bar.\u0027))"},{"line_number":105,"context_line":"@utils.on_data_require_fields(DATA_FIELDS)"},{"line_number":106,"context_line":"def do_image_create_via_import(gc, args):"},{"line_number":107,"context_line":"    \"\"\"EXPERIMENTAL: Create a new image via image import.\"\"\""},{"line_number":108,"context_line":"    schema \u003d gc.schemas.get(\"image\")"},{"line_number":109,"context_line":"    _args \u003d [(x[0].replace(\u0027-\u0027, \u0027_\u0027), x[1]) for x in vars(args).items()]"},{"line_number":110,"context_line":"    fields \u003d dict(filter(lambda x: x[1] is not None and"}],"source_content_type":"text/x-python","patch_set":8,"id":"ff346bd7_0cfd41b0","line":107,"in_reply_to":"ff346bd7_ef92f256","updated":"2017-07-27 14:54:50.000000000","message":"Good suggestion, but probably not appropriate for the CLI.","commit_id":"6abf10069e8c733ca5d50934662f61a9f835618a"}]}