)]}'
{"id":"openstack%2Fpython-glanceclient~494352","triplet_id":"openstack%2Fpython-glanceclient~master~I5e34d772d561306c6f103c859740658a825dd189","project":"openstack/python-glanceclient","branch":"master","topic":"bug/1711259","hashtags":[],"change_id":"I5e34d772d561306c6f103c859740658a825dd189","subject":"Fix image-import call","status":"MERGED","created":"2017-08-17 01:48:15.000000000","updated":"2017-08-24 09:18:22.000000000","submitted":"2017-08-24 09:17:30.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"1f233c0506f0e2e370c34344de5313eb10de3b22","_number":494352,"virtual_id_number":494352,"owner":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},{"value":2,"date":"2017-08-24 09:17:30.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"value":0,"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"all":[{"value":2,"date":"2017-08-24 07:47:16.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2017-08-18 19:21:15.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"value":0,"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"all":[{"value":1,"date":"2017-08-24 07:47:16.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"value":0,"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"value":0,"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Top Priority / Holds Gate"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-08-18 11:47:03.000000000","updated_by":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"reviewer":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"state":"REVIEWER"},{"updated":"2017-08-18 19:21:15.000000000","updated_by":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"reviewer":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"state":"REVIEWER"},{"updated":"2017-08-24 07:47:16.000000000","updated_by":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"reviewer":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"state":"REVIEWER"},{"updated":"2017-08-24 09:17:30.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"7bc81d0f9faf8524a68d865ada55ad6e523e269c","author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"date":"2017-08-17 01:48:15.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"737ee188788ea78f832165829d972548b4ad3132","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-08-17 03:35:01.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-glanceclient-docs-ubuntu-xenial http://docs-draft.openstack.org/52/494352/1/check/gate-python-glanceclient-docs-ubuntu-xenial/d6d42e5//doc/build/html/ : SUCCESS in 3m 22s\n- gate-python-glanceclient-pep8-ubuntu-xenial http://logs.openstack.org/52/494352/1/check/gate-python-glanceclient-pep8-ubuntu-xenial/30897a3/ : SUCCESS in 3m 57s\n- gate-python-glanceclient-python27-ubuntu-xenial http://logs.openstack.org/52/494352/1/check/gate-python-glanceclient-python27-ubuntu-xenial/1a89969/ : SUCCESS in 3m 35s\n- gate-python-glanceclient-python35 http://logs.openstack.org/52/494352/1/check/gate-python-glanceclient-python35/ed70806/ : SUCCESS in 3m 54s\n- gate-tempest-dsvm-neutron-src-python-glanceclient-ubuntu-xenial http://logs.openstack.org/52/494352/1/check/gate-tempest-dsvm-neutron-src-python-glanceclient-ubuntu-xenial/c812b37/ : SUCCESS in 1h 43m 00s\n- gate-glanceclient-dsvm-functional-ubuntu-xenial http://logs.openstack.org/52/494352/1/check/gate-glanceclient-dsvm-functional-ubuntu-xenial/a6ae9c4/ : SUCCESS in 39m 37s\n- gate-glanceclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv http://logs.openstack.org/52/494352/1/check/gate-glanceclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv/a388ee2/ : FAILURE in 23m 25s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"8862bff4db75430a7428bd7facb7a569ea69c67b","author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"date":"2017-08-17 04:56:01.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"ecb136731a4978b86fb3b33c9330b19d5ca09db5","author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"date":"2017-08-18 11:47:03.000000000","message":"Patch Set 1: Code-Review-1\n\nThis should have a Depends-On:  I08783e28719e63b5a4b2115b8fce135e55be460a\n\nI\u0027m surprised tests pass :/","accounts_in_message":[],"_revision_number":1},{"id":"00e613b909d8c1122b900a693f0b2bf468d9111d","author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"date":"2017-08-18 15:12:17.000000000","message":"Patch Set 2: Published edit on patch set 1","accounts_in_message":[],"_revision_number":2},{"id":"757a016e03eecf346eaa724b85337a197095bcdd","author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"date":"2017-08-18 15:13:17.000000000","message":"Patch Set 2:\n\n@Flavio: good point about the dependency.\n\nAlso a good point that we need more and better tests around image import.","accounts_in_message":[],"_revision_number":2},{"id":"4240e5e08e64eef9cc86c8d4224cf9abb41bf9e8","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-08-18 19:18:26.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-glanceclient-docs-ubuntu-xenial http://docs-draft.openstack.org/52/494352/2/check/gate-python-glanceclient-docs-ubuntu-xenial/4eb2fdf//doc/build/html/ : SUCCESS in 4m 17s\n- gate-python-glanceclient-pep8-ubuntu-xenial http://logs.openstack.org/52/494352/2/check/gate-python-glanceclient-pep8-ubuntu-xenial/0542947/ : SUCCESS in 3m 45s\n- gate-python-glanceclient-python27-ubuntu-xenial http://logs.openstack.org/52/494352/2/check/gate-python-glanceclient-python27-ubuntu-xenial/0cb8470/ : SUCCESS in 3m 24s\n- gate-python-glanceclient-python35 http://logs.openstack.org/52/494352/2/check/gate-python-glanceclient-python35/beab380/ : SUCCESS in 3m 45s\n- gate-tempest-dsvm-neutron-src-python-glanceclient-ubuntu-xenial http://logs.openstack.org/52/494352/2/check/gate-tempest-dsvm-neutron-src-python-glanceclient-ubuntu-xenial/0dcb93e/ : SUCCESS in 1h 20m 54s\n- gate-glanceclient-dsvm-functional-ubuntu-xenial http://logs.openstack.org/52/494352/2/check/gate-glanceclient-dsvm-functional-ubuntu-xenial/11d5ed4/ : SUCCESS in 25m 02s\n- gate-glanceclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv http://logs.openstack.org/52/494352/2/check/gate-glanceclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv/83bdc1c/ : FAILURE in 26m 29s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"e7f9b299925e1f1e27cbec39a9322d923e2ba5ae","author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"date":"2017-08-18 19:21:15.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"fea0404b27c91a26c940b1658b9ba8d4d19d3c83","author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"date":"2017-08-21 10:51:27.000000000","message":"Patch Set 2: Code-Review-2\n\n\u0027import_method\u0027 is what the server is expecting https://github.com/openstack/glance/blob/master/glance/common/scripts/utils.py#L58-L61\n\nIf that is wrong it needs to be fixed first.","accounts_in_message":[],"_revision_number":2},{"id":"4862a8ff0c0d283585e3adf49149ef5a24210a84","author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"date":"2017-08-21 14:15:31.000000000","message":"Patch Set 2:\n\n@Erno: what\u0027s loading the task_input that\u0027s being unpacked in common/scripts/utils.py?  The code that\u0027s doing that could introduce import_method as a field for internal consumption.  Right now, looks like task_input is not being set:\nhttp://git.openstack.org/cgit/openstack/glance/tree/glance/api/v2/images.py#n97\n\nFrom the API side, we are currently expecting {\"method\":{\"name\":\"glance-direct\"}} in the RequestDeserializer:\nhttp://git.openstack.org/cgit/openstack/glance/commit/?id\u003d2bce32ba2c75c159eee6085df31bee0fdfcc8706\n\nAnd that conforms to the spec:\nhttps://specs.openstack.org/openstack/glance-specs/specs/mitaka/approved/image-import/image-import-refactor.html#example-glance-direct-method\n\nand the proposed api-ref:\nhttps://review.openstack.org/#/c/494243/3/api-ref/source/v2/samples/image-import-request.json\n\nNot saying something doesn\u0027t need to change on the Glance side, just saying I\u0027m not exactly sure what at this point.","accounts_in_message":[],"_revision_number":2},{"id":"8121d31be6ea61a26d024e9f12874c273aadf896","author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"date":"2017-08-23 04:08:04.000000000","message":"Patch Set 2:\n\nhttps://review.openstack.org/#/c/496477/ fixes this on the Glance side.","accounts_in_message":[],"_revision_number":2},{"id":"59e3c6862012c1e63028521275aa25dc73119633","author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"date":"2017-08-24 07:47:16.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1\n\nThanks ... looks like this is good to go now","accounts_in_message":[],"_revision_number":2},{"id":"d4722566ee444a80aafac15c46f4966d3422e4bb","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-08-24 07:47:40.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"07becdef10214079156554ee8a7eea4ec1c3f284","date":"2017-08-24 09:17:30.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":2},{"id":"57f2b19bfdad6c98871d0c91271e7a3d0fedc590","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-08-24 09:17:30.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-glanceclient-docs-ubuntu-xenial http://docs-draft.openstack.org/52/494352/2/gate/gate-python-glanceclient-docs-ubuntu-xenial/1b15d64//doc/build/html/ : SUCCESS in 3m 24s\n- gate-python-glanceclient-pep8-ubuntu-xenial http://logs.openstack.org/52/494352/2/gate/gate-python-glanceclient-pep8-ubuntu-xenial/6cf8ce6/ : SUCCESS in 3m 55s\n- gate-python-glanceclient-python27-ubuntu-xenial http://logs.openstack.org/52/494352/2/gate/gate-python-glanceclient-python27-ubuntu-xenial/0c0cb06/ : SUCCESS in 5m 23s\n- gate-python-glanceclient-python35 http://logs.openstack.org/52/494352/2/gate/gate-python-glanceclient-python35/176a9d8/ : SUCCESS in 5m 22s\n- gate-tempest-dsvm-neutron-src-python-glanceclient-ubuntu-xenial http://logs.openstack.org/52/494352/2/gate/gate-tempest-dsvm-neutron-src-python-glanceclient-ubuntu-xenial/00ba2fd/ : SUCCESS in 1h 26m 29s\n- gate-glanceclient-dsvm-functional-ubuntu-xenial http://logs.openstack.org/52/494352/2/gate/gate-glanceclient-dsvm-functional-ubuntu-xenial/ac402bf/ : SUCCESS in 27m 35s","accounts_in_message":[],"_revision_number":2},{"id":"bbc3119142a0dfe37c137955d6f91eb6e783e384","author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"date":"2017-08-24 09:18:22.000000000","message":"Patch Set 2: Cherry Picked\n\nThis patchset was cherry picked to branch stable/pike as commit 66d486738a4f198fca4934d6cb7db5caec0e8fd7","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"e5b69eff693e7e012f867d83a54d737fedf74cb0","revisions":{"016505cd2a7b4bc3bb3f16af8b3c190e5d70b5fd":{"kind":"REWORK","_number":1,"created":"2017-08-17 01:48:15.000000000","uploader":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"ref":"refs/changes/52/494352/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/52/494352/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/52/494352/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/52/494352/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/52/494352/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/52/494352/1"}}},"commit":{"parents":[{"commit":"6fe3018de8564a20865d9350bc942e8e14296d85","subject":"Update reno for stable/pike","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/6fe3018de8564a20865d9350bc942e8e14296d85"}]}],"author":{"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","date":"2017-08-17 01:46:21.000000000","tz":-240},"committer":{"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","date":"2017-08-17 01:48:14.000000000","tz":-240},"subject":"Fix image-import call","message":"Fix image-import call\n\nChange the request body sent from the client to be the format\nthat the API expects for the image-import call.\n\nChange-Id: I5e34d772d561306c6f103c859740658a825dd189\nCloses-bug: #1711259\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/016505cd2a7b4bc3bb3f16af8b3c190e5d70b5fd"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/016505cd2a7b4bc3bb3f16af8b3c190e5d70b5fd"}]},"branch":"refs/heads/master"},"e5b69eff693e7e012f867d83a54d737fedf74cb0":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2017-08-18 15:12:17.000000000","uploader":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"ref":"refs/changes/52/494352/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/52/494352/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/52/494352/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/52/494352/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/52/494352/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/52/494352/2"}}},"commit":{"parents":[{"commit":"6fe3018de8564a20865d9350bc942e8e14296d85","subject":"Update reno for stable/pike","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/6fe3018de8564a20865d9350bc942e8e14296d85"}]}],"author":{"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","date":"2017-08-17 01:46:21.000000000","tz":-240},"committer":{"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","date":"2017-08-18 15:12:04.000000000","tz":0},"subject":"Fix image-import call","message":"Fix image-import call\n\nChange the request body sent from the client to be the format\nthat the API expects for the image-import call.\n\nDepends-On:  I08783e28719e63b5a4b2115b8fce135e55be460a\nChange-Id: I5e34d772d561306c6f103c859740658a825dd189\nCloses-bug: #1711259\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/e5b69eff693e7e012f867d83a54d737fedf74cb0"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/e5b69eff693e7e012f867d83a54d737fedf74cb0"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}