)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"0df26a63fc68e53ad241940e75a24be20fb553a7","unresolved":false,"context_lines":[{"line_number":11,"context_line":"and response."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Further it fails with AttributeError: \u0027Namespace\u0027 object has"},{"line_number":14,"context_line":"no attribute \u0027import_method\u0027. The rason is do_import_image() call"},{"line_number":15,"context_line":"requires \u0027import_method\u0027 as input which is not provided at the"},{"line_number":16,"context_line":"moment."},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9f436f4f_5f8ec0d0","line":14,"range":{"start_line":14,"start_character":34,"end_line":14,"end_character":39},"updated":"2017-08-19 19:28:50.000000000","message":"reason","commit_id":"681f16f2ac6077dae5f1e33a93518c9b91e11a96"}],"glanceclient/v2/shell.py":[{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"7bc279a3cf367464a49d320018451061b0f9ac3c","unresolved":false,"context_lines":[{"line_number":102,"context_line":"                  \u0027passed to the client via stdin.\u0027))"},{"line_number":103,"context_line":"@utils.arg(\u0027--progress\u0027, action\u003d\u0027store_true\u0027, default\u003dFalse,"},{"line_number":104,"context_line":"           help\u003d_(\u0027Show upload progress bar.\u0027))"},{"line_number":105,"context_line":"@utils.on_data_require_fields(DATA_FIELDS)"},{"line_number":106,"context_line":"def do_image_create_via_import(gc, args):"},{"line_number":107,"context_line":"    \"\"\"EXPERIMENTAL: Create a new image via image import.\"\"\""},{"line_number":108,"context_line":"    schema \u003d gc.schemas.get(\"image\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f436f4f_df8e1e26","line":105,"updated":"2017-08-21 11:10:24.000000000","message":"We probably should add --import-method like in https://github.com/openstack/python-glanceclient/blob/master/glanceclient/v2/shell.py#L413-L417 above this.","commit_id":"681f16f2ac6077dae5f1e33a93518c9b91e11a96"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"243de922952334b002c23f697b3011f6d5f0d62a","unresolved":false,"context_lines":[{"line_number":102,"context_line":"                  \u0027passed to the client via stdin.\u0027))"},{"line_number":103,"context_line":"@utils.arg(\u0027--progress\u0027, action\u003d\u0027store_true\u0027, default\u003dFalse,"},{"line_number":104,"context_line":"           help\u003d_(\u0027Show upload progress bar.\u0027))"},{"line_number":105,"context_line":"@utils.on_data_require_fields(DATA_FIELDS)"},{"line_number":106,"context_line":"def do_image_create_via_import(gc, args):"},{"line_number":107,"context_line":"    \"\"\"EXPERIMENTAL: Create a new image via image import.\"\"\""},{"line_number":108,"context_line":"    schema \u003d gc.schemas.get(\"image\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f436f4f_531c6276","line":105,"in_reply_to":"9f436f4f_df8e1e26","updated":"2017-08-21 16:00:46.000000000","message":"sounds good","commit_id":"681f16f2ac6077dae5f1e33a93518c9b91e11a96"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"ab03a588e37d311a70aa9fd905aa8a55bf1a9edc","unresolved":false,"context_lines":[{"line_number":124,"context_line":"    import_methods \u003d gc.images.get_import_info().get(\u0027import-methods\u0027)"},{"line_number":125,"context_line":"    if file_name and (not import_methods or"},{"line_number":126,"context_line":"                      \u0027glance-direct\u0027 not in import_methods.get(\u0027value\u0027)):"},{"line_number":127,"context_line":"        utils.exit(\"No suitable import method available for direct upload, \""},{"line_number":128,"context_line":"                   \"please use image-create instead.\")"},{"line_number":129,"context_line":"    image \u003d gc.images.create(**fields)"},{"line_number":130,"context_line":"    try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f436f4f_2e405507","line":127,"range":{"start_line":127,"start_character":60,"end_line":127,"end_character":73},"updated":"2017-08-21 16:12:29.000000000","message":"I think change this to \"immediate import\" if it\u0027s going to be relevant to other import methods.","commit_id":"681f16f2ac6077dae5f1e33a93518c9b91e11a96"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"739043fc46039665c6559050dbff35d8ecba9a85","unresolved":false,"context_lines":[{"line_number":124,"context_line":"    import_methods \u003d gc.images.get_import_info().get(\u0027import-methods\u0027)"},{"line_number":125,"context_line":"    if file_name and (not import_methods or"},{"line_number":126,"context_line":"                      \u0027glance-direct\u0027 not in import_methods.get(\u0027value\u0027)):"},{"line_number":127,"context_line":"        utils.exit(\"No suitable import method available for direct upload, \""},{"line_number":128,"context_line":"                   \"please use image-create instead.\")"},{"line_number":129,"context_line":"    image \u003d gc.images.create(**fields)"},{"line_number":130,"context_line":"    try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_9209b12d","line":127,"range":{"start_line":127,"start_character":60,"end_line":127,"end_character":73},"in_reply_to":"7f287b81_033699e7","updated":"2017-08-24 14:14:07.000000000","message":"No, but this specific check is. If the file is provided we only support direct upload. This is one of our traditional fail early checks.","commit_id":"681f16f2ac6077dae5f1e33a93518c9b91e11a96"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"bd542c9d4249b27ad26d17b82abe73480b870ba6","unresolved":false,"context_lines":[{"line_number":124,"context_line":"    import_methods \u003d gc.images.get_import_info().get(\u0027import-methods\u0027)"},{"line_number":125,"context_line":"    if file_name and (not import_methods or"},{"line_number":126,"context_line":"                      \u0027glance-direct\u0027 not in import_methods.get(\u0027value\u0027)):"},{"line_number":127,"context_line":"        utils.exit(\"No suitable import method available for direct upload, \""},{"line_number":128,"context_line":"                   \"please use image-create instead.\")"},{"line_number":129,"context_line":"    image \u003d gc.images.create(**fields)"},{"line_number":130,"context_line":"    try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_033699e7","line":127,"range":{"start_line":127,"start_character":60,"end_line":127,"end_character":73},"in_reply_to":"7f287b81_0fc7e547","updated":"2017-08-24 11:57:25.000000000","message":"OK, so now I\u0027m confused about your comments on lines 105 and 139.  If this function is only good for glance-direct, then why are we offering an import-method as an option?","commit_id":"681f16f2ac6077dae5f1e33a93518c9b91e11a96"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"2cdf0c99ac92d93f15f07862401c60c8154a7695","unresolved":false,"context_lines":[{"line_number":124,"context_line":"    import_methods \u003d gc.images.get_import_info().get(\u0027import-methods\u0027)"},{"line_number":125,"context_line":"    if file_name and (not import_methods or"},{"line_number":126,"context_line":"                      \u0027glance-direct\u0027 not in import_methods.get(\u0027value\u0027)):"},{"line_number":127,"context_line":"        utils.exit(\"No suitable import method available for direct upload, \""},{"line_number":128,"context_line":"                   \"please use image-create instead.\")"},{"line_number":129,"context_line":"    image \u003d gc.images.create(**fields)"},{"line_number":130,"context_line":"    try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_0fc7e547","line":127,"range":{"start_line":127,"start_character":60,"end_line":127,"end_character":73},"in_reply_to":"9f436f4f_2e405507","updated":"2017-08-24 07:51:41.000000000","message":"Well the thing is that it\u0027s not. \"copy-from\" or what ever we will call it is not going to accept --file, and unless we want to implement the upload to swift into glanceclient neither does the swift-local. This is very specific case for the direct upload.","commit_id":"681f16f2ac6077dae5f1e33a93518c9b91e11a96"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"7bc279a3cf367464a49d320018451061b0f9ac3c","unresolved":false,"context_lines":[{"line_number":136,"context_line":"            # NOTE(abhishekk): In the EXPERIMENTAL Image API v2.6, the only"},{"line_number":137,"context_line":"            # import method available is \u0027glance-direct\u0027. Once other methods"},{"line_number":138,"context_line":"            # are available this needs to be fixed."},{"line_number":139,"context_line":"            args.import_method \u003d \u0027glance-direct\u0027"},{"line_number":140,"context_line":"            do_image_import(gc, args)"},{"line_number":141,"context_line":"            image \u003d gc.images.get(args.id)"},{"line_number":142,"context_line":"    finally:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f436f4f_7f9bb265","line":139,"updated":"2017-08-21 11:10:24.000000000","message":"And we could forget this and not need to change it again later.","commit_id":"681f16f2ac6077dae5f1e33a93518c9b91e11a96"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"243de922952334b002c23f697b3011f6d5f0d62a","unresolved":false,"context_lines":[{"line_number":136,"context_line":"            # NOTE(abhishekk): In the EXPERIMENTAL Image API v2.6, the only"},{"line_number":137,"context_line":"            # import method available is \u0027glance-direct\u0027. Once other methods"},{"line_number":138,"context_line":"            # are available this needs to be fixed."},{"line_number":139,"context_line":"            args.import_method \u003d \u0027glance-direct\u0027"},{"line_number":140,"context_line":"            do_image_import(gc, args)"},{"line_number":141,"context_line":"            image \u003d gc.images.get(args.id)"},{"line_number":142,"context_line":"    finally:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f436f4f_b306ee1f","line":139,"in_reply_to":"9f436f4f_7f9bb265","updated":"2017-08-21 16:00:46.000000000","message":"if we add --import-method to args then no need to add it here.","commit_id":"681f16f2ac6077dae5f1e33a93518c9b91e11a96"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"ab03a588e37d311a70aa9fd905aa8a55bf1a9edc","unresolved":false,"context_lines":[{"line_number":416,"context_line":""},{"line_number":417,"context_line":"@utils.arg(\u0027--import-method\u0027, metavar\u003d\u0027\u003cMETHOD\u003e\u0027, default\u003d\u0027glance-direct\u0027,"},{"line_number":418,"context_line":"           help\u003d_(\u0027Import method used for Image Import workflow. \u0027"},{"line_number":419,"context_line":"                  \u0027Valid values can be retrieved with import-info command \u0027"},{"line_number":420,"context_line":"                  \u0027and the default \"glance-direct\" is used with \u0027"},{"line_number":421,"context_line":"                  \u0027\"image-stage\".\u0027))"},{"line_number":422,"context_line":"@utils.arg(\u0027id\u0027, metavar\u003d\u0027\u003cIMAGE_ID\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f436f4f_2ecbb5a5","line":419,"updated":"2017-08-21 16:12:29.000000000","message":"Abhishek: end the help text for the other function with the above sentence (don\u0027t want to mention the image-stage stuff).","commit_id":"681f16f2ac6077dae5f1e33a93518c9b91e11a96"}]}