)]}'
{"id":"openstack%2Fpython-glanceclient~527370","triplet_id":"openstack%2Fpython-glanceclient~master~I7dadf32d37ac2bda33a92c71d5882e9f23e38a82","project":"openstack/python-glanceclient","branch":"master","topic":"bug/1736759","hashtags":[],"change_id":"I7dadf32d37ac2bda33a92c71d5882e9f23e38a82","subject":"Compare against \u0027RequestIdProxy.wrapped\u0027","status":"MERGED","created":"2017-12-12 11:05:13.000000000","updated":"2018-01-02 22:51:25.000000000","submitted":"2018-01-02 22:51:25.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"527370-1514933485347-cccab92a","meta_rev_id":"c9627473eafbbb72178c4cf1a82d4638c3d2d73a","_number":527370,"virtual_id_number":527370,"owner":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},{"value":2,"date":"2018-01-02 22:51:25.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"all":[{"value":2,"date":"2018-01-02 17:29:53.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2018-01-02 20:38:21.000000000","_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"all":[{"value":0,"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2018-01-02 20:38:21.000000000","_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Top Priority / Holds Gate"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2018-01-02 17:29:53.000000000","updated_by":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"reviewer":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"state":"REVIEWER"},{"updated":"2018-01-02 20:38:21.000000000","updated_by":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"reviewer":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"state":"REVIEWER"},{"updated":"2018-01-02 22:51:25.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"54ad034686048baec4b7ab64d9f2b652b4051d73","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2017-12-12 11:05:13.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"9194562224109797a711b28598f7b157daec5e06","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2017-12-12 13:35:17.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-pep8 http://logs.openstack.org/70/527370/1/check/openstack-tox-pep8/07e913a/ : SUCCESS in 4m 36s\n- openstack-tox-py27 http://logs.openstack.org/70/527370/1/check/openstack-tox-py27/882971b/ : SUCCESS in 5m 24s\n- openstack-tox-py35 http://logs.openstack.org/70/527370/1/check/openstack-tox-py35/329935a/ : SUCCESS in 6m 16s\n- build-openstack-sphinx-docs http://logs.openstack.org/70/527370/1/check/build-openstack-sphinx-docs/1aeca6c/html/ : SUCCESS in 4m 51s\n- legacy-tempest-dsvm-neutron-src http://logs.openstack.org/70/527370/1/check/legacy-tempest-dsvm-neutron-src/de9ec2b/ : POST_FAILURE in 2h 19m 39s","accounts_in_message":[],"_revision_number":1},{"id":"f94b5d0070f4332c661958c5c6a30b0100275c99","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2017-12-21 12:29:06.000000000","message":"Patch Set 2: Patch Set 1 was rebased","accounts_in_message":[],"_revision_number":2},{"id":"55d90f6e471f47eab1c74ac933b5422e627c8048","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2017-12-21 13:21:34.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-pep8 http://logs.openstack.org/70/527370/2/check/openstack-tox-pep8/41c1a8f/ : SUCCESS in 4m 10s\n- openstack-tox-py27 http://logs.openstack.org/70/527370/2/check/openstack-tox-py27/cf788eb/ : SUCCESS in 4m 07s\n- openstack-tox-py35 http://logs.openstack.org/70/527370/2/check/openstack-tox-py35/dd695b2/ : SUCCESS in 4m 24s\n- build-openstack-sphinx-docs http://logs.openstack.org/70/527370/2/check/build-openstack-sphinx-docs/a9335d8/html/ : SUCCESS in 3m 33s\n- legacy-tempest-dsvm-neutron-src http://logs.openstack.org/70/527370/2/check/legacy-tempest-dsvm-neutron-src/e6659b0/ : FAILURE in 49m 33s\n- glanceclient-dsvm-functional http://logs.openstack.org/70/527370/2/check/glanceclient-dsvm-functional/f584ace/ : SUCCESS in 25m 54s\n- glanceclient-dsvm-functional-identity-v3-only http://logs.openstack.org/70/527370/2/check/glanceclient-dsvm-functional-identity-v3-only/3c51a77/ : SUCCESS in 22m 39s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"7072b380569c1af3b07adfedb90a21eb52e081ed","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2018-01-02 11:36:15.000000000","message":"Uploaded patch set 3: Patch Set 2 was rebased.","accounts_in_message":[],"_revision_number":3},{"id":"9f1aebd62e2a326e61c19c869f43ec87b1b029f0","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-01-02 12:51:41.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/70/527370/3/check/openstack-tox-pep8/dfab731/ : SUCCESS in 4m 58s\n- openstack-tox-py27 http://logs.openstack.org/70/527370/3/check/openstack-tox-py27/750589c/ : SUCCESS in 4m 12s\n- openstack-tox-py35 http://logs.openstack.org/70/527370/3/check/openstack-tox-py35/6d2eb64/ : SUCCESS in 4m 10s\n- build-openstack-sphinx-docs http://logs.openstack.org/70/527370/3/check/build-openstack-sphinx-docs/df7927f/html/ : SUCCESS in 3m 43s\n- legacy-tempest-dsvm-neutron-src http://logs.openstack.org/70/527370/3/check/legacy-tempest-dsvm-neutron-src/aedf2cb/ : SUCCESS in 1h 13m 33s\n- glanceclient-dsvm-functional http://logs.openstack.org/70/527370/3/check/glanceclient-dsvm-functional/24a237f/ : SUCCESS in 21m 18s\n- glanceclient-dsvm-functional-identity-v3-only http://logs.openstack.org/70/527370/3/check/glanceclient-dsvm-functional-identity-v3-only/3ce6a42/ : SUCCESS in 25m 09s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"ff5a76ed4613696cac970d727a21bef6dcf38669","author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"date":"2018-01-02 17:29:53.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"1471350841a895426fc92845620c0d14407d98a7","author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"date":"2018-01-02 20:38:21.000000000","message":"Patch Set 3: Workflow+1 Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"0340562f2bb7068a99c9fb6cd72bab7cc224c91c","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-01-02 20:38:33.000000000","message":"Patch Set 3: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":3},{"id":"5aae6fda441ac0d5297eacec5e95d671b10d3baa","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-01-02 22:51:25.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":3},{"id":"bb05b2f1678ee50c22d5a0010f8b58f2eb71767e","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-01-02 22:51:25.000000000","message":"Patch Set 3: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/70/527370/3/gate/openstack-tox-pep8/3cf34b2/ : SUCCESS in 5m 55s\n- openstack-tox-py27 http://logs.openstack.org/70/527370/3/gate/openstack-tox-py27/b8984a9/ : SUCCESS in 6m 05s\n- openstack-tox-py35 http://logs.openstack.org/70/527370/3/gate/openstack-tox-py35/bbe3ab6/ : SUCCESS in 3m 50s\n- build-openstack-sphinx-docs http://logs.openstack.org/70/527370/3/gate/build-openstack-sphinx-docs/f1ad54c/html/ : SUCCESS in 28m 45s\n- legacy-tempest-dsvm-neutron-src http://logs.openstack.org/70/527370/3/gate/legacy-tempest-dsvm-neutron-src/7e1f66d/ : SUCCESS in 1h 13m 14s\n- glanceclient-dsvm-functional http://logs.openstack.org/70/527370/3/gate/glanceclient-dsvm-functional/b9920d9/ : SUCCESS in 23m 20s","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"4dcbc30e317a25495bebc073bb9913d9fd9d43a2","revisions":{"4fe149f845d1654f59a39bc7c82c2af44de2dd85":{"kind":"REWORK","_number":1,"created":"2017-12-12 11:05:13.000000000","uploader":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"ref":"refs/changes/70/527370/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/70/527370/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/70/527370/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/70/527370/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/70/527370/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/70/527370/1"}}},"commit":{"parents":[{"commit":"9915f275ca0ba82a13a8b2e3ba1a67481162c780","subject":"Merge \"Remove Babel as a runtime requirement\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/9915f275ca0ba82a13a8b2e3ba1a67481162c780"}]}],"author":{"name":"Stephen Finucane","email":"sfinucan@redhat.com","date":"2017-12-12 10:57:24.000000000","tz":0},"committer":{"name":"Stephen Finucane","email":"sfinucan@redhat.com","date":"2017-12-12 11:00:20.000000000","tz":0},"subject":"Compare against \u0027RequestIdProxy.wrapped\u0027","message":"Compare against \u0027RequestIdProxy.wrapped\u0027\n\nDue to the \u0027glanceclient.common.utils.add_req_id_to_object\u0027 decorator,\nan instance of \u0027glanceclient.common.utils.RequestIdProxy\u0027 is returned\nfor most calls in glanceclient. If we wish to compare to None, we have\nto compare the contents of this wrapper and not the wrapper itself.\n\nUnit tests are updated to highlight this.\n\nChange-Id: I7dadf32d37ac2bda33a92c71d5882e9f23e38a82\nCloses-Bug: #1736759\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/4fe149f845d1654f59a39bc7c82c2af44de2dd85"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/4fe149f845d1654f59a39bc7c82c2af44de2dd85"}]},"branch":"refs/heads/master"},"c0c252ad3005048b8862209ad1ba0086863b10da":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2017-12-21 12:29:06.000000000","uploader":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"ref":"refs/changes/70/527370/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/70/527370/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/70/527370/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/70/527370/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/70/527370/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/70/527370/2"}}},"commit":{"parents":[{"commit":"bb0911910ebf582f0b3fb59e199d1cbb5d8b0f52","subject":"Revise functional testing README file","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/bb0911910ebf582f0b3fb59e199d1cbb5d8b0f52"}]}],"author":{"name":"Stephen Finucane","email":"sfinucan@redhat.com","date":"2017-12-12 10:57:24.000000000","tz":0},"committer":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2017-12-21 12:29:06.000000000","tz":0},"subject":"Compare against \u0027RequestIdProxy.wrapped\u0027","message":"Compare against \u0027RequestIdProxy.wrapped\u0027\n\nDue to the \u0027glanceclient.common.utils.add_req_id_to_object\u0027 decorator,\nan instance of \u0027glanceclient.common.utils.RequestIdProxy\u0027 is returned\nfor most calls in glanceclient. If we wish to compare to None, we have\nto compare the contents of this wrapper and not the wrapper itself.\n\nUnit tests are updated to highlight this.\n\nChange-Id: I7dadf32d37ac2bda33a92c71d5882e9f23e38a82\nCloses-Bug: #1736759\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/c0c252ad3005048b8862209ad1ba0086863b10da"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/c0c252ad3005048b8862209ad1ba0086863b10da"}]},"branch":"refs/heads/master"},"4dcbc30e317a25495bebc073bb9913d9fd9d43a2":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2018-01-02 11:36:15.000000000","uploader":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"ref":"refs/changes/70/527370/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/70/527370/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/70/527370/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/70/527370/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/70/527370/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/70/527370/3"}}},"commit":{"parents":[{"commit":"319579b34f635ea8efad81b7f6011ca06bfd7eba","subject":"Merge \"Updated from global requirements\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/319579b34f635ea8efad81b7f6011ca06bfd7eba"}]}],"author":{"name":"Stephen Finucane","email":"sfinucan@redhat.com","date":"2017-12-12 10:57:24.000000000","tz":0},"committer":{"name":"Stephen Finucane","email":"sfinucan@redhat.com","date":"2018-01-02 11:36:02.000000000","tz":0},"subject":"Compare against \u0027RequestIdProxy.wrapped\u0027","message":"Compare against \u0027RequestIdProxy.wrapped\u0027\n\nDue to the \u0027glanceclient.common.utils.add_req_id_to_object\u0027 decorator,\nan instance of \u0027glanceclient.common.utils.RequestIdProxy\u0027 is returned\nfor most calls in glanceclient. If we wish to compare to None, we have\nto compare the contents of this wrapper and not the wrapper itself.\n\nUnit tests are updated to highlight this.\n\nChange-Id: I7dadf32d37ac2bda33a92c71d5882e9f23e38a82\nCloses-Bug: #1736759\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/4dcbc30e317a25495bebc073bb9913d9fd9d43a2"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/4dcbc30e317a25495bebc073bb9913d9fd9d43a2"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}