)]}'
{"tox.ini":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"4815e3ee93c66efb2ea5f6a3d13c0e5f69b55485","unresolved":false,"context_lines":[{"line_number":44,"context_line":"[testenv:docs]"},{"line_number":45,"context_line":"deps \u003d -r{toxinidir}/doc/requirements.txt"},{"line_number":46,"context_line":"commands\u003d"},{"line_number":47,"context_line":"    phinx-build -W -b html doc/source doc/build/html"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"[testenv:releasenotes]"},{"line_number":50,"context_line":"deps \u003d -r{toxinidir}/doc/requirements.txt"}],"source_content_type":"text/x-properties","patch_set":1,"id":"df7087c5_5d16b057","line":47,"range":{"start_line":47,"start_character":4,"end_line":47,"end_character":15},"updated":"2018-03-21 12:29:04.000000000","message":"this should be \u0027sphinx-build\u0027","commit_id":"d56d5109ae2f21f3626619483840549dc9a6b533"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"edd12e150e928731985298a7d2045c2974632b7e","unresolved":false,"context_lines":[{"line_number":42,"context_line":"           coverage report"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"[testenv:docs]"},{"line_number":45,"context_line":"deps \u003d -r{toxinidir}/doc/requirements.txt"},{"line_number":46,"context_line":"commands\u003d"},{"line_number":47,"context_line":"    sphinx-build -W -b html doc/source doc/build/html"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-properties","patch_set":2,"id":"df7087c5_94941046","line":45,"updated":"2018-03-22 01:27:08.000000000","message":"We use upper-constraints, so you need to have\n\n    -c{env:UPPER_CONSTRAINTS_FILE:https://git.openstack.org/cgit/openstack/requirements/plain/upper-constraints.txt}\n    -r{toxinidir}/requirements.txt\n\nlisted before doc/requirements.txt in the deps list.","commit_id":"869422701b23307c7e8ad817bd40e0b85bed4e46"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"edd12e150e928731985298a7d2045c2974632b7e","unresolved":false,"context_lines":[{"line_number":44,"context_line":"[testenv:docs]"},{"line_number":45,"context_line":"deps \u003d -r{toxinidir}/doc/requirements.txt"},{"line_number":46,"context_line":"commands\u003d"},{"line_number":47,"context_line":"    sphinx-build -W -b html doc/source doc/build/html"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"[testenv:releasenotes]"},{"line_number":50,"context_line":"deps \u003d -r{toxinidir}/doc/requirements.txt"}],"source_content_type":"text/x-properties","patch_set":2,"id":"df7087c5_d4ffe864","line":47,"updated":"2018-03-22 01:27:08.000000000","message":"This doesn\u0027t build because we use the pbr autodoc feature.  The fix Monty mentions in http://lists.openstack.org/pipermail/openstack-dev/2017-December/125710.html enables zuul to directly use sphinx-build, but that doesn\u0027t apply in a local dev environment using tox.  I think you may have to keep this as\n\n    python setup.py build_sphinx\n\n(That command also builds man pages for us, some of the packagers really like them.)\n\nCheck with Monty about what to do.  I really don\u0027t like this change for the gate not to use tox to build the docs because now developers have no way to know whether the build will work or not since we\u0027ll be using different build commands in a dev environment than are used in the gate.  For instance, the build-openstack-sphinx-docs Zuul check passed on this patch even though your changes have broken the tox doc build.","commit_id":"869422701b23307c7e8ad817bd40e0b85bed4e46"}]}