)]}'
{"id":"openstack%2Fpython-glanceclient~555550","triplet_id":"openstack%2Fpython-glanceclient~master~I0a225f5471a9311217b5d90ebb5fd415c369129a","project":"openstack/python-glanceclient","branch":"master","topic":"bug/1758149","hashtags":[],"change_id":"I0a225f5471a9311217b5d90ebb5fd415c369129a","subject":"Make image-create-via-import fail faster","status":"MERGED","created":"2018-03-23 00:47:30.000000000","updated":"2018-04-05 12:11:13.000000000","submitted":"2018-04-05 06:11:51.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":17,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"555550-1522908711542-82265747","meta_rev_id":"d625a5eb6b8b36cddf6736f494b70d012d7b4a46","_number":555550,"virtual_id_number":555550,"owner":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},{"value":0,"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},{"value":0,"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"value":2,"date":"2018-04-05 06:11:51.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"all":[{"value":2,"date":"2018-04-04 19:28:09.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},{"value":0,"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},{"value":2,"date":"2018-04-05 04:58:13.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"all":[{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},{"value":0,"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},{"value":1,"date":"2018-04-05 04:58:13.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},{"value":0,"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},{"value":0,"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Top Priority / Holds Gate"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2018-04-04 17:11:37.000000000","updated_by":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"reviewer":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"state":"REVIEWER"},{"updated":"2018-04-04 19:28:09.000000000","updated_by":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"reviewer":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"state":"REVIEWER"},{"updated":"2018-04-05 04:58:13.000000000","updated_by":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"reviewer":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"state":"REVIEWER"},{"updated":"2018-04-05 06:11:51.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"cde6a73504b3b0aea293915135edd3ac1ef15fea","author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"date":"2018-03-23 00:47:30.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"025071af83c4718fe13980f5f28de6159804e9bc","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-03-23 02:10:36.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/50/555550/1/check/openstack-tox-pep8/39b6c41/ : SUCCESS in 4m 35s\n- openstack-tox-py27 http://logs.openstack.org/50/555550/1/check/openstack-tox-py27/65bef8a/ : SUCCESS in 4m 11s\n- openstack-tox-py35 http://logs.openstack.org/50/555550/1/check/openstack-tox-py35/348a254/ : SUCCESS in 4m 03s\n- build-openstack-sphinx-docs http://logs.openstack.org/50/555550/1/check/build-openstack-sphinx-docs/28d494a/html/ : SUCCESS in 6m 57s\n- legacy-tempest-dsvm-neutron-src http://logs.openstack.org/50/555550/1/check/legacy-tempest-dsvm-neutron-src/8a54a5e/ : SUCCESS in 1h 18m 22s\n- glanceclient-dsvm-functional http://logs.openstack.org/50/555550/1/check/glanceclient-dsvm-functional/5a8e9f6/ : SUCCESS in 23m 48s\n- glanceclient-dsvm-functional-identity-v3-only http://logs.openstack.org/50/555550/1/check/glanceclient-dsvm-functional-identity-v3-only/9f372b6/ : SUCCESS in 25m 17s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"4c325ed6522ca42fdc37a37d6a526c5e8980e082","author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"date":"2018-03-23 04:57:57.000000000","message":"Patch Set 1: Code-Review+2\n\nLooks much better, I guess ok to add additional tests in followup patch.\n\nThanks Brian!!!","accounts_in_message":[],"_revision_number":1},{"id":"52166a3186d15afcea6e7e96c1682bb1a0b7f2d4","author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"date":"2018-03-23 15:45:40.000000000","message":"Patch Set 1:\n\nLooks good Brian.\n\nIn your ML post you mentioned something about planning to add more tests. Is that still planned for this patch, or as a follow up?","accounts_in_message":[],"_revision_number":1},{"id":"4823a8486c56863fa8aad6df648a05f9f1dbb88f","author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"date":"2018-03-24 02:36:30.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"182ba9dbde818a6034542819c5279e942bfaf1b7","author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"date":"2018-03-24 02:39:07.000000000","message":"Patch Set 2:\n\nMoar testing!","accounts_in_message":[],"_revision_number":2},{"id":"9b1c5f2c0e7e68f1551cef22ba46849510d186d5","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-03-24 03:56:48.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/50/555550/2/check/openstack-tox-pep8/e95256e/ : SUCCESS in 3m 43s\n- openstack-tox-py27 http://logs.openstack.org/50/555550/2/check/openstack-tox-py27/7444db7/ : SUCCESS in 3m 52s\n- openstack-tox-py35 http://logs.openstack.org/50/555550/2/check/openstack-tox-py35/936458c/ : SUCCESS in 4m 06s\n- build-openstack-sphinx-docs http://logs.openstack.org/50/555550/2/check/build-openstack-sphinx-docs/d4f3c7c/html/ : SUCCESS in 3m 18s\n- legacy-tempest-dsvm-neutron-src http://logs.openstack.org/50/555550/2/check/legacy-tempest-dsvm-neutron-src/13813fa/ : SUCCESS in 1h 19m 24s\n- glanceclient-dsvm-functional http://logs.openstack.org/50/555550/2/check/glanceclient-dsvm-functional/89500fe/ : SUCCESS in 24m 09s\n- glanceclient-dsvm-functional-identity-v3-only http://logs.openstack.org/50/555550/2/check/glanceclient-dsvm-functional-identity-v3-only/0fbe4ca/ : SUCCESS in 25m 12s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"775e61e3d3becb33193acbc6f5606f92f242dc16","author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"date":"2018-03-26 04:06:41.000000000","message":"Patch Set 2: Code-Review+2\n\nExcellent tests!","accounts_in_message":[],"_revision_number":2},{"id":"8b7a5fbea2f26aaf6bd0f39312eb578366570387","author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"date":"2018-03-26 12:33:36.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"e7e4a3afca0eadae25e1b5de8c3aaf94c545daca","author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"date":"2018-03-26 13:44:29.000000000","message":"Patch Set 2: Code-Review-1\n\n(1 comment)\n\nI\u0027m not convinced about this.\n\nNot having default method nor a way to set one FE. via env variable is not going to improve that user experience. And I think that chage is the part where the bug is introduced that change is closing, so I\u0027m not convinced the bug exists in the first place.","accounts_in_message":[],"_revision_number":2},{"id":"0c0922a4db2bbc2d36aae2f8b43066249a30663a","author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"date":"2018-03-26 14:36:07.000000000","message":"Patch Set 2:\n\n(2 comments)\n\nSome responses inline.  My feeling about removing the default import-method is that this command does a lot of stuff, and it\u0027s better to require the user to be explicit about what they expect to accomplish.  The default will create an image record, just like the image-create call does now, but if you\u0027re going to supply data, you need to explicitly state what import-method you are using.  I think this is a more extensible strategy.","accounts_in_message":[],"_revision_number":2},{"id":"c79f38264ddd144835ccdf06dfdcfee8b8d34c16","author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"date":"2018-03-26 14:46:34.000000000","message":"Patch Set 2:\n\n(1 comment)\n\nLets put this on the agenda for Thu","accounts_in_message":[],"_revision_number":2},{"id":"d78210fb04abdfe6e3e7cf40ad7dc84c4f5328ba","author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"date":"2018-03-26 23:18:09.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"7cf06a95360dddb0477bf76a390c01e09e0a59f8","author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"date":"2018-03-27 15:06:48.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"eea5730acb0a1b4adbc163aa5f9d499835496aa0","author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"date":"2018-03-27 17:48:17.000000000","message":"Patch Set 2: -Code-Review\n\nNice catch sean","accounts_in_message":[],"_revision_number":2},{"id":"34ea8b49584118b3116673da54a4216fc1817f07","author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"date":"2018-03-28 16:13:21.000000000","message":"Patch Set 2:\n\n(1 comment)\n\nI updated the bug description with a workflow and log extract to illustrate the problem.  Also, comment inline.","accounts_in_message":[],"_revision_number":2},{"id":"318ce8f1358b9df2819305b54c42243a19f82252","author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"date":"2018-03-28 16:26:11.000000000","message":"Patch Set 2:\n\nWe can discuss whether there should be an import-method default or not at this week\u0027s meeting.  I\u0027m thinking ahead to when we replace the current image-create command with this command.  If you think of this as image-create, it\u0027s ambiguous for v2 because it could mean \"create an image record\" or \"create a full-blown bootable image\".  Right now, image-create with no --file or stdin just creates a record.  This is a bit more complex because there are several different import sources (and could be more if other methods are eventually added).  So I don\u0027t think it\u0027s too bad to have this command act the way it does on this patch (i.e., in order for it to accept data, you have to specify which import-method you are using).  I focused on the import-method instead of --file or --uri because there could eventually be other import methods using --file or --uri.  Also, i think it\u0027s easier for consumers to use: first decide what method I want to use, then decide what arguments I need to supply to the call.  But like I said, I\u0027m flexible about that.  We definitely need to add something like the series of tests on this patch, though.","accounts_in_message":[],"_revision_number":2},{"id":"b889f0a006a86312ffc3d516c7b66dab15f7414a","author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"date":"2018-03-28 16:41:49.000000000","message":"Patch Set 2:\n\nBTW, see https://review.openstack.org/557382 for a test that shows one problem situation that arises from the current glanceclient master.","accounts_in_message":[],"_revision_number":2},{"id":"253f31d9762fd8c20abed3096194e4294d59bec4","author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"date":"2018-03-28 18:32:33.000000000","message":"Patch Set 2:\n\n\u003e We can discuss whether there should be an import-method default or\n \u003e not at this week\u0027s meeting.  I\u0027m thinking ahead to when we replace\n \u003e the current image-create command with this command.  If you think\n \u003e of this as image-create, it\u0027s ambiguous for v2 because it could\n \u003e mean \"create an image record\" or \"create a full-blown bootable\n \u003e image\".  Right now, image-create with no --file or stdin just\n \u003e creates a record.  This is a bit more complex because there are\n \u003e several different import sources (and could be more if other\n \u003e methods are eventually added).  So I don\u0027t think it\u0027s too bad to\n \u003e have this command act the way it does on this patch (i.e., in order\n \u003e for it to accept data, you have to specify which import-method you\n \u003e are using).  I focused on the import-method instead of --file or\n \u003e --uri because there could eventually be other import methods using\n \u003e --file or --uri.  Also, i think it\u0027s easier for consumers to use:\n \u003e first decide what method I want to use, then decide what arguments\n \u003e I need to supply to the call.  But like I said, I\u0027m flexible about\n \u003e that.  We definitely need to add something like the series of tests\n \u003e on this patch, though.\n\nI do not like removing the default for exactly the same reason. Once we have stabilized deployments the swap would be seamless for the end user ... exactly the same command would work and do the same thing, only using different mechanism to achieve the image creation.\n\nIf we do not keep the default and change the name, we will break literally everyone and I\u0027ve gone through that already once too many times.","accounts_in_message":[],"_revision_number":2},{"id":"c68b967fe42666321231e7b007418ca10cfc50cb","author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"date":"2018-03-29 17:35:13.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"bd7d8c4604742b56dc75d3eb275d54c5b8cec18c","author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"date":"2018-03-29 17:44:26.000000000","message":"Patch Set 3:\n\nRevised according to what we discussed at today\u0027s Glance meeting.\n\nThere\u0027s no test for the env var setting because utils.env will put the value into args.import_method, so there\u0027s no way to tell from within the function whether or not the value came from an env var.  I think the tests in tests/unit/test_shell.py that check the env vars show us that utils.env work as expected, though.","accounts_in_message":[],"_revision_number":3},{"id":"ad3d3327d85074bb03191713c10d1d5584991195","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-03-29 18:52:23.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/50/555550/3/check/openstack-tox-pep8/24374bb/ : SUCCESS in 3m 54s\n- openstack-tox-py27 http://logs.openstack.org/50/555550/3/check/openstack-tox-py27/c389a3c/ : SUCCESS in 4m 13s\n- openstack-tox-py35 http://logs.openstack.org/50/555550/3/check/openstack-tox-py35/4f02c4b/ : SUCCESS in 3m 48s\n- build-openstack-sphinx-docs http://logs.openstack.org/50/555550/3/check/build-openstack-sphinx-docs/96f89ed/html/ : SUCCESS in 3m 50s\n- legacy-tempest-dsvm-neutron-src http://logs.openstack.org/50/555550/3/check/legacy-tempest-dsvm-neutron-src/b385264/ : SUCCESS in 1h 15m 48s\n- glanceclient-dsvm-functional http://logs.openstack.org/50/555550/3/check/glanceclient-dsvm-functional/625197c/ : SUCCESS in 26m 32s\n- glanceclient-dsvm-functional-identity-v3-only http://logs.openstack.org/50/555550/3/check/glanceclient-dsvm-functional-identity-v3-only/a23290a/ : SUCCESS in 26m 42s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"d1548bc6975adeba976a3a29e3737f6be50bde72","author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"date":"2018-04-03 05:54:09.000000000","message":"Patch Set 3: Code-Review+2\n\nCovered as per discussion in meeting.","accounts_in_message":[],"_revision_number":3},{"id":"1f8422e1495df1521a3453be3a0c831471b76b1a","author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"date":"2018-04-03 12:49:00.000000000","message":"Patch Set 3: Code-Review-1\n\n(7 comments)\n\nCouple of minor things but in general this looks really nicely covering all the aspects.\n\nThanks Brian!","accounts_in_message":[],"_revision_number":3},{"id":"ee79a335390e038fd4c7569e59375c31af0ed7c4","author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"date":"2018-04-03 15:01:34.000000000","message":"Patch Set 3:\n\n(2 comments)\n\nNew PS up shortly.","accounts_in_message":[],"_revision_number":3},{"id":"9c48351d0e8f90c56c35b817469ffe9cdfed26a5","author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"date":"2018-04-03 15:10:55.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"7fb39c915c1b68bcdb0d08b280da1e64c729d15c","author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"date":"2018-04-03 15:51:49.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"be559018f73afca66b828bb06aec94a384ede267","author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"date":"2018-04-03 15:53:46.000000000","message":"Patch Set 5:\n\nJust realized that I forgot to un-stash the example URL changes before I submitted PS4.","accounts_in_message":[],"_revision_number":5},{"id":"9d7d2a5a34711aeb5cfd0e3d33b4183bb1404be6","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-04-03 17:09:08.000000000","message":"Patch Set 5: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/50/555550/5/check/openstack-tox-pep8/e37222e/ : SUCCESS in 4m 15s\n- openstack-tox-py27 http://logs.openstack.org/50/555550/5/check/openstack-tox-py27/6260b48/ : SUCCESS in 4m 19s\n- openstack-tox-py35 http://logs.openstack.org/50/555550/5/check/openstack-tox-py35/6263021/ : SUCCESS in 5m 36s\n- build-openstack-sphinx-docs http://logs.openstack.org/50/555550/5/check/build-openstack-sphinx-docs/7ac4fee/html/ : SUCCESS in 4m 15s\n- legacy-tempest-dsvm-neutron-src http://logs.openstack.org/50/555550/5/check/legacy-tempest-dsvm-neutron-src/d4fbdc4/ : SUCCESS in 1h 15m 07s\n- glanceclient-dsvm-functional http://logs.openstack.org/50/555550/5/check/glanceclient-dsvm-functional/42c2e44/ : SUCCESS in 26m 34s\n- glanceclient-dsvm-functional-identity-v3-only http://logs.openstack.org/50/555550/5/check/glanceclient-dsvm-functional-identity-v3-only/5d28fb9/ : SUCCESS in 29m 06s (non-voting)","accounts_in_message":[],"_revision_number":5},{"id":"88af9bf1180339238434f6583fedfe5db8bcad65","author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"date":"2018-04-04 13:24:51.000000000","message":"Patch Set 5: Code-Review+2\n\nThanks Brian,\n\nLooks good to me","accounts_in_message":[],"_revision_number":5},{"id":"e14a44e4a70003174b29ee756a493bb31b278d86","author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"date":"2018-04-04 13:26:00.000000000","message":"Patch Set 5: Workflow+1 Code-Review+2\n\nLooks good to me, and all comments have been addressed.","accounts_in_message":[],"_revision_number":5},{"id":"9963d0bb78fa74a69674b05b0ba0bf75a7c9aaba","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-04-04 13:26:11.000000000","message":"Patch Set 5: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":5},{"id":"4ca899ba93bebfa02d96d86ec3b3a05757254acd","author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"date":"2018-04-04 14:17:14.000000000","message":"Uploaded patch set 6.","accounts_in_message":[],"_revision_number":6},{"id":"b4d14347665a90dc9b2a3ce39bff3fa6f93c1741","author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"date":"2018-04-04 14:19:13.000000000","message":"Patch Set 6:\n\nI realized that the 2 backward-compat tests I added would pass even if the code wasn\u0027t doing what it was supposed to.  This patch beefs those up and while I was in there, I improved the web-download test.","accounts_in_message":[],"_revision_number":6},{"id":"fb26aafd4e4a08dd24f4e0b66553c8469d49c1bd","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-04-04 15:54:57.000000000","message":"Patch Set 6: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/50/555550/6/check/openstack-tox-pep8/db4d40a/ : SUCCESS in 3m 52s\n- openstack-tox-py27 http://logs.openstack.org/50/555550/6/check/openstack-tox-py27/0586bba/ : SUCCESS in 4m 56s\n- openstack-tox-py35 http://logs.openstack.org/50/555550/6/check/openstack-tox-py35/0811882/ : SUCCESS in 4m 23s\n- build-openstack-sphinx-docs http://logs.openstack.org/50/555550/6/check/build-openstack-sphinx-docs/606a8bf/html/ : SUCCESS in 4m 33s\n- legacy-tempest-dsvm-neutron-src http://logs.openstack.org/50/555550/6/check/legacy-tempest-dsvm-neutron-src/b2bc6a7/ : SUCCESS in 1h 29m 29s\n- glanceclient-dsvm-functional http://logs.openstack.org/50/555550/6/check/glanceclient-dsvm-functional/8a80c04/ : SUCCESS in 24m 45s\n- glanceclient-dsvm-functional-identity-v3-only http://logs.openstack.org/50/555550/6/check/glanceclient-dsvm-functional-identity-v3-only/c246013/ : SUCCESS in 23m 09s (non-voting)","accounts_in_message":[],"_revision_number":6},{"id":"cab0f8ed44cb20b6c0f969fc54bae96fbb3c7b5d","author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"date":"2018-04-04 17:11:37.000000000","message":"Patch Set 6:\n\nAs you are using the mock\u0027s assert_called_with() and assert_not_called(), how about for the consistency also replace \"self.assertEqual(1, mock_*.call_count)\" with assert_called_once()?","accounts_in_message":[],"_revision_number":6},{"id":"d413079c1f8be57833fb991cef97bbbbbad87aea","author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"date":"2018-04-04 17:51:50.000000000","message":"Uploaded patch set 7.","accounts_in_message":[],"_revision_number":7},{"id":"f43fe463b854c20d9e9e044a5c2ea54f2babc4b6","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-04-04 19:11:14.000000000","message":"Patch Set 7: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/50/555550/7/check/openstack-tox-pep8/a3fb883/ : SUCCESS in 4m 00s\n- openstack-tox-py27 http://logs.openstack.org/50/555550/7/check/openstack-tox-py27/8eb71a0/ : SUCCESS in 4m 10s\n- openstack-tox-py35 http://logs.openstack.org/50/555550/7/check/openstack-tox-py35/2d22251/ : SUCCESS in 4m 23s\n- build-openstack-sphinx-docs http://logs.openstack.org/50/555550/7/check/build-openstack-sphinx-docs/330db12/html/ : SUCCESS in 5m 05s\n- legacy-tempest-dsvm-neutron-src http://logs.openstack.org/50/555550/7/check/legacy-tempest-dsvm-neutron-src/09c4cee/ : SUCCESS in 1h 17m 44s\n- glanceclient-dsvm-functional http://logs.openstack.org/50/555550/7/check/glanceclient-dsvm-functional/cd69586/ : SUCCESS in 29m 55s\n- glanceclient-dsvm-functional-identity-v3-only http://logs.openstack.org/50/555550/7/check/glanceclient-dsvm-functional-identity-v3-only/1473686/ : SUCCESS in 24m 08s (non-voting)","accounts_in_message":[],"_revision_number":7},{"id":"1a24a13156d6f0fbcde45d0a9409354f0d1a66b3","author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"date":"2018-04-04 19:28:09.000000000","message":"Patch Set 7: Code-Review+2\n\nStill looks good to me.","accounts_in_message":[],"_revision_number":7},{"id":"4579e2b3dabb987f74b00316d12f0b9e546c4044","author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"date":"2018-04-05 04:58:13.000000000","message":"Patch Set 7: Workflow+1 Code-Review+2\n\nAll concerns addressed and looks pretty good, Thank you Brian!","accounts_in_message":[],"_revision_number":7},{"id":"d08b0a6227da3a63d91d33de2d3647ea8ace9a9c","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-04-05 04:58:25.000000000","message":"Patch Set 7: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":7},{"id":"141f3b49b8259745a3374709ef4d7bdc22fbe6f4","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-04-05 06:11:51.000000000","message":"Patch Set 7: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/50/555550/7/gate/openstack-tox-pep8/899f40f/ : SUCCESS in 4m 42s\n- openstack-tox-py27 http://logs.openstack.org/50/555550/7/gate/openstack-tox-py27/015dabc/ : SUCCESS in 4m 15s\n- openstack-tox-py35 http://logs.openstack.org/50/555550/7/gate/openstack-tox-py35/2518815/ : SUCCESS in 4m 01s\n- build-openstack-sphinx-docs http://logs.openstack.org/50/555550/7/gate/build-openstack-sphinx-docs/ae226e4/html/ : SUCCESS in 28m 21s\n- legacy-tempest-dsvm-neutron-src http://logs.openstack.org/50/555550/7/gate/legacy-tempest-dsvm-neutron-src/fc08768/ : SUCCESS in 1h 12m 03s\n- glanceclient-dsvm-functional http://logs.openstack.org/50/555550/7/gate/glanceclient-dsvm-functional/c02a935/ : SUCCESS in 26m 07s","accounts_in_message":[],"_revision_number":7},{"id":"7ceec469ca94dd69b1821d65aa15792fa763e0e4","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-04-05 06:11:51.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":7},{"id":"018c4c3107c7ca08706032962cd6e150a6c57341","author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"date":"2018-04-05 12:11:13.000000000","message":"Patch Set 7: Cherry Picked\n\nThis patchset was cherry picked to branch stable/queens as commit 4211b67e7aa560b97e19945d3bbb07a697628382","accounts_in_message":[],"_revision_number":7}],"current_revision_number":7,"current_revision":"79543a67edd7a15aa23426548d3be9ac5b99366d","revisions":{"4943671aea72361b70e2faf6b442e35e5b27b2eb":{"kind":"REWORK","_number":1,"created":"2018-03-23 00:47:30.000000000","uploader":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"ref":"refs/changes/50/555550/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/50/555550/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/50/555550/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/50/555550/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/50/555550/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/50/555550/1"}}},"commit":{"parents":[{"commit":"6cd537e2748fa636aa3061812b257d549a6d603f","subject":"Check for container,disk_format on web-download","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/6cd537e2748fa636aa3061812b257d549a6d603f"}]}],"author":{"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","date":"2018-03-22 19:49:44.000000000","tz":-240},"committer":{"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","date":"2018-03-23 00:47:27.000000000","tz":-240},"subject":"Make image-create-via-import fail faster","message":"Make image-create-via-import fail faster\n\nAdd checks to the image-create-via-import commmand so that it provides\nbetter user feedback and doesn\u0027t begin the import workflow unless the\ninput has a chance of succeeding.  Also changes the default input-method\nto None so that in the absence of an --input-method argument this call\ncan be used simply to create an image record.  In that way it can\neventually replace the current image-create command.\n\nChange-Id: I0a225f5471a9311217b5d90ebb5fd415c369129a\nCloses-bug: #1758149\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/4943671aea72361b70e2faf6b442e35e5b27b2eb"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/4943671aea72361b70e2faf6b442e35e5b27b2eb"}]},"branch":"refs/heads/master"},"45a51ecad219ecd141e8b8dbc39e299d18ca2fa4":{"kind":"REWORK","_number":2,"created":"2018-03-24 02:36:30.000000000","uploader":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"ref":"refs/changes/50/555550/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/50/555550/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/50/555550/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/50/555550/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/50/555550/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/50/555550/2"}}},"commit":{"parents":[{"commit":"6cd537e2748fa636aa3061812b257d549a6d603f","subject":"Check for container,disk_format on web-download","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/6cd537e2748fa636aa3061812b257d549a6d603f"}]}],"author":{"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","date":"2018-03-22 19:49:44.000000000","tz":-240},"committer":{"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","date":"2018-03-24 02:36:04.000000000","tz":-240},"subject":"Make image-create-via-import fail faster","message":"Make image-create-via-import fail faster\n\nAdd checks to the image-create-via-import commmand so that it provides\nbetter user feedback and doesn\u0027t begin the import workflow unless the\ninput has a chance of succeeding.  Also changes the default input-method\nto None so that in the absence of an --input-method argument this call\ncan be used simply to create an image record.  In that way it can\neventually replace the current image-create command.\n\nChange-Id: I0a225f5471a9311217b5d90ebb5fd415c369129a\nCloses-bug: #1758149\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/45a51ecad219ecd141e8b8dbc39e299d18ca2fa4"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/45a51ecad219ecd141e8b8dbc39e299d18ca2fa4"}]},"branch":"refs/heads/master"},"db71a2a2055bfe88670ca5f9b59fd9b437a2a667":{"kind":"REWORK","_number":3,"created":"2018-03-29 17:35:13.000000000","uploader":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"ref":"refs/changes/50/555550/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/50/555550/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/50/555550/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/50/555550/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/50/555550/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/50/555550/3"}}},"commit":{"parents":[{"commit":"6cd537e2748fa636aa3061812b257d549a6d603f","subject":"Check for container,disk_format on web-download","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/6cd537e2748fa636aa3061812b257d549a6d603f"}]}],"author":{"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","date":"2018-03-22 19:49:44.000000000","tz":-240},"committer":{"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","date":"2018-03-29 17:32:05.000000000","tz":-240},"subject":"Make image-create-via-import fail faster","message":"Make image-create-via-import fail faster\n\nAdd checks to the image-create-via-import commmand so that it provides\nbetter user feedback and doesn\u0027t begin the import workflow unless the\ninput has a chance of succeeding.  Preserves backward compatibility\nwith the current image-create command by (1) allowing an image record\nonly to be created when no import-method is specified AND no data is\nsupplied, and (2) doing the glance-direct workflow when no import-\nmethod is specified AND data is provided.  Also adds the ability for\nthe import-method to be set as an env var OS_IMAGE_IMPORT_METHOD.\n\nChange-Id: I0a225f5471a9311217b5d90ebb5fd415c369129a\nCloses-bug: #1758149\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/db71a2a2055bfe88670ca5f9b59fd9b437a2a667"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/db71a2a2055bfe88670ca5f9b59fd9b437a2a667"}]},"branch":"refs/heads/master"},"fd33fa7622a4360c1da4b86594a0bbc67a6851a8":{"kind":"REWORK","_number":4,"created":"2018-04-03 15:10:55.000000000","uploader":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"ref":"refs/changes/50/555550/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/50/555550/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/50/555550/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/50/555550/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/50/555550/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/50/555550/4"}}},"commit":{"parents":[{"commit":"6bab2404ecaba996fb97b1f33fa6f3ccae0bcd4a","subject":"Merge \"Fix intermittent v2 shell unit test failures\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/6bab2404ecaba996fb97b1f33fa6f3ccae0bcd4a"}]}],"author":{"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","date":"2018-03-22 19:49:44.000000000","tz":-240},"committer":{"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","date":"2018-04-03 15:10:30.000000000","tz":-240},"subject":"Make image-create-via-import fail faster","message":"Make image-create-via-import fail faster\n\nAdd checks to the image-create-via-import commmand so that it provides\nbetter user feedback and doesn\u0027t begin the import workflow unless the\ninput has a chance of succeeding.  Preserves backward compatibility\nwith the current image-create command by (1) allowing an image record\nonly to be created when no import-method is specified AND no data is\nsupplied, and (2) doing the glance-direct workflow when no import-\nmethod is specified AND data is provided.  Also adds the ability for\nthe import-method to be set as an env var OS_IMAGE_IMPORT_METHOD.\n\nChange-Id: I0a225f5471a9311217b5d90ebb5fd415c369129a\nCloses-bug: #1758149\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/fd33fa7622a4360c1da4b86594a0bbc67a6851a8"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/fd33fa7622a4360c1da4b86594a0bbc67a6851a8"}]},"branch":"refs/heads/master"},"2a60677bb11dfe8e11c5cf6013e16b9645ca1b34":{"kind":"REWORK","_number":5,"created":"2018-04-03 15:51:49.000000000","uploader":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"ref":"refs/changes/50/555550/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/50/555550/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/50/555550/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/50/555550/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/50/555550/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/50/555550/5"}}},"commit":{"parents":[{"commit":"6bab2404ecaba996fb97b1f33fa6f3ccae0bcd4a","subject":"Merge \"Fix intermittent v2 shell unit test failures\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/6bab2404ecaba996fb97b1f33fa6f3ccae0bcd4a"}]}],"author":{"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","date":"2018-03-22 19:49:44.000000000","tz":-240},"committer":{"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","date":"2018-04-03 15:51:35.000000000","tz":-240},"subject":"Make image-create-via-import fail faster","message":"Make image-create-via-import fail faster\n\nAdd checks to the image-create-via-import commmand so that it provides\nbetter user feedback and doesn\u0027t begin the import workflow unless the\ninput has a chance of succeeding.  Preserves backward compatibility\nwith the current image-create command by (1) allowing an image record\nonly to be created when no import-method is specified AND no data is\nsupplied, and (2) doing the glance-direct workflow when no import-\nmethod is specified AND data is provided.  Also adds the ability for\nthe import-method to be set as an env var OS_IMAGE_IMPORT_METHOD.\n\nChange-Id: I0a225f5471a9311217b5d90ebb5fd415c369129a\nCloses-bug: #1758149\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/2a60677bb11dfe8e11c5cf6013e16b9645ca1b34"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/2a60677bb11dfe8e11c5cf6013e16b9645ca1b34"}]},"branch":"refs/heads/master"},"62f06922cbdc73cd37f0eafbddc49ee7c8a1b3db":{"kind":"REWORK","_number":6,"created":"2018-04-04 14:17:14.000000000","uploader":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"ref":"refs/changes/50/555550/6","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/50/555550/6","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/50/555550/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/50/555550/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/50/555550/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/50/555550/6"}}},"commit":{"parents":[{"commit":"6bab2404ecaba996fb97b1f33fa6f3ccae0bcd4a","subject":"Merge \"Fix intermittent v2 shell unit test failures\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/6bab2404ecaba996fb97b1f33fa6f3ccae0bcd4a"}]}],"author":{"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","date":"2018-03-22 19:49:44.000000000","tz":-240},"committer":{"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","date":"2018-04-04 14:17:01.000000000","tz":-240},"subject":"Make image-create-via-import fail faster","message":"Make image-create-via-import fail faster\n\nAdd checks to the image-create-via-import commmand so that it provides\nbetter user feedback and doesn\u0027t begin the import workflow unless the\ninput has a chance of succeeding.  Preserves backward compatibility\nwith the current image-create command by (1) allowing an image record\nonly to be created when no import-method is specified AND no data is\nsupplied, and (2) doing the glance-direct workflow when no import-\nmethod is specified AND data is provided.  Also adds the ability for\nthe import-method to be set as an env var OS_IMAGE_IMPORT_METHOD.\n\nChange-Id: I0a225f5471a9311217b5d90ebb5fd415c369129a\nCloses-bug: #1758149\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/62f06922cbdc73cd37f0eafbddc49ee7c8a1b3db"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/62f06922cbdc73cd37f0eafbddc49ee7c8a1b3db"}]},"branch":"refs/heads/master"},"79543a67edd7a15aa23426548d3be9ac5b99366d":{"kind":"REWORK","_number":7,"created":"2018-04-04 17:51:50.000000000","uploader":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"ref":"refs/changes/50/555550/7","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/50/555550/7","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/50/555550/7 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/50/555550/7 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/50/555550/7 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/50/555550/7"}}},"commit":{"parents":[{"commit":"6bab2404ecaba996fb97b1f33fa6f3ccae0bcd4a","subject":"Merge \"Fix intermittent v2 shell unit test failures\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/6bab2404ecaba996fb97b1f33fa6f3ccae0bcd4a"}]}],"author":{"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","date":"2018-03-22 19:49:44.000000000","tz":-240},"committer":{"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","date":"2018-04-04 17:51:40.000000000","tz":-240},"subject":"Make image-create-via-import fail faster","message":"Make image-create-via-import fail faster\n\nAdd checks to the image-create-via-import commmand so that it provides\nbetter user feedback and doesn\u0027t begin the import workflow unless the\ninput has a chance of succeeding.  Preserves backward compatibility\nwith the current image-create command by (1) allowing an image record\nonly to be created when no import-method is specified AND no data is\nsupplied, and (2) doing the glance-direct workflow when no import-\nmethod is specified AND data is provided.  Also adds the ability for\nthe import-method to be set as an env var OS_IMAGE_IMPORT_METHOD.\n\nChange-Id: I0a225f5471a9311217b5d90ebb5fd415c369129a\nCloses-bug: #1758149\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/79543a67edd7a15aa23426548d3be9ac5b99366d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/79543a67edd7a15aa23426548d3be9ac5b99366d"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}