)]}'
{"id":"openstack%2Fpython-glanceclient~557834","triplet_id":"openstack%2Fpython-glanceclient~master~I3c85bb358f669504b364d55618c21382b7a2a66b","project":"openstack/python-glanceclient","branch":"master","topic":"bug/1759951","hashtags":[],"change_id":"I3c85bb358f669504b364d55618c21382b7a2a66b","subject":"Fix intermittent v2 shell unit test failures","status":"MERGED","created":"2018-03-29 21:29:10.000000000","updated":"2018-04-03 14:41:45.000000000","submitted":"2018-04-03 14:41:45.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"557834-1522766505660-b4c38317","meta_rev_id":"32089fb9f1a6c843941aa800281f243ef6923c5c","_number":557834,"virtual_id_number":557834,"owner":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"date":"2018-03-30 14:11:00.000000000","_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},{"value":0,"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},{"value":0,"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"value":2,"date":"2018-04-03 14:41:45.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"all":[{"value":0,"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},{"value":2,"date":"2018-04-03 13:09:50.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},{"value":2,"date":"2018-04-02 05:31:05.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"all":[{"value":0,"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},{"value":1,"date":"2018-04-03 13:09:50.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},{"value":0,"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},{"value":0,"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},{"value":0,"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Top Priority / Holds Gate"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2018-04-02 05:31:05.000000000","updated_by":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"reviewer":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"state":"REVIEWER"},{"updated":"2018-04-03 13:09:50.000000000","updated_by":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"reviewer":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"state":"REVIEWER"},{"updated":"2018-04-03 14:41:45.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"0ae51ffd8d3c133bd08434dc1bbaf8a25edc2432","author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"date":"2018-03-29 21:29:10.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"b4a4553af17262b22312323701414ea8d58e3b34","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-03-29 22:29:11.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-pep8 http://logs.openstack.org/34/557834/1/check/openstack-tox-pep8/0b560ad/ : SUCCESS in 4m 00s\n- openstack-tox-py27 http://logs.openstack.org/34/557834/1/check/openstack-tox-py27/11d7f15/ : SUCCESS in 4m 13s\n- openstack-tox-py35 http://logs.openstack.org/34/557834/1/check/openstack-tox-py35/5c4a345/ : SUCCESS in 4m 14s\n- build-openstack-sphinx-docs http://logs.openstack.org/34/557834/1/check/build-openstack-sphinx-docs/1ffa3af/html/ : SUCCESS in 4m 15s\n- legacy-tempest-dsvm-neutron-src http://logs.openstack.org/34/557834/1/check/legacy-tempest-dsvm-neutron-src/ea37fb9/ : FAILURE in 58m 07s\n- glanceclient-dsvm-functional http://logs.openstack.org/34/557834/1/check/glanceclient-dsvm-functional/a7e9b5f/ : SUCCESS in 22m 59s\n- glanceclient-dsvm-functional-identity-v3-only http://logs.openstack.org/34/557834/1/check/glanceclient-dsvm-functional-identity-v3-only/834433a/ : SUCCESS in 30m 43s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"58f6200ef3f4939830143ce6350aed63f199a9de","author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"date":"2018-03-30 14:10:40.000000000","message":"Patch Set 1:\n\nFailure is completely unrelated to this change:\n\ntempest.exceptions.VolumeResourceBuildErrorException: backup bd12dfcc-ad40-4992-9189-a6a3bca73596 failed to build and is in ERROR status\n\noccurred in test:\n\ntempest.api.volume.admin.test_volumes_backup.VolumesBackupsAdminTest.test_volume_backup_export_import","accounts_in_message":[],"_revision_number":1},{"id":"493fb7e21af113e4f1fa1c9642138d4b65f2a824","author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"date":"2018-03-30 14:11:00.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"7e42d514db004a47f50eb7a4c1a7cd88d867a555","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-03-30 15:40:33.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/34/557834/1/check/openstack-tox-pep8/8b94dca/ : SUCCESS in 3m 18s\n- openstack-tox-py27 http://logs.openstack.org/34/557834/1/check/openstack-tox-py27/ddfda66/ : SUCCESS in 3m 55s\n- openstack-tox-py35 http://logs.openstack.org/34/557834/1/check/openstack-tox-py35/4dfac11/ : SUCCESS in 3m 55s\n- build-openstack-sphinx-docs http://logs.openstack.org/34/557834/1/check/build-openstack-sphinx-docs/a0820e3/html/ : SUCCESS in 3m 39s\n- legacy-tempest-dsvm-neutron-src http://logs.openstack.org/34/557834/1/check/legacy-tempest-dsvm-neutron-src/8dc3f56/ : SUCCESS in 1h 23m 39s\n- glanceclient-dsvm-functional http://logs.openstack.org/34/557834/1/check/glanceclient-dsvm-functional/8a6fdce/ : SUCCESS in 26m 42s\n- glanceclient-dsvm-functional-identity-v3-only http://logs.openstack.org/34/557834/1/check/glanceclient-dsvm-functional-identity-v3-only/dd88834/ : SUCCESS in 27m 15s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"9ce2609e510479e3e562d0b64a3c4a4bebb80ddf","author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"date":"2018-04-02 05:31:05.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"a811447ad4e3001f83454ead745b6cd74cf03215","author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"date":"2018-04-03 13:09:50.000000000","message":"Patch Set 1: Workflow+1 Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"5ebbe30c5308887f353a2f891a45504c3e7e5a40","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-04-03 13:10:29.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"cb012f5fb50285f3eaba9dc7a7241d7ffb526a3c","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-04-03 14:41:45.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/34/557834/1/gate/openstack-tox-pep8/9bfba39/ : SUCCESS in 3m 52s\n- openstack-tox-py27 http://logs.openstack.org/34/557834/1/gate/openstack-tox-py27/a912b2b/ : SUCCESS in 5m 14s\n- openstack-tox-py35 http://logs.openstack.org/34/557834/1/gate/openstack-tox-py35/c564f7b/ : SUCCESS in 5m 09s\n- build-openstack-sphinx-docs http://logs.openstack.org/34/557834/1/gate/build-openstack-sphinx-docs/bf99f3f/html/ : SUCCESS in 4m 18s\n- legacy-tempest-dsvm-neutron-src http://logs.openstack.org/34/557834/1/gate/legacy-tempest-dsvm-neutron-src/5b406d0/ : SUCCESS in 1h 25m 30s\n- glanceclient-dsvm-functional http://logs.openstack.org/34/557834/1/gate/glanceclient-dsvm-functional/a6aac45/ : SUCCESS in 24m 09s","accounts_in_message":[],"_revision_number":1},{"id":"192161e9c46ee907dc7c3e478d78c05a66474968","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-04-03 14:41:45.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"dc3ee4aedbd9023bba1581a987b517f00b9bfd0e","revisions":{"dc3ee4aedbd9023bba1581a987b517f00b9bfd0e":{"kind":"REWORK","_number":1,"created":"2018-03-29 21:29:10.000000000","uploader":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"ref":"refs/changes/34/557834/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/34/557834/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/34/557834/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/34/557834/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/34/557834/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/34/557834/1"}}},"commit":{"parents":[{"commit":"bf820a18966c32f630d59220129cb48b66c080e6","subject":"Merge \"Remove usage of ordereddict\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/bf820a18966c32f630d59220129cb48b66c080e6"}]}],"author":{"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","date":"2018-03-29 21:21:59.000000000","tz":-240},"committer":{"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","date":"2018-03-29 21:28:44.000000000","tz":-240},"subject":"Fix intermittent v2 shell unit test failures","message":"Fix intermittent v2 shell unit test failures\n\nThe do_image_download code has a check to make sure that there\u0027s\na place to put the data (either filename or stdout redirect) before\ninitiating the download.  The location of this check was moved by\nchange I841bebeda38814235079429eca0b1e5fd2f04dae to happen at the\nbeginning of the function.  The two intermittently failing tests\ndo not explicitly address the check condition, and as a result the\ntests do exit early, but before they can check what they\u0027re supposed\nto be testing.\n\nCloses-bug: #1759951\n\nChange-Id: I3c85bb358f669504b364d55618c21382b7a2a66b\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/dc3ee4aedbd9023bba1581a987b517f00b9bfd0e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/dc3ee4aedbd9023bba1581a987b517f00b9bfd0e"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}