)]}'
{"id":"openstack%2Fpython-glanceclient~559121","triplet_id":"openstack%2Fpython-glanceclient~master~Ide62a2bacd1d03bce90dfb4707dfd6478bc8ed89","project":"openstack/python-glanceclient","branch":"master","hashtags":[],"change_id":"Ide62a2bacd1d03bce90dfb4707dfd6478bc8ed89","subject":"Using assertIsNone() instead of assertEqual(None)","status":"ABANDONED","created":"2018-04-05 16:21:34.000000000","updated":"2018-04-06 07:13:56.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"e9cd91ae99cb90c95cda2a15c01b3a48febf0f1d","_number":559121,"virtual_id_number":559121,"owner":{"_account_id":21486,"name":"wangqi","email":"wang.qi@99cloud.net","username":"wangqi"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":-1,"date":"2018-04-06 03:01:38.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Top Priority / Holds Gate"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2018-04-06 03:01:38.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"71ed06e7cabeec679b13d071500eba04197865e5","author":{"_account_id":21486,"name":"wangqi","email":"wang.qi@99cloud.net","username":"wangqi"},"date":"2018-04-05 16:21:34.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"6d6482ab865c3b4f0891b80fcaf48676e6f68657","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-04-05 17:54:21.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-pep8 http://logs.openstack.org/21/559121/1/check/openstack-tox-pep8/e90f489/ : FAILURE in 3m 27s\n- openstack-tox-py27 http://logs.openstack.org/21/559121/1/check/openstack-tox-py27/0254bc6/ : FAILURE in 4m 09s\n- openstack-tox-py35 http://logs.openstack.org/21/559121/1/check/openstack-tox-py35/ec2f8d3/ : FAILURE in 4m 13s\n- build-openstack-sphinx-docs http://logs.openstack.org/21/559121/1/check/build-openstack-sphinx-docs/2cbfdbf/html/ : SUCCESS in 3m 47s\n- legacy-tempest-dsvm-neutron-src http://logs.openstack.org/21/559121/1/check/legacy-tempest-dsvm-neutron-src/512a4de/ : SUCCESS in 1h 27m 00s\n- glanceclient-dsvm-functional http://logs.openstack.org/21/559121/1/check/glanceclient-dsvm-functional/b99f90a/ : SUCCESS in 22m 06s\n- glanceclient-dsvm-functional-identity-v3-only http://logs.openstack.org/21/559121/1/check/glanceclient-dsvm-functional-identity-v3-only/8557312/ : SUCCESS in 27m 47s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"bc87844458b93613f2cc783c9a0166d21d9fc86a","author":{"_account_id":21486,"name":"wangqi","email":"wang.qi@99cloud.net","username":"wangqi"},"date":"2018-04-06 01:46:36.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"195b98c99558fe4b86f067356939bc75761fc26f","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-04-06 03:01:38.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-pep8 http://logs.openstack.org/21/559121/2/check/openstack-tox-pep8/eeef379/ : SUCCESS in 3m 59s\n- openstack-tox-py27 http://logs.openstack.org/21/559121/2/check/openstack-tox-py27/dffc16e/ : FAILURE in 4m 39s\n- openstack-tox-py35 http://logs.openstack.org/21/559121/2/check/openstack-tox-py35/56c905d/ : FAILURE in 4m 02s\n- build-openstack-sphinx-docs http://logs.openstack.org/21/559121/2/check/build-openstack-sphinx-docs/1a17121/html/ : SUCCESS in 3m 46s\n- legacy-tempest-dsvm-neutron-src http://logs.openstack.org/21/559121/2/check/legacy-tempest-dsvm-neutron-src/72b1aec/ : SUCCESS in 1h 12m 38s\n- glanceclient-dsvm-functional http://logs.openstack.org/21/559121/2/check/glanceclient-dsvm-functional/104936c/ : SUCCESS in 25m 51s\n- glanceclient-dsvm-functional-identity-v3-only http://logs.openstack.org/21/559121/2/check/glanceclient-dsvm-functional-identity-v3-only/f0ef971/ : SUCCESS in 23m 14s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"e9cd91ae99cb90c95cda2a15c01b3a48febf0f1d","author":{"_account_id":21486,"name":"wangqi","email":"wang.qi@99cloud.net","username":"wangqi"},"date":"2018-04-06 07:13:56.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"7570e39c75b22aee518e8a5b0930a24459070368","revisions":{"570737f2c03a0b61da433929e577204c7c70cddb":{"kind":"REWORK","_number":1,"created":"2018-04-05 16:21:34.000000000","uploader":{"_account_id":21486,"name":"wangqi","email":"wang.qi@99cloud.net","username":"wangqi"},"ref":"refs/changes/21/559121/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/21/559121/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/21/559121/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/21/559121/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/21/559121/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/21/559121/1"}}},"commit":{"parents":[{"commit":"cbe602c6dd44c6b8a852b2f39e7e6724c0c2718c","subject":"Replace uuid.uuid4() with uuidutils.generate_uuid()","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/cbe602c6dd44c6b8a852b2f39e7e6724c0c2718c"}]}],"author":{"name":"wangqi","email":"wang.qi@99cloud.net","date":"2018-04-05 16:20:36.000000000","tz":0},"committer":{"name":"wangqi","email":"wang.qi@99cloud.net","date":"2018-04-05 16:20:36.000000000","tz":0},"subject":"Using assertIsNone() instead of assertEqual(None)","message":"Using assertIsNone() instead of assertEqual(None)\n\nFollowing OpenStack Style Guidelines:\n[1] http://docs.openstack.org/developer/hacking/#unit-tests-and-assertraises\n[H203] Unit test assertions tend to give better messages for more specific\nassertions. As a result, assertIsNone(...) is preferred over\nassertEqual(None, ...) and assertIs(..., None)\n\nChange-Id: Ide62a2bacd1d03bce90dfb4707dfd6478bc8ed89\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/570737f2c03a0b61da433929e577204c7c70cddb"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/570737f2c03a0b61da433929e577204c7c70cddb"}]},"branch":"refs/heads/master"},"7570e39c75b22aee518e8a5b0930a24459070368":{"kind":"REWORK","_number":2,"created":"2018-04-06 01:46:36.000000000","uploader":{"_account_id":21486,"name":"wangqi","email":"wang.qi@99cloud.net","username":"wangqi"},"ref":"refs/changes/21/559121/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/21/559121/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/21/559121/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/21/559121/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/21/559121/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/21/559121/2"}}},"commit":{"parents":[{"commit":"cbe602c6dd44c6b8a852b2f39e7e6724c0c2718c","subject":"Replace uuid.uuid4() with uuidutils.generate_uuid()","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/cbe602c6dd44c6b8a852b2f39e7e6724c0c2718c"}]}],"author":{"name":"wangqi","email":"wang.qi@99cloud.net","date":"2018-04-05 16:20:36.000000000","tz":0},"committer":{"name":"wangqi","email":"wang.qi@99cloud.net","date":"2018-04-06 01:46:24.000000000","tz":0},"subject":"Using assertIsNone() instead of assertEqual(None)","message":"Using assertIsNone() instead of assertEqual(None)\n\nFollowing OpenStack Style Guidelines:\n[1] http://docs.openstack.org/developer/hacking/#unit-tests-and-assertraises\n[H203] Unit test assertions tend to give better messages for more specific\nassertions. As a result, assertIsNone(...) is preferred over\nassertEqual(None, ...) and assertIs(..., None)\n\nChange-Id: Ide62a2bacd1d03bce90dfb4707dfd6478bc8ed89\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/7570e39c75b22aee518e8a5b0930a24459070368"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/7570e39c75b22aee518e8a5b0930a24459070368"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}