)]}'
{"id":"openstack%2Fpython-glanceclient~573334","triplet_id":"openstack%2Fpython-glanceclient~master~I8a41be18dac0fc3199ee5fa691a4ab48fae66849","project":"openstack/python-glanceclient","branch":"master","topic":"python3-first","hashtags":[],"change_id":"I8a41be18dac0fc3199ee5fa691a4ab48fae66849","subject":"fix tox python3 overrides","status":"MERGED","created":"2018-06-07 16:45:10.000000000","updated":"2018-07-06 22:21:44.000000000","submitted":"2018-07-06 22:21:43.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"573334-1530915704093-050f3658","meta_rev_id":"3b857229d36ae70e0d61fb7916f70b8ca227212b","_number":573334,"virtual_id_number":573334,"owner":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":27153,"name":"Nguyen Hai","email":"nguyentrihai93@gmail.com","username":"nguyentrihai"},{"value":0,"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},{"value":0,"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},{"value":0,"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},{"value":0,"_account_id":18791,"name":"Glance Bot","email":"glancebot@mailinator.com","username":"glancebot","inactive":true},{"value":0,"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"value":0,"date":"2018-06-07 21:52:27.000000000","_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},{"value":0,"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},{"value":2,"date":"2018-07-06 22:21:43.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"all":[{"value":2,"date":"2018-06-08 14:41:48.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":1,"date":"2018-06-11 08:23:23.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":27153,"name":"Nguyen Hai","email":"nguyentrihai93@gmail.com","username":"nguyentrihai"},{"value":0,"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},{"value":2,"date":"2018-07-06 20:49:41.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},{"value":1,"date":"2018-06-08 06:08:29.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},{"value":0,"_account_id":18791,"name":"Glance Bot","email":"glancebot@mailinator.com","username":"glancebot","inactive":true},{"value":0,"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"value":0,"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},{"value":0,"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"all":[{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":27153,"name":"Nguyen Hai","email":"nguyentrihai93@gmail.com","username":"nguyentrihai"},{"value":0,"date":"2018-07-06 01:36:13.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},{"value":1,"date":"2018-07-06 20:49:41.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},{"value":0,"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},{"value":0,"date":"2018-07-06 01:36:13.000000000","_account_id":18791,"name":"Glance Bot","email":"glancebot@mailinator.com","username":"glancebot","inactive":true},{"value":0,"date":"2018-07-06 01:36:13.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"value":0,"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},{"value":0,"date":"2018-07-06 01:36:13.000000000","_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":27153,"name":"Nguyen Hai","email":"nguyentrihai93@gmail.com","username":"nguyentrihai"},{"value":0,"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},{"value":0,"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},{"value":0,"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},{"value":0,"_account_id":18791,"name":"Glance Bot","email":"glancebot@mailinator.com","username":"glancebot","inactive":true},{"value":0,"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"value":0,"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},{"value":0,"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Top Priority / Holds Gate"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"_account_id":18791,"name":"Glance Bot","email":"glancebot@mailinator.com","username":"glancebot","inactive":true},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":27153,"name":"Nguyen Hai","email":"nguyentrihai93@gmail.com","username":"nguyentrihai"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2018-06-08 06:08:29.000000000","updated_by":{"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},"reviewer":{"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},"state":"REVIEWER"},{"updated":"2018-06-08 14:41:48.000000000","updated_by":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"reviewer":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"state":"REVIEWER"},{"updated":"2018-06-11 08:23:23.000000000","updated_by":{"_account_id":27153,"name":"Nguyen Hai","email":"nguyentrihai93@gmail.com","username":"nguyentrihai"},"reviewer":{"_account_id":27153,"name":"Nguyen Hai","email":"nguyentrihai93@gmail.com","username":"nguyentrihai"},"state":"REVIEWER"},{"updated":"2018-07-06 01:36:13.000000000","updated_by":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"reviewer":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"state":"REVIEWER"},{"updated":"2018-07-06 01:36:13.000000000","updated_by":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"reviewer":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"state":"REVIEWER"},{"updated":"2018-07-06 01:36:13.000000000","updated_by":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"reviewer":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"state":"REVIEWER"},{"updated":"2018-07-06 01:36:13.000000000","updated_by":{"_account_id":18791,"name":"Glance Bot","email":"glancebot@mailinator.com","username":"glancebot","inactive":true},"reviewer":{"_account_id":18791,"name":"Glance Bot","email":"glancebot@mailinator.com","username":"glancebot","inactive":true},"state":"REVIEWER"},{"updated":"2018-07-06 20:49:41.000000000","updated_by":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"reviewer":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"state":"REVIEWER"},{"updated":"2018-07-06 22:21:43.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"cb1e2a36197a7e5230b1d055aadb1a6fd5b90b81","author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"date":"2018-06-07 16:45:10.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"eee54b24c8a47d1e99f76c4e6c2bc585fe107a93","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-06-07 19:44:50.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-pep8 http://logs.openstack.org/34/573334/1/check/openstack-tox-pep8/1cc846b/ : SUCCESS in 4m 39s\n- openstack-tox-py27 http://logs.openstack.org/34/573334/1/check/openstack-tox-py27/66ee87d/ : SUCCESS in 4m 51s\n- openstack-tox-py35 http://logs.openstack.org/34/573334/1/check/openstack-tox-py35/9f9970e/ : FAILURE in 5m 06s\n- build-openstack-sphinx-docs http://logs.openstack.org/34/573334/1/check/build-openstack-sphinx-docs/33f92a8/html/ : SUCCESS in 5m 30s\n- legacy-tempest-dsvm-neutron-src http://logs.openstack.org/34/573334/1/check/legacy-tempest-dsvm-neutron-src/62c3b9e/ : SUCCESS in 1h 24m 31s\n- glanceclient-dsvm-functional-v1 http://logs.openstack.org/34/573334/1/check/glanceclient-dsvm-functional-v1/796d5f2/ : SUCCESS in 23m 51s\n- glanceclient-dsvm-functional http://logs.openstack.org/34/573334/1/check/glanceclient-dsvm-functional/1eec124/ : SUCCESS in 28m 17s\n- openstack-tox-lower-constraints http://logs.openstack.org/34/573334/1/check/openstack-tox-lower-constraints/4341a52/ : SUCCESS in 4m 35s","accounts_in_message":[],"_revision_number":1},{"id":"f199537a613d3bd5c81cd5ba9c68c7b5918d8fdf","author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"date":"2018-06-07 19:47:48.000000000","message":"Patch Set 1:\n\nHmm, looks like errors due to changes in dict ordering with python3, but that shouldn\u0027t have changed with this patch.","accounts_in_message":[],"_revision_number":1},{"id":"a797572b9b0db4a5458bafa26ba429752becb1ac","author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"date":"2018-06-07 20:11:54.000000000","message":"Patch Set 1:\n\nActually, this looks like a side effect from https://review.openstack.org/#/c/502074/\n\nWe may need to update the assert checks for these to handle variable ordering. Unless you know of a better way to handle this.","accounts_in_message":[],"_revision_number":1},{"id":"dbb985b759b623dce8adfef4ff72f2a323921ee5","author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"date":"2018-06-07 21:37:26.000000000","message":"Patch Set 1:\n\n\u003e Actually, this looks like a side effect from https://review.openstack.org/#/c/502074/\n \u003e \n \u003e We may need to update the assert checks for these to handle\n \u003e variable ordering. Unless you know of a better way to handle this.\n\nA quick search doesn\u0027t turn up a way to change the hash seed behavior at runtime once it has been initialized.\n\nThat test appears to be trying to validate that the schema is being written to a file after being serialized. That\u0027s 2 things, so, we could split the test into a few separate tests and avoid depending on the serialized representation.\n\nSplitting the tests will require changing the library code so that the write can be mocked. That means moving lines 462-463 into their own method or function. The arguments should be the filename and the not-yet-serialized schema data. That method can then be mocked and we can test that it tries to write to a file when it is called (this is test 1).\n\nThe logic within _cache_schemas() that builds the list of schema data can also then be extracted into its own method, and we can test that it produces the expected sequence of filenames and schema data. If we turn it into a generator function we can still loop over its output easily as well, so that _cache_schemas() will be simpler when the change is done (the sequence test is test 2).\n\nFinally, we can loop over the schema data we are given from the new generator and test that it can be serialized to JSON at all, without checking what the result is other than to verify that it is not empty (this is test 3). This lets us know that we don\u0027t have something in the schema that can\u0027t be represented as JSON (a socket or file handle or something) but the test won\u0027t care what the representation is because that would be testing the JSON serializer, which is not part of glance client.\n\nIt\u0027s possible there is a shorter way to do that, and that someone more familiar with the code would be able to get creative with mocks or ordered dicts or something like that.","accounts_in_message":[],"_revision_number":1},{"id":"ff56e27b7e8375030e944f86c552932aae2af9bd","author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"date":"2018-06-07 21:39:02.000000000","message":"Patch Set 1:\n\n\u003e \u003e Actually, this looks like a side effect from https://review.openstack.org/#/c/502074/\n \u003e \u003e\n \u003e \u003e We may need to update the assert checks for these to handle\n \u003e \u003e variable ordering. Unless you know of a better way to handle\n \u003e this.\n \u003e \n \u003e A quick search doesn\u0027t turn up a way to change the hash seed\n \u003e behavior at runtime once it has been initialized.\n \u003e \n \u003e That test appears to be trying to validate that the schema is being\n \u003e written to a file after being serialized. That\u0027s 2 things, so, we\n \u003e could split the test into a few separate tests and avoid depending\n \u003e on the serialized representation.\n \u003e \n \u003e Splitting the tests will require changing the library code so that\n \u003e the write can be mocked. That means moving lines 462-463 into their\n \u003e own method or function. The arguments should be the filename and\n \u003e the not-yet-serialized schema data. That method can then be mocked\n \u003e and we can test that it tries to write to a file when it is called\n \u003e (this is test 1).\n \u003e \n \u003e The logic within _cache_schemas() that builds the list of schema\n \u003e data can also then be extracted into its own method, and we can\n \u003e test that it produces the expected sequence of filenames and schema\n \u003e data. If we turn it into a generator function we can still loop\n \u003e over its output easily as well, so that _cache_schemas() will be\n \u003e simpler when the change is done (the sequence test is test 2).\n \u003e \n \u003e Finally, we can loop over the schema data we are given from the new\n \u003e generator and test that it can be serialized to JSON at all,\n \u003e without checking what the result is other than to verify that it is\n \u003e not empty (this is test 3). This lets us know that we don\u0027t have\n \u003e something in the schema that can\u0027t be represented as JSON (a socket\n \u003e or file handle or something) but the test won\u0027t care what the\n \u003e representation is because that would be testing the JSON\n \u003e serializer, which is not part of glance client.\n \u003e \n \u003e It\u0027s possible there is a shorter way to do that, and that someone\n \u003e more familiar with the code would be able to get creative with\n \u003e mocks or ordered dicts or something like that.\n\nOh, alternatively we could deserialize the argument to the mock call and compare that against the raw data structure instead of comparing the strings. I don\u0027t know how hard it is to get the data out of a mock call like that.","accounts_in_message":[],"_revision_number":1},{"id":"a2330daccf0e0e255c7769406d85b0dadd96995e","author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"date":"2018-06-07 21:51:33.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.","accounts_in_message":[],"_revision_number":2},{"id":"b4d28738b5f283281633b79d380b2d4a1ad36d37","author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"date":"2018-06-07 21:52:27.000000000","message":"Patch Set 2:\n\n\u003e Oh, alternatively we could deserialize the argument to the mock\n \u003e call and compare that against the raw data structure instead of\n \u003e comparing the strings. I don\u0027t know how hard it is to get the data\n \u003e out of a mock call like that.\n\nI\u0027m trying that in the new parent patch that I rebased this one on top of.","accounts_in_message":[],"_revision_number":2},{"id":"9289749f0f4383f2af85cc66b60acd4af970405f","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-06-07 23:16:29.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/34/573334/2/check/openstack-tox-pep8/b7c9e0f/ : SUCCESS in 4m 24s\n- openstack-tox-py27 http://logs.openstack.org/34/573334/2/check/openstack-tox-py27/c06ab51/ : SUCCESS in 4m 07s\n- openstack-tox-py35 http://logs.openstack.org/34/573334/2/check/openstack-tox-py35/058faee/ : SUCCESS in 4m 29s\n- build-openstack-sphinx-docs http://logs.openstack.org/34/573334/2/check/build-openstack-sphinx-docs/c110b6f/html/ : SUCCESS in 4m 06s\n- legacy-tempest-dsvm-neutron-src http://logs.openstack.org/34/573334/2/check/legacy-tempest-dsvm-neutron-src/7be9816/ : SUCCESS in 1h 23m 14s\n- glanceclient-dsvm-functional-v1 http://logs.openstack.org/34/573334/2/check/glanceclient-dsvm-functional-v1/6c6713f/ : SUCCESS in 27m 54s\n- glanceclient-dsvm-functional http://logs.openstack.org/34/573334/2/check/glanceclient-dsvm-functional/3c9dd7c/ : SUCCESS in 23m 31s\n- openstack-tox-lower-constraints http://logs.openstack.org/34/573334/2/check/openstack-tox-lower-constraints/14e7965/ : SUCCESS in 4m 08s","accounts_in_message":[],"_revision_number":2},{"id":"f9f9b3e60fc8c5c5fd7be8a389204f37868c9305","author":{"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},"date":"2018-06-08 06:08:29.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"0677441c36109032c8509e86c4409a3d75963f5b","author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"date":"2018-06-08 14:41:48.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"d7737691b3e9fd62951e680830bae57b993e7533","author":{"_account_id":27153,"name":"Nguyen Hai","email":"nguyentrihai93@gmail.com","username":"nguyentrihai"},"date":"2018-06-11 08:23:23.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"15fec2134f49c49d757e8995cb8748271ff01882","author":{"_account_id":27153,"name":"Nguyen Hai","email":"nguyentrihai93@gmail.com","username":"nguyentrihai"},"date":"2018-06-23 02:07:18.000000000","message":"Patch Set 2:\n\nrecheck","accounts_in_message":[],"_revision_number":2},{"id":"54658ecc79d619a7c9490defd33e9f85085ca459","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-06-23 04:13:19.000000000","message":"Patch Set 2:\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/34/573334/2/check/openstack-tox-pep8/aa56c14/ : SUCCESS in 5m 47s\n- openstack-tox-py27 http://logs.openstack.org/34/573334/2/check/openstack-tox-py27/a1654f2/ : SUCCESS in 4m 22s\n- openstack-tox-py35 http://logs.openstack.org/34/573334/2/check/openstack-tox-py35/cf2835b/ : SUCCESS in 4m 18s\n- build-openstack-sphinx-docs http://logs.openstack.org/34/573334/2/check/build-openstack-sphinx-docs/7135dc3/html/ : SUCCESS in 4m 14s\n- legacy-tempest-dsvm-neutron-src http://logs.openstack.org/34/573334/2/check/legacy-tempest-dsvm-neutron-src/ea257af/ : SUCCESS in 2h 04m 54s\n- glanceclient-dsvm-functional-v1 http://logs.openstack.org/34/573334/2/check/glanceclient-dsvm-functional-v1/2e9a370/ : SUCCESS in 29m 07s\n- glanceclient-dsvm-functional http://logs.openstack.org/34/573334/2/check/glanceclient-dsvm-functional/0052568/ : SUCCESS in 23m 47s\n- openstack-tox-lower-constraints http://logs.openstack.org/34/573334/2/check/openstack-tox-lower-constraints/986a6cb/ : SUCCESS in 3m 36s","accounts_in_message":[],"_revision_number":2},{"id":"db2d88f28b4b6988c027d4700dcd01838fdd9c79","author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"date":"2018-07-06 20:48:33.000000000","message":"Patch Set 2:\n\nThe other patch set Doug mentioned has merged: https://review.openstack.org/#/c/573448/","accounts_in_message":[],"_revision_number":2},{"id":"e35ef990e8bce0593f9e8d6400c3850c9b55ed5b","author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"date":"2018-07-06 20:49:41.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1\n\nLGTM.","accounts_in_message":[],"_revision_number":2},{"id":"a06c9c94e7c0933c5e626c1488dab06a769e4933","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-07-06 20:49:54.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"c325db9c88a2f07925e0853dce002667cc6a187e","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-07-06 22:21:43.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/34/573334/2/gate/openstack-tox-pep8/c978a2b/ : SUCCESS in 4m 01s\n- openstack-tox-py27 http://logs.openstack.org/34/573334/2/gate/openstack-tox-py27/51da5f1/ : SUCCESS in 4m 27s\n- openstack-tox-py35 http://logs.openstack.org/34/573334/2/gate/openstack-tox-py35/43a2945/ : SUCCESS in 4m 12s\n- build-openstack-sphinx-docs http://logs.openstack.org/34/573334/2/gate/build-openstack-sphinx-docs/b90362c/html/ : SUCCESS in 4m 32s\n- legacy-tempest-dsvm-neutron-src http://logs.openstack.org/34/573334/2/gate/legacy-tempest-dsvm-neutron-src/e2afbe8/ : SUCCESS in 1h 30m 47s\n- glanceclient-dsvm-functional-v1 http://logs.openstack.org/34/573334/2/gate/glanceclient-dsvm-functional-v1/03267e2/ : SUCCESS in 23m 04s\n- glanceclient-dsvm-functional http://logs.openstack.org/34/573334/2/gate/glanceclient-dsvm-functional/2f5eed7/ : SUCCESS in 23m 41s\n- openstack-tox-lower-constraints http://logs.openstack.org/34/573334/2/gate/openstack-tox-lower-constraints/e35b8a5/ : SUCCESS in 5m 24s","accounts_in_message":[],"_revision_number":2},{"id":"3d175118622cdbea1435aa73aac811bf8b92594c","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-07-06 22:21:44.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"f536541eb65ddfaccfc90ddaa83df0648dc85d2d","revisions":{"d48c59fac7a2bab187dea87d27cfec6f4df7d98b":{"kind":"REWORK","_number":1,"created":"2018-06-07 16:45:10.000000000","uploader":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"ref":"refs/changes/34/573334/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/34/573334/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/34/573334/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/34/573334/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/34/573334/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/34/573334/1"}}},"commit":{"parents":[{"commit":"1cf00a5cc9c095071d18137c44f2722d0e20d84e","subject":"Merge \"Add release note for HTTP headers fix\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/1cf00a5cc9c095071d18137c44f2722d0e20d84e"}]}],"author":{"name":"Doug Hellmann","email":"doug@doughellmann.com","date":"2018-06-06 21:58:17.000000000","tz":-240},"committer":{"name":"Doug Hellmann","email":"doug@doughellmann.com","date":"2018-06-06 21:58:17.000000000","tz":-240},"subject":"fix tox python3 overrides","message":"fix tox python3 overrides\n\nWe want to default to running all tox environments under python 3, so\nset the basepython value in each environment.\n\nWe do not want to specify a minor version number, because we do not\nwant to have to update the file every time we upgrade python.\n\nWe do not want to set the override once in testenv, because that\nbreaks the more specific versions used in default environments like\npy35 and py36.\n\nChange-Id: I8a41be18dac0fc3199ee5fa691a4ab48fae66849\nSigned-off-by: Doug Hellmann \u003cdoug@doughellmann.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/d48c59fac7a2bab187dea87d27cfec6f4df7d98b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/d48c59fac7a2bab187dea87d27cfec6f4df7d98b"}]},"branch":"refs/heads/master"},"f536541eb65ddfaccfc90ddaa83df0648dc85d2d":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2018-06-07 21:51:33.000000000","uploader":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"ref":"refs/changes/34/573334/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/34/573334/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/34/573334/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/34/573334/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/34/573334/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/34/573334/2"}}},"commit":{"parents":[{"commit":"e48431192375bbace0adc896b9c4de3a9cd00b34","subject":"update shell tests to not rely on the serialization order of a dict","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/e48431192375bbace0adc896b9c4de3a9cd00b34"}]}],"author":{"name":"Doug Hellmann","email":"doug@doughellmann.com","date":"2018-06-06 21:58:17.000000000","tz":-240},"committer":{"name":"Doug Hellmann","email":"doug@doughellmann.com","date":"2018-06-07 21:51:28.000000000","tz":-240},"subject":"fix tox python3 overrides","message":"fix tox python3 overrides\n\nWe want to default to running all tox environments under python 3, so\nset the basepython value in each environment.\n\nWe do not want to specify a minor version number, because we do not\nwant to have to update the file every time we upgrade python.\n\nWe do not want to set the override once in testenv, because that\nbreaks the more specific versions used in default environments like\npy35 and py36.\n\nChange-Id: I8a41be18dac0fc3199ee5fa691a4ab48fae66849\nSigned-off-by: Doug Hellmann \u003cdoug@doughellmann.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/f536541eb65ddfaccfc90ddaa83df0648dc85d2d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/f536541eb65ddfaccfc90ddaa83df0648dc85d2d"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}