)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"fd62eae2549a6eb2ef8de2c155405f1d722a2bea","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add multi-store support"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Added multi-store support. User can now use \u0027--backned\u0027"},{"line_number":10,"context_line":"option to pass desire store while creating, uploading or"},{"line_number":11,"context_line":"importing image to speific store backend."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"5f7c97a3_cc04a180","line":9,"range":{"start_line":9,"start_character":51,"end_line":9,"end_character":53},"updated":"2018-07-23 13:30:29.000000000","message":"NIT: if new rev needed \u0027en\u0027","commit_id":"e510377e49c634ee899b219a80903a974a31a05c"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"8cb4372e1bdebcd97a85c1088f34f16251e36f43","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add multi-store support"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Added multi-store support. User can now use \u0027--backned\u0027"},{"line_number":10,"context_line":"option to pass desire store while creating, uploading or"},{"line_number":11,"context_line":"importing image to speific store backend."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"5f7c97a3_2f2502c0","line":9,"range":{"start_line":9,"start_character":51,"end_line":9,"end_character":53},"in_reply_to":"5f7c97a3_cc04a180","updated":"2018-07-23 18:00:51.000000000","message":"Done","commit_id":"e510377e49c634ee899b219a80903a974a31a05c"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"fd62eae2549a6eb2ef8de2c155405f1d722a2bea","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add multi-store support"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Added multi-store support. User can now use \u0027--backned\u0027"},{"line_number":10,"context_line":"option to pass desire store while creating, uploading or"},{"line_number":11,"context_line":"importing image to speific store backend."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Added new command \u0027stores-info\u0027 which will return available"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"5f7c97a3_ececfdbd","line":10,"range":{"start_line":10,"start_character":20,"end_line":10,"end_character":21},"updated":"2018-07-23 13:30:29.000000000","message":"NIT: \u0027ed\u0027","commit_id":"e510377e49c634ee899b219a80903a974a31a05c"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"8cb4372e1bdebcd97a85c1088f34f16251e36f43","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add multi-store support"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Added multi-store support. User can now use \u0027--backned\u0027"},{"line_number":10,"context_line":"option to pass desire store while creating, uploading or"},{"line_number":11,"context_line":"importing image to speific store backend."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Added new command \u0027stores-info\u0027 which will return available"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"5f7c97a3_ef186a84","line":10,"range":{"start_line":10,"start_character":20,"end_line":10,"end_character":21},"in_reply_to":"5f7c97a3_ececfdbd","updated":"2018-07-23 18:00:51.000000000","message":"Done","commit_id":"e510377e49c634ee899b219a80903a974a31a05c"}],"glanceclient/tests/unit/v2/test_shell_v2.py":[{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"fd62eae2549a6eb2ef8de2c155405f1d722a2bea","unresolved":false,"context_lines":[{"line_number":433,"context_line":""},{"line_number":434,"context_line":"                    temp_args.pop(\u0027file\u0027, None)"},{"line_number":435,"context_line":"                    mocked_create.assert_called_once_with("},{"line_number":436,"context_line":"                        container_format\u003d\u0027bare\u0027, disk_format\u003d\u0027vhd\u0027,"},{"line_number":437,"context_line":"                        name\u003d\u0027IMG-01\u0027, progress\u003dFalse)"},{"line_number":438,"context_line":"                    mocked_get.assert_called_once_with(\u0027pass\u0027)"},{"line_number":439,"context_line":"                    utils.print_dict.assert_called_once_with({"},{"line_number":440,"context_line":"                        \u0027id\u0027: \u0027pass\u0027, \u0027name\u0027: \u0027IMG-01\u0027, \u0027disk_format\u0027: \u0027vhd\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_2c667558","line":437,"range":{"start_line":436,"start_character":24,"end_line":437,"end_character":53},"updated":"2018-07-23 13:30:29.000000000","message":"why changing this and leaving the temp_args above unused?","commit_id":"e510377e49c634ee899b219a80903a974a31a05c"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"8cb4372e1bdebcd97a85c1088f34f16251e36f43","unresolved":false,"context_lines":[{"line_number":433,"context_line":""},{"line_number":434,"context_line":"                    temp_args.pop(\u0027file\u0027, None)"},{"line_number":435,"context_line":"                    mocked_create.assert_called_once_with("},{"line_number":436,"context_line":"                        container_format\u003d\u0027bare\u0027, disk_format\u003d\u0027vhd\u0027,"},{"line_number":437,"context_line":"                        name\u003d\u0027IMG-01\u0027, progress\u003dFalse)"},{"line_number":438,"context_line":"                    mocked_get.assert_called_once_with(\u0027pass\u0027)"},{"line_number":439,"context_line":"                    utils.print_dict.assert_called_once_with({"},{"line_number":440,"context_line":"                        \u0027id\u0027: \u0027pass\u0027, \u0027name\u0027: \u0027IMG-01\u0027, \u0027disk_format\u0027: \u0027vhd\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_efbcea6c","line":437,"range":{"start_line":436,"start_character":24,"end_line":437,"end_character":53},"in_reply_to":"5f7c97a3_2c667558","updated":"2018-07-23 18:00:51.000000000","message":"Done","commit_id":"e510377e49c634ee899b219a80903a974a31a05c"}],"glanceclient/v2/shell.py":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"73ccc9b6834c9d8ac8e629aefe40603661cfb833","unresolved":false,"context_lines":[{"line_number":184,"context_line":"        if not file_name and not using_stdin:"},{"line_number":185,"context_line":"            utils.exit(\"You must specify a --file or provide data via stdin \""},{"line_number":186,"context_line":"                       \"for the glance-direct import method.\")"},{"line_number":187,"context_line":"        if not file_name and args.backend:"},{"line_number":188,"context_line":"            utils.exit(\"--backend option should only be provided with --file \""},{"line_number":189,"context_line":"                       \"option for the glance-direct import method.\")"},{"line_number":190,"context_line":"    if args.import_method \u003d\u003d \u0027web-download\u0027:"},{"line_number":191,"context_line":"        if not args.uri:"},{"line_number":192,"context_line":"            utils.exit(\"URI is required for web-download import method. \""}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_7f4e2839","line":189,"range":{"start_line":187,"start_character":8,"end_line":189,"end_character":69},"updated":"2018-06-18 15:32:20.000000000","message":"This code is unreachable as well","commit_id":"d18b10b466806c403ffa3c7b64415b91cfdcfef3"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"73ccc9b6834c9d8ac8e629aefe40603661cfb833","unresolved":false,"context_lines":[{"line_number":197,"context_line":"        if using_stdin:"},{"line_number":198,"context_line":"            utils.exit(\"You cannot pass data via stdin with the web-download \""},{"line_number":199,"context_line":"                       \"import method.\")"},{"line_number":200,"context_line":"        if not args.uri and args.backend:"},{"line_number":201,"context_line":"            utils.exit(\"--backend option should only be provided with --uri \""},{"line_number":202,"context_line":"                       \"option for the web-download import method.\")"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"    # process"},{"line_number":205,"context_line":"    image \u003d gc.images.create(**fields)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_bfbfe0fa","line":202,"range":{"start_line":200,"start_character":8,"end_line":202,"end_character":68},"updated":"2018-06-18 15:32:20.000000000","message":"This code is unreachable.","commit_id":"d18b10b466806c403ffa3c7b64415b91cfdcfef3"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"fd62eae2549a6eb2ef8de2c155405f1d722a2bea","unresolved":false,"context_lines":[{"line_number":79,"context_line":"    backend \u003d args.backend"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    file_name \u003d fields.pop(\u0027file\u0027, None)"},{"line_number":82,"context_line":"    if not file_name and backend:"},{"line_number":83,"context_line":"        utils.exit(\"--backend option should only be provided with --file \""},{"line_number":84,"context_line":"                   \"option.\")"},{"line_number":85,"context_line":"    if backend:"},{"line_number":86,"context_line":"        # determine if backend is valid"},{"line_number":87,"context_line":"        _validate_backend(backend, gc)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_cc610113","line":84,"range":{"start_line":82,"start_character":0,"end_line":84,"end_character":29},"updated":"2018-07-23 13:30:29.000000000","message":"Why is this? What\u0027s wrong with stdin?","commit_id":"e510377e49c634ee899b219a80903a974a31a05c"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"8cb4372e1bdebcd97a85c1088f34f16251e36f43","unresolved":false,"context_lines":[{"line_number":79,"context_line":"    backend \u003d args.backend"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    file_name \u003d fields.pop(\u0027file\u0027, None)"},{"line_number":82,"context_line":"    if not file_name and backend:"},{"line_number":83,"context_line":"        utils.exit(\"--backend option should only be provided with --file \""},{"line_number":84,"context_line":"                   \"option.\")"},{"line_number":85,"context_line":"    if backend:"},{"line_number":86,"context_line":"        # determine if backend is valid"},{"line_number":87,"context_line":"        _validate_backend(backend, gc)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_6c99c869","line":84,"range":{"start_line":82,"start_character":0,"end_line":84,"end_character":29},"in_reply_to":"5f7c97a3_cc610113","updated":"2018-07-23 18:00:51.000000000","message":"Done","commit_id":"e510377e49c634ee899b219a80903a974a31a05c"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"400eb23f9885a6ecda9527e442015a32ec4a85a2","unresolved":false,"context_lines":[{"line_number":95,"context_line":"            backend \u003d fields.get(\u0027backend\u0027, None)"},{"line_number":96,"context_line":"            args.id \u003d image[\u0027id\u0027]"},{"line_number":97,"context_line":"            args.size \u003d None"},{"line_number":98,"context_line":"            do_image_upload(gc, args, backend\u003dbackend)"},{"line_number":99,"context_line":"            image \u003d gc.images.get(args.id)"},{"line_number":100,"context_line":"    finally:"},{"line_number":101,"context_line":"        utils.print_image(image)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_d2151c40","line":98,"range":{"start_line":98,"start_character":32,"end_line":98,"end_character":53},"updated":"2018-07-23 14:15:57.000000000","message":"if backend is provided, it will be there twice now.","commit_id":"e510377e49c634ee899b219a80903a974a31a05c"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"8cb4372e1bdebcd97a85c1088f34f16251e36f43","unresolved":false,"context_lines":[{"line_number":95,"context_line":"            backend \u003d fields.get(\u0027backend\u0027, None)"},{"line_number":96,"context_line":"            args.id \u003d image[\u0027id\u0027]"},{"line_number":97,"context_line":"            args.size \u003d None"},{"line_number":98,"context_line":"            do_image_upload(gc, args, backend\u003dbackend)"},{"line_number":99,"context_line":"            image \u003d gc.images.get(args.id)"},{"line_number":100,"context_line":"    finally:"},{"line_number":101,"context_line":"        utils.print_image(image)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_2cbc30b4","line":98,"range":{"start_line":98,"start_character":32,"end_line":98,"end_character":53},"in_reply_to":"5f7c97a3_d2151c40","updated":"2018-07-23 18:00:51.000000000","message":"Done","commit_id":"e510377e49c634ee899b219a80903a974a31a05c"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"400eb23f9885a6ecda9527e442015a32ec4a85a2","unresolved":false,"context_lines":[{"line_number":124,"context_line":"                  \u0027record if no import-method and no data is supplied\u0027))"},{"line_number":125,"context_line":"@utils.arg(\u0027--uri\u0027, metavar\u003d\u0027\u003cIMAGE_URL\u003e\u0027, default\u003dNone,"},{"line_number":126,"context_line":"           help\u003d_(\u0027URI to download the external image.\u0027))"},{"line_number":127,"context_line":"@utils.arg(\u0027--backend\u0027, metavar\u003d\u0027\u003cSTORE\u003e\u0027,"},{"line_number":128,"context_line":"           help\u003d\u0027Backend store to upload image to.\u0027)"},{"line_number":129,"context_line":"@utils.on_data_require_fields(DATA_FIELDS)"},{"line_number":130,"context_line":"def do_image_create_via_import(gc, args):"},{"line_number":131,"context_line":"    \"\"\"EXPERIMENTAL: Create a new image via image import."}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_32efb0fb","line":128,"range":{"start_line":127,"start_character":0,"end_line":128,"end_character":52},"updated":"2018-07-23 14:15:57.000000000","message":"perhaps we should add `default\u003dutils.env(\u0027OS_IMAGE_BACKEND\u0027, default\u003dNone,` here and all the others?","commit_id":"e510377e49c634ee899b219a80903a974a31a05c"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"8cb4372e1bdebcd97a85c1088f34f16251e36f43","unresolved":false,"context_lines":[{"line_number":124,"context_line":"                  \u0027record if no import-method and no data is supplied\u0027))"},{"line_number":125,"context_line":"@utils.arg(\u0027--uri\u0027, metavar\u003d\u0027\u003cIMAGE_URL\u003e\u0027, default\u003dNone,"},{"line_number":126,"context_line":"           help\u003d_(\u0027URI to download the external image.\u0027))"},{"line_number":127,"context_line":"@utils.arg(\u0027--backend\u0027, metavar\u003d\u0027\u003cSTORE\u003e\u0027,"},{"line_number":128,"context_line":"           help\u003d\u0027Backend store to upload image to.\u0027)"},{"line_number":129,"context_line":"@utils.on_data_require_fields(DATA_FIELDS)"},{"line_number":130,"context_line":"def do_image_create_via_import(gc, args):"},{"line_number":131,"context_line":"    \"\"\"EXPERIMENTAL: Create a new image via image import."}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_ac0cc093","line":128,"range":{"start_line":127,"start_character":0,"end_line":128,"end_character":52},"in_reply_to":"5f7c97a3_32efb0fb","updated":"2018-07-23 18:00:51.000000000","message":"Done","commit_id":"e510377e49c634ee899b219a80903a974a31a05c"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"400eb23f9885a6ecda9527e442015a32ec4a85a2","unresolved":false,"context_lines":[{"line_number":172,"context_line":"                   args.import_method)"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"    # determine if backend is valid"},{"line_number":175,"context_line":"    _validate_backend(args.backend, gc)"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"    # make sure we have all and only correct inputs for the requested method"},{"line_number":178,"context_line":"    if args.import_method is None:"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_923004ba","line":175,"range":{"start_line":175,"start_character":22,"end_line":175,"end_character":34},"updated":"2018-07-23 14:15:57.000000000","message":"this should return key error if the --backend is not provided as it doesn\u0027t have default value?","commit_id":"e510377e49c634ee899b219a80903a974a31a05c"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"8cb4372e1bdebcd97a85c1088f34f16251e36f43","unresolved":false,"context_lines":[{"line_number":172,"context_line":"                   args.import_method)"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"    # determine if backend is valid"},{"line_number":175,"context_line":"    _validate_backend(args.backend, gc)"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"    # make sure we have all and only correct inputs for the requested method"},{"line_number":178,"context_line":"    if args.import_method is None:"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_2cdbd0ea","line":175,"range":{"start_line":175,"start_character":22,"end_line":175,"end_character":34},"in_reply_to":"5f7c97a3_923004ba","updated":"2018-07-23 18:00:51.000000000","message":"Done","commit_id":"e510377e49c634ee899b219a80903a974a31a05c"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"fd62eae2549a6eb2ef8de2c155405f1d722a2bea","unresolved":false,"context_lines":[{"line_number":543,"context_line":"           help\u003d_(\u0027ID of image to import.\u0027))"},{"line_number":544,"context_line":"@utils.arg(\u0027--backend\u0027, metavar\u003d\u0027\u003cSTORE\u003e\u0027,"},{"line_number":545,"context_line":"           help\u003d\u0027Backend store to upload image to.\u0027)"},{"line_number":546,"context_line":"def do_image_import(gc, args, backend\u003dNone):"},{"line_number":547,"context_line":"    \"\"\"Initiate the image import taskflow.\"\"\""},{"line_number":548,"context_line":"    if args.backend:"},{"line_number":549,"context_line":"        backend \u003d args.backend"},{"line_number":550,"context_line":"        # determine if backend is valid"},{"line_number":551,"context_line":"        _validate_backend(backend, gc)"},{"line_number":552,"context_line":""},{"line_number":553,"context_line":"    if getattr(args, \u0027from_create\u0027, False):"},{"line_number":554,"context_line":"        # this command is being called \"internally\" so we can skip"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_b79972d0","line":551,"range":{"start_line":546,"start_character":0,"end_line":551,"end_character":38},"updated":"2018-07-23 13:30:29.000000000","message":"Really not sure what the logic is here.\n\nIf the backend is provided as kwarg like it\u0027s defined in the function definition, we do not validate it.","commit_id":"e510377e49c634ee899b219a80903a974a31a05c"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"400eb23f9885a6ecda9527e442015a32ec4a85a2","unresolved":false,"context_lines":[{"line_number":543,"context_line":"           help\u003d_(\u0027ID of image to import.\u0027))"},{"line_number":544,"context_line":"@utils.arg(\u0027--backend\u0027, metavar\u003d\u0027\u003cSTORE\u003e\u0027,"},{"line_number":545,"context_line":"           help\u003d\u0027Backend store to upload image to.\u0027)"},{"line_number":546,"context_line":"def do_image_import(gc, args, backend\u003dNone):"},{"line_number":547,"context_line":"    \"\"\"Initiate the image import taskflow.\"\"\""},{"line_number":548,"context_line":"    if args.backend:"},{"line_number":549,"context_line":"        backend \u003d args.backend"},{"line_number":550,"context_line":"        # determine if backend is valid"},{"line_number":551,"context_line":"        _validate_backend(backend, gc)"},{"line_number":552,"context_line":""},{"line_number":553,"context_line":"    if getattr(args, \u0027from_create\u0027, False):"},{"line_number":554,"context_line":"        # this command is being called \"internally\" so we can skip"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_97455675","line":551,"range":{"start_line":546,"start_character":0,"end_line":551,"end_character":38},"in_reply_to":"5f7c97a3_17c94679","updated":"2018-07-23 14:15:57.000000000","message":"But that\u0027s not the case. The do_create_image_via_import doesn\u0027t pass it as kwarg but within the args (L221 on this diff). So nothing is actually using that kwarg within the client at least.","commit_id":"e510377e49c634ee899b219a80903a974a31a05c"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"8cb4372e1bdebcd97a85c1088f34f16251e36f43","unresolved":false,"context_lines":[{"line_number":543,"context_line":"           help\u003d_(\u0027ID of image to import.\u0027))"},{"line_number":544,"context_line":"@utils.arg(\u0027--backend\u0027, metavar\u003d\u0027\u003cSTORE\u003e\u0027,"},{"line_number":545,"context_line":"           help\u003d\u0027Backend store to upload image to.\u0027)"},{"line_number":546,"context_line":"def do_image_import(gc, args, backend\u003dNone):"},{"line_number":547,"context_line":"    \"\"\"Initiate the image import taskflow.\"\"\""},{"line_number":548,"context_line":"    if args.backend:"},{"line_number":549,"context_line":"        backend \u003d args.backend"},{"line_number":550,"context_line":"        # determine if backend is valid"},{"line_number":551,"context_line":"        _validate_backend(backend, gc)"},{"line_number":552,"context_line":""},{"line_number":553,"context_line":"    if getattr(args, \u0027from_create\u0027, False):"},{"line_number":554,"context_line":"        # this command is being called \"internally\" so we can skip"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_8ce304a1","line":551,"range":{"start_line":546,"start_character":0,"end_line":551,"end_character":38},"in_reply_to":"5f7c97a3_97455675","updated":"2018-07-23 18:00:51.000000000","message":"Got it, removed kwargs","commit_id":"e510377e49c634ee899b219a80903a974a31a05c"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"52c8ea8dde3c118864de8f92d3f5a77770611784","unresolved":false,"context_lines":[{"line_number":543,"context_line":"           help\u003d_(\u0027ID of image to import.\u0027))"},{"line_number":544,"context_line":"@utils.arg(\u0027--backend\u0027, metavar\u003d\u0027\u003cSTORE\u003e\u0027,"},{"line_number":545,"context_line":"           help\u003d\u0027Backend store to upload image to.\u0027)"},{"line_number":546,"context_line":"def do_image_import(gc, args, backend\u003dNone):"},{"line_number":547,"context_line":"    \"\"\"Initiate the image import taskflow.\"\"\""},{"line_number":548,"context_line":"    if args.backend:"},{"line_number":549,"context_line":"        backend \u003d args.backend"},{"line_number":550,"context_line":"        # determine if backend is valid"},{"line_number":551,"context_line":"        _validate_backend(backend, gc)"},{"line_number":552,"context_line":""},{"line_number":553,"context_line":"    if getattr(args, \u0027from_create\u0027, False):"},{"line_number":554,"context_line":"        # this command is being called \"internally\" so we can skip"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_17c94679","line":551,"range":{"start_line":546,"start_character":0,"end_line":551,"end_character":38},"in_reply_to":"5f7c97a3_b79972d0","updated":"2018-07-23 13:41:27.000000000","message":"the reason why backend from the kwargs is not validated is that it already validated in do_create_image_via_import call.\n\nIf image-import command directly called then we need to validate this backend here passed by user.","commit_id":"e510377e49c634ee899b219a80903a974a31a05c"}]}