)]}'
{"glanceclient/common/utils.py":[{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"08ed9215d713f2632f591930b7265a4a390e4270","unresolved":false,"context_lines":[{"line_number":422,"context_line":"    ignore \u003d [\u0027self\u0027, \u0027access\u0027, \u0027file\u0027, \u0027schema\u0027]"},{"line_number":423,"context_line":"    image \u003d dict([item for item in image_obj.items()"},{"line_number":424,"context_line":"                  if item[0] not in ignore])"},{"line_number":425,"context_line":"    if \u0027hidden\u0027 in image:"},{"line_number":426,"context_line":"        image[\u0027os_hidden\u0027] \u003d image.pop(\u0027hidden\u0027)"},{"line_number":427,"context_line":"    if \u0027virtual_size\u0027 in image:"},{"line_number":428,"context_line":"        image[\u0027virtual_size\u0027] \u003d image.get(\u0027virtual_size\u0027) or \u0027Not available\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_7281b1c2","line":425,"range":{"start_line":425,"start_character":8,"end_line":425,"end_character":14},"updated":"2018-07-23 08:43:57.000000000","message":"this should be os_hidden?","commit_id":"e583e6c2667cdbc21f5f67464cf8f5346ff4dd1f"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"09028c79691fc744a9bcb16e75d4a6a09261ad9c","unresolved":false,"context_lines":[{"line_number":422,"context_line":"    ignore \u003d [\u0027self\u0027, \u0027access\u0027, \u0027file\u0027, \u0027schema\u0027]"},{"line_number":423,"context_line":"    image \u003d dict([item for item in image_obj.items()"},{"line_number":424,"context_line":"                  if item[0] not in ignore])"},{"line_number":425,"context_line":"    if \u0027hidden\u0027 in image:"},{"line_number":426,"context_line":"        image[\u0027os_hidden\u0027] \u003d image.pop(\u0027hidden\u0027)"},{"line_number":427,"context_line":"    if \u0027virtual_size\u0027 in image:"},{"line_number":428,"context_line":"        image[\u0027virtual_size\u0027] \u003d image.get(\u0027virtual_size\u0027) or \u0027Not available\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_f2fdc109","line":425,"range":{"start_line":425,"start_character":8,"end_line":425,"end_character":14},"in_reply_to":"5f7c97a3_7281b1c2","updated":"2018-07-23 08:49:11.000000000","message":"In order to change this to os_hidden, I need to change the column name to os_hidden in the database.","commit_id":"e583e6c2667cdbc21f5f67464cf8f5346ff4dd1f"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"08ed9215d713f2632f591930b7265a4a390e4270","unresolved":false,"context_lines":[{"line_number":423,"context_line":"    image \u003d dict([item for item in image_obj.items()"},{"line_number":424,"context_line":"                  if item[0] not in ignore])"},{"line_number":425,"context_line":"    if \u0027hidden\u0027 in image:"},{"line_number":426,"context_line":"        image[\u0027os_hidden\u0027] \u003d image.pop(\u0027hidden\u0027)"},{"line_number":427,"context_line":"    if \u0027virtual_size\u0027 in image:"},{"line_number":428,"context_line":"        image[\u0027virtual_size\u0027] \u003d image.get(\u0027virtual_size\u0027) or \u0027Not available\u0027"},{"line_number":429,"context_line":"    if human_readable:"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_12663d58","line":426,"range":{"start_line":426,"start_character":40,"end_line":426,"end_character":46},"updated":"2018-07-23 08:43:57.000000000","message":"ditto","commit_id":"e583e6c2667cdbc21f5f67464cf8f5346ff4dd1f"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"09028c79691fc744a9bcb16e75d4a6a09261ad9c","unresolved":false,"context_lines":[{"line_number":423,"context_line":"    image \u003d dict([item for item in image_obj.items()"},{"line_number":424,"context_line":"                  if item[0] not in ignore])"},{"line_number":425,"context_line":"    if \u0027hidden\u0027 in image:"},{"line_number":426,"context_line":"        image[\u0027os_hidden\u0027] \u003d image.pop(\u0027hidden\u0027)"},{"line_number":427,"context_line":"    if \u0027virtual_size\u0027 in image:"},{"line_number":428,"context_line":"        image[\u0027virtual_size\u0027] \u003d image.get(\u0027virtual_size\u0027) or \u0027Not available\u0027"},{"line_number":429,"context_line":"    if human_readable:"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_adfda808","line":426,"range":{"start_line":426,"start_character":40,"end_line":426,"end_character":46},"in_reply_to":"5f7c97a3_12663d58","updated":"2018-07-23 08:49:11.000000000","message":"In order to change this to os_hidden, I need to change the column name to os_hidden in the database.","commit_id":"e583e6c2667cdbc21f5f67464cf8f5346ff4dd1f"}],"glanceclient/v2/image_schema.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"b8f628827dcf846ccf044a711a32837a58e9af68","unresolved":false,"context_lines":[{"line_number":200,"context_line":"            \"type\": \"boolean\","},{"line_number":201,"context_line":"            \"description\": \"If true, image will not be deletable.\""},{"line_number":202,"context_line":"        },"},{"line_number":203,"context_line":"        \"hidden\": {"},{"line_number":204,"context_line":"            \"type\": \"boolean\","},{"line_number":205,"context_line":"            \"description\": \"If true, image will not appear in default \""},{"line_number":206,"context_line":"                           \"image list response.\""}],"source_content_type":"text/x-python","patch_set":8,"id":"5f7c97a3_15c115fe","line":203,"updated":"2018-07-24 21:30:15.000000000","message":"I can see how this would address my concern on shell.py, but I\u0027m not sure it\u0027s a good idea.  I\u0027ve been hoping that someone would tackle the problem of having the current Glance image schema propagated automatically to the glanceclient repo somehow, so I don\u0027t think having this file be intentionally out of sync with the Glance image schema is a good idea.  But if other cores think it\u0027s OK, I won\u0027t object, other than to say that it would be a good idea to add a comment here explaining what\u0027s going on so someone doesn\u0027t come along and \"fix\" it.","commit_id":"c9db88e8aee096206ebbbf462a840d393eeecfe5"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"83567fcb64e91f081f75eb71aff4e97fd2eb0d86","unresolved":false,"context_lines":[{"line_number":200,"context_line":"            \"type\": \"boolean\","},{"line_number":201,"context_line":"            \"description\": \"If true, image will not be deletable.\""},{"line_number":202,"context_line":"        },"},{"line_number":203,"context_line":"        \"hidden\": {"},{"line_number":204,"context_line":"            \"type\": \"boolean\","},{"line_number":205,"context_line":"            \"description\": \"If true, image will not appear in default \""},{"line_number":206,"context_line":"                           \"image list response.\""}],"source_content_type":"text/x-python","patch_set":8,"id":"5f7c97a3_dd70a30c","line":203,"in_reply_to":"5f7c97a3_15c115fe","updated":"2018-07-24 22:33:14.000000000","message":"I\u0027ll admit I wasn\u0027t entirely sure on this part of the change, so interested to see what folks decide.","commit_id":"c9db88e8aee096206ebbbf462a840d393eeecfe5"}],"glanceclient/v2/shell.py":[{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"08ed9215d713f2632f591930b7265a4a390e4270","unresolved":false,"context_lines":[{"line_number":271,"context_line":"def do_image_list(gc, args):"},{"line_number":272,"context_line":"    \"\"\"List images you can access.\"\"\""},{"line_number":273,"context_line":"    filter_keys \u003d [\u0027visibility\u0027, \u0027member_status\u0027, \u0027owner\u0027, \u0027checksum\u0027, \u0027tag\u0027,"},{"line_number":274,"context_line":"                   \u0027hidden\u0027]"},{"line_number":275,"context_line":"    filter_items \u003d [(key, getattr(args, key)) for key in filter_keys]"},{"line_number":276,"context_line":"    if args.properties:"},{"line_number":277,"context_line":"        filter_properties \u003d [prop.split(\u0027\u003d\u0027, 1) for prop in args.properties]"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_12215dfe","line":274,"range":{"start_line":274,"start_character":20,"end_line":274,"end_character":26},"updated":"2018-07-23 08:43:57.000000000","message":"This should be os_hidden, no?","commit_id":"e583e6c2667cdbc21f5f67464cf8f5346ff4dd1f"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"09028c79691fc744a9bcb16e75d4a6a09261ad9c","unresolved":false,"context_lines":[{"line_number":271,"context_line":"def do_image_list(gc, args):"},{"line_number":272,"context_line":"    \"\"\"List images you can access.\"\"\""},{"line_number":273,"context_line":"    filter_keys \u003d [\u0027visibility\u0027, \u0027member_status\u0027, \u0027owner\u0027, \u0027checksum\u0027, \u0027tag\u0027,"},{"line_number":274,"context_line":"                   \u0027hidden\u0027]"},{"line_number":275,"context_line":"    filter_items \u003d [(key, getattr(args, key)) for key in filter_keys]"},{"line_number":276,"context_line":"    if args.properties:"},{"line_number":277,"context_line":"        filter_properties \u003d [prop.split(\u0027\u003d\u0027, 1) for prop in args.properties]"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_72121164","line":274,"range":{"start_line":274,"start_character":20,"end_line":274,"end_character":26},"in_reply_to":"5f7c97a3_12215dfe","updated":"2018-07-23 08:49:11.000000000","message":"In order to change this to os_hidden, I need to change the column name to os_hidden in the database.","commit_id":"e583e6c2667cdbc21f5f67464cf8f5346ff4dd1f"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"ba79bc3f67b02eaefb23441cb55a0005bbd099c8","unresolved":false,"context_lines":[{"line_number":283,"context_line":"@utils.arg(\u0027--hidden\u0027,"},{"line_number":284,"context_line":"           metavar\u003d\u0027\u003ctrue|false\u003e\u0027,"},{"line_number":285,"context_line":"           default\u003dNone,"},{"line_number":286,"context_line":"           const\u003d\u0027true\u0027,"},{"line_number":287,"context_line":"           nargs\u003d\u0027?\u0027,"},{"line_number":288,"context_line":"           choices\u003d[\u0027true\u0027, \u0027false\u0027],"},{"line_number":289,"context_line":"           help\u003d\"Filters results by hidden status. Default\u003dNone.\")"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f7c97a3_c9bc6a09","line":286,"updated":"2018-07-24 18:41:11.000000000","message":"If you add \"dest\u003d\u0027os_hidden\u0027 here then I believe you can get rid of the special key handling below.","commit_id":"8c8d0c2cce3b50ca8d3ec525d309acb07ca51da2"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"1a8adafd0f24494acb3afc32524428fd885d6397","unresolved":false,"context_lines":[{"line_number":283,"context_line":"@utils.arg(\u0027--hidden\u0027,"},{"line_number":284,"context_line":"           metavar\u003d\u0027\u003ctrue|false\u003e\u0027,"},{"line_number":285,"context_line":"           default\u003dNone,"},{"line_number":286,"context_line":"           const\u003d\u0027true\u0027,"},{"line_number":287,"context_line":"           nargs\u003d\u0027?\u0027,"},{"line_number":288,"context_line":"           choices\u003d[\u0027true\u0027, \u0027false\u0027],"},{"line_number":289,"context_line":"           help\u003d\"Filters results by hidden status. Default\u003dNone.\")"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f7c97a3_49785af6","line":286,"in_reply_to":"5f7c97a3_c9bc6a09","updated":"2018-07-24 19:07:30.000000000","message":"Done","commit_id":"8c8d0c2cce3b50ca8d3ec525d309acb07ca51da2"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"b8f628827dcf846ccf044a711a32837a58e9af68","unresolved":false,"context_lines":[{"line_number":49,"context_line":"@utils.schema_args(get_image_schema, omit\u003d[\u0027created_at\u0027, \u0027updated_at\u0027, \u0027file\u0027,"},{"line_number":50,"context_line":"                                           \u0027checksum\u0027, \u0027virtual_size\u0027, \u0027size\u0027,"},{"line_number":51,"context_line":"                                           \u0027status\u0027, \u0027schema\u0027, \u0027direct_url\u0027,"},{"line_number":52,"context_line":"                                           \u0027locations\u0027, \u0027self\u0027])"},{"line_number":53,"context_line":"@utils.arg(\u0027--property\u0027, metavar\u003d\"\u003ckey\u003dvalue\u003e\", action\u003d\u0027append\u0027,"},{"line_number":54,"context_line":"           default\u003d[], help\u003d_(\u0027Arbitrary property to associate with image.\u0027"},{"line_number":55,"context_line":"                              \u0027 May be used multiple times.\u0027))"}],"source_content_type":"text/x-python","patch_set":8,"id":"5f7c97a3_3578d1f5","line":52,"updated":"2018-07-24 21:30:15.000000000","message":"see question at line 101","commit_id":"c9db88e8aee096206ebbbf462a840d393eeecfe5"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"b8f628827dcf846ccf044a711a32837a58e9af68","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        utils.print_image(image)"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"@utils.schema_args(get_image_schema, omit\u003d[\u0027created_at\u0027, \u0027updated_at\u0027, \u0027file\u0027,"},{"line_number":99,"context_line":"                                           \u0027checksum\u0027, \u0027virtual_size\u0027, \u0027size\u0027,"},{"line_number":100,"context_line":"                                           \u0027status\u0027, \u0027schema\u0027, \u0027direct_url\u0027,"},{"line_number":101,"context_line":"                                           \u0027locations\u0027, \u0027self\u0027])"},{"line_number":102,"context_line":"@utils.arg(\u0027--property\u0027, metavar\u003d\"\u003ckey\u003dvalue\u003e\", action\u003d\u0027append\u0027,"},{"line_number":103,"context_line":"           default\u003d[], help\u003d_(\u0027Arbitrary property to associate with image.\u0027"},{"line_number":104,"context_line":"                              \u0027 May be used multiple times.\u0027))"}],"source_content_type":"text/x-python","patch_set":8,"id":"5f7c97a3_150ef58e","line":101,"range":{"start_line":98,"start_character":0,"end_line":101,"end_character":64},"updated":"2018-07-24 21:30:15.000000000","message":"don\u0027t we need to include os_hidden here (since we\u0027re using --hidden instead)?  Do we also have to add --hidden as a @utils.arg below so that it will show up in the help?","commit_id":"c9db88e8aee096206ebbbf462a840d393eeecfe5"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"5febdb0696aaab45aad14501bbf7d37f30fc78cf","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        utils.print_image(image)"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"@utils.schema_args(get_image_schema, omit\u003d[\u0027created_at\u0027, \u0027updated_at\u0027, \u0027file\u0027,"},{"line_number":99,"context_line":"                                           \u0027checksum\u0027, \u0027virtual_size\u0027, \u0027size\u0027,"},{"line_number":100,"context_line":"                                           \u0027status\u0027, \u0027schema\u0027, \u0027direct_url\u0027,"},{"line_number":101,"context_line":"                                           \u0027locations\u0027, \u0027self\u0027])"},{"line_number":102,"context_line":"@utils.arg(\u0027--property\u0027, metavar\u003d\"\u003ckey\u003dvalue\u003e\", action\u003d\u0027append\u0027,"},{"line_number":103,"context_line":"           default\u003d[], help\u003d_(\u0027Arbitrary property to associate with image.\u0027"},{"line_number":104,"context_line":"                              \u0027 May be used multiple times.\u0027))"}],"source_content_type":"text/x-python","patch_set":8,"id":"5f7c97a3_40402805","line":101,"range":{"start_line":98,"start_character":0,"end_line":101,"end_character":64},"in_reply_to":"5f7c97a3_150ef58e","updated":"2018-07-24 23:03:44.000000000","message":"yes and yes, same applies to the update below.","commit_id":"c9db88e8aee096206ebbbf462a840d393eeecfe5"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"32135427f1cb7f9ff30ea425fde839f8b5845645","unresolved":false,"context_lines":[{"line_number":279,"context_line":"                                           \u0027schema\u0027, \u0027direct_url\u0027, \u0027tags\u0027,"},{"line_number":280,"context_line":"                                           \u0027self\u0027, \u0027os_hidden\u0027,"},{"line_number":281,"context_line":"                                           \u0027os_hash_value\u0027, \u0027os_hash_algo\u0027])"},{"line_number":282,"context_line":"@utils.arg(\u0027--hidden\u0027, metavar\u003d\u0027\u003ctrue|false\u003e\u0027, choices\u003d[\u0027true\u0027, \u0027false\u0027],"},{"line_number":283,"context_line":"           help\u003d(\"If true, image will not appear in default image list \""},{"line_number":284,"context_line":"                 \"response.\"))"},{"line_number":285,"context_line":"@utils.arg(\u0027--property\u0027, metavar\u003d\"\u003ckey\u003dvalue\u003e\", action\u003d\u0027append\u0027,"},{"line_number":286,"context_line":"           default\u003d[], help\u003d_(\u0027Arbitrary property to associate with image.\u0027"},{"line_number":287,"context_line":"                              \u0027 May be used multiple times.\u0027))"}],"source_content_type":"text/x-python","patch_set":9,"id":"5f7c97a3_8940a461","line":284,"range":{"start_line":282,"start_character":0,"end_line":284,"end_character":30},"updated":"2018-07-25 08:16:05.000000000","message":"Hi Brian, Erno, Sean,\n\nI need to change this to type\u003dutils.str_to_bool otherwise it will raise error\n\nTypeError: Unable to set \u0027os_hidden\u0027 to u\u0027true\u0027. Reason: u\u0027true\u0027 is not of type u\u0027boolean\u0027\n\nFailed validating u\u0027type\u0027 in schema[u\u0027properties\u0027][u\u0027os_hidden\u0027]:\n    {u\u0027description\u0027: u\u0027If true, image will not appear in default image list response.\u0027,\n     u\u0027type\u0027: u\u0027boolean\u0027}\n\nOn instance[u\u0027os_hidden\u0027]:\n    u\u0027true\u0027\n\nThe reason behind not setting type\u003dboolean is everytime you pass any value to --hidden it accepts it as True. (Something weiered in python i guess [1]). So as I have set it to utils.str_to_bool now it accepts true/false and for other it will raise exception.\n\nNote: I can use strutils.bool_from_string then it will accepts all true (y,yes,Treu,true,1 etc) or false (n, no, false, 0 etc.) values. This conversion is used for converting protected command line option [2].\n\n[1] https://stackoverflow.com/questions/15008758/parsing-boolean-values-with-argparse\n[2] https://github.com/openstack/python-glanceclient/blob/master/glanceclient/common/utils.py#L108","commit_id":"4ba5e84d944bb6e48a5090a8791c716882c4166d"}]}