)]}'
{"glanceclient/common/http.py":[{"author":{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},"change_message_id":"0465a9a777209a24d4005f8882ba2dddd0af63ff","unresolved":false,"context_lines":[{"line_number":62,"context_line":"    # So we first %-encode them to get them into range \u003c 128 and then turn"},{"line_number":63,"context_line":"    # them into ASCII."},{"line_number":64,"context_line":"    encoded_dict \u003d {}"},{"line_number":65,"context_line":"    if six.PY2:"},{"line_number":66,"context_line":"        # incoming items may be unicode, so get them into something"},{"line_number":67,"context_line":"        # the py2 version of urllib can handle before percent encoding"},{"line_number":68,"context_line":"        for h, v in headers.items():"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_6b96fcf1","line":65,"updated":"2018-07-18 10:06:35.000000000","message":"Can\u0027t we reduce some code duplication by doing the same condition like-\n\nfor h, v in headers.items():\n     if v is not None:\n         if h in [\u0027X-Auth-Token\u0027, \u0027X-Service-Token\u0027]:\n             encoded_dict[h] \u003d v\n         elif six.PY2:\n              key \u003d  urlparse.quote(encodeutils.safe_encode(h))\n              value \u003d urlparse.quote(encodeutils.safe_encode(v))\n              encoded_dict[key] \u003d value\n          else:\n              encoded_dict[urlparse.quote(h)] \u003d urlparse.quote(v)","commit_id":"15c979ae506604373e1a468f6affc0b224c7095c"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"3bcb62b867d84214d21511daa1c20e3738005560","unresolved":false,"context_lines":[{"line_number":62,"context_line":"    # So we first %-encode them to get them into range \u003c 128 and then turn"},{"line_number":63,"context_line":"    # them into ASCII."},{"line_number":64,"context_line":"    encoded_dict \u003d {}"},{"line_number":65,"context_line":"    if six.PY2:"},{"line_number":66,"context_line":"        # incoming items may be unicode, so get them into something"},{"line_number":67,"context_line":"        # the py2 version of urllib can handle before percent encoding"},{"line_number":68,"context_line":"        for h, v in headers.items():"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_911f7459","line":65,"in_reply_to":"5f7c97a3_49837a56","updated":"2018-07-25 02:16:41.000000000","message":"Done","commit_id":"15c979ae506604373e1a468f6affc0b224c7095c"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"ae14d3462093e802c1dd3d93597188e7adb8c6a9","unresolved":false,"context_lines":[{"line_number":62,"context_line":"    # So we first %-encode them to get them into range \u003c 128 and then turn"},{"line_number":63,"context_line":"    # them into ASCII."},{"line_number":64,"context_line":"    encoded_dict \u003d {}"},{"line_number":65,"context_line":"    if six.PY2:"},{"line_number":66,"context_line":"        # incoming items may be unicode, so get them into something"},{"line_number":67,"context_line":"        # the py2 version of urllib can handle before percent encoding"},{"line_number":68,"context_line":"        for h, v in headers.items():"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_49837a56","line":65,"in_reply_to":"5f7c97a3_6b96fcf1","updated":"2018-07-24 18:36:17.000000000","message":"+1, it would be nice to get rid of some of that duplication. Not a big blocker, but it would be nice to have.","commit_id":"15c979ae506604373e1a468f6affc0b224c7095c"}]}
